< fanquake> jonasschnelli Interesting GH stats. I wouldn't have thought we'd have nearly 5* more commenters/reviewers compared to code contributors.
< jonasschnelli> fanquake: yeah. indeed
< bitcoin-git> [bitcoin] hebasto opened pull request #15098: qt: Show addresses for "SendToSelf" transactions (master...20190104-gui-self-payment) https://github.com/bitcoin/bitcoin/pull/15098
< promag> fanquake: where did you get that info?
< fanquake> promag Jonas has it up on his Twitter
< fanquake> wumpus #15085, 15007 & 14594 all probably mergable
< gribble> https://github.com/bitcoin/bitcoin/issues/15085 | gui: Fix incorrect application name when passing -regtest by benthecarman · Pull Request #15085 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] domob1812 opened pull request #15099: tests: Use std::vector API for construction of test data (master...p2sh-test-refactor) https://github.com/bitcoin/bitcoin/pull/15099
< wumpus> fanquake: great
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d71d0d7b7f3f...d3dc6d879450
< bitcoin-git> bitcoin/master cc341ad Ben Carman: gui: Fix for Incorrect application name when passing -regtest
< bitcoin-git> bitcoin/master d3dc6d8 Wladimir J. van der Laan: Merge #15085: gui: Fix incorrect application name when passing -regtest...
< bitcoin-git> [bitcoin] laanwj closed pull request #15085: gui: Fix incorrect application name when passing -regtest (master...regest_window_name) https://github.com/bitcoin/bitcoin/pull/15085
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3dc6d879450...f51aeac5add6
< bitcoin-git> bitcoin/master 698d0f8 Hennadii Stepanov: Remove misplaced Q_UNUSED and others enhancements...
< bitcoin-git> bitcoin/master f51aeac Wladimir J. van der Laan: Merge #15007: qt: Notificator class refactoring...
< bitcoin-git> [bitcoin] laanwj closed pull request #15007: qt: Notificator class refactoring (master...20181219-notificator-enhancement) https://github.com/bitcoin/bitcoin/pull/15007
< wumpus> jonasschnelli: oh I had forgotten that that PR was still open! reviewed
< promag> wumpus: not sure I understand your comment in #15087
< gribble> https://github.com/bitcoin/bitcoin/issues/15087 | Error if rpcpassword contains hash in conf sections by MeshCollider · Pull Request #15087 · bitcoin/bitcoin · GitHub
< promag> is `regtest.rpcpassword=foo` a valid config line?
< luke-jr> I think so
< wumpus> yes
< wumpus> promag: okay that means your suggestion doesn't work
< promag> wumpus: right
< promag> it's a pity that isn't obvious from the implementation
< wumpus> there needs to be a test for it
< promag> yap
< promag> [section] rpcpassword=xxx, section.rpcpassword=xxx and rpcpassword=xxx
< wumpus> yes, I just posted that too
< promag> allright, I'll just delete my comment then
< fanquake> promag strikethrough normally better than delete
< fanquake> so that PR conversations remains sensical
< fanquake> depends on context though
< promag> ok
< promag> wumpus: have you seen failures related with http shutdown?
< promag> or anyone else?
< wumpus> not recently?
< promag> ok, great :P
< bitcoin-git> [bitcoin] fanquake closed pull request #14026: docs: updated README.md to include link to repo, files list and description (master...fix-8160) https://github.com/bitcoin/bitcoin/pull/14026
< bitcoin-git> [bitcoin] fanquake closed pull request #14961: docs: Root readme improvements (master...improvements/readme) https://github.com/bitcoin/bitcoin/pull/14961
< meshcollider> promag: indeed, that's why I did it that way
< promag> meshcollider: +1
< meshcollider> I'll add the other tests in the morning
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f51aeac5add6...fd83c57d6bee
< bitcoin-git> bitcoin/master a62e667 Jon Layton: docs: Add more Doxygen information to Developer Notes
< bitcoin-git> bitcoin/master fd83c57 MarcoFalke: Merge #14832: docs: Add more Doxygen information to Developer Notes...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14832: docs: Add more Doxygen information to Developer Notes (master...improvement/doxygen-docs) https://github.com/bitcoin/bitcoin/pull/14832
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd83c57d6bee...9c64278e1a72
< bitcoin-git> bitcoin/master e58985c Daniel Kraft: Log progress while verifying blocks at level 4....
< bitcoin-git> bitcoin/master 9c64278 MarcoFalke: Merge #13910: Log progress while verifying blocks at level 4...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13910: Log progress while verifying blocks at level 4 (master...progress) https://github.com/bitcoin/bitcoin/pull/13910
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c64278e1a72...5b6b371c777a
< bitcoin-git> bitcoin/master 75778a0 Ben Woosley: test: Correct ineffectual WithOrVersion from transactions_tests...
< bitcoin-git> bitcoin/master 5b6b371 MarcoFalke: Merge #14855: test: Correct ineffectual WithOrVersion from transactions_tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14855: test: Correct ineffectual WithOrVersion from transactions_tests (master...with-or-version-test) https://github.com/bitcoin/bitcoin/pull/14855
< fanquake> I wonder what Travis uses to determine "abuse". Smashing the restart job button? https://travis-ci.org/bitcoin/bitcoin/requests
< cjd> mining monero
< cjd> j/k id
< cjd> k
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b6b371c777a...f7e182a973ed
< bitcoin-git> bitcoin/master 54dc13b João Barbosa: rpc: Fix SoftForkMajorityDesc and SoftForkDesc signatures
< bitcoin-git> bitcoin/master 343b98c João Barbosa: rpc: Specify chain tip instead of chain in GetDifficulty
< bitcoin-git> bitcoin/master b9f226b João Barbosa: rpc: Remove cs_main lock from blockToJSON and blockHeaderToJSON
< bitcoin-git> [bitcoin] DesWurstes opened pull request #15100: Revert "Check if sys/random.h is required for getentropy on OSX." (master...patch-7) https://github.com/bitcoin/bitcoin/pull/15100
< promag> please reopen #12153
< gribble> https://github.com/bitcoin/bitcoin/issues/12153 | Avoid permanent cs_main lock in getblockheader by promag · Pull Request #12153 · bitcoin/bitcoin · GitHub
< fanquake> promag done
< bitcoin-git> [bitcoin] fanquake reopened pull request #12153: Avoid permanent cs_main lock in getblockheader (master...2018-01-getblockheader) https://github.com/bitcoin/bitcoin/pull/12153
< fanquake> I'm assuming remove up for grabs?
< promag> yap, ty
< bitcoin-git> [bitcoin] promag opened pull request #15101: gui: Add WalletController (master...2019-01-walletcontroller) https://github.com/bitcoin/bitcoin/pull/15101
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15102: test: Run invalid_txs.InputMissing test in feature_block (master...Mf1901-testInputMissing) https://github.com/bitcoin/bitcoin/pull/15102
< bitcoin-git> [bitcoin] jameshilliard opened pull request #15103: declare getentropy weak import on osx (master...getentropy-weak) https://github.com/bitcoin/bitcoin/pull/15103
< bitcoin-git> [bitcoin] DesWurstes closed pull request #15100: Utils and libraries Revert <<Use getentropy rather than /dev/urandom on macOS>> (master...patch-7) https://github.com/bitcoin/bitcoin/pull/15100
< bitcoin-git> [bitcoin] mmachicao opened pull request #15104: Tests: Add unit testing for the CompressScript function (master...compress_contract_test3) https://github.com/bitcoin/bitcoin/pull/15104
< Chris_Stewart_5> jonasschnelli: FYI i think your testnet seed might be down
< jonasschnelli> Chris_Stewart_5: thanks... checking
< jonasschnelli> Seems to run
< instagibbs> sipa, is Descriptor parsing already supposed to support key origin string stuff?
< sipa> yes
< instagibbs> ok im likely just not escaping the key origin right
< sipa> format is described in doc/descriptors.md
< instagibbs> Yes I'm literally trying to enter in an example from there :)
< instagibbs> probably failing to escape something properly
< instagibbs> on -cli
< bitcoin-git> [bitcoin] thedevworks opened pull request #15105: Qt: Use MINUS (U+2212) instead of HYPHEN-MINUS (U+002D) Fixes #15034 (master...2019-1-4-hyphenminus) https://github.com/bitcoin/bitcoin/pull/15105
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f7e182a973ed...fe5a70b9fefa
< bitcoin-git> bitcoin/master 6b25f29 Daniel Kraft: Use std::vector API for construction of test data....
< bitcoin-git> bitcoin/master fe5a70b MarcoFalke: Merge #15099: tests: Use std::vector API for construction of test data...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15099: tests: Use std::vector API for construction of test data (master...p2sh-test-refactor) https://github.com/bitcoin/bitcoin/pull/15099