01:02 < bitcoin-git> [bitcoin] fanquake opened pull request #15637: rpc: Rename size to vsize in mempool related calls (master...rebased-13008-rename-size-vsize) https://github.com/bitcoin/bitcoin/pull/15637

01:04 < bitcoin-git> [bitcoin] fanquake closed pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008

05:00 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638

05:33 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639

05:57 < Qualitat_> Helo

06:35 < wumpus> echeveria: thanks!

10:09 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/717fd58c4ba5...abd914ed34f1

10:09 < bitcoin-git> bitcoin/master a10972b João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active

10:09 < bitcoin-git> bitcoin/master abd914e Jonas Schnelli: Merge #15614: gui: Defer removeAndDeleteWallet when no modal widget is act...

10:10 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15614: gui: Defer removeAndDeleteWallet when no modal widget is active (master...2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15614

10:11 < jonasschnelli> wumpus: should I just push the commit from #15614 to 0.18 or open a PR?

10:11 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub

10:17 < fanquake> jonasschnelli tbh I'd prefer a PR

10:17 < fanquake> Also, does anyone think should #15591 be a blocker for 0.18 ? Have confirmed the buggy load/unload balance behaviour.

10:17 < gribble> https://github.com/bitcoin/bitcoin/issues/15591 | balance wrong after unloading wallet and loading it again · Issue #15591 · bitcoin/bitcoin · GitHub

10:18 < jonasschnelli> fanquake: ack

10:56 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641

11:36 < wumpus> jonasschnelli: unless it's compltely obvious I'd prefer a PR

12:29 < bitcoin-git> [bitcoin] jonatack closed pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607

12:30 < bitcoin-git> [bitcoin] jonatack reopened pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607

12:36 < fanquake> jonatack fyi, if you're opening/closing to reboot travis, you can ping here, or you might be able to restart yourself if you auth.

12:46 < jonatack> fanquake thanks for the tip, typed the wrong shortcut on a new keyboard but will take note for the future

14:34 < promag> provoostenator: regarding #15493

14:34 < gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub

14:34 < promag> please see my last comment?

14:35 < bitcoin-git> [bitcoin] jnewbery opened pull request #15642: [rpc] Remove deprecated rpc functionality (master...2019_03_remove_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/15642

15:02 < kanzure> was p2sh verifymessage ever implemented? https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2013-April/002406.html

15:35 < instagibbs> im sure it was implemented somewhere(I did it for a branch of Core with hww support to convince myself I actually controlled address keys)

15:35 < instagibbs> but not standard, no

15:36 < gmaxwell> kanzure: I think electrum implements something thats electrum compatible only.

15:36 < gmaxwell> since p2sh has historically meant multisig, the question isn't exactly all that simple.

15:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/238ef3369296...b0222428879f

15:48 < bitcoin-git> bitcoin/0.18 98a24a2 João Barbosa: gui: Defer removeAndDeleteWallet when no modal widget is active

15:48 < bitcoin-git> bitcoin/0.18 b022242 Wladimir J. van der Laan: Merge #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet wh...

15:49 < bitcoin-git> [bitcoin] laanwj merged pull request #15641: Backport #15614 to 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active (0.18...2019/03/promag/2019-03-wallet-modal-widget) https://github.com/bitcoin/bitcoin/pull/15641

15:52 < gmaxwell> \O?

15:53 < gmaxwell> er \O/

16:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15643: contrib: gh-merge: Include review comments in merge commit (master...1903-ghMergeAck) https://github.com/bitcoin/bitcoin/pull/15643

16:27 < bitcoin-git> [bitcoin] sipa opened pull request #15644: Make orphan processing interruptible (master...201903_interruptibleorphans) https://github.com/bitcoin/bitcoin/pull/15644

17:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/abd914ed34f1...68520597ccf8

17:12 < bitcoin-git> bitcoin/master fab0a68 MarcoFalke: qa: mininode: Clearer error message on invalid magic bytes

17:12 < bitcoin-git> bitcoin/master 6852059 MarcoFalke: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes

17:13 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15631: qa: mininode: Clearer error message on invalid magic bytes (master...1903-qaMagicMininode) https://github.com/bitcoin/bitcoin/pull/15631

18:50 < jnewbery> wallet meeting today?

19:02 < kanzure> hi

19:06 < jnewbery> hi

19:07 < achow101> is there?

19:08 < jnewbery> I guess not. Looks like there was one last week

19:08 < jnewbery> we missed one during FC so it seems like they've been shifted to the alternate week now

19:15 < bitcoin-git> [bitcoin] jnewbery opened pull request #15646: [tests] Add test for wallet rebroadcasts (master...2019_03_wallet_rebroadcasat_test) https://github.com/bitcoin/bitcoin/pull/15646

19:22 < bitcoin-git> [bitcoin] jnewbery opened pull request #15647: [rpc] Remove deprecated functionality message from validateaddress help (0.18...2019_03_backport_remove_verifyaddress_deprecated_warning) https://github.com/bitcoin/bitcoin/pull/15647

21:01 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15649: Add ChaCha20Poly1305@Bitcoin AEAD (master...2019/03/chachapoly1305) https://github.com/bitcoin/bitcoin/pull/15649

23:58 < promag> jnewbery: please take a look at 15591