< bitcoin-git>
bitcoin/master 80968cf Peter Bushnell: scripted-diff: rename movie folder to animation
< bitcoin-git>
bitcoin/master 6a53c3e MarcoFalke: Merge bitcoin-core/gui#14: scripted-diff: rename movie folder to animation...
< bitcoin-git>
[bitcoin] jnewbery opened pull request #19533: [tests] Remove unnecessary cs_mains in denialofservice_tests (master...2020-07-dos-tests-cs-main) https://github.com/bitcoin/bitcoin/pull/19533
< bitcoin-git>
[bitcoin] vasild opened pull request #19534: net: save the network type explicitly in CNetAddr (master...explicit_network_type_in_CNetAddr) https://github.com/bitcoin/bitcoin/pull/19534
< provoostenator>
wumpus fjahr: I'm able to restart Travis instances as well. Sometimes the "trick" is to logout of Travis and log back in, as it forgets your powers.
< fanquake>
I won't be at the meeting. However my input for my topic is that I think #19524 should be merged, and a 0.20.1rc1 tagged today/tomorrow. We've dragged our heels on this, and there is a publicly know issue affecting at-least the two most recent releases.
< gribble>
https://github.com/bitcoin/bitcoin/issues/19524 | [0.20] Backport #19517 - Increment input value sum only once per UTXO in decodepsbt by fanquake · Pull Request #19524 · bitcoin/bitcoin · GitHub
< bitcoin-git>
bitcoin/0.20 bad9cf8 Andrew Chow: Increment input value sum only once per UTXO in decodepsbt
< bitcoin-git>
bitcoin/0.20 f61398a Wladimir J. van der Laan: Merge #19524: [0.20] Backport #19517 - Increment input value sum only once...
< bitcoin-git>
[bitcoin] laanwj merged pull request #19524: [0.20] Backport #19517 - Increment input value sum only once per UTXO in decodepsbt (0.20...0_20_19517) https://github.com/bitcoin/bitcoin/pull/19524
< wumpus>
another one was already merged, so we're at 12 blockers now
< wumpus>
enough to review for everyone I'd hope
< luke-jr>
haven't seen it help tbh
< wumpus>
oh 11 even
< luke-jr>
wumpus: please add #11082
< gribble>
https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
< wumpus>
luke-jr: added
< luke-jr>
it also has a "Waiting for author" label that should be removed AFAICT
< wumpus>
ok
< wumpus>
#topic 0.20.1rc1 (fanquake)
< luke-jr>
I guess technically #18818 needs to be dropped from the high-prio list. Nobody seems to care to review it, and it's not like the tarball has ever really worked anyway :/
< wumpus>
"I won't be at the meeting. However my input for my topic is that I think #19524 should be merged, and a 0.20.1rc1 tagged today/tomorrow. We've dragged our heels on this, and there is a publicly know issue affecting at-least the two most recent releases."
< gribble>
https://github.com/bitcoin/bitcoin/issues/19524 | [0.20] Backport #19517 - Increment input value sum only once per UTXO in decodepsbt by fanquake · Pull Request #19524 · bitcoin/bitcoin · GitHub
< wumpus>
I agree with fanquake there; that PR has been merged now, so I intend to start the release process for 0.20.0rc1 soon
< achow101>
ack
< jnewbery>
ack
< luke-jr>
sgtm
< sipa>
sgtm
< luke-jr>
unless we want to merge Taproot with flagday activation on Dec 1st :P j/k
< wumpus>
I'm not sure that's critical enough to hold the release up further tbh
< hebasto>
ok
< wumpus>
but ok, it's a one line change
< wumpus>
in bulid system
< jnewbery>
#proposedtopic p2p irc meeting
< luke-jr>
it means rebuilding Qt, but IMO should be fixed anyway
< wumpus>
I'm sure we can get that merged and backported tomorrow if the build system people people review it
< wumpus>
yes, it requires a rebuild of qt so would make the build somewhat longer
< wumpus>
#topic p2p irc meeting (jnewbery)
< jnewbery>
thanks wumpus
< jnewbery>
I'd like to start a fortnightly (that's every two weeks) meeting in this channel for p2p PRs.
< jnewbery>
It seems like there are enough people doing interesting things in p2p that a short check-in to share what everyone’s focus is would be helpful
< jnewbery>
I’m aware of the following people actively working on p2p projects:
< jnewbery>
vasild (addrv2), carl (addrv2 and parallel validation protocol), aj (various), suhas (wtxid relay and various), gleb (addr relay and various), amiti (refactor peer types, testing, tx relay), sipa (tx relay and various), troy (logging), me (net/net_processing split)
< jnewbery>
... and there are probably a bunch more that I’m temporarily not remembering.
< jonatack>
Yup, I am, but I don't talk about it.
< wumpus>
sounds good to me, though, don't those topics fit in the normal meeting? we generally have enough time for more topics in the main meeting
< gzhao408>
+1 i wanna lurk
< jnewbery>
jonatack: yes, I've seen you've been reviewing a bunch of PRs. There are quite a few other regular reviewers too
< jnewbery>
it might end up just being a five minute check in on what everyone's focus is that week. I don't like having long meetings for meetings' sake.
< gzhao408>
are there other code area-specific meetings?
< wumpus>
the wallet meeting
< sipa>
jnewbery: it seems the biggest hurdle may be getting all those people on irc at the same time :)
< hebasto>
build meeting
< troygiorshev>
ack
< jnewbery>
gzhao408: there's a fortnightly wallet meeting, which I think was very successful at focusing attention (at least initially)
< wumpus>
bitcoin-builds even has its own IRC channel, but no planned time afaik?
< cfields>
we've informally been doing meetings for buildsystem discussion too lately
< vasild>
imhere now, a bit sleepy though ;)
< wumpus>
ohh
< cfields>
^^ what hebasto said.
< jonatack>
sipa: agree. this hour is too late for me tbh.
< jnewbery>
yes, with apologies to our antipodean friends I'm going to suggest that we do the same time on a different day
< sipa>
aj is also in a timezone far away from most others
< sipa>
jnewbery: i think it may make sense to first see people's availability and preferences; if this time of day would be a good meeting time, those people would already be here in this meeting right now, i'd expect
< cfields>
jnewbery: 1 min while everyone googles antipodean.
< jnewbery>
or we could do an hour or two earlier and still get america and europe. Again, sorry to Asia and Australia :(
< cfields>
TIL :)
< jnewbery>
ok, I don't think we need to figure out a time now. Was more looking for concept ACKs/NACKs
< wumpus>
concept ACK
< vasild>
concept ACK
< gzhao408>
concept ACK
< jonatack>
these hours are pretty US-centric, would be nice to alternate a bit if possible, ACK if earlier
< amiti>
concept ACK! I'm a fan of the idea of a p2p focused meeting. even if we can't get everyone at the same time, encouraging convo between our work tracks seems great!
< jnewbery>
like I said, I'd prefer to keep the meeting short. I think there's always value in hearing what other people's focus is
< sipa>
concept ACK, but conditional on finding a good time and buy-in :)
< jnewbery>
I defintely want to avoid adding an hour of unproductive time to people's calendars
< sipa>
my reasoning: if it'll just end up being the people who are here today now, we can also do it regular weekly meetings, especially if it's short
< wumpus>
yes, that was also my only remark
< cfields>
maybe meetings could be called for by a sponsor when there's something concrete to discuss?
< jnewbery>
cfields jonatack: I think these things have much more chance of succeeding if they have a regular reliable time/day
< sipa>
i agree with that
< cfields>
fair enough.
< jnewbery>
cfields: antipodean:feet on the wrong end
< jnewbery>
ok, I'll try to figure out a process for choosing a time
< sipa>
antipodism (uncountable)
< sipa>
A form of foot juggling where the juggler lies on his or her back, usually on a sort of chair.
< wumpus>
hehe
< meshcollider>
Ah yes, regular occurrence down here
< cfields>
clearly I was confused as that's the only usage I know ;)
< wumpus>
I think there's no further topics for today then
< wumpus>
#endmeeting
< lightningbot>
Meeting ended Thu Jul 16 19:29:11 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< meshcollider>
Speaking of specific meetings, reminder that the wallet meeting is on this week, same time tomorrow
< luke-jr>
#16525 looks mergablek
< gribble>
https://github.com/bitcoin/bitcoin/issues/16525 | Dump transaction version as an unsigned integer in RPC/TxToUniv by TheBlueMatt · Pull Request #16525 · bitcoin/bitcoin · GitHub
< jonatack>
Goodnight! FWIW an unofficial blocker imho would be #18044.
< bitcoin-git>
bitcoin/master 970de70 Matt Corallo: Dump transaction version as an unsigned integer in RPC/TxToUniv
< bitcoin-git>
bitcoin/master e80259f Matt Corallo: Additionally treat Tx.nVersion as unsigned in joinpsbts
< bitcoin-git>
bitcoin/master c57dc56 Wladimir J. van der Laan: Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToU...
< bitcoin-git>
[bitcoin] laanwj merged pull request #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16525
< wumpus>
jonatack: added to high prio for review
< wumpus>
seems close to mergeable
< bitcoin-git>
[bitcoin] hebasto opened pull request #19538: ci: Add tsan suppression for race in DatabaseBatch (master...200716-tsan-db) https://github.com/bitcoin/bitcoin/pull/19538