00:06 < achow101> Sometimes (read: usually) I think it was a mistake to add wallet type options as bools to createwallet

00:06 < achow101> Should've made that an "options" arg

00:07 < luke-jr> yes

00:07 < luke-jr> not too late to fix tho?

00:08 < achow101> We could add one at the end but that wouldn't necessarily make things better since we still need to keep the existing ones

00:08 < luke-jr> could replace the existing ones, and just interpret bools compatibly for a few releases

00:09 < achow101> I suppose so

00:09 < achow101> Forgot that was a thing we did

06:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991

06:45 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991

06:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471

06:47 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471

07:24 < bitcoin-git> [bitcoin] hebasto opened pull request #19588: test: Use uniform distribution for random intervals in functional tests (master...200725-uni-test) https://github.com/bitcoin/bitcoin/pull/19588

18:52 < instagibbs> unless it's an important improvement I'd be careful about deprecating highly used commands/args combos

19:01 < sipa> sdaftuar: i was thinking of tx request data as being a map keyed by (is_wtxid, hash), but perhaps that's not the best mental model

19:01 < luke-jr> instagibbs: not highly used if it's that new I'd think

19:02 < sipa> and it's better to see is_wtxid more as metadata along with the rest of the data, but just keyed by hash

19:17 < sdaftuar> sipa: yes, i think that's basically how i was thinking about it.

19:20 < sipa> sdaftuar: that makes sense... it also means m_tx_in_flight and m_tx_announced should probably just be by hash

19:22 < sipa> aj: that means i'd be reverting to your original patch, really :)

22:55 < aj> sipa: sometimes the simplest approach is the best!