< phantomcircuit> sipa, length extension attacks it the only reason i can think of
< sipa> phantomcircuit: that's probably the rationale... but length extension attacks really only apply when it's about hashing secret data
< phantomcircuit> sipa, i agree that it's probably not relevant to any use of HASH, but it seems likely to be the rationale
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/26d7941224bc...867dbeba5f91
< bitcoin-git> bitcoin/master 5d99174 Nadav Ivgi: docs: Correct getblockstats documentation for (sw)total_weight
< bitcoin-git> bitcoin/master 867dbeb MarcoFalke: Merge #20281: docs: Correct getblockstats documentation for (sw)total_weig...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20281: docs: Correct getblockstats documentation for (sw)total_weight (master...202011-getblockstats-docs-weight) https://github.com/bitcoin/bitcoin/pull/20281
< adulrunaredviva> good morning everybody. What is the money transfer fee variable? It depends on what? I will be happy if you give me information. Thank you.
< sipa> adulrunaredviva: https://bitcoin.stackexchange.com is a better place for these questions; in short: the price is set by supply and demand
< adulrunaredviva> What does the "settxfee" command do? Is there any connection with the global transaction fee?
< sipa> adulrunaredviva: not here, this is a development channel
< bitcoin-git> [bitcoin] jnewbery opened pull request #20282: Wallet: Change upgradewallet return type to be an object (master...2020-11-upgrade-wallet-return) https://github.com/bitcoin/bitcoin/pull/20282
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20283: test: Only try witness deser when checking for witness deser failure (master...2011-testWitnessFail) https://github.com/bitcoin/bitcoin/pull/20283
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/867dbeba5f91...c5ec0367d718
< bitcoin-git> bitcoin/master 525cbd4 Pieter Wuille: Only relay Taproot spends if next block has it active
< bitcoin-git> bitcoin/master 3d0556d Pieter Wuille: Increase feature_taproot inactive test coverage
< bitcoin-git> bitcoin/master c5ec036 MarcoFalke: Merge #20165: Only relay Taproot spends if next block has it active
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20165: Only relay Taproot spends if next block has it active (master...202010_taproot_policy) https://github.com/bitcoin/bitcoin/pull/20165
< bitcoin-git> [bitcoin] vasild opened pull request #20284: addrman: ensure old versions don't parse peers.dat (master...peers_dat_format) https://github.com/bitcoin/bitcoin/pull/20284
< bitcoin-git> [bitcoin] fanquake opened pull request #20285: Remove references to CreateWalletFromFile (master...createwalletfromfilenomore) https://github.com/bitcoin/bitcoin/pull/20285
< bitcoin-git> [gui] hebasto opened pull request #127: Replace QMetaObject::invokeMethod with Mutex locking (master...201102-queued) https://github.com/bitcoin-core/gui/pull/127
< vasild> Proposed topic for P2P meeting tomorrow (Nov 3): I2P, https://github.com/vasild/bitcoin/wiki/I2P-connectivity
< shesek> I was not able to reliably reproduce this yet, but I got `"scanning":{"duration":19,"progress":}}` (with no value for `progress`) in response to `getwalletinfo` when rescanning is in progress
< shesek> I'm still trying to reproduce and will report back if I have more information, but perhaps someone familiar with the wallet internals have some ideas on potential causes?
< shesek> it just happened again, but I'm still not sure why exactly. it didn't happen before for like 15-20 attempts in a row. seems like something racey is going on
< shesek> another thing I noticed is that getnetworkinfo and getwalletinfo are very slow to reply when a rescan is taking place, is that to be expected?
< shesek> I'm running v0.20.0 and testing against a regtest instance. this happened while doing a batched `importmulti` of 2000 addresses, none of which have any history.
< shesek> I also noticed during my attempts to reproduce this that the `progress` field is always either 0 or missing, it never reports any progress
< vasild> jnewbery: how to propose a topic for the P2P meeting? I guess #proposedmeetingtopic will do so for the general dev meeting on Thu.
< jonatack> vasild: yes, hashtag proposedmeetingtopic <topic>
< vasild> *General* meeting every Thursday -- #proposedmeetingtopic
< vasild> *Wallet* meeting every other Friday -- #proposedwalletmeetingtopic
< vasild> *P2P* meeting every other Tuesday -- ?
< jonatack> vasild: istm for the p2p meeting there is a wiki
< jonatack> good point, will update that link
< vasild> added I2P to that wiki, thanks!
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5ec0367d718...b6a00e76ab6f
< bitcoin-git> bitcoin/master e5f3e95 Jon Atack: doc: fix getchaintxstats fields in release-process.md
< bitcoin-git> bitcoin/master b6a00e7 MarcoFalke: Merge #20279: doc: release process updates/fixups
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20279: doc: release process updates/fixups (master...release-process-getchaintxstats-fix) https://github.com/bitcoin/bitcoin/pull/20279
< vasild> It is never too late to learn some new "basic" thing for C++: sizeof(x + y) is 4 when both x and y are uint8_t
< vasild> I expected it to be 1
< wumpus> still looking for review for #20237
< gribble> https://github.com/bitcoin/bitcoin/issues/20237 | net: Hardcoded seeds update for 0.21 by laanwj · Pull Request #20237 · bitcoin/bitcoin · GitHub
< wumpus> vasild: I don't know the exact rules but yes, C/C++ really likes to promote things to 'int'
< jonatack> vasild: am reviewing 20284, and a propos, was looking at why the cast was needed: s << static_cast<uint8_t>(m_incompatibility_base + lowest_compatible);
< jonatack> i was surprised, but it is
< vasild> yes, poor me expected that typeX + typeX will be of typeX
< jonatack> yes
< jonatack> same
< jonatack> i wonder if the cast can still be avoided though
< jnewbery> vasild: you found the right place for p2p topics: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< vasild> thanks to jonatack :)
< wumpus> one of the things I like about rust is that it does not have silent promotions or truncations like that; want to cast between sized integer types? you always need to be explicit about it
< sipa> jonatack, wumpus: there is a very annoying rule in C++ (and C) that any operations on a type smaller than int automatically get upcasted to int
< jonatack> sipa: agreed; it's annoying :p
< jonatack> https://wiki.sei.cmu.edu/confluence/display/c/INT02-C.+Understand+integer+conversion+rules "Integer types smaller than int are promoted when an operation is performed on them. If all values of the original type can be represented as an int, the value of the smaller type is converted to an int; otherwise, it is converted to an unsigned int."
< jonatack> https://en.cppreference.com/w/cpp/language/implicit_conversion "In particular, arithmetic operators do not accept types smaller than int as arguments, and integral promotions are automatically applied after lvalue-to-rvalue conversion, if applicable."
< bitcoin-git> [bitcoin] laanwj pushed 20 commits to master: https://github.com/bitcoin/bitcoin/compare/b6a00e76ab6f...ef4c7c4e0bf2
< bitcoin-git> bitcoin/master a357111 Andrew Chow: Update wallet_importprunedfunds to avoid dumpprivkey
< bitcoin-git> bitcoin/master dc81418 Andrew Chow: Use a separate watchonly wallet in rpc_fundrawtransaction.py
< bitcoin-git> bitcoin/master 553dbf9 Andrew Chow: Make import tests in wallet_listtransactions.py legacy wallet only
< bitcoin-git> [bitcoin] laanwj merged pull request #18788: tests: Update more tests to work with descriptor wallets (master...desc-wallet-tests) https://github.com/bitcoin/bitcoin/pull/18788
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef4c7c4e0bf2...ca1886056325
< bitcoin-git> bitcoin/master fa90ba3 MarcoFalke: Update assumed chain params
< bitcoin-git> bitcoin/master ca18860 Wladimir J. van der Laan: Merge #20263: Update assumed chain params
< bitcoin-git> [bitcoin] laanwj merged pull request #20263: Update assumed chain params (master...2010-21assumed) https://github.com/bitcoin/bitcoin/pull/20263
< jnewbery> wumpus fanquake: #20187 seems ready for merge
< gribble> https://github.com/bitcoin/bitcoin/issues/20187 | Addrman: test-before-evict bugfix and improvements for block-relay-only peers by sdaftuar · Pull Request #20187 · bitcoin/bitcoin · GitHub
< jnewbery> ACKs on 16d9bfc from me, jonatack, sipa, ariard, mzumsande, amitiuttarwar
< bitcoin-git> [bitcoin] mjdietzx opened pull request #20286: rpc: remove `reqSigs` from rpc outputs (master...remove-reqsigs-from-rpcs) https://github.com/bitcoin/bitcoin/pull/20286
< bitcoin-git> [bitcoin] jonatack opened pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> [bitcoin] practicalswift opened pull request #20289: fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService (master...fuzzers-service_deserialize-addrv2) https://github.com/bitcoin/bitcoin/pull/20289
< bitcoin-git> [bitcoin] practicalswift opened pull request #20290: fuzz: Fix DecodeHexTx fuzzing harness issue (master...fuzzers-decode_tx-fixup) https://github.com/bitcoin/bitcoin/pull/20290