< bitcoin-git> [bitcoin] troygiorshev opened pull request #20411: Fix Version Message Deserialization Discrepancy (master...2020-11-test-framework-version-msg-fix) https://github.com/bitcoin/bitcoin/pull/20411
< luke-jr> feature_taproot is failing 100% of the time for me on master - anyone else?
< luke-jr> line 1454 test_framework.authproxy.JSONRPCException: 'signrawtransactionwithwallet' RPC took longer than 30.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
< aj> luke-jr: finishes successfully in 3minutes total here
< sipa> luke-jr: do you have #20292?
< gribble> https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke · Pull Request #20292 · bitcoin/bitcoin · GitHub
< luke-jr> yes, current master
< luke-jr> annoyingly, if I skip the long tests before it, it passes :/
< sipa> actually, does it work if you revert 20292?
< sipa> this is so silly, it's the most boring part of the test, moving some funds from one node to the other
< luke-jr> XD
< luke-jr> scarily, it looks like it's inside SignatureHash<CTransaction> it gets stuck
< aj> using pre-segwit addresses and getting O(N^2) hashing somehow?
< luke-jr> yes, it still failed with 20292 reverted
< luke-jr> oh wait, I only reverted the top commit of 20292
< * luke-jr> waits another 5 mins for the test to run x.x
< luke-jr> ok, yes, with 20292 reverted, it does pass
< aj> ah, if i time just that line it takes 19.8 seconds
< sipa> luke-jr: i think that's easy to fix
< aj> also much faster, the entire loop takes 4s vs 19.8s for just the signing previously?
< sipa> aj: i was just going to use createrawtx with no inputs, and only part of the funds as output, and then call fundrawtx
< sipa> but yes, that also workz
< MarcoFalke> Another alternative would be to set "self.rpc_timeout = 240" like in some other tests
< aj> MarcoFalke: quicker tests are better tests though
< sipa> yeah, this is just a waste of time
< sipa> it's isn't even testing anything
< wumpus> branching time *dusts off release notes* please don't merge anything for a bit
< bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/a339289c2ef9...a2fa11f9de78
< bitcoin-git> bitcoin/0.20 05bd0c2 Nadav Ivgi: docs: Correct description for getblockstats's txs field
< bitcoin-git> bitcoin/0.20 ee0082b Pieter Wuille: Avoid the use of abs64 in timedata
< bitcoin-git> bitcoin/0.20 731502a MarcoFalke: rpc: Properly deserialize txs with witness before signing
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20166: [0.20] Backports (0.20...more_020_backports) https://github.com/bitcoin/bitcoin/pull/20166
< MarcoFalke> whoops
< MarcoFalke> I guess merging to 0.20 was fine
< wumpus> yes
< sipa> is the branchening upon us
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/831675c8dccf...132e1d897f13
< bitcoin-git> bitcoin/master 132e1d8 Wladimir J. van der Laan: build: Bump master version to 0.21.99
< wumpus> why does build_msvc/bitcoin_config.h have to have the version number in three different places, this is absurd
< wumpus> please either generate the version from configure.ac like decent people or at the least make it in one place
< wumpus> anyhow master should be free for merging again
< wumpus> (for 0.22)
< MarcoFalke> noice \o/
< aj> (you mean 22.0 right?)
< aj> also yay!
< wumpus> or 22.0 what ever versioning customs your people prefer
< MarcoFalke> ok, lets remove python3.5 first and then boost :) ...
< wumpus> now that sounds ambitious!
< midnight> \o/
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/132e1d897f13...4b24c3962fd9
< bitcoin-git> bitcoin/master 8ae9d31 Anthony Towns: Bump minimum python version to 3.6
< bitcoin-git> bitcoin/master 97c738f Anthony Towns: [tests] Recommend f-strings for formatting, update feature_block to use th...
< bitcoin-git> bitcoin/master 4b24c39 MarcoFalke: Merge #19504: Bump minimum python version to 3.6
< aj> first!
< wumpus> okay that was the easy one
< MarcoFalke> aj: lol, congrats
< aj> what's the boost one?
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19504: Bump minimum python version to 3.6 (master...202007-python3.6) https://github.com/bitcoin/bitcoin/pull/19504
< wumpus> i thought you were going to rewrite the test framework in powershell
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/commit/463b316822c7
< bitcoin-git> bitcoin/0.21 463b316 Wladimir J. van der Laan: build: Bump version for 0.21.0rc1
< MarcoFalke> aj #19183, but it needs rebase
< gribble> https://github.com/bitcoin/bitcoin/issues/19183 | [WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke · Pull Request #19183 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/463b316822c7...6cde7bb9b26c
< bitcoin-git> bitcoin/0.21 6cde7bb Wladimir J. van der Laan: doc: Generate manual pages for 0.21.0rc1
< aj> MarcoFalke: aha. presumably the shared_mutex thing should be dropped too
< MarcoFalke> jup
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20413: build: Require C++17 compiler (master...2011-buildCxx17) https://github.com/bitcoin/bitcoin/pull/20413
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4b24c3962fd9...4ae04090bb1d
< bitcoin-git> bitcoin/master e4fc45a Hennadii Stepanov: gui: Remove BDB version from the Information tab
< bitcoin-git> bitcoin/master 4ae0409 MarcoFalke: Merge bitcoin-core/gui#118: Remove BDB version from the Information tab
< bitcoin-git> [gui] MarcoFalke merged pull request #118: Remove BDB version from the Information tab (master...201027-bdb) https://github.com/bitcoin-core/gui/pull/118
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4ae04090bb1d...54532f46c4e2
< bitcoin-git> bitcoin/master 6e95011 Hennadii Stepanov: qt, wallet: Remove unused AskPassphraseDialog::Decrypt
< bitcoin-git> bitcoin/master f886a20 Hennadii Stepanov: qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet
< bitcoin-git> bitcoin/master 4146a31 Hennadii Stepanov: qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted
< bitcoin-git> [gui] MarcoFalke merged pull request #109: wallet: Remove unused AskPassphraseDialog::Decrypt (master...201023-decrypt) https://github.com/bitcoin-core/gui/pull/109
< bitcoin-git> [bitcoin] laanwj opened pull request #20414: doc: Remove generated manual pages from master branch (master...2020_11_manpages) https://github.com/bitcoin/bitcoin/pull/20414
< bitcoin-git> [bitcoin] jonatack reopened pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/54532f46c4e2...a64ff1c4d32c
< bitcoin-git> bitcoin/master fa62304 MarcoFalke: Remove dead CheckForkWarningConditionsOnNewFork
< bitcoin-git> bitcoin/master fa7eed5 MarcoFalke: doc: Clarify that vpindexToConnect is in reverse order
< bitcoin-git> bitcoin/master a64ff1c MarcoFalke: Merge #19905: Remove dead CheckForkWarningConditionsOnNewFork
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19905: Remove dead CheckForkWarningConditionsOnNewFork (master...2009-noFork) https://github.com/bitcoin/bitcoin/pull/19905
< bitcoin-git> [bitcoin] jonatack reopened pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
< hebasto> MarcoFalke: https://github.com/bitcoin-core/gui/pull/42 could be closed now
< bitcoin-git> [gui] MarcoFalke closed pull request #42: qt: remove unused 'Decrypt' wallet (master...qt-remove-decrypt-case) https://github.com/bitcoin-core/gui/pull/42
< bitcoin-git> [bitcoin] elonmu opened pull request #20415: Create Double.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20415
< hebasto> ^ scam
< bitcoin-git> [bitcoin] laanwj closed pull request #20415: Create Double.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20415
< wumpus> banned
< Tennis> that's fine work chief
< bitcoin-git> [bitcoin] jnewbery opened pull request #20416: net: Remove SetMaxOutboundTimeframe() (master...2020-11-remove-set-outbound-timeframe) https://github.com/bitcoin/bitcoin/pull/20416
< bitcoin-git> [bitcoin] jnewbery closed pull request #20416: net: Remove SetMaxOutboundTimeframe() (master...2020-11-remove-set-outbound-timeframe) https://github.com/bitcoin/bitcoin/pull/20416
< aj> jnewbery: thinking about it slightly more, calling Init() with parts of Options filled out with fuzzed data might be easy and better than the current test
< jnewbery> aj: I don't think fuzz testers should be able to change internal state without using public interface methods. If the only use of that method is the fuzz tester, then it can be removed.
< jnewbery> I don't like the way that Init() is called internally in the ctor and start. It obscures how members are initialized
< jnewbery> I agree that the fuzzer should construct CConnmans with different connOptions
< bitcoin-git> [bitcoin] fanquake closed pull request #20320: Depends: Update FreeType package (CVE-2020-15999) (master...master) https://github.com/bitcoin/bitcoin/pull/20320
< fanquake> time to open some PRs 🚀
< aj> jnewbery: yeah, on third thoughts i don't think the fuzz tester currently exercises any code that's dependent on those values anyway
< aj> jnewbery: CConnman having an `Options m_options;` variable instead of all the different ones might simplify things
< jnewbery> aj: I think eventually the ctor should be passed a connOptions object and all of the member initialization be done in the ctor. That requires moving a lot of code around in init.cpp
< jnewbery> but it makes the construction of CConnman a lot clearer, and would make constructing CConnmans in the production code and test code follow the same code paths
< bitcoin-git> [bitcoin] seclab-skku opened pull request #20417: Test (master...test) https://github.com/bitcoin/bitcoin/pull/20417
< bitcoin-git> [bitcoin] fanquake closed pull request #20417: Test (master...test) https://github.com/bitcoin/bitcoin/pull/20417
< bitcoin-git> [bitcoin] fanquake opened pull request #20418: doc: clean out release notes post branch-off (master...clean_out_rel_notes) https://github.com/bitcoin/bitcoin/pull/20418
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a64ff1c4d32c...5bcae7967f73
< bitcoin-git> bitcoin/master 9d09132 Anthony Towns: CConnman: initialise at declaration rather than in Start()
< bitcoin-git> bitcoin/master 5bcae79 fanquake: Merge #20408: CConnman: move initialization to declaration
< bitcoin-git> [bitcoin] fanquake merged pull request #20408: CConnman: move initialization to declaration (master...202011-connman-fuzz) https://github.com/bitcoin/bitcoin/pull/20408
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5bcae7967f73...d020e8839fa5
< bitcoin-git> bitcoin/master dc5a35a fanquake: doc: clean out release notes post branch-off
< bitcoin-git> bitcoin/master 8a715a6 fanquake: build: Bump gitian descriptors to 0.22
< bitcoin-git> bitcoin/master d020e88 MarcoFalke: Merge #20418: doc: clean out release notes post branch-off
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20418: doc: clean out release notes post branch-off (master...clean_out_rel_notes) https://github.com/bitcoin/bitcoin/pull/20418
< bitcoin-git> [bitcoin] fanquake closed pull request #11082: Add new bitcoin_rw.conf file that is used for settings modified by this software itself (master...rwconf) https://github.com/bitcoin/bitcoin/pull/11082
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d020e8839fa5...50e019a97a5b
< bitcoin-git> bitcoin/master daf1ebf Wladimir J. van der Laan: doc: Remove generated manual pages from master branch
< bitcoin-git> bitcoin/master 50e019a MarcoFalke: Merge #20414: doc: Remove generated manual pages from master branch
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20414: doc: Remove generated manual pages from master branch (master...2020_11_manpages) https://github.com/bitcoin/bitcoin/pull/20414
< bitcoin-git> [bitcoin] fanquake opened pull request #20419: build: set minimum supported macOS to 10.14 (master...macos_minimum_10_14) https://github.com/bitcoin/bitcoin/pull/20419
< provoostenator> If you have a Mac and want to waste an enormous amount of time, upgrade to Big Sure, delete Python and try to reinstall it via PyEnv
< wumpus> i could try this on my ex-gfs mac and have some fun :')
< luke-jr> aj: sipa: that works… so this is just the wallet being stupid slow when big?
< achow101> yay branching
< luke-jr> * [new tag] branch-0.21 -> branch-0.21
< hebasto> wondering how long it could take for Tor connected 0.21 nodes to propagate their new v3 onion addresses (without -addnode)?
< jnewbery> achow101: is btcinformation.org still maintained?
< achow101> jnewbery: not currently
< bitcoin-git> [bitcoin] achow101 opened pull request #20420: wallet: Don't upgrade to HD split if it is already supported (master...upgradewallet-fix-split) https://github.com/bitcoin/bitcoin/pull/20420
< luke-jr> MarcoFalke: afaik we have no data on what OSs are used for nodes?
< MarcoFalke> Ubuntu's snap is basically spyware
< luke-jr> :o
< MarcoFalke> So at least for Ubuntu OSs we can get the distribution quite well
< luke-jr> MarcoFalke: but snap users are also getting the gitian binary anyway, so not the target supported for building :P
< MarcoFalke> Absent any other information, I assume that the snap users distribution is identical to the self-building distribution
< achow101> we don't have download numbers for bitcoincore.org?
< luke-jr> that seems unlikely, but I don't really mind supporting older Ubuntu at this point anyway
< MarcoFalke> achow101: What happend with your survey thingy?
< sipa> i think macOS users are in general more upgrade-happy than other OS'es
< achow101> MarcoFalke: it's happening soon(tm)
< MarcoFalke> Upgrade preference about OS/Core would be a good q to ask
< sipa> (but that's just a general impression i have)
< achow101> still working on it
< luke-jr> sipa: otoh, there's like 5 years of hardware that casn't upgrade IIRC
< luke-jr> 2009-2015
< sipa> macos 10.13 will be unsupported next month
< luke-jr> sipa: good to know
< promag> anyone recommends ODROID-HC4 or ODROID-C4? or other?
< hebasto> using odroid-hc1 with armbian
< hebasto> choose good sd-card, it is important
< promag> do you use as full node?
< hebasto> yes
< promag> what disk?
< hebasto> hdd from old laptop :)
< promag> ah :)
< hebasto> from my experience armbian is better than stock ubuntu
< promag> you use as headless right?
< hebasto> yes
< achow101> jonatack: I've just realized that #20403 is already marked for backport. Do you want to just pull in the fix in #20420 into that?
< gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20420 | wallet: Dont upgrade to HD split if it is already supported by achow101 · Pull Request #20420 · bitcoin/bitcoin · GitHub
< jonasschnelli> promag: I used HC2 and XU4. The HC4 looks nice. Im still a big fan of the Rock64pro. Has an mSATA slot.
< jonatack> achow101: either way sgtm. i'll test tomorrow am first thing
< jonatack> achow101: happy to pull it in
< achow101> jonatack: in that case, I'll close my pr so we don't have more conflicts
< jonatack> achow101: okey dokey, thanks for looking into it
< bitcoin-git> [bitcoin] achow101 closed pull request #20420: wallet: Don't upgrade to HD split if it is already supported (master...upgradewallet-fix-split) https://github.com/bitcoin/bitcoin/pull/20420
< luke-jr> ugh, why is NetPermissionFlags out of order
< luke-jr> why does accessing m_blockman require cs_main?