< bitcoin-git>
bitcoin/master 17c6fb1 Samuel Dobson: Merge #20282: wallet: change upgradewallet return type to be an object
< bitcoin-git>
[bitcoin] meshcollider merged pull request #20282: wallet: change upgradewallet return type to be an object (master...2020-11-upgrade-wallet-return) https://github.com/bitcoin/bitcoin/pull/20282
< shesek>
I'm sometimes getting an invalid json reply from `getwalletinfo` when scanning is in progress, that looks like that: `"scanning":{"duration":19,"progress":}}` (with no value for `progress`). I can't reliably reproduce this, but I did manage to run into this 3 times now (once every 20 attempts or so). seems like something racey is going on.
< shesek>
I'm running v0.20.0 and testing against a regtest instance. this happened while doing a batched `importmulti` of 2000 addresses, none of which have any history.
< shesek>
any pointers for diagnosing this? what useful information can I provide to help understand the cause?
< shesek>
so if I'm reading things correctly, when current and end are equal it should report the progress as 1?
< sipa>
shesek: but if begin and end are equal, it gives infinity
< shesek>
right, I meant what it should do conceptually, not what it currently does
< S3RK>
question about fuzzing. we use regtest chain params, but in corups for src/test/fuzz/descriptor_parse.cpp I see xprv keys. As a result fuzzing don't cover code paths with valid keys for bip32 decriptors. I tried to add initial seeds with tprv, but fuzzer doesn't detect any new edges covered. What do I miss?
< sipa>
S3RK: that's strange
< sipa>
are you sure it's using regtest params?
< sipa>
fuzzing should automatically find interesting inputs, so if the corpus onky have xprv ones... that probably means those are the ones that trigger coverage
< phantomcircuit>
S3RK, it's also possible it just needs more time, if it's not something that's trivial to find or needs a specific magic value
< bitcoin-git>
bitcoin/master faf58ab MarcoFalke: ci: Add --with-libs=no to one ci config
< bitcoin-git>
bitcoin/master fafc529 MarcoFalke: test: Run AssetTest even if built --with-libs=no
< bitcoin-git>
bitcoin/master fa3967e MarcoFalke: test: Replace ARRAYLEN with C++11 ranged for loop
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20245: test: Run script_assets_test even if built --with-libs=no (master...2010-testAssetTestlibconsensus) https://github.com/bitcoin/bitcoin/pull/20245
< S3RK>
phantomcircuit: I'm giving it new seeds myself. By providing existing corups and new seeds in separate directories with -merge=1
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #20298: macOS deploy: use the new plistlib API if python>=3.9 (master...2020/11/macdeployfix) https://github.com/bitcoin/bitcoin/pull/20298
< jonasschnelli>
sipa: for the AEAD with the internal-per-byte-rekey, I think it also works with the Poly1305 mac. If we precompute the chacha20-stream it doesn't matter where the rekeying happened.
< jonasschnelli>
what I don't get how one would precompute the chacha20 stream with respecting the sequence numbers per message.
< MarcoFalke>
S3RK: I guess your question is "how to debug"? You can use std::cout to print the parsed descriptor in the fuzzer (and run with your newly generated input(s))
< MarcoFalke>
It might also work with gdb, if you prefer that over std::cout
< bitcoin-git>
bitcoin/master af3b0df Vasil Dimov: net: fix output of peer address in version message
< bitcoin-git>
bitcoin/master 1209b6c MarcoFalke: Merge #20212: net: fix output of peer address in version message
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20212: net: fix output of peer address in version message (master...fix_version_message_print) https://github.com/bitcoin/bitcoin/pull/20212
< bitcoin-git>
[bitcoin] S3RK opened pull request #20300: fuzz: Add missing ECC_Start to descriptor_parse test (master...fix_fuzz_descriptor_parse) https://github.com/bitcoin/bitcoin/pull/20300
< S3RK>
MarcoFalke: thanks, I was able to figure it out with debug printing. Couldn't make debuger to stop at a breakpoint within tested function. It only stops within initialize()
< S3RK>
the problem was in CR-LF characters at the end of the test case
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20302: net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress) (master...NodeEvictionCandidate-addr) https://github.com/bitcoin/bitcoin/pull/20302