< bitcoin-git>
[bitcoin] hebasto closed pull request #20366: scripted-diff: Fix includes when secp256k1 is locally installed on macOS (master...201111-incl) https://github.com/bitcoin/bitcoin/pull/20366
< bitcoin-git>
[bitcoin] lontivero opened pull request #20405: Avoid calculating onion address checksum when version is not 3 (master...tinyrefactoring) https://github.com/bitcoin/bitcoin/pull/20405
< provoostenator>
Ok, it's actually pretty easy to generate the asmap file and use it, but the instructions could be better...
< sipa>
provoostenator: fwiw my plan is to create a separate project with asmap encoding tools
< sipa>
but haven't gotten around to it
< sipa>
as we'll probably want some kind of "asmap diff" tool too, for auditing
< provoostenator>
Some of the RRC files are ancient(e.g. rrc02 last updated 2008). Do we fetch all or filter for recency?
< sipa>
oh wow, i wasn't aware of that
< sipa>
we probably should
< sipa>
it's not information that goes outdated quickly, but if it's more than a year i guess it's useless
< provoostenator>
I only noticed because I wondered what interval they're updated
< provoostenator>
So e.g. if we were to include it in core, how much time other reviewers can verify the result (probably forever since they also keep previous versions)
< bitcoin-git>
[bitcoin] practicalswift opened pull request #20406: util: Avoid invalid integer negation in FormatMoney and ValueFromAmount (master...avoid-invalid-integer-negation-in-FormatMoney) https://github.com/bitcoin/bitcoin/pull/20406