< aj> kallewoof: hey are you still running mff and collecting data?
< kallewoof> aj: did for a long while, but stopped awhile back. I am running your zmq script still though
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/489030f2a8f8...b55dc3ad84ab
< bitcoin-git> bitcoin/master ffff84a MarcoFalke: fuzz: Remove expensive and redundant muhash from crypto fuzz target
< bitcoin-git> bitcoin/master b55dc3a MarcoFalke: Merge #21185: fuzz: Remove expensive and redundant muhash from crypto fuzz...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21185: fuzz: Remove expensive and redundant muhash from crypto fuzz target (master...2102-speedupFuzz) https://github.com/bitcoin/bitcoin/pull/21185
< prayank> I am unable to understand why `setlabel` for a change address makes it not a change address according to this line https://github.com/bitcoin/bitcoin/blob/b55dc3ad84abec4f58e54a8581bdf8556c74b1e3/src/wallet/wallet.h#L203
< prayank> If an address is "change address" it should remain change address. Why does "label" matter?
< michaelfolkson> Because the user doesn't want it to be a change address anymore and wants to spend from it? I'm not sure I understand the question
< michaelfolkson> UTXO management is a complex issue with user trade-offs covering privacy, transaction fees, future transaction fees. One user will want to minimize transaction fees, another user will want to maximize privacy. All we can do is provide tools so they can do whatever their preference is
< prayank> michaelfolkson: Consider I create a change address. I use it or maybe not used yet. I decide to label this one as "change from binance". I create another change address and label it as "change for darknet". I want to use these labels so that I can identify later what was this change used for and use one of them again if required or differentiate for my ease of privacy. Why does this affect the address being change or not
< michaelfolkson> So the question is why the act of the user setting a label on a change address turns it into not a change address?
< prayank> Yes
< michaelfolkson> I guess because whoever introduced labels thought the act of introducing a label meant you were intending to spend from it?
< michaelfolkson> Do a git blame and see who introduced the label handling?
< prayank> Maybe. Sure I will check the history and do some experiments in next few hours. Thanks for the help and ideas.
< michaelfolkson> No problem
< bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/b55dc3ad84ab...9bbf08bf9848
< bitcoin-git> bitcoin/master f8b3058 John Newbery: [net processing] Add Peer& arg to MaybeDiscourageAndDisconnect()
< bitcoin-git> bitcoin/master 1a07600 John Newbery: [net] Add RunInactivityChecks()
< bitcoin-git> bitcoin/master 0b43b81 John Newbery: [net processing] Move send ping message logic into function
< bitcoin-git> [bitcoin] fanquake merged pull request #20721: Net: Move ping data to net_processing (master...2020-12-ping-in-peer) https://github.com/bitcoin/bitcoin/pull/20721
< michaelfolkson> Interesting conversation between John, AJ on STL algorithms vs range based for loops and what is easier to review in that ^ merged PR
< michaelfolkson> Maybe a topic for the Core dev meeting?
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21190: net: Avoid discouraging the onion proxy when one inbound onion misbehaves (master...2102-netOnionInboundDiscourage) https://github.com/bitcoin/bitcoin/pull/21190
< bitcoin-git> [bitcoin] SinEstresOrrantia opened pull request #21196: Create codeql-analysis.yml (master...I-think-those-bitcoin-guys-hacked-mr) https://github.com/bitcoin/bitcoin/pull/21196
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21196: Create codeql-analysis.yml (master...I-think-those-bitcoin-guys-hacked-mr) https://github.com/bitcoin/bitcoin/pull/21196
< bitcoin-git> [bitcoin] jnewbery opened pull request #21198: [net] Address outstanding review comments from PR20721 (master...2021-02-20721-followups) https://github.com/bitcoin/bitcoin/pull/21198
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21200: test: Speed up rpc_blockchain.py by removing miniwallet.generate() (master...2102-testSpeedUp) https://github.com/bitcoin/bitcoin/pull/21200
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9bbf08bf9848...3c9d9d21e195
< bitcoin-git> bitcoin/master 6014d6e Sebastian Falbesoner: zmq test: dedup message reception handling in ZMQSubscriber
< bitcoin-git> bitcoin/master 8666033 Sebastian Falbesoner: zmq test: accept arbitrary sequence start number in ZMQSubscriber
< bitcoin-git> bitcoin/master 5c65463 Sebastian Falbesoner: zmq test: fix flakiness by using more robust sync method
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21008: test: fix zmq test flakiness, improve speed (master...2021-test-zmq-fix_flakiness) https://github.com/bitcoin/bitcoin/pull/21008
< bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3c9d9d21e195...92fee79dab38
< bitcoin-git> bitcoin/master 7a6c46b James O'Beirne: chainparams: add allowed assumeutxo values
< bitcoin-git> bitcoin/master f6e2da5 James O'Beirne: simplify ChainstateManager::SnapshotBlockhash() return semantics
< bitcoin-git> bitcoin/master ad949ba James O'Beirne: txdb: don't reset during in-memory cache resize
< bitcoin-git> [bitcoin] laanwj merged pull request #19806: validation: UTXO snapshot activation (master...2020-08-au.activate) https://github.com/bitcoin/bitcoin/pull/19806
< bitcoin-git> [bitcoin] achow101 opened pull request #21201: rpc: Disallow sendtoaddress and sendmany when private keys disabled (master...fix-sendmoney) https://github.com/bitcoin/bitcoin/pull/21201
< jamesob> Alright! Time to rebase the parent assumeutxo PR.
< fjahr> jamesob: \o/
< jamesob> :)
< luke-jr> ##Taproot-activation
< CubicEarth> ^^^ meeting is starting now ^^^
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #21202: [validation] Two small clang lock annotation improvements (master...2021-02-locks) https://github.com/bitcoin/bitcoin/pull/21202
< ariard> congrats jamesob!
< jamesob> Thanks for the help!
< michaelfolkson> Ah wow. Indeed, congrats jamesob
< jamesob> Thanks. Still a few PRs to go before AU is usable