< bitcoin-git>
[bitcoin] DariusParvin opened pull request #21178: test: run mempool_reorg.py even with wallet disabled (master...mempool-reorg-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/21178
< bitcoin-git>
[bitcoin] jonatack opened pull request #21181: p2p: if no anchors.dat file, log a message instead of an error (master...log-message-instead-of-error-if-missing-anchors) https://github.com/bitcoin/bitcoin/pull/21181
< bitcoin-git>
[bitcoin] jonatack closed pull request #21171: Save client version to the settings file on shutdown (master...persist-version-on-shutdown) https://github.com/bitcoin/bitcoin/pull/21171
< fanquake>
aj: Thanks. Sorting out that PR is my TODO list for this arvo 😅. Will take a look at your changes
< aj>
fanquake: it just fixes conflicts, and switches from gmtime_int() from the parent commit (0512b02750e301324861007e78405ed4aea9fe51) to gmtime directly
< aj>
fanquake: (as a result, could be worth noting that the sanitycheck is not thread-safe in the header file i guess)
< fanquake>
aj: ok, thanks. Was also thinking about moving that into compat/time_sanity.cpp
< aj>
fanquake: sure
< aj>
fanquake: mostly wanted to make sure there wasn't anything crazy hard blocking things before i asked you how it was going :)
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21185: fuzz: Remove expensive and redundant from cryto fuzz target (master...2102-speedupFuzz) https://github.com/bitcoin/bitcoin/pull/21185
< aj>
jnewbery: have you considered moving the eviction logic/weighting to net_processing btw?
< bitcoin-git>
[bitcoin] jnewbery closed pull request #20925: RFC: Move Peer and PeerManagerImpl declarations to separate header (master...2021-01-peermanimplh) https://github.com/bitcoin/bitcoin/pull/20925
< bitcoin-git>
[bitcoin] jnewbery opened pull request #21186: Net/Net Processing: Move addr data into net_processing (master...2020-02-addr-in-peer) https://github.com/bitcoin/bitcoin/pull/21186
< bitcoin-git>
[bitcoin] jnewbery opened pull request #21187: [net processing] Add Peer& arg to MaybeDiscourageAndDisconnect() (master...2021-02-getpeerlocaladdr) https://github.com/bitcoin/bitcoin/pull/21187
< bitcoin-git>
[bitcoin] jonatack closed pull request #21181: p2p: if no anchors.dat file, log a message instead of an error (master...log-message-instead-of-error-if-missing-anchors) https://github.com/bitcoin/bitcoin/pull/21181
< jnewbery>
aj: the eviction logic uses a mixture of metrics from the net layer (connection establishment time, connection type, net group, islocal, ..) and net_processing layer (most recent block, most recent tx, bloom filter, ...), and is necessarily invoked in the net layer (when a new inbound connection is attempted).
< jnewbery>
I don't think it would make sense for it to live in net_processing. I think it should stay in net (or be broken out into an entirely new component)
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21188: scripted-diff: Remove shadowing lock annotations in net processing (master...2102-netProcNoShadow) https://github.com/bitcoin/bitcoin/pull/21188
< bitcoin-git>
[bitcoin] jonatack reopened pull request #21181: p2p: if no anchors.dat file, log a message instead of an error (master...log-message-instead-of-error-if-missing-anchors) https://github.com/bitcoin/bitcoin/pull/21181
< jonatack>
MarcoFalke: hebasto: looking at 21188, what is the "header" being referred to?
< MarcoFalke>
class PeerManagerImpl { ... }
< MarcoFalke>
(usually the stuff that is put in the header)
< aj>
"declaration"
< MarcoFalke>
"member specification in the class declaration"
< jonatack>
thanks! iiuc, for example, the lock declaration annoted to the MarkBlockAsReceived::L424 declaration covers the MarkBlockAsReceived::L649 definition
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21190: net: Avoid discouraging the onion proxy when one inbound onion misbehaves (master...2102-netOnionInboundDiscourage) https://github.com/bitcoin/bitcoin/pull/21190
< aj>
morcos: on the off-chance you're checking irc in the next 20m; ping re: #21161 ? current patch make sense to you?
< morcos>
aj: i missed you, i need to look through it closer... will try tomorrow. long weekend here.
< hebasto>
jonatack: anyway the scope of those annotations is limited to a translation unit only
< bitcoin-git>
[bitcoin] laanwj opened pull request #21192: cli: Treat high detail levels as maximum in -netinfo (master...2021-02-netinfo-verbosity) https://github.com/bitcoin/bitcoin/pull/21192