<bitcoin-git>
bitcoin/master e3de7cb MarcoFalke: Merge bitcoin/bitcoin#24102: mempool: Run coin.IsSpent only once in a row
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24102: mempool: Run coin.IsSpent only once in a row (master...2201-mempoolCoinOnce) https://github.com/bitcoin/bitcoin/pull/24102
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
RDK has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
RDK has quit [Remote host closed the connection]
RDK has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
bitdex has quit [Quit: = ""]
brunoerg has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
pergaminho has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
baakeydow has quit [Quit: baakeydow]
baakeydow has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24138: index: Commit MuHash and best block together for coinstatsindex (master...202201_coinstatsindex_commits) https://github.com/bitcoin/bitcoin/pull/24138
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 240 seconds]
dougefish_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Remote host closed the connection]
dougefish has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
baldur has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
RDK_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
RDK has quit [Read error: Connection reset by peer]
gleb74543866 has joined #bitcoin-core-dev
gleb7454386 has quit [Ping timeout: 268 seconds]
gleb74543866 is now known as gleb7454386
sirdigby727 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24139: Avoid unsigned integer overflow in bitcoin-tx (master...2201-utilTxOverflow) https://github.com/bitcoin/bitcoin/pull/24139
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
<stickies-v>
Any suggestions for best practices on rebasing? Currently I'm rebasing from upstream master whenever I force push changes (e.g. from review comments) to keep my branch up to date. However, this makes the "x force-pushed y" diffs on GitHub less legible because they include all the irrelevant changes that happened on master too. Is it better practice to only rebase when there are merge conflicts?
brunoerg has quit [Ping timeout: 268 seconds]
RDK_ has quit [Quit: Leaving]
Guest57 has joined #bitcoin-core-dev
Guest57 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 240 seconds]
<achow101>
stickies-v: you should pretty much only rebase when there are merge conflicts. drahtbot will make a post when there are conflicts to let you know when to rebase.
brunoerg has quit [Ping timeout: 268 seconds]
<stickies-v>
ty achow101 . I'll do that going forward
<hebasto>
stickies-v: using gh for checking diff is not best practice itself, and git range-diff works well for comparing branches after rebasing
gnaf has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master e8a6c88 fanquake: build: point to latest commit on the master branch
<bitcoin-git>
bitcoin/master 8588591 fanquake: guix: ignore additioanl failing certvalidator test
<bitcoin-git>
bitcoin/master 9ec3991 MarcoFalke: Merge bitcoin/bitcoin#24057: guix: point to recent commit on the master br...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24057: guix: point to recent commit on the master branch (master...actually_fix_guix) https://github.com/bitcoin/bitcoin/pull/24057
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
rex4539_ is now known as rex4539
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] shaavan opened pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
Guest3748 has joined #bitcoin-core-dev
Guest3748 has quit [Client Quit]
too_harsh has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sirdigby727 has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
Guyver2_ is now known as Guyver2
Talkless has joined #bitcoin-core-dev
too_harsh has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Guest35 has joined #bitcoin-core-dev
Guest35 has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
Guyver2 has quit [Ping timeout: 250 seconds]
Guyver2 has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
bomb-on has quit [Read error: Connection reset by peer]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] luke-jr opened pull request #537: Point out position of invalid characters in Bech32 addresses (master...gui_bech32_errpos) https://github.com/bitcoin-core/gui/pull/537
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has quit [Ping timeout: 256 seconds]
andytoshi has quit [Quit: leaving]
andytoshi has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
too_harsh has joined #bitcoin-core-dev
SpaceDwarf has joined #bitcoin-core-dev
SpaceDwarf has left #bitcoin-core-dev [#bitcoin-core-dev]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
too_harsh has quit [Quit: Client closed]
rex4539 has joined #bitcoin-core-dev
ziggie has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Remote host closed the connection]
andytoshi has quit [Ping timeout: 256 seconds]
andytoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has joined #bitcoin-core-dev
Guest8443 has joined #bitcoin-core-dev
Guest8443 has quit [Client Quit]
brunoerg has quit [Ping timeout: 256 seconds]
yanmaani has quit [Ping timeout: 276 seconds]
pergaminho has quit []
___nick___ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
yanmaani has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]