brunoerg has joined #bitcoin-core-dev
sdfgsdfg has quit [K-Lined]
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
sdfgsdfg has quit [Ping timeout: 256 seconds]
sdfgsdfg has joined #bitcoin-core-dev
sdfgsdfg has quit [K-Lined]
sipsorcery has quit [Ping timeout: 250 seconds]
dgjhdgj2 has joined #bitcoin-core-dev
dgjhdgj2 has quit [K-Lined]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 276 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
sdfgsdfg has joined #bitcoin-core-dev
sdfgsdfg has quit [Client Quit]
AaronvanW has quit [Quit: Leaving...]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
jespada has quit [Ping timeout: 250 seconds]
jespada has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
outfox has quit [Ping timeout: 240 seconds]
outfox has joined #bitcoin-core-dev
outfox has quit [Changing host]
outfox has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 240 seconds]
jarthur_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Authenticity has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Authenticity has quit [Changing host]
Authenticity has joined #bitcoin-core-dev
Authenticity has quit [Quit: You attract the wrong things if you have no sense of who you are]
sdfgsdfg has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
jarthur_ has quit [Ping timeout: 240 seconds]
jarthur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
sudoforge has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: You attract the wrong things if you have no sense of who you are]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Guest9 has joined #bitcoin-core-dev
Guest9 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sdfgsdfg has joined #bitcoin-core-dev
kabaum has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
kabaum has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
kabaum has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
gleb745438 has quit [Ping timeout: 256 seconds]
salvatoshi has joined #bitcoin-core-dev
gleb7454386 has joined #bitcoin-core-dev
baldur has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
sipsorcery has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master 224d878 Hennadii Stepanov: net, refactor: Drop tautological local variables
<bitcoin-git> bitcoin/master 3073a99 Hennadii Stepanov: scripted-diff: Rename CNetMessage::m_command with CNetMessage::m_type
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d859cbd794a...973c39029808
<bitcoin-git> bitcoin/master 973c390 MarcoFalke: Merge bitcoin/bitcoin#24078: net, refactor: Rename CNetMessage::m_command ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24078: net, refactor: Rename CNetMessage::m_command with CNetMessage::m_type (master...220115-message) https://github.com/bitcoin/bitcoin/pull/24078
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
gnaf has joined #bitcoin-core-dev
luke-jr has quit [Quit: ZNC - http://znc.sourceforge.net]
luke-jr has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
mikehu44 has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sdfgsdfg has quit [Quit: You attract the wrong things if you have no sense of who you are]
mikehu44 has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Nikhil09 has joined #bitcoin-core-dev
Nikhil09 has quit [Client Quit]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24136: Extract CTxIn::MAX_SEQUENCE_NONFINAL constant, rework BIP 65/68/112 docs (master...2201-docSeq) https://github.com/bitcoin/bitcoin/pull/24136
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
secondl1ght[m] has quit [Quit: You have been kicked for being idle]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
jonatack has quit [Ping timeout: 256 seconds]
bomb-on has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 268 seconds]
kexkey has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24137: doc: Rework generate* doc (master...2201-docBlock) https://github.com/bitcoin/bitcoin/pull/24137
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sdfgsdfg has quit [Quit: You attract the wrong things if you have no sense of who you are]
brunoerg has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/973c39029808...b3122e167a02
<bitcoin-git> bitcoin/master d8dfc40 anouar kappitou: script: redirecting stderr to stdout before pipelining into grep
<bitcoin-git> bitcoin/master 30df5c3 anouar kappitou: script: preventing non-compatible sed binary.
<bitcoin-git> bitcoin/master b3122e1 MarcoFalke: Merge bitcoin/bitcoin#23543: test: Prevent non-compatible sed binary for s...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23543: test: Prevent non-compatible sed binary for scripted-diffs (master...improve-scripted-diff-check) https://github.com/bitcoin/bitcoin/pull/23543
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 256 seconds]
jonatack has quit [Ping timeout: 256 seconds]
sdfgsdfg has quit [Ping timeout: 268 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/b3122e167a02...b32f0d3af1e0
<bitcoin-git> bitcoin/master c4a31ca w0xlt: scripted-diff: rename cs_addrLocal -> m_addr_local_mutex
<bitcoin-git> bitcoin/master 93609c1 w0xlt: p2p: add assertions and negative TS annotations for m_addr_local_mutex
<bitcoin-git> bitcoin/master dec787d w0xlt: refactor: replace RecursiveMutex `m_addr_local_mutex` with Mutex
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24108: Replace RecursiveMutex `cs_addrLocal` with Mutex, and rename it (master...change_cs_addrLocal) https://github.com/bitcoin/bitcoin/pull/24108
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master fa2bcc4 MarcoFalke: Run coin.IsSpent only once in a row
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b32f0d3af1e0...e3de7cb90397
<bitcoin-git> bitcoin/master e3de7cb MarcoFalke: Merge bitcoin/bitcoin#24102: mempool: Run coin.IsSpent only once in a row
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24102: mempool: Run coin.IsSpent only once in a row (master...2201-mempoolCoinOnce) https://github.com/bitcoin/bitcoin/pull/24102
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [gui] meshcollider opened pull request #536: Add address error location to GUI (master...202201_bech32_error_gui) https://github.com/bitcoin-core/gui/pull/536
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
RDK has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
RDK has quit [Remote host closed the connection]
RDK has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
bitdex has quit [Quit: = ""]
brunoerg has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
pergaminho has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
baakeydow has quit [Quit: baakeydow]
baakeydow has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] mzumsande opened pull request #24138: index: Commit MuHash and best block together for coinstatsindex (master...202201_coinstatsindex_commits) https://github.com/bitcoin/bitcoin/pull/24138
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 240 seconds]
dougefish_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Remote host closed the connection]
dougefish has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
baldur has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
RDK_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
RDK has quit [Read error: Connection reset by peer]
gleb74543866 has joined #bitcoin-core-dev
gleb7454386 has quit [Ping timeout: 268 seconds]
gleb74543866 is now known as gleb7454386
sirdigby727 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #24139: Avoid unsigned integer overflow in bitcoin-tx (master...2201-utilTxOverflow) https://github.com/bitcoin/bitcoin/pull/24139
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
<stickies-v> Any suggestions for best practices on rebasing? Currently I'm rebasing from upstream master whenever I force push changes (e.g. from review comments) to keep my branch up to date. However, this makes the "x force-pushed y" diffs on GitHub less legible because they include all the irrelevant changes that happened on master too. Is it better practice to only rebase when there are merge conflicts?
brunoerg has quit [Ping timeout: 268 seconds]
RDK_ has quit [Quit: Leaving]
Guest57 has joined #bitcoin-core-dev
Guest57 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 240 seconds]
<achow101> stickies-v: you should pretty much only rebase when there are merge conflicts. drahtbot will make a post when there are conflicts to let you know when to rebase.
brunoerg has quit [Ping timeout: 268 seconds]
<stickies-v> ty achow101 . I'll do that going forward
<hebasto> stickies-v: using gh for checking diff is not best practice itself, and git range-diff works well for comparing branches after rebasing
gnaf has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master e8a6c88 fanquake: build: point to latest commit on the master branch
<bitcoin-git> bitcoin/master 8588591 fanquake: guix: ignore additioanl failing certvalidator test
<bitcoin-git> bitcoin/master 9ec3991 MarcoFalke: Merge bitcoin/bitcoin#24057: guix: point to recent commit on the master br...
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e3de7cb90397...9ec3991ad3b2
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24057: guix: point to recent commit on the master branch (master...actually_fix_guix) https://github.com/bitcoin/bitcoin/pull/24057
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
rex4539_ is now known as rex4539
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] shaavan opened pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
Guest3748 has joined #bitcoin-core-dev
Guest3748 has quit [Client Quit]
too_harsh has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sirdigby727 has quit [Quit: Connection closed for inactivity]
AaronvanW has quit [Quit: Leaving...]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
Guyver2_ is now known as Guyver2
Talkless has joined #bitcoin-core-dev
too_harsh has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Guest35 has joined #bitcoin-core-dev
Guest35 has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
Guyver2 has quit [Ping timeout: 250 seconds]
Guyver2 has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
bomb-on has quit [Read error: Connection reset by peer]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [gui] luke-jr opened pull request #537: Point out position of invalid characters in Bech32 addresses (master...gui_bech32_errpos) https://github.com/bitcoin-core/gui/pull/537
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has quit [Ping timeout: 256 seconds]
andytoshi has quit [Quit: leaving]
andytoshi has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
too_harsh has joined #bitcoin-core-dev
SpaceDwarf has joined #bitcoin-core-dev
SpaceDwarf has left #bitcoin-core-dev [#bitcoin-core-dev]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
too_harsh has quit [Quit: Client closed]
rex4539 has joined #bitcoin-core-dev
ziggie has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Remote host closed the connection]
andytoshi has quit [Ping timeout: 256 seconds]
andytoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has joined #bitcoin-core-dev
Guest8443 has joined #bitcoin-core-dev
Guest8443 has quit [Client Quit]
brunoerg has quit [Ping timeout: 256 seconds]
yanmaani has quit [Ping timeout: 276 seconds]
pergaminho has quit []
___nick___ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
yanmaani has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 opened pull request #24142: Deprecate SubtractFeeFromOutputs (master...deprecate-sffo) https://github.com/bitcoin/bitcoin/pull/24142
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
Guest35 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
Guest35 has quit [Quit: Ping timeout (120 seconds)]
dhruv_ has quit [Quit: leaving]
dhruv has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
bitdex has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]