<fanquake>
Comments like that aren't adding any value, and you seem to be insinuating some attempt to do something underhanded. The CI failures are likely just due to a bad rebase.
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 240 seconds]
prayank has joined #bitcoin-core-dev
<prayank>
fanquake: it is not offtopic
<prayank>
I am not surprised by your reaction although every dev says "nothing is bad" "please don't comment" " we will close this issue", there is a perspective and background to my comments so I said. This repo might have have some extra rights with few people but everyone contributing is a part of it and I think people changing mempool related things in different PRs are unware of few things.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<sipa>
prayank: you can say whatever you want, but neither this irc channel nor issues are a place for conspiracy theories.
<sipa>
I agree with fanquake, your comment doesn't add anything, and I don't understand what you're trying to imply.
<prayank>
sipa: which part of that comment is conspiracy?
<sipa>
Come on.
<sipa>
You're implying that this PR is an attempt to sabotage.
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] JeremyRubin opened pull request #24158: Optimize Mempool Reorg logic using Epochs, improving memory usage and runtime. (master...epoch-mempool-reorg-updates) https://github.com/bitcoin/bitcoin/pull/24158
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<prayank>
sipa: deleted
<sipa>
Thanks. Please stick to contributing comstructively.
<sipa>
*constructively
x88x88x has quit [Read error: Connection reset by peer]
bitdex has joined #bitcoin-core-dev
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] RandyMcMillan opened pull request #24159: tests: commit-script-check.sh - use gsed if exists (master...1643135199-test-lint-comit-script) https://github.com/bitcoin/bitcoin/pull/24159
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<prayank>
sipa: anyone can contribute, if i say anything more it will be offtopic but it is possible to influence development and recently EU did bug bounty for some open source projects obviously there are some incentives. Maybe my comments were not correct but I still think everyone is trying to introduce bug and review PR with that perspective. Maybe I should write less before anything.
<prayank>
Mempool is treated as some hacking playground which is not true. This is True.
<sipa>
But the issue above sounds like your bitcoind is just not running, or you're running as the wrong user (why are you running bitcoin-cli as root?).
<sipa>
Which sounds unrelated to the PR.
<prayank>
its weird but never happened for other PR
<prayank>
but where else would I discuss?
<prayank>
twitter?
<sipa>
Some context would have helped. From what you pasted it sounded like you weren't sure how to use bitcoin-cli on linux.
<sipa>
I'd suggest just commenting on the PR, if you think it's related.
<prayank>
-getinfo returned results
yanmaani has joined #bitcoin-core-dev
<sipa>
Ok then what's the problem?
<prayank>
oh maybe sudo was the problem in this case. I am not as experienced as others with ljnux shells so there is no need to "this is not a support channel". I was a support engineer and but microsoft (exchange server) and have done it for more than 2 years including calls.
<sipa>
No offence, but if you're having problems with the system you're using, this isn't the place to ask for help.
<prayank>
Cool I will remember this. Thanks for your help.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
prayank has left #bitcoin-core-dev [#bitcoin-core-dev]
kinlo has quit [Ping timeout: 240 seconds]
morcos_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
morcos has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
kinlo has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] kallewoof opened pull request #24161: rpc/doc: describe using combo(privkey) to get checksum and then list … (master...202201-derivefromprivkey) https://github.com/bitcoin/bitcoin/pull/24161
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 250 seconds]
kinlo has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] kallewoof opened pull request #24162: rpc: add require_checksum flag to deriveaddresses (master...202201-deriveaddr-nochecksum) https://github.com/bitcoin/bitcoin/pull/24162
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master dd405ad MarcoFalke: Merge bitcoin/bitcoin#24154: test: add functional test for `-maxtipage` pa...
<bitcoin-git>
bitcoin/master 75656ad Sebastian Falbesoner: test: add functional test for `-maxtipage` parameter
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24154: test: add functional test for `-maxtipage` parameter (master...202201-test-add_maxtipage_test) https://github.com/bitcoin/bitcoin/pull/24154
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jeremyrubin>
prayank: sudo means something like "switch user and do" and is used to run as another user (by default, root)
<jeremyrubin>
you should probably never have to run sudo for a bitcoin-cli thing!
sipsorcery has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
jeremyrubin: I never use sudo when running bitcoind or bitcoin-cli, maybe I have tried a few times while testing few things and understand it's use. Maybe it was a mistake today or just got to learn new things. Thanks.
prayank has quit [Quit: irc thread exit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24164: build: Bump minimum required clang/libc++ to 8.0 (master...2201-clangRoll) https://github.com/bitcoin/bitcoin/pull/24164
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
kinlo has quit [Ping timeout: 250 seconds]
grettke has joined #bitcoin-core-dev
Guest53 has quit [Ping timeout: 256 seconds]
Sha256 has quit [Quit: Client closed]
sdfgsdfg has joined #bitcoin-core-dev
kinlo has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
brunoerg has quit [Ping timeout: 268 seconds]
vysn has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
jakobsn has joined #bitcoin-core-dev
guest99100 has joined #bitcoin-core-dev
kinlo has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
sdfgsdfg has quit [Quit: your partner prefers dildos]
<Guest>
My build has succeeded in Visual Studio but I am getting this message : ../bitcoin/build_msvc/x64/Debug/libbitcoinconsensus/libbitcoinconsensus.lib is not a valid Win32 application
<Guest>
Hence the program is unable to start
mikehu44 has quit [Ping timeout: 256 seconds]
<laanwj>
it's a lib, you can't start it, you'd want to start bitcoind.exe
<Guest>
I cannot loacte this exe file.. I had previously cloned the Bitcoin Core project, then installed vcpkg, then went to build_msvc folder and opened bitcoin.sln.. After that, I ran local Windows Debugger
<laanwj>
ok, no idea, never built with msvc myself, might be a matter of choosing the right target to build somehow
brunoerg has quit [Remote host closed the connection]
<laanwj>
if you do a debug build the directory will be Debug instead of Release
<Guest>
Yes
<Guest>
But I cannot find exe file in Debug
<laanwj>
apparently you only built the lib and not the exes
<hebasto>
Guest: you wrote -- 13:58:45 <Guest> I can only see this path `bitcoin\build_msvc\x64\Debug\bitcoind.exe`
<Guest>
Yes.. I wrote this.. But after that I wrote 'one sec' and corrected myself
<Guest>
Could you please tell how to build the exes?
<hebasto>
did you try without Windows Debugger?
<laanwj>
for "make" the default is to build all, dunno why msvc default would be to only build the lib, but it must be some menu or selection option
<Guest>
In documentation, it is written to type this in command line : msbuild -property:Configuration=Release -maxCpuCount -verbosity:minimal bitcoin.sln
<Guest>
But when I type this it gives the message that msbuild is not recognised
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #24167: fs: consistently use fsbridge:: for ifstream / ofstream (master...always_use_fsbridge) https://github.com/bitcoin/bitcoin/pull/24167
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
NorrinRadd has joined #bitcoin-core-dev
NorrinRadd has quit [Client Quit]
NorrinRadd has joined #bitcoin-core-dev
Guest9 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #24168: Fix some race conditions in `BanMan::DumpBanlist()` (master...220126-dump) https://github.com/bitcoin/bitcoin/pull/24168
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
NorrinRadd has quit [Client Quit]
NorrinRadd has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
sudoforge has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guest9 has quit [Quit: Client closed]
NorrinRadd has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
NorrinRadd has joined #bitcoin-core-dev
NorrinRadd has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
NorrinRadd has joined #bitcoin-core-dev
NorrinRadd has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Talkless has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
monlovesmango has quit []
erik-etsuji-kato has joined #bitcoin-core-dev
<Kaizen_Kintsugi_>
prayank, sipa, lightlike: thanks for the feedback. I'm still exploring the issue, it is something that came up in a chaincode meeting that I thought was an opportunity. I will get more details.
<Kaizen_Kintsugi_>
lightlike: It was a timeout in the shareing of a block, when a node A tells node B that it has a certain block, and then never sends the block, I think it times out in 15-20 minutes.
___nick___ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
gleb7454386 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
sipsorcery has joined #bitcoin-core-dev
<m011>
How can node connect to CJDNS peers? IS there a tutorial ?
<m011>
The CJDNS document says that I need to find trusted peers and send them a specific credential for each peer. That's it ?
arythmetic has quit [Remote host closed the connection]
<sipa>
Do you have cjdns running?
vysn has quit [Ping timeout: 268 seconds]
<m011>
Yes. `systemctl status cjdns` shows `Active: shows active (running)`
<m011>
The system is Fedora Linux 35
Nekorand has joined #bitcoin-core-dev
<sipa>
Then just run bitcoin core with -cjdnsreachable=1
<sipa>
If CJDNS addresses get rumoured on the network, your node may decide to connect to them.
<m011>
I was running it with -cjdnsreachable=0
<sipa>
Alternatively, you can use -addnode or the addnode RPC to force a connection to one of them, if you have a CJDNS address of someone you want to connect to.
<laanwj>
can you ping the address? or other addresses on the CJDNS network?
sdfgsdfg has joined #bitcoin-core-dev
<laanwj>
CJDNS is simply another network interface from the viewpoint of the application, so if bitcoin can't connect, there's a large chance something is wrong at a lower level
Talkless has quit [Quit: Konversation terminated!]
<m011>
I'm not familiar with CJDNS and not sure how to debug it, I started the node with -cjdnsreachable=1 but I've only been getting ipv4 addresses.
<sipa>
I assume that the number of CJDNS nodes on the network is extremely low, so that's not surprising.
<m011>
So it should take a while to automatically get CJDNS addresses? Even though the 12 outbound connections are filled by ipv4 (or tor) ?
<laanwj>
you'd debug it like any kind of network interface, so you could try to ping some known addresses on the CJDNS network (with "ping6"), as well as the ones added in that PR, you could also try opening TCP connections with netcat (nc -v addr port)
<sipa>
It could take forever to get outbound CJDNS peers. I don't think the outbound logic preferentially selects those over IPv4 or IPv6.
<laanwj>
it's extremely unlikely you'd automatically get cjdns addresses at this point, it's not in a release yet, any cjdns bitcoin nodes are running the master branch
<m011>
Got it. But should `addnode` work? Do you have any public CJDNS that I can add for a test?
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24170: p2p, rpc: Manual block-relay-only connections with addnode (master...202112_manual_blocksonly) https://github.com/bitcoin/bitcoin/pull/24170
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rottenstonks has quit [Remote host closed the connection]
rottenstonks has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
<laanwj>
yes, addnode should work with a cjdns address, and no, i am not running cjdns myself
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
<m011>
Got it. Thanks.
brunoerg has quit [Ping timeout: 268 seconds]
___nick___ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sdaftuar opened pull request #24171: p2p: Sync chain more readily from inbound peers during IBD (master...2022-01-download-from-inbound) https://github.com/bitcoin/bitcoin/pull/24171
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<larryruane>
Hi, I'm working on #24007 (BTW can a maintainer add the review club label?) and a reviewer suggested some minor improvements to the test ... I'm just wondering, force-pushing the suggestion immediately triggers a full CI run; would it be preferred for CI resource usage reasons to put that off and wait for a few other suggestions and force-push them all at once? Or is it not that big of a deal to trigger CI?
<jonatack>
i might write some getting started info, i.e. doc/cjdns.md
<jonatack>
m011: once you are connected to the cjdns network, then running the following will work: ./src/bitcoin-cli addnode fcc7:be49:ccd1:dc91:3125:f0da:457d:8ce onetry