#bitcoin-core-dev on 2022-07-22 — searchable irc log

00:05 brunoerg has joined #bitcoin-core-dev

00:08 brunoerg has quit [Ping timeout: 260 seconds]

00:26 <bitcoin-git> [gui] w0xlt opened pull request #634: [WIP/Draft] Add Address tab (master...address_tab) https://github.com/bitcoin-core/gui/pull/634

00:46 ghost43 has quit [Remote host closed the connection]

00:47 ghost43 has joined #bitcoin-core-dev

00:47 jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

00:53 brunoerg has joined #bitcoin-core-dev

00:57 brunoerg has quit [Ping timeout: 240 seconds]

01:21 brunoerg has joined #bitcoin-core-dev

01:23 vasild has quit [Remote host closed the connection]

01:26 brunoerg has quit [Ping timeout: 276 seconds]

01:28 vasild has joined #bitcoin-core-dev

01:50 brunoerg has joined #bitcoin-core-dev

01:54 theStack has quit [Quit: theStack]

01:55 brunoerg has quit [Ping timeout: 268 seconds]

01:57 bomb-on has quit [Quit: aллилѹіа!]

02:01 ghost43 has quit [Remote host closed the connection]

02:02 ghost43 has joined #bitcoin-core-dev

02:13 brunoerg has joined #bitcoin-core-dev

02:17 brunoerg has quit [Ping timeout: 272 seconds]

02:18 brunoerg has joined #bitcoin-core-dev

02:28 brunoerg has quit [Ping timeout: 276 seconds]

02:29 brunoerg has joined #bitcoin-core-dev

02:34 brunoerg has quit [Ping timeout: 260 seconds]

02:46 brunoerg has joined #bitcoin-core-dev

02:49 kexkey has joined #bitcoin-core-dev

02:51 brunoerg has quit [Ping timeout: 268 seconds]

02:53 ronoaldo has quit [Quit: Konversation terminated!]

03:09 brunoerg has joined #bitcoin-core-dev

03:13 brunoerg has quit [Ping timeout: 240 seconds]

03:37 brunoerg has joined #bitcoin-core-dev

03:42 brunoerg has quit [Ping timeout: 276 seconds]

03:42 brunoerg has joined #bitcoin-core-dev

03:47 brunoerg has quit [Ping timeout: 276 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:10 brunoerg has joined #bitcoin-core-dev

04:15 brunoerg has quit [Ping timeout: 268 seconds]

04:21 brunoerg has joined #bitcoin-core-dev

04:26 brunoerg has quit [Ping timeout: 268 seconds]

04:30 ghost43 has quit [Remote host closed the connection]

04:30 ghost43 has joined #bitcoin-core-dev

05:06 brunoerg has joined #bitcoin-core-dev

05:11 brunoerg has quit [Ping timeout: 272 seconds]

05:12 theStack has joined #bitcoin-core-dev

05:25 vasild has quit [Remote host closed the connection]

05:31 vasild has joined #bitcoin-core-dev

05:36 SpellChecker has quit [Quit: bye]

05:37 SpellChecker has joined #bitcoin-core-dev

05:38 ghost43 has quit [Remote host closed the connection]

05:38 yanmaani has quit [Remote host closed the connection]

05:38 evanlinjin has quit [Remote host closed the connection]

05:39 evanlinjin has joined #bitcoin-core-dev

05:39 yanmaani has joined #bitcoin-core-dev

05:39 brunoerg has joined #bitcoin-core-dev

05:39 ghost43 has joined #bitcoin-core-dev

05:44 brunoerg has quit [Ping timeout: 272 seconds]

05:45 brunoerg has joined #bitcoin-core-dev

05:50 brunoerg has quit [Ping timeout: 268 seconds]

05:50 brunoerg has joined #bitcoin-core-dev

05:51 Cory has quit [Ping timeout: 268 seconds]

05:55 brunoerg has quit [Ping timeout: 272 seconds]

06:01 SpellChecker has quit [Remote host closed the connection]

06:01 jarthur has quit [Quit: jarthur]

06:01 brunoerg has joined #bitcoin-core-dev

06:01 SpellChecker has joined #bitcoin-core-dev

06:06 brunoerg has quit [Ping timeout: 268 seconds]

06:07 brunoerg has joined #bitcoin-core-dev

06:08 sudoforge has quit [Ping timeout: 240 seconds]

06:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b8067cd43505...86133df7a2be

06:09 <bitcoin-git> bitcoin/master cc5b39e fanquake: ci: better pin to dwarf4 in valgrind job

06:09 <bitcoin-git> bitcoin/master a08c972 fanquake: contrib: remove unneeded valgrind suppressions

06:09 <bitcoin-git> bitcoin/master 86133df MacroFake: Merge bitcoin/bitcoin#25662: contrib: prune valgrind suppressions

06:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25662: contrib: prune valgrind suppressions (master...prune_valgrind_supps) https://github.com/bitcoin/bitcoin/pull/25662

06:12 brunoerg has quit [Ping timeout: 276 seconds]

06:18 brunoerg has joined #bitcoin-core-dev

06:23 yanmaani has quit [Ping timeout: 268 seconds]

06:23 brunoerg has quit [Ping timeout: 276 seconds]

06:24 brunoerg has joined #bitcoin-core-dev

06:28 brunoerg has quit [Ping timeout: 240 seconds]

06:31 yanmaani has joined #bitcoin-core-dev

06:35 brunoerg has joined #bitcoin-core-dev

06:35 yanmaani has quit [Write error: Connection reset by peer]

06:35 SpellChecker has quit [Write error: Connection reset by peer]

06:35 vasild has quit [Remote host closed the connection]

06:36 yanmaani has joined #bitcoin-core-dev

06:36 SpellChecker has joined #bitcoin-core-dev

06:39 SpellChecker has quit [Remote host closed the connection]

06:40 brunoerg has quit [Ping timeout: 272 seconds]

06:40 SpellChecker has joined #bitcoin-core-dev

06:41 brunoerg has joined #bitcoin-core-dev

06:41 vasild has joined #bitcoin-core-dev

06:45 brunoerg has quit [Ping timeout: 272 seconds]

06:51 brunoerg has joined #bitcoin-core-dev

06:57 brunoerg has quit [Ping timeout: 268 seconds]

07:01 brunoerg has joined #bitcoin-core-dev

07:02 vasild has quit [Remote host closed the connection]

07:02 SpellChecker has quit [Remote host closed the connection]

07:02 yanmaani has quit [Remote host closed the connection]

07:02 vasild has joined #bitcoin-core-dev

07:03 yanmaani has joined #bitcoin-core-dev

07:03 SpellChecker has joined #bitcoin-core-dev

07:05 brunoerg has quit [Ping timeout: 244 seconds]

07:18 <bitcoin-git> [bitcoin] Empact closed pull request #13462: Make SER_GETHASH implicit for CHashWriter and SerializeHash (master...serialize-hash-type) https://github.com/bitcoin/bitcoin/pull/13462

07:29 brunoerg has joined #bitcoin-core-dev

07:34 brunoerg has quit [Ping timeout: 276 seconds]

07:40 jonatack has quit [Ping timeout: 244 seconds]

07:41 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/86133df7a2be...510ac41eac06

07:41 <bitcoin-git> bitcoin/master faa5425 MacroFake: Add HashWriter without ser-type and ser-version

07:41 <bitcoin-git> bitcoin/master faf9acc MacroFake: Use HashWriter where possible

07:41 <bitcoin-git> bitcoin/master 510ac41 fanquake: Merge bitcoin/bitcoin#25331: Add HashWriter without ser-type and ser-versi...

07:41 <bitcoin-git> [bitcoin] fanquake merged pull request #25331: Add HashWriter without ser-type and ser-version and use it where possible (master...2206-hashwriter-👽) https://github.com/bitcoin/bitcoin/pull/25331

07:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/510ac41eac06...6dc3084eec91

07:48 <bitcoin-git> bitcoin/master fad3c58 MacroFake: refactor: Fix iwyu on node/chainstate

07:48 <bitcoin-git> bitcoin/master 6dc3084 MacroFake: Merge bitcoin/bitcoin#25668: refactor: Fix iwyu on node/chainstate

07:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25668: refactor: Fix iwyu on node/chainstate (master...2207-iwyu-👏) https://github.com/bitcoin/bitcoin/pull/25668

07:58 Guest4443 has joined #bitcoin-core-dev

08:03 brunoerg has joined #bitcoin-core-dev

08:08 brunoerg has quit [Ping timeout: 272 seconds]

08:08 brunoerg has joined #bitcoin-core-dev

08:12 brunoerg has quit [Ping timeout: 240 seconds]

08:19 brunoerg has joined #bitcoin-core-dev

08:23 brunoerg has quit [Ping timeout: 244 seconds]

08:36 brunoerg has joined #bitcoin-core-dev

08:40 brunoerg has quit [Ping timeout: 244 seconds]

08:55 aurele has quit [Ping timeout: 260 seconds]

08:58 SpellChecker has quit [Quit: bye]

08:59 aurele has joined #bitcoin-core-dev

08:59 SpellChecker has joined #bitcoin-core-dev

09:09 brunoerg has joined #bitcoin-core-dev

09:14 brunoerg has quit [Ping timeout: 255 seconds]

09:28 brunoerg has joined #bitcoin-core-dev

09:32 brunoerg has quit [Ping timeout: 240 seconds]

09:38 <willcl_ark> Why during Package Mempool Accept would it be a requirement that none of the package transactions are already present in the mempool? https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L972 (ping glozow ?)

09:39 brunoerg has joined #bitcoin-core-dev

09:44 brunoerg has quit [Ping timeout: 272 seconds]

09:45 afmencken has joined #bitcoin-core-dev

09:48 af_mencken has quit [Ping timeout: 276 seconds]

10:08 brunoerg has joined #bitcoin-core-dev

10:12 brunoerg has quit [Ping timeout: 244 seconds]

10:16 <glozow> willcl_ark: package transactions can be present in the mempool, but they're removed from the package before we get to that point in the code. see https://github.com/bitcoin/bitcoin/blob/6dc3084eec912cf2abfe18d1c05655defaa45e20/src/validation.cpp#L1390

10:18 <glozow> `CheckPackageLimits()` expects non-mempool transactions. that assertion is just making sure this precondition is met.

10:22 <willcl_ark> Thanks, this makes sense!

10:23 jonatack has joined #bitcoin-core-dev

10:31 jonatack5 has joined #bitcoin-core-dev

10:32 jonatack has quit [Ping timeout: 255 seconds]

10:38 <bitcoin-git> [bitcoin] aureleoules opened pull request #25673: refactor: make member functions const when applicable (master...2022-07-refactor) https://github.com/bitcoin/bitcoin/pull/25673

10:47 bitdex has joined #bitcoin-core-dev

10:58 brunoerg has joined #bitcoin-core-dev

11:01 evanlinjin has quit [Remote host closed the connection]

11:03 brunoerg has quit [Ping timeout: 260 seconds]

11:03 evanlinjin has joined #bitcoin-core-dev

11:17 jespada has joined #bitcoin-core-dev

11:19 jespada has quit [Read error: Connection reset by peer]

11:20 jespada has joined #bitcoin-core-dev

11:25 brunoerg has joined #bitcoin-core-dev

11:29 brunoerg has quit [Ping timeout: 240 seconds]

11:33 <bitcoin-git> [bitcoin] glozow opened pull request #25674: add unit tests for RBF rules in isolation (master...2022-07-rbf-unit-tests) https://github.com/bitcoin/bitcoin/pull/25674

11:51 clipaz has joined #bitcoin-core-dev

11:55 brunoerg has joined #bitcoin-core-dev

11:57 jonatack5 has quit [Ping timeout: 272 seconds]

11:59 clipaz has quit [Remote host closed the connection]

12:00 clipaz has joined #bitcoin-core-dev

12:06 clipaz has quit [Remote host closed the connection]

12:09 Guest4443 has quit [Ping timeout: 252 seconds]

12:20 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #22242: Move CBlockTreeDB to node/blockstorage (master...2106-blockstorage) https://github.com/bitcoin/bitcoin/pull/22242

12:37 bitdex has quit [Quit: = ""]

12:41 Guyver2 has joined #bitcoin-core-dev

13:06 <bitcoin-git> [bitcoin] vasild opened pull request #25676: sync: simplify and remove unused code from sync.h (master...improve_sync.h) https://github.com/bitcoin/bitcoin/pull/25676

13:19 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20753: rpc: Allow to ignore specific policy reject reasons (master...2012-policyRpcIgnore) https://github.com/bitcoin/bitcoin/pull/20753

13:51 <bitcoin-git> [bitcoin] aureleoules opened pull request #25677: refactor: make active_chain_tip a reference (master...2022-07-make-active-chain-ref) https://github.com/bitcoin/bitcoin/pull/25677

14:06 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

14:07 sudoforge has joined #bitcoin-core-dev

14:08 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

14:11 clipaz has joined #bitcoin-core-dev

14:23 clipaz has quit [Remote host closed the connection]

14:24 clipaz has joined #bitcoin-core-dev

14:39 Guest67 has joined #bitcoin-core-dev

14:39 jonatack has joined #bitcoin-core-dev

14:41 Guest67 has quit [Client Quit]

14:41 Guest67 has joined #bitcoin-core-dev

14:52 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

15:03 Alina-malina has quit [Remote host closed the connection]

15:04 Alina-malina has joined #bitcoin-core-dev

15:11 clipaz has quit [Remote host closed the connection]

15:30 Alina-malina has quit [Quit: !be back soon]

15:35 ronoaldo has joined #bitcoin-core-dev

15:36 deadslug has joined #bitcoin-core-dev

15:52 Alina-malina has joined #bitcoin-core-dev

16:03 clipaz has joined #bitcoin-core-dev

16:04 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

16:05 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

16:09 clipaz has quit [Remote host closed the connection]

16:25 Guest67 has quit [Quit: Client closed]

16:27 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

16:29 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

16:42 af_mencken has joined #bitcoin-core-dev

16:44 afmencken has quit [Ping timeout: 240 seconds]

16:50 jespada has quit [Quit: Textual IRC Client: www.textualapp.com]

16:50 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

16:53 ___nick___ has joined #bitcoin-core-dev

17:01 kexkey has quit [Ping timeout: 240 seconds]

17:02 kexkey has joined #bitcoin-core-dev

17:22 deadslug has quit [Remote host closed the connection]

17:22 deadslug has joined #bitcoin-core-dev

17:28 jarthur has joined #bitcoin-core-dev

17:45 * luke-jr wonders if it would defeat the point of pruning tests, to have a debug/test option that deletes the block locator entry even if the file itself isn't ready to be deleted

17:47 Guest5 has joined #bitcoin-core-dev

17:49 Guest5 has quit [Client Quit]

17:59 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

18:01 ___nick___ has joined #bitcoin-core-dev

18:01 ___nick___ has quit [Client Quit]

18:03 ___nick___ has joined #bitcoin-core-dev

18:12 Talkless has joined #bitcoin-core-dev

18:12 jonatack has quit [Ping timeout: 276 seconds]

18:23 deadslug has quit [Ping timeout: 264 seconds]

18:28 bomb-on has joined #bitcoin-core-dev

18:39 clipaz has joined #bitcoin-core-dev

19:00 brunoerg has quit [Remote host closed the connection]

19:01 brunoerg has joined #bitcoin-core-dev

19:05 brunoerg has quit [Ping timeout: 276 seconds]

19:11 brunoerg has joined #bitcoin-core-dev

19:16 brunoerg has quit [Ping timeout: 260 seconds]

19:18 brunoerg has joined #bitcoin-core-dev

19:22 brunoerg has quit [Ping timeout: 272 seconds]

19:24 brunoerg has joined #bitcoin-core-dev

19:27 clipaz has quit [Remote host closed the connection]

19:28 brunoerg has quit [Ping timeout: 240 seconds]

19:30 clipaz has joined #bitcoin-core-dev

19:34 brunoerg has joined #bitcoin-core-dev

19:47 jarthur has quit [Quit: jarthur]

19:53 clkmyfsh has joined #bitcoin-core-dev

19:53 clkmyfsh has quit [Client Quit]

20:04 ___nick___ has quit [Ping timeout: 276 seconds]

20:14 Talkless has quit [Quit: Konversation terminated!]

20:48 brunoerg has quit [Ping timeout: 268 seconds]

20:52 clipaz has quit [Remote host closed the connection]

20:54 brunoerg has joined #bitcoin-core-dev

20:57 clipaz has joined #bitcoin-core-dev

21:05 clipaz has quit [Remote host closed the connection]

21:06 luke-jr has quit [Read error: Connection reset by peer]

21:07 clkmyfsh has joined #bitcoin-core-dev

21:10 luke-jr has joined #bitcoin-core-dev

21:30 <bitcoin-git> [bitcoin] mzumsande opened pull request #25678: p2p: skip querying dns seeds if `-onlynet` disables IPv4 and IPv6 (master...202207_onlynet_dns) https://github.com/bitcoin/bitcoin/pull/25678

21:43 <bitcoin-git> [bitcoin] achow101 opened pull request #25679: wallet: Correctly identify external inputs that are also in the wallet (master...fix-external-but-have-tx) https://github.com/bitcoin/bitcoin/pull/25679

21:43 afmencken has joined #bitcoin-core-dev

21:44 kexkey has quit [Quit: kexkey]

21:44 af_mencken has quit [Ping timeout: 240 seconds]

21:45 luke-jr has quit [Ping timeout: 268 seconds]

21:47 kexkey has joined #bitcoin-core-dev

21:51 kexkey has quit [Ping timeout: 244 seconds]

21:53 kexkey has joined #bitcoin-core-dev

21:58 brunoerg has quit [Ping timeout: 272 seconds]

21:59 brunoerg has joined #bitcoin-core-dev

22:02 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

22:03 brunoerg has quit [Ping timeout: 240 seconds]

22:07 AaronvanW has quit [Quit: Leaving...]

22:10 brunoerg has joined #bitcoin-core-dev

22:11 Alina-malina has quit [Ping timeout: 240 seconds]

22:13 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

22:13 luke-jr has joined #bitcoin-core-dev

22:13 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

22:26 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

22:39 Alina-malina has joined #bitcoin-core-dev

22:42 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

22:49 Guest14 has joined #bitcoin-core-dev

22:50 Alina-malina has quit [Ping timeout: 240 seconds]

22:51 d19mc has joined #bitcoin-core-dev

22:51 d19mc has quit [Client Quit]

22:54 Alina-malina has joined #bitcoin-core-dev

22:56 weez22 has joined #bitcoin-core-dev

23:01 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

23:03 Alina-malina has quit [Ping timeout: 244 seconds]

23:08 Alina-malina has joined #bitcoin-core-dev

23:08 Guest14 has quit [Quit: Client closed]

23:17 brunoerg has quit [Ping timeout: 268 seconds]

23:18 brunoerg has joined #bitcoin-core-dev

23:19 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

23:20 Kaizen_K_ has joined #bitcoin-core-dev

23:21 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

23:23 brunoerg has quit [Ping timeout: 268 seconds]

23:23 brunoerg has joined #bitcoin-core-dev

23:23 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

23:28 brunoerg has quit [Ping timeout: 276 seconds]

23:29 brunoerg has joined #bitcoin-core-dev

23:41 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

23:44 Kaizen_K_ has quit [Ping timeout: 240 seconds]