vasild has quit [Remote host closed the connection]
<stevenroose>
qt crashes when trying to encrypt a watchonly wallet
<stevenroose>
it prompts for the passphrase and then hangs about 5 seconds and crashes
<fanquake>
stevenroose: master?
<stevenroose>
fanquake: v22.0.0 release
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #25618: Release notes for Miniscript support in P2WSH descriptors (master...changelog_miniscript_descriptors) https://github.com/bitcoin/bitcoin/pull/25618
ghost43 has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
evanlinjin has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] vasild opened pull request #25619: net: avoid overriding non-virtual ToString() in CService and use better naming (master...CNetAddr_ToString) https://github.com/bitcoin/bitcoin/pull/25619
<bitcoin-git>
[bitcoin] fanquake merged pull request #25551: refactor: Throw exception on invalid Univalue pushes over silent ignore (master...2207-json-push-🎬) https://github.com/bitcoin/bitcoin/pull/25551
<provoostenator>
stevenroose: it should not be possible to encrypt a watch-only wallet. But it should defeinately not crash when you try... cc achow101
<provoostenator>
(ah I see you're already looking at it)
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
<stevenroose>
provoostenator: so only keys are encrypted? not the metadata and descriptors etc?
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
<sipa>
Yes, only private keys are encrypted.
<sipa>
This was a popular way of constructing watch-only wallets before there was actual support for that (and a scammer technique...): construct a wallet with public keys matching what you want to watch, and encrypted garbage as their private keys.
<bitcoin-git>
[gui] achow101 opened pull request #631: Disallow encryption of watchonly wallets (master...watchonly-disable-encryption) https://github.com/bitcoin-core/gui/pull/631
<achow101>
^ that should fix that problem
<sipa>
You only need to provide the private key when spending effectively (or a few other operations, like importing more keys).
ronoaldo has quit [Ping timeout: 276 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
adam2k[m] has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
adam2k has quit [Quit: Connection closed]
javi404 has quit [Remote host closed the connection]
nanotube has quit [Ping timeout: 256 seconds]
evanlinjin has quit [Ping timeout: 268 seconds]
javi404 has joined #bitcoin-core-dev
provoostenator has quit [Ping timeout: 240 seconds]
blackmarble has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
<dongcarl>
Hi all. Would it make sense to `InitCoinsDB` and `InitCoinsCache` in `CChainState`'s constructor? They both return void and are always called after every `CChainState` construction (the one and only exception being the `chainstatemanager_loadblockindex` test). It'd be cleaner, we can remove a few checks for the existence of `m_coins_views`, and
<dongcarl>
might improve memory locality.
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 276 seconds]
<bitcoin-git>
[bitcoin] anibilthare opened pull request #25621: rpc/wallet: Add details and duplicate section for simulaterawtransaction (master...202108-analyzerawtransaction) https://github.com/bitcoin/bitcoin/pull/25621
<sipa>
@dongcarl It sounds like you accidentally a verb?
<dongcarl>
sipa: Huh?
<sipa>
Your first sentence above seems to be missing a verb.
<dongcarl>
I'm letting the `Init` in `InitCoinsDB` be the verb if that's what you're talking about :-)
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<sipa>
Ah.
<dongcarl>
I guess we can say "call `InitCoinsDB`", but it might actually make sense to entirely remove the `InitCoinsDB` function entirely :-)
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<provoostenator>
Despite normalising descriptors, I guess we don't guarantee that a scriptPubKey never matches more than 1 descriptor? (context #25504)
<provoostenator>
In other words, that PR needs to introduce parent_descs plural.
<sipa>
@Sjors That is obviously impossible. Every descriptor's output can be matched with an addr(ADDR) descriptor.
<sipa>
Inpossible to guarantee, I mena.
<instagibbs>
same keys but different key origin info too, IIURC
<provoostenator>
In that case you could prefer the non-addr() descriptor? Same with combo(). Any others?
<sipa>
Though I think it's possible in case tbere are multiple matching descriptors to "merge" them into a most-informative one.
<sipa>
With the partial information descriptors (I forgot the issue number) that may become generally useful too.
<provoostenator>
instagibbs: different origin info makes sense, especially in a watch-only scenario where you might not have the derivation all the way from the seed
<provoostenator>
It's just an aesthetic nuisance. Probably not worth rocket science to solve.
<provoostenator>
Someone using two overlapping descriptors in the same wallet hopefully knows what they're doing; that seems like a confusing situation.
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Remote host closed the connection]
yanmaani has quit [Remote host closed the connection]
evanlinjin has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
jespada_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 240 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<bytes1440000>
Having a different opinion, trying to contribute or seeing a gang of simps isn't new for me although this is open source repo for decentralized network
<bytes1440000>
i am new in this respository but not new in this world. i have seen people who do not respect new contributors in my whole life and some incidents are not even mentioned. this will not work with me in case you are trying it because of some victory in past or being entertained because of some reasons.
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]