Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
_apex2_ has joined #bitcoin-core-dev
Guest34 has joined #bitcoin-core-dev
Guest34 has quit [Client Quit]
_apex2_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Cory has quit [Ping timeout: 268 seconds]
Pasha has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_K_ has quit [Ping timeout: 252 seconds]
vysn has quit [Ping timeout: 268 seconds]
Guest26 has joined #bitcoin-core-dev
Guest26 has quit [Client Quit]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
<ariard>
laanwj: many thanks for the ~10y of project maintenance and the standard set in terms of dedication and commitment in that space, I wish you the really best for your personal projects and I hope you'll keep contributing to the repo
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
AaronvanW has quit [Remote host closed the connection]
_apex2_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
bomb-on has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
bomb-on has quit [Quit: aллилѹіа!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
AaronvanW has quit [Ping timeout: 268 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
<bitcoin-git>
bitcoin/master 4786959 Ben Woosley: bench: Add a benchmark for descriptor expansion
<bitcoin-git>
bitcoin/master bf3f05f MacroFake: Merge bitcoin/bitcoin#25785: bench: Add a benchmark for descriptor expansi...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25785: bench: Add a benchmark for descriptor expansion (master...2208-bench-desc-🍉) https://github.com/bitcoin/bitcoin/pull/25785
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
vasild has quit [Ping timeout: 268 seconds]
<bitcoin-git>
[bitcoin] aureleoules opened pull request #25830: refactor: Replace m_params with chainman.GetParams() (master...2022-08-replace-m_params) https://github.com/bitcoin/bitcoin/pull/25830
sdaftuar has quit [Quit: WeeChat 2.8]
sdaftuar4 is now known as sdaftuar
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
<bitcoin-git>
[bitcoin] aureleoules opened pull request #25831: refactor: Remove trailing semicolon from LOCK2 macro (master...2022-08-macro-trailing-semicolon) https://github.com/bitcoin/bitcoin/pull/25831
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
_andrewtoth_ has quit [Remote host closed the connection]
bitdex has quit [Remote host closed the connection]
evanlinjin has quit [Remote host closed the connection]
yanmaani has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
SpellChecker has quit [Write error: Broken pipe]
brunoerg has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
brunoerg has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
<bytes1440000>
I see a need for "janitorial maintainer" who understands the importance of privacy in core and privacy of contributors. Since #25560 is still open and intent of reviewers doesn't look they want to improve anything in the process, there is no "call for maintainers" thing.
<gribble>
https://github.com/bitcoin/bitcoin/issues/25560 | [WIP] Add a MAINTAINERS.md file and desribe the role of maintainer more directly by JeremyRubin · Pull Request #25560 · bitcoin/bitcoin · GitHub
<bytes1440000>
I would prefer someone who has already contributed to bitcoin privacy and privacy in general, not living in first world countries and not funded by brink.
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
ariard: thank you!
AaronvanW has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<jnewbery>
laanwj: Thank you for all of your hard work. Enjoy your retirement :)
AaronvanW has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Client Quit]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
<lightlike>
+1, thank you laanwj!
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 255 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
Kaizen_K_ has quit [Ping timeout: 268 seconds]
dviola has left #bitcoin-core-dev [#bitcoin-core-dev]
_apex2_ has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 268 seconds]
djsbtc[m] has quit [Quit: You have been kicked for being idle]
<vasild>
#proposedmeetingtopic vasild for a new maintainer with a focus on P2P/networking
djsbtc[m] has joined #bitcoin-core-dev
<vasild>
I volunteer, if there is a perceived need for that.
djsbtc[m] has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
<bytes1440000>
vasild: thanks for volunteering and i think you are the best candidate for p2p/privacy. I wish we had one for mempool/privacy and wallet/privacy as well.
andrewtoth_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bytes1440000>
I had one question after I looked at #25355 and some conversation with u/alreadybrunt on i2p subreddit. Java router and I am assuming C++ router as well has some limits.
<bytes1440000>
What if an attacker tries to establish outbound connections with your node from different i2p addresses out of max sessions. Didn't get time to test it.
_andrewtoth_ has quit [Remote host closed the connection]
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 255 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
ynnitan has joined #bitcoin-core-dev
<vasild>
bytes1440000: an attacker can easily do that even without #25355
<S3RK_>
yep, I used it on a VM. Do you imagine just running simulation as a CI for each PR?
<achow101>
I think that would be useful, but would probably have to be separate from our actual CI
<achow101>
since they can take a really long time
<S3RK_>
wouldn't we hit some limits in terms of CPU/jobs or run time?
brunoerg has joined #bitcoin-core-dev
<S3RK_>
sound heavy to run sims for all PRs
<achow101>
yeah
<furszy>
and there shouldn't be many PRs changing behavior there
<achow101>
maybe something like the "guix build requested" label
<S3RK_>
that's interesting
<instagibbs>
yeah
<achow101>
so we could just run it on the prs that would effect coin selection
<Murch>
hi
<Murch>
Yeah, that sounds interesting
<Murch>
So far I've been running simulations manually, it would definitely be nice to get it automatically. How could we control how often it gets run though?
<Murch>
Let's say if you spot a typo and forcepush to fix briefly after pushing, it shouldn't do the whole simulation twice.
brunoerg has quit [Ping timeout: 268 seconds]
<Murch>
Perhaps if we leave a few hours until kicking off the simulation and only run it for the latest version?
brunoerg has joined #bitcoin-core-dev
<S3RK_>
I like the idea with using a label to trigger the CI
<achow101>
if we do it the same way that drahtbot guix builds work, then it's basically just triggered manually whenever the label is added
<achow101>
the bot removes the label when it's done
<Murch>
Who can add labels?
<achow101>
anyone who has the permission
<S3RK_>
hm.. is it a separate permission? I think I can't modify lables even for my PRs
brunoerg has quit [Ping timeout: 264 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
<achow101>
it's a separate permission, but I think we give it out pretty freely
<S3RK_>
it's good that it's separate
SpellChecker has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
<S3RK_>
If nobody have more topics, I have one more thing about #25647
<Murch>
right now fees are so low, I'd say close it and just match the legacy outputs, but in the long-term I do think that it would potentially create unexpected costs for users
<Murch>
that is, not to merge it
<S3RK_>
if you don't want to create legacy change outputs you shouldn't have a descriptor
<S3RK_>
it's possible to deactivate a descriptor
<S3RK_>
unless we're talking legacy wallets :D
<achow101>
well legacy wallets are still a thing
<Murch>
S3RK_: I think we have to operate under the assumption that most users will never change a config option or otherwise customize their wallet
<S3RK_>
I can see why asking users to understand decsriptors could be too much
<Murch>
And it might feel "more surprising" to a user that they suddenly sent themselves a legacy change output than the opposite
<S3RK_>
but do you think it's too much for them to be aware what types their wallet supports?
_apex2_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<Murch>
Yeah
<S3RK_>
it feels to me adding more special cases like this make wallet behavior opaque and unpredictable in a way
<Murch>
I think that most users would probably be aware w
<Murch>
of the type of outputs they use for receivling only
<S3RK_>
this is already good enough
<Murch>
S3RK_: "Special case" as in not matching the recipient with the change just for legacy, or "special case" matching recipient outputs in the first place?
<S3RK_>
the first
<achow101>
I think right now it's not a problem, and perhaps we could revisit this if users start complaining or we see a noticeable increase in legacy usage?
real_or_random has quit [Quit: Connection closed for inactivity]
<achow101>
I would hope this becomes moot and legacy usage dies out
<Murch>
achow101: Alright, then let's close it for now?
<achow101>
sure
<Murch>
Yeah, hopefully before feerates go up again, or at least when feerates start going up again…
<achow101>
further proposals like josie[m]'s idea of using a different address type for change when the inputs match the recipients would also mitigate this somewhat
SpellChecker has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
_apex2_ has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<achow101>
anything else to talk about in the last minute of the meeting?
<Murch>
I like the idea (but then, it was mine :p), but I think it should only happen when we would use the given input set already for cost reasons until we have a better way to score privacy benefits in a numeric fashion
<S3RK_>
Murch, how do folks control receiving types today? Is it possible to setup default in GUI?
brunoerg has joined #bitcoin-core-dev
<Murch>
I think it should be possible in the receive tab to pick the output type, yes
<Murch>
And otherwise the default is currently bech32, afair
<S3RK_>
then you can contorl change type there as well
<furszy>
yep, there is a spin box there
<S3RK_>
otherwise if you have an option to setup default, it would be a good place to also setup your defaults for change output types
brunoerg_ has joined #bitcoin-core-dev
<S3RK_>
I don't really see how recipient types and change types that much different
___nick___ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
S3RK_ is now known as S3RK
vasild has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
yanmaani has quit [Remote host closed the connection]
bitdex has quit [Read error: Connection reset by peer]
vasild has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 closed pull request #24362: wallet: Do not match legacy addresses for change type (master...rm-legacy-change) https://github.com/bitcoin/bitcoin/pull/24362
vasild has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg_ has quit [Remote host closed the connection]