<sipa>
That would depend on the purpose of that hash, but in general that sounds very unsafe to me.
<sipa>
If an attacker can observe behavior that derives from the result of that "hash", they can learn the salt, and then grind hashes to achieve whatever effect you were preventing them to get by using a salted hash.
<elichai2>
hmmm you're right, xor is too straight forward for that. Another thing is, does it give any advantage to feed siphash the full SHA256 digest instead of just the first 64bits considering that siphash is also 64bits?
<elichai2>
(I also see that `BlockHasher` just reads the first 64bits, but supposedly it's very expensive to DoS the hash of a block because of PoW)
<sipa>
Yeah, blocks are subject to the world's best DoS resistance system already.
andytoshi has quit [Remote host closed the connection]
andytoshi has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 255 seconds]
sudoforge has quit [Quit: 404]
sudoforge has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
sipsorcery has quit [Ping timeout: 268 seconds]
sipsorcery has joined #bitcoin-core-dev
_apex2_ has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
_apex2_ has quit [Ping timeout: 268 seconds]
sipsorcery has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 268 seconds]
<jeremyrubin>
elichai2: note that we care quite a bit which 64 bits we read for block hasher
_apex2_ has joined #bitcoin-core-dev
murrayn has quit [Ping timeout: 264 seconds]
_apex2_ has quit [Ping timeout: 244 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
_apex2_ has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
_apex2_ has quit [Client Quit]
<laanwj>
jeremyrubin: thank you!
___nick___ has quit [Ping timeout: 268 seconds]
<bitcoin-git>
[gui] achow101 opened pull request #653: gui: Show watchonly balance only for Legacy wallets (master...show-bal-send) https://github.com/bitcoin-core/gui/pull/653
andrewtoth_ has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
justache has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]