<bitcoin-git>
[bitcoin] ishaanam opened pull request #26084: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26084
<luke-jr>
are there really that many merged PRs that didn't get at least one "review approval"? XD
Guest15 has joined #bitcoin-core-dev
<achow101>
i haven't really noticed people using the approve button, other than spammers
<luke-jr>
…
kexkey has quit [Quit: kexkey]
kexkey has joined #bitcoin-core-dev
Guest15 has quit [Quit: Client closed]
_apex_ has quit [Ping timeout: 252 seconds]
Evel-Knievel has quit []
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 265 seconds]
realies has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 244 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
fjMSX has quit [Remote host closed the connection]
Evel-Knievel has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 264 seconds]
<fanquake>
I'll delete the revert-26081-sendall_maxtxfee branch that is hanging around
vasild has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<elichai2>
Is there any reason not to implement an allocation free implementation for https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L67? it seems like that would be possible via a "recursion" algorithm (traverse down the tree to a leaf, then hash it with its neighbor, go up and then traverse into the sibling, slowly rising up the tree until you get the final root hash)
<elichai2>
I feel like I might be missing something if it's implemented using allocations right now
<bitcoin-git>
[bitcoin] fanquake opened pull request #26090: fs: fully initialize `_OVERLAPPED` for win32 (master...fixup_overlapped_init_win32) https://github.com/bitcoin/bitcoin/pull/26090
<luke-jr>
elichai2: you're assuming a rather large stack?
<elichai2>
luke-jr: It seems to me that you could do the recursion algorithm via a loop, but maybe I should just try to implement it and see where(and if) I fail
PaperSword has quit [Read error: Connection reset by peer]
realies has quit [Quit: ~]
AaronvanW has quit [Quit: Leaving...]
realies has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<vasild>
I am studying Erlay. Is it aiming to optimize the traffic made by inv/tx messages? This is my understanding so far: https://github.com/vasild/bitcoin/wiki/Erlay, I must be missing something because it seems that traffic is just 2.4% from the total traffic. Or my node is giving me skewed results?
<instagibbs>
what kind of nodes, have you measured with different number of connections, etc
<vasild>
instagibbs: or my counting is wrong ;)
<instagibbs>
gleb, in case you are around to answer how the numbers were originally derived ^
<vasild>
I run just one public node that has ipv4 and ipv6
<instagibbs>
might be skewed if you're seeding lots of nodes IBD, for example
<instagibbs>
measure with a non-public node?
<vasild>
instagibbs: I left it to run naturally without trying to limit the connections, in the first few minutes they became ~50, now after 2 days they are 99
<instagibbs>
IIUC it's more looking at being able to increase outbound connections slots without impacting traffic so much
<vasild>
alright, next I will try with non-listening node that has just ~10 outbound connections
<instagibbs>
which would matter more for non-public
<instagibbs>
great, interested to see what the difference looks like
_apex_ has joined #bitcoin-core-dev
<instagibbs>
could also modify to do 20 outbound, say, see what difference is
<vasild>
in total traffic for 1 month: listening node 450GB, non-listening 15GB
<vasild>
right
<sipa>
@vasild Yeah, the point of Erlay is mostly that its bandwidth requirements don't go up (much) with more connections.
<instagibbs>
if youre accepting incoming I suspect usage patterns are quite different
<vasild>
because I am listening on non-8333 port, that should not but you never know, maybe skew the results in some way (only spies connect to me?)
<sipa>
Because the idea is that every node will effectively learn about every transaction once, rather than once per peer. And the naive way of doing that (with fewer tx-relaying connections) increases eclipse risk.
<sipa>
@vasild If you run on a non-standard port I expect you'll se skewed results, as most honest nodes today still won't connect to you.
<sipa>
which gives me an approximation of tx bandwidth of currently connected peers
<sipa>
for me, invs sent is ~20 kB/s, tx sent is ~85 kB/s; invs recv is ~18 kB/s, tx recv is 3 kB/s
<sipa>
my guess is these numbers are very skewed by spy nodes that download all transactions... that's the only explanation i have for why my tx/inv ratio is so high for sending vs receiving
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
piptart has joined #bitcoin-core-dev
_apex_ has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 250 seconds]
Talkless has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
chipxxx has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] aureleoules opened pull request #26094: rpc: Return block hash & height in getbalances, gettransaction and getwalletinfo (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/26094
piptart has quit [Ping timeout: 252 seconds]
realies has quit [Quit: ~]
realies has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
evanlinjin has quit [Ping timeout: 258 seconds]
nanotube has quit [Quit: *poof*]
_apex_ has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
_apex_ has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] jonatack opened pull request #26095: doc: fix spelling identified by codespell and update ignored words (master...2022-09-14-spelling-updates) https://github.com/bitcoin/bitcoin/pull/26095
__afmencken has joined #bitcoin-core-dev
af_mencken has quit [Ping timeout: 252 seconds]
dougefish_ has joined #bitcoin-core-dev
dougefish has quit [Read error: Connection reset by peer]