ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
kevkevin_ has quit [Remote host closed the connection]
Guest28 has joined #bitcoin-core-dev
Guest28 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
furszy has quit [Quit: ZNC - https://znc.in]
furszy has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
twistedline has joined #bitcoin-core-dev
Guest25 has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
<gmaxwell> _aj_: hm. Why does what miners doing matter? users signaling or not is a wallet distinguisher even if the signaling is completely moot.
<gmaxwell> For what miners are doing you could say that the requiring opt-in to replace could just go away.
Guest84 has joined #bitcoin-core-dev
Guest84 has quit [Client Quit]
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Guest25 has quit [Quit: Client closed]
<phantomcircuit> gmaxwell: wouldn't the people who already have it set hard on already be fingerprinted?
<gmaxwell> my comments are about the wallet making transactions, it's on by default for a few years now (unless I'm confused!)
<phantomcircuit> gmaxwell: so it's about fingerprinting users who have rbf for the wallet manually enabled?
<phantomcircuit> i dont get it
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
<gmaxwell> phantomcircuit: a PR was recently merged that enables RBF at all times for all transactions, espeically given that ~all miners are already doing that, there is no need to opt-in to rbf anymore. So the optin flag is just an unnecessary wallet distinguisher.
<gmaxwell> since it doesn't matter one could say that all wallets should just opt in (I think opt-in is the majority now). Or wallets should stop. I think the latter works a bit better because the wallets that currently opt in are more likely to actually update their behavior.
<gmaxwell> And my suggestion/question was that if you do stop, might it be better to get all that stop to stop at once.
<_aj_> seems kind of plausible
<gmaxwell> also works because there is no particular urgency in changing the behavior, I think-- so it could be scheduled a year out or something.
<phantomcircuit> gmaxwell: oh hmm yeah i see that does kinda make sense
<phantomcircuit> though maybe it's better to wait and see how fast nodes are actually updated?
<gmaxwell> if you're an outbound only node, behind 8 nodes not doing fullrbf, and try to do a replacement without having used optin, it won't work.
<gmaxwell> but that requires you to have all 8 peers .... which means that 57% of listeners need to not do the replacement for the probablity of finding yourself in that state is just 1%. And if you are simply restarting will probably fix it.
<gmaxwell> so I don't think there is too much reason for uptake worry.
Talkless has joined #bitcoin-core-dev
AHHHHlol85 has joined #bitcoin-core-dev
AHHHHlol85 has left #bitcoin-core-dev [#bitcoin-core-dev]
BrandonOdiwuor has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
pigeons has quit [Ping timeout: 260 seconds]
nanotube has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Guest23 has joined #bitcoin-core-dev
Guest23 has quit [Client Quit]
<bitcoin-git> [bitcoin] glozow opened pull request #30594: docs: update documentation for new mempoolfullrbf default (master...2024-07-fullrbf-docs) https://github.com/bitcoin/bitcoin/pull/30594
<glozow> instagibbs: re "Leaving as draft since there is plenty of other things people should be working on for 28.0 freeze." in #30592, are you suggesting not doing this in 28.0?
<gribble> https://github.com/bitcoin/bitcoin/issues/30592 | Remove mempoolfullrbf by instagibbs · Pull Request #30592 · bitcoin/bitcoin · GitHub
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/949b67347255...d928f4c47ff9
<bitcoin-git> bitcoin/master 41797f8 fanquake: Squashed 'src/secp256k1/' changes from 4af241b320..642c885b61
<bitcoin-git> bitcoin/master 183e2fd fanquake: Update secp256k1 subtree to latest master
<bitcoin-git> bitcoin/master 9ec776a fanquake: Revert "build: pass --with-ecmult-gen-kb=86 to secp256k1"
<bitcoin-git> [bitcoin] fanquake merged pull request #30573: Update libsecp256k1 subtree to latest master (master...secp_0_5_1) https://github.com/bitcoin/bitcoin/pull/30573
<bitcoin-git> [bitcoin] TheCharlatan opened pull request #30595: kernel: Introduce initial C header API (master...kernelApi) https://github.com/bitcoin/bitcoin/pull/30595
mickin has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<bitcoin-git> [bitcoin] josibake opened pull request #30596: fuzz: replace hardcoded numbers for bech32 limits (master...fix-leftover-hardcoded-bech32-limits) https://github.com/bitcoin/bitcoin/pull/30596
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d928f4c47ff9...43740f4971f4
<bitcoin-git> bitcoin/master a0a9a11 fanquake: depends: fix ZMQ CMake getcachesize check
<bitcoin-git> bitcoin/master 43740f4 merge-script: Merge bitcoin/bitcoin#30588: depends: fix ZMQ CMake getcachesize check
<bitcoin-git> [bitcoin] fanquake merged pull request #30588: depends: fix ZMQ CMake getcachesize check (master...zmq_s390x_missing_fixes) https://github.com/bitcoin/bitcoin/pull/30588
akrmn has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Guyver2 has quit [Remote host closed the connection]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
flooded has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Quit: Client closed]
<instagibbs> glozow I don't think it's an important change to make for 28.0, personally? Maybe mark the option as deprecated for a cycle?
flooded is now known as _flood
<glozow> instagibbs: I'm thinking that, if we came to the conclusion that mempoolfullrbf=0 is bad enough to change the default, then logically it's also bad enough to at least warn users that try to set it?
pablomartin has joined #bitcoin-core-dev
<glozow> If we think it'd be a footgun then we shouldn't provide it as an option imo? Or do we not think it's not that bad?
<instagibbs> yeah hence the deprecation warning? that make sense?
<glozow> warning sounds good
<sipa> glozow: ignoring whether or not the option makes sense, i think logistically it's wrong to remove an option without deprecation cycle... there may be software/packaging relying on even just the option existing
<instagibbs> not everything can be supported like this, but this has essentially 0 cost
<glozow> I think I'm just trying to say that the deprecation should start in 28.0
Olsen has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<BlueMatt[m]> has anyone in bitcoin core land ever gotten driller or fuzzolic or some other concolic execution tool working?
<instagibbs> glozow yes, I agree. I don't know the process for deprecating a startup arg :)
<Murch[m]> gmaxwell: The coordinated switch in signaling sounds interesting, but I’m not sure a rolling update is that harmful. Especially for those that continue signaling after the update, everyone else switching at the same time might leave them sticking out even more
<Murch[m]> glozow, instagibbs: I think removing the option completely may dissuade some users from upgrading, it might be better to only update the default and deprecate this release
<Murch[m]> gmaxwell: If we are worried about full-rbf transactions propagating well by the time the opt-in signaling is turned off by default, maybe we should try to connect to at least one peer whose version is at least v28?
<instagibbs> I don't see the payoff in trying to solve wallet behavior switching now, and by the time it's decided I suspect propagation will be pretty trivial?
<instagibbs> I guess I'm saying, this is all post-28.0 talk in my mind
Olsen has quit [Quit: Client closed]
<sipa> Murch[m], gmaxwell: it looks (https://txstats.com/d/000000020/replace-by-fee) like close to or over a majority of transactions signal opt-in RBF; it seems like defaulting to on is a better shelling point than trying to default to off?
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 252 seconds]
<dergoegge> BlueMatt: I've played around with symcc
<dergoegge> i think i also tried fuzzolic but don't remember if I actually got it working
<dergoegge> https://github.com/SoftSec-KAIST/Eclipser has also been used on core before
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43740f4971f4...31a3ff55154b
<bitcoin-git> bitcoin/master 59c0ece josibake: fuzz: replace hardcoded numbers for bech32 limits
<bitcoin-git> bitcoin/master 31a3ff5 glozow: Merge bitcoin/bitcoin#30596: fuzz: replace hardcoded numbers for bech32 li...
<bitcoin-git> [bitcoin] glozow merged pull request #30596: fuzz: replace hardcoded numbers for bech32 limits (master...fix-leftover-hardcoded-bech32-limits) https://github.com/bitcoin/bitcoin/pull/30596
<dergoegge> Afaik we've never had big success with any of them in terms of new coverage or bugs found
<BlueMatt[m]> ah cool, hadn't come across symcc yet
<BlueMatt[m]> thanks
Guyver2 has joined #bitcoin-core-dev
BUSY has quit [Ping timeout: 248 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 272 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jon_atack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #30597: doc: Drop no longer needed workaround for WSL (master...240806-wsl-note) https://github.com/bitcoin/bitcoin/pull/30597
preimage has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31a3ff55154b...870447fd585e
<bitcoin-git> bitcoin/master 87b1880 willcl-ark: rpc: clarify ALREADY_IN_CHAIN rpc errors
<bitcoin-git> bitcoin/master e9de0a7 willcl-ark: doc: release note for 30212
<bitcoin-git> bitcoin/master 870447f Ryan Ofsky: Merge bitcoin/bitcoin#30212: rename TransactionError:ALREADY_IN_CHAIN
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30212: rename TransactionError:ALREADY_IN_CHAIN (master...clarify-missing-inputs-err) https://github.com/bitcoin/bitcoin/pull/30212
pablomartin has quit [Ping timeout: 248 seconds]
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 264 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/870447fd585e...d7333ece15b8
<bitcoin-git> bitcoin/master 37c9abd fanquake: build: remove check for __attribute__((visibility..
<bitcoin-git> bitcoin/master bbcba09 fanquake: build: remove check for __declspec(dllexport)
<bitcoin-git> bitcoin/master d7333ec merge-script: Merge bitcoin/bitcoin#30590: build: Remove unused visibility checks
<bitcoin-git> [bitcoin] fanquake merged pull request #30590: build: Remove unused visibility checks (master...remove_unused_visibility) https://github.com/bitcoin/bitcoin/pull/30590
pablomartin has joined #bitcoin-core-dev
<gmaxwell> sipa: yeah I mentioned above that I thought it was a majority. The answer I have to that is that it's probably easier to get the ones who've turned it on to turn it off than it is to get the ones that still don't have it on to turn it on?
<sipa> gmaxwell: hmm, good question
pablomartin has quit [Ping timeout: 264 seconds]
qxs_ has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 260 seconds]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 276 seconds]
noonien808310429 has joined #bitcoin-core-dev
halff has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
halff has quit [Changing host]
halff has joined #bitcoin-core-dev
<halff> chat p2p?
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
<bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7333ece15b8...bb25e0691f65
<bitcoin-git> bitcoin/master fa18fc7 MarcoFalke: log: Remove NOLINT(bitcoin-unterminated-logprintf)
<bitcoin-git> bitcoin/master bb25e06 Ryan Ofsky: Merge bitcoin/bitcoin#30485: log: Remove NOLINT(bitcoin-unterminated-logpr...
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30485: log: Remove NOLINT(bitcoin-unterminated-logprintf) (master...2407-log-lint) https://github.com/bitcoin/bitcoin/pull/30485
<Murch[m]> sipa: Everyone settling on not signaling for a previously enforced optional feature seems a bit cleaner than everyone settling on signaling for a no-longer enforced feature.
halff has quit [Quit: Leaving]
<sipa> Murch[m]: agreed there
<gmaxwell> +1
_flood has quit [Ping timeout: 265 seconds]
_flood has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
Talkless has quit [Quit: Konversation terminated!]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
Wh4xk69_1 has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.3.5]
Wh4xk69_1 has quit [Quit: Leaving]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jon_atack has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] fjahr opened pull request #30598: assumeutxo: Drop block height from metadata (master...2024-08-au-drop-height) https://github.com/bitcoin/bitcoin/pull/30598
jonatack has joined #bitcoin-core-dev
RaphaelH has joined #bitcoin-core-dev
noonien808310429 has quit [Quit: Ping timeout (120 seconds)]
bitdex has joined #bitcoin-core-dev
noonien808310429 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]