achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
PaperSword has quit [Quit: PaperSword]
zeropoint has quit [Quit: leaving]
rszarka has joined #bitcoin-core-dev
robszarka has quit [Ping timeout: 245 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
Saturday7 has quit [Changing host]
Saturday7 has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] johnny9 opened pull request #441: Rename Block Clock to Block Status (main...blockstatus) https://github.com/bitcoin-core/gui-qml/pull/441
jonatack has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
kevkevin_ has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
agentcasey has quit [Quit: ZNC 1.10.x-git-27-bfd731cf - https://znc.in]
agentcasey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<achow101> darosior: is there a reason they're using importdescriptors to make a rescan happen instead of rescanblockchain?
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
bcdarc_ has joined #bitcoin-core-dev
bcdarc has quit [Ping timeout: 248 seconds]
sdaftuar has quit [Ping timeout: 248 seconds]
cmirror has quit [Ping timeout: 265 seconds]
sdaftuar has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
cm has joined #bitcoin-core-dev
cm has quit [Client Quit]
bcdarc has joined #bitcoin-core-dev
sdaftuar has joined #bitcoin-core-dev
cm has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
cm has quit [Quit: Bye.]
cm has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
cm has quit [Quit: Bye.]
cm has joined #bitcoin-core-dev
agentcasey has quit [Ping timeout: 276 seconds]
TheRec has quit [Ping timeout: 246 seconds]
TheRec_ has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] maflcko closed pull request #31693: bench: fix used file that is not opened (master...fix-useClosedFile) https://github.com/bitcoin/bitcoin/pull/31693
bitdex has quit [Ping timeout: 264 seconds]
bitdex has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
agentcasey has joined #bitcoin-core-dev
bitdex_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 264 seconds]
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 244 seconds]
pyth has quit [Ping timeout: 246 seconds]
pyth has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
LinuxNoob has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4601b7ca6111...d7f56cc5d9e1
<bitcoin-git> bitcoin/master 092569e Ava Chow: descriptor: Try the other parity in ConstPubkeyProvider::GetPrivKey()
<bitcoin-git> bitcoin/master 4c50c21 Ava Chow: tests: Check ExpandPrivate matches for both parsed descriptors
<bitcoin-git> bitcoin/master b4ac480 Ava Chow: descriptor: Use InferXOnlyPubkey for miniscript XOnly pubkey from script
<bitcoin-git> [bitcoin] fanquake merged pull request #31590: descriptors: Try pubkeys of both parities when retrieving the private keys for an xonly pubkey in a descriptor (master...fix-constpubkey-xonly-getprivkey) https://github.com/bitcoin/bitcoin/pull/31590
pyth has quit [Ping timeout: 265 seconds]
pyth has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
pyth has quit [Ping timeout: 252 seconds]
pyth has joined #bitcoin-core-dev
pyth has quit [Ping timeout: 252 seconds]
pyth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #31696: test: Check that reindex with prune wipes blk files (master...2501-test-reindex-prune) https://github.com/bitcoin/bitcoin/pull/31696
kevkevin has quit [Ping timeout: 252 seconds]
SpellChecker_ is now known as SpellChecker
kevkevin has joined #bitcoin-core-dev
pyth has quit [Remote host closed the connection]
pyth has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
Cory93 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
Cory93 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
bitdex_ has quit [Quit: = ""]
Guest58 has joined #bitcoin-core-dev
Guest58 has quit [Client Quit]
Guest58 has joined #bitcoin-core-dev
Guest58 has quit [Client Quit]
Guest58 has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
Guest58 has quit [Client Quit]
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
eval-exec has quit [Remote host closed the connection]
binarybaron has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 246 seconds]
binarybaron2 has joined #bitcoin-core-dev
Guest75 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] l0rinc opened pull request #31699: test,bench: validate `CheckTransaction`'s duplicate input detection in broader context (master...l0rinc/bench-processtransaction) https://github.com/bitcoin/bitcoin/pull/31699
Guest63 has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
Guest63 has quit [Quit: Client closed]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #31701: test: Bump sync_mempools timeout in p2p_1p1c_network.py (master...2501-test-fixup) https://github.com/bitcoin/bitcoin/pull/31701
gribble has quit [Remote host closed the connection]
<darosior> achow101: there was a reason, let me see
BrandonOdiwuor has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
<darosior> achow101: looks there is no good reason, looks like i just went for importdesc instead of rescanblockchain to not have to convert the timestamp: https://github.com/wizardsardine/liana/pull/84/commits/bd4de0b87a0db999ead08de335566df462251ca6 (explicit content warning: this code is a bunch of ugly hacks to workaround the fact that the bitcoind RPC
<darosior> interface blocks during a rescan but will also always timeout before it finishes in real life conditions)
andytoshi has quit [Quit: Lost terminal]
Guest75 has quit [Quit: Client closed]
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
<darosior> What's the reason we need to compile libc++ to fuzz with MSan? Reproducing a finding from dergoegge and figured i'd add a couple lines to the fuzzing doc for the next one to do that.
<sipa> darosior: msan requires that _all_ linked code is instrumented with msan, so you need an msan-enabled version of the standard library too
<fanquake> all code in the binary needs to be instrumented for msan to work properly, so the
<sipa> !hi5 fanquake
<gribble> Error: "hi5" is not a valid command.
<sipa> gribble: IT SHOULD BE
<fanquake> there are a bunch of interceptors for glibc, so we don't need to do anything there
<darosior> How comes their own doc doesn't mention this?
<darosior> (besides "link with clang not ld")
andytoshi has joined #bitcoin-core-dev
<darosior> Ok thanks i'll put that in doc/fuzzing.md along with the instructions based on the ci scripts.
<dergoegge> Maybe just link to the ci script, the exact steps change occasionally with newer llvm versions. Would be slightly annoying to have to update the docs everytime as well...
<darosior> k
<dergoegge> But good idea to mention it in the docs!
<dergoegge> Valgrind *should* also be able to find the same kind of issues, perhaps worth mentioning as well
<dergoegge> (as it is slightly easier to setup)
<darosior> will do
Guest22 has joined #bitcoin-core-dev
Guest22 has quit [Client Quit]
zebra43 has joined #bitcoin-core-dev
zebra43 has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 276 seconds]
jespada has joined #bitcoin-core-dev
Victor_sueca has quit [Quit: Gone frying asparagus or my Windows had a BSOD]
Victor_sueca has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
jespada has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f56cc5d9e1...a9edec941980
<bitcoin-git> bitcoin/master 1111b0a MarcoFalke: ci: Add missing --combinedlogslen to test-each-commit task
<bitcoin-git> bitcoin/master fa80a7d MarcoFalke: test: Bump sync_mempools timeout in p2p_1p1c_network.py
<bitcoin-git> bitcoin/master a9edec9 merge-script: Merge bitcoin/bitcoin#31701: test: Bump sync_mempools timeout in p2p_1p1c_...
<bitcoin-git> [bitcoin] fanquake merged pull request #31701: test: Bump sync_mempools timeout in p2p_1p1c_network.py (master...2501-test-fixup) https://github.com/bitcoin/bitcoin/pull/31701
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a9edec941980...8fc7140846f9
<bitcoin-git> bitcoin/master d336b7a fanquake: Squashed 'src/leveldb/' changes from 688561cba8..04b5790928
<bitcoin-git> bitcoin/master 9ec6425 fanquake: Update leveldb subtree to latest upstream
<bitcoin-git> bitcoin/master 910a11f fanquake: build: remove LEVELDB_IS_BIG_ENDIAN
<bitcoin-git> [bitcoin] fanquake merged pull request #31671: Update leveldb subtree to latest upstream (master...update_leveldb_subtree) https://github.com/bitcoin/bitcoin/pull/31671
zeropoint has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8fc7140846f9...5691fa93c48c
<bitcoin-git> bitcoin/master d44626a Hennadii Stepanov: depends: Override default build type for `libevent`
<bitcoin-git> bitcoin/master 5691fa9 merge-script: Merge bitcoin/bitcoin#31661: depends: Override default build type for `lib...
<bitcoin-git> [bitcoin] fanquake merged pull request #31661: depends: Override default build type for `libevent` (master...250115-dep-build-type) https://github.com/bitcoin/bitcoin/pull/31661
jespada has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 265 seconds]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
arferreira3 has joined #bitcoin-core-dev
binarybaron has quit [Quit: Client closed]
binarybaron2 has quit [Quit: Client closed]
binarybaron2 has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
TallTim_ has joined #bitcoin-core-dev
samaltman0 has joined #bitcoin-core-dev
shesek5 has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
binarybaron2 has quit [Ping timeout: 240 seconds]
helo has quit [Ping timeout: 252 seconds]
Earnestly has quit [Ping timeout: 248 seconds]
JTL has quit [Ping timeout: 248 seconds]
luke-jr has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 248 seconds]
jnewbery has quit [Ping timeout: 248 seconds]
TallTim has quit [Read error: Connection reset by peer]
Talkless has quit [Read error: Connection reset by peer]
_flood has quit [Ping timeout: 248 seconds]
samaltman has quit [Ping timeout: 248 seconds]
samaltman0 is now known as samaltman
shesek has quit [Ping timeout: 272 seconds]
shesek5 is now known as shesek
helo has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
jnewbery has joined #bitcoin-core-dev
JTL has joined #bitcoin-core-dev
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
LinuxNoob has quit [Quit: Leaving]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
TallTim_ is now known as TallTim
<bitcoin-git> [bitcoin] sipa opened pull request #31703: 202501 dirty coin count (master...202501_dirty_coin_count) https://github.com/bitcoin/bitcoin/pull/31703
Guest80 has joined #bitcoin-core-dev
Guest80 has quit [Client Quit]
<sipa> mental note: change PR title from auto-filled branch name before opening PR
<darosior> :)
<bitcoin-git> [bitcoin] darosior opened pull request #31704: doc: add a section in the fuzzing documentation about using MSan (master...2501_doc_fuzz_msan) https://github.com/bitcoin/bitcoin/pull/31704
BrandonOdiwuor has quit [Ping timeout: 240 seconds]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
cm has quit [Ping timeout: 246 seconds]
greypw149508 has quit [Ping timeout: 264 seconds]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
johnny9dev584508 has quit [Quit: Ping timeout (120 seconds)]
johnny9dev584508 has joined #bitcoin-core-dev
Holz has quit [Ping timeout: 265 seconds]
Holz has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
greypw149508 has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
arferreira3 has quit [Ping timeout: 248 seconds]
greypw149508 has quit [Quit: Connection reset by beer]
greypw149508 has joined #bitcoin-core-dev
greypw149508 has quit [Remote host closed the connection]
greypw149508 has joined #bitcoin-core-dev
Guest55 has joined #bitcoin-core-dev
Guest55 has quit [Client Quit]
Guest55 has joined #bitcoin-core-dev
Guest55 has quit [Client Quit]
bugs_ has quit [Quit: Leaving]
arferreira3 has joined #bitcoin-core-dev
freesprung512697 has quit [Quit: Ping timeout (120 seconds)]
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 244 seconds]