ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
bitdex has joined #bitcoin-core-dev
<jonatack> good question, apart from the debug log timestamp. there are some config options with ./build/src/bitcoind -help-debug | grep time ... but on the RPC side, running ./build/src/bitcoin-cli help | grep time didn't turn up much
andytoshi has quit [Quit: Lost terminal]
PaperSword has joined #bitcoin-core-dev
PaperSword has quit [Client Quit]
<furszy> instagibbs: in tests there is a mocktime field and a bumpmocktime() method in the node class, but.. IIRC, most tests don't use it. We usually get it from the last tip header.
PaperSword has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 264 seconds]
zeropoint has quit [Quit: leaving]
<bitcoin-git> [bitcoin] adlai opened pull request #31621: doc: Update dependency installation for Debian/Ubuntu (master...master) https://github.com/bitcoin/bitcoin/pull/31621
<bitcoin-git> [bitcoin] achow101 opened pull request #31622: psbt: add non-default sighash types to PSBTs and unify sighash type match checking (master...psbt-sighashes) https://github.com/bitcoin/bitcoin/pull/31622
bitdex has joined #bitcoin-core-dev
andytoshi has joined #bitcoin-core-dev
Guest50 has joined #bitcoin-core-dev
Guest50 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
WizJin has joined #bitcoin-core-dev
<WizJin> hello
<WizJin> i need help regarding recovering an old wallet
<WizJin> anyone can help me
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
gribble has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
WizJin has quit [Ping timeout: 246 seconds]
rszarka has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 265 seconds]
conman has quit [Quit: Konversation terminated!]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] luke-jr opened pull request #31623: tracing: Rename the `MIN` macro to `_TRACEPOINT_TEST_MIN` in log_raw_p2p_msgs (master...tracing_MIN_macro_rename) https://github.com/bitcoin/bitcoin/pull/31623
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin has quit [Ping timeout: 260 seconds]
WizJin has joined #bitcoin-core-dev
WizJin has quit [Remote host closed the connection]
WizJin has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin has quit [Ping timeout: 264 seconds]
kevkevin has quit [Ping timeout: 260 seconds]
infernix has quit [Ping timeout: 246 seconds]
infernix has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
WizJin has quit [Read error: Connection reset by peer]
kevkevin has quit [Ping timeout: 260 seconds]
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
Guest79 has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
johnzwen- has joined #bitcoin-core-dev
johnzweng has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors closed pull request #27433: getblocktemplate improvements for segwit and sigops (master...2023/04/gbt) https://github.com/bitcoin/bitcoin/pull/27433
<bitcoin-git> [bitcoin] Sjors opened pull request #31624: doc: warn that CheckBlock() underestimates sigops (master...2025/01/doc-sigops) https://github.com/bitcoin/bitcoin/pull/31624
<bitcoin-git> [bitcoin] Sjors opened pull request #31625: miner: always treat SegWit as active (master...2025/01/gbt-segwit-active) https://github.com/bitcoin/bitcoin/pull/31625
kevkevin has quit [Ping timeout: 264 seconds]
Guest79 has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
nanotube has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 252 seconds]
aleggg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #31626: depends: Use base system's `sha256sum` utility (master...250109-sha256sum) https://github.com/bitcoin/bitcoin/pull/31626
kevkevin has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
aleggg has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
Cory has quit [Quit: Client closed]
Cory has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 252 seconds]
aleggg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] hebasto opened pull request #31627: depends: Fix spacing issue (master...250109-gen_id) https://github.com/bitcoin/bitcoin/pull/31627
kevkevin has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
<achow101> #startmeeting
<core-meetbot> achow101: Meeting started at 2025-01-09T14:00+0000
<core-meetbot> achow101: Current chairs: achow101
<core-meetbot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
<core-meetbot> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
<core-meetbot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
<achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
<core-meetbot> achow101: Unknown command: #bitcoin
<willcl-ark> Hi
<maxedw> hi
<brunoerg> hi
<abubakarsadiq> hi
<pinheadmz> "#here"
<stickies-v> hi
<pinheadmz> FirstLast
<hebasto> hi
<achow101> lol
<kanzure> hi
<tdb3> hi
<glozow> hi
<darosior> hi
<TheCharlatan> hi
<Chris_Stewart_5> hi
<achow101> There is one preproposed meeting topic this week. Any last minute ones to add?
<glozow> #here FirstLast
<cfields> hi
<jonatack> hola
<achow101> #topic Kernel WG Update (TheCharlatan)
<TheCharlatan> nothing new this week
<b10c> hi
<sr_gi[m]> Hi
<achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
<sr_gi[m]> I continued with simulations this week, working to address the most relevant outstanding question so far: what is a reasonable proportion of inbounds/outbounds for fanout.
<sr_gi[m]> I’m still working on this question, but preliminary results seem to show that this is indeed a tradeoff between bandwidth and latency, so the parameters (and bandwidth savings) may depend on what is a reasonable propagation time for a transaction.
<sr_gi[m]> I hopping to have some conclusions by next meeting, if not the next one (so 2 weeks TM)
rockhouse has joined #bitcoin-core-dev
<sr_gi[m]> That's it for me
<achow101> #topic MuSig2 WG Update (achow101)
<achow101> There's been some testing of the PR with other implementations, and one of these testers discovered a more general issue with sighash type conflicts
<achow101> 've opened #31622 to fix those sighashing issues.
<gribble> https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
<achow101> #31242 and #31243 are still the next prs to review. #31242 seems to be rfm.
<core-meetbot> achow101: Unknown command: #31242
<gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<achow101> #topic Legacy Wallet Removal WG Update (achow101)
<achow101> No updates, still waiting for review on #31495
<gribble> https://github.com/bitcoin/bitcoin/issues/31495 | wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases by achow101 · Pull Request #31495 · bitcoin/bitcoin · GitHub
<achow101> #topic package relay WG Update (glozow)
<glozow> hi! I am still working on #31397, which looks closeish
<gribble> https://github.com/bitcoin/bitcoin/issues/31397 | p2p: track and use all potential peers for orphan resolution by glozow · Pull Request #31397 · bitcoin/bitcoin · GitHub
<glozow> It looks like I could collect the currently outstanding comments into a followup, but also happy to update, so more review would be appreciated
<glozow> also i haven't given up on #31385 yet 😅
Cory has quit [Quit: Client closed]
<gribble> https://github.com/bitcoin/bitcoin/issues/31385 | package validation: relax the package-not-child-with-unconfirmed-parents rule by glozow · Pull Request #31385 · bitcoin/bitcoin · GitHub
Cory has joined #bitcoin-core-dev
<glozow> I also updated the wiki doc about orphanage problems https://github.com/bitcoin-core/bitcoin-devwiki/wiki/%5BP2P%5D-known-TxOrphanage-problems
<glozow> It's a more comprehensive writeup of what this subproject of "package relay" is attempting to solve
<glozow> That's it from me. I kind of wonder if we should rename this to "Tx Orphan Resolution" instead of calling it package relay
<achow101> #topic moving meeting later by 3 hours (achow101)
<glozow> ACK, but maybe more of a problem for the people who live in europe?
<achow101> a couple of us are moving to the us west coast, myself included. the current meeting time there is 6 am, which is not a time that multiple people there would really be able to do, myself included.
<dergoegge> would prefer to keep it as is
<cfields> 6am doesn't do it for you? :)
<achow101> the current time is optimized for europe
<achow101> cfields: i can barely do the current 9 am lol, but it's at least possible
<jonatack> ACK. The last change made the meeting times more difficult for me.
<fanquake> that’ll be 5/6pm in London/europe, so I assume you’ll just loose as many as you might gain
<jonatack> (When I was in Europe, I rather liked the evening meeting times, but I digress.)
<glozow> I remember last time we changed the time, we noted that fewer people lived on the west coast, and that's no longer the case
<dergoegge> we have great attendance right now, i fear we'd be giving that up
<fanquake> also that’ll be lunchtime for NYC?
<sipa> hi
<vasild> maybe have a poll?
<achow101> we can do another time poll thing like last time
<cfields> and I assume with +3 we'd completely lose aus/asia.
<sdaftuar> hi
<stickies-v> poll sounds like the best approach to me
<glozow> I propose using this: https://www.when2meet.com/?28273038-y9Yr7
<sipa> the domain name sounds appropriate
<_aj_> hi
<glozow> (there is no authentication but writing your name suffices imo)
<cfields> no auth required. I'm the glozow now.
<dergoegge> does that just assume a timezone? doesn't say what it is using
<glozow> it should tell you a timezone
<tdb3> glozow: are the times listed in utc?
<achow101> assume utc presumably?
<glozow> oh 🤔 I guess it doesn't. UTC yes
<darosior> Yeah im confused by the timezone too
<_aj_> yeah, +5h from now is an early state, +3h is stay-up-all-night territory
<jonatack> Voting would ideally take into account not only preferences but degree of preference / inconvenience.
<glozow> ok let's do that
<darosior> Looks like you set the timezone when creating the event on when2meet.com
<achow101> we can give until next meeting to get that filled out
<dergoegge> "Unauthorized"
<tdb3> to clarify, we're using https://app.rallly.co/poll/k0zyyk2uD3ug
<tdb3> ?
<glozow> yes, forget about the when2meet
<achow101> oh, real link is https://app.rallly.co/invite/k0zyyk2uD3ug
<achow101> the other one is admin oops
<cfields> 👍
<achow101> since it looks like several people aren't here, let's wait until next week to decide based on the results of the poll
moresteakpls has joined #bitcoin-core-dev
Emc99 has quit [Quit: Client closed]
kevkevin has quit [Ping timeout: 246 seconds]
Emc99 has joined #bitcoin-core-dev
<achow101> any other topics to discuss?
<sdaftuar> sipa and i are here now, can give a cluster mempool update
<achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
<sdaftuar> i just have a brief update, i'm started rebasing #28676 on top of sipa's txgraph implementation. once that is complete we'll have a pretty good idea of what the finish line looks like (and this may highlight any sharp edges we want to address in sipa's implementation)
<gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
<sdaftuar> in the meantime sipa's txgraph PRs are the ones we'd like review on
<sipa> there are three open txggraph PRs (31363, 31444, 31553), each one building on the next
kevkevin has joined #bitcoin-core-dev
<sipa> but i understand some reviewers are waiting for the full cluster mempool rebase on top of them
Guest33 has joined #bitcoin-core-dev
<sipa> on the research side, we may need to replace the cluster linearization code (later, not now!) at some point, because the new algorithm looks super promising
Guest33 has quit [Client Quit]
<sipa> when, and if, that happens, i don't expect txgraph to really change, except for swapping out the underlying calls
<sipa> that's it for me, i think
<achow101> any other topics to discuss?
<dergoegge> #21590 and #31549 look ready for merge
<core-meetbot> dergoegge: Unknown command: #21590
<gribble> https://github.com/bitcoin/bitcoin/issues/21590 | Safegcd-based modular inverses in MuHash3072 by sipa · Pull Request #21590 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31549 | fuzz: Abort if system time is called without mock time being set by marcofleon · Pull Request #31549 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21590 | Safegcd-based modular inverses in MuHash3072 by sipa · Pull Request #21590 · bitcoin/bitcoin · GitHub
<achow101> dergoegge: will look today
<dergoegge> thanks
<sipa> looks like there are some open questions on 21590 by TheCharlatan, will look
<achow101> #endmeeting
<core-meetbot> achow101: Meeting ended at 2025-01-09T14:29+0000
Emc99 has quit [Quit: Client closed]
<achow101> in case anyone cares, I had the meeting bot go through historical meetings too. everything's at https://achow101.com/ircmeetings/
<stickies-v> nice one, thanks achow101!
<jonatack> The poll begins at Wed 5 pm for me. Unclear how to vote :)
<achow101> jonatack: it's your local timezone
<achow101> it's otherwise hourly on a thursday utc
<_aj_> jonatack: it's the UTC midnight to midnight day i think
<jonatack> ok ty
<sipa> achow101: looks like the current meeting time is the current frontrunner, sorry ;)
<_aj_> sipa: i think my most recent mail's doubly-anti-cycle approach works, fwiw
<sipa> (maybe there is a tiny bit of selection bias here)
<sipa> _aj_: sorry, i need to catch up on your last... 5 mails?
<_aj_> sipa: :)
<achow101> sipa: just a bit of selection bias
dzxzg has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
bugs_ has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
moresteakpls has quit [Quit: Client closed]
dzxzg has quit [Quit: Client closed]
pyth has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] instagibbs opened pull request #31628: test: add coverage for immediate orphanage eviction case (master...2025-01-immediate-orphan-evict) https://github.com/bitcoin/bitcoin/pull/31628
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]