achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 264 seconds]
bitdex has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 248 seconds]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
arferreira3 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
bitdex has quit [Ping timeout: 264 seconds]
jonatack has quit [Ping timeout: 248 seconds]
robszarka has joined #bitcoin-core-dev
rszarka has quit [Ping timeout: 252 seconds]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
jonatack has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
agentcas- has joined #bitcoin-core-dev
agentcasey has quit [Ping timeout: 264 seconds]
gribble has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 248 seconds]
gribble has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
bitdex has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 265 seconds]
jonatack has quit [Ping timeout: 248 seconds]
cmirror has joined #bitcoin-core-dev
agentcasey has joined #bitcoin-core-dev
agentcas- has quit [Ping timeout: 246 seconds]
eval-exec has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Excess Flood]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 4.5.1]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
Holz has quit [Ping timeout: 248 seconds]
Holz has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
luke-jr has quit [Remote host closed the connection]
luke-jr has joined #bitcoin-core-dev
essz has joined #bitcoin-core-dev
essz has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has left #bitcoin-core-dev [Closing Window]
essz has joined #bitcoin-core-dev
essz has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5691fa93c48c...523520f82799
<bitcoin-git> bitcoin/master 6d11c9c Ava Chow: descriptor: Add proper Clone function to miniscript::Node
<bitcoin-git> bitcoin/master 9ccb46f Ava Chow: miniscript: Ensure there is no NodeRef copy constructor or assignment oper...
<bitcoin-git> bitcoin/master 09a1875 Ava Chow: miniscript: Make NodeRef a unique_ptr
<bitcoin-git> [bitcoin] fanquake merged pull request #30866: descriptor: Add proper Clone function to miniscript::Node (master...multipath-spkm-fuzz-crash) https://github.com/bitcoin/bitcoin/pull/30866
mcey has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 272 seconds]
mcey_ has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 252 seconds]
mcey has quit [Ping timeout: 276 seconds]
jespada has joined #bitcoin-core-dev
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
arferreira3 has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 246 seconds]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
arferreira3 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<jonatack> Doing IBD on a fluctuating + slower internet connection, I wonder if our "Peer is stalling block download, disconnecting" algo could be optimized. Seeing 100+ disconnections per hour, often of friendly good manual peers that the node reconnects to again right after. Peer ping times are often 20-100 seconds.
<jonatack> If anyone has seen or looked into this recently, don't hesitate to reach out.
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<jonatack> (Good morning from El Salvador ;)
<sipa> jonatack: i believe lightlike has been looking into that
<jonatack> sipa: ty
eval-exec has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jonatack has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 252 seconds]
eval-exec has joined #bitcoin-core-dev
arferreira3 has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 4.5.1]
<lightlike> yes, been thinking of adding past block download times into the algorithm, still in an early stage / setting up simulations... The challenge is to distinguish this situation from making things worse for fast/reliable connections that just have some slow peers which should be disconnected.
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
<darosior> laanwj: looking into https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-2606831902, is it possible the firewall interprets the PCP request as a NAT-PMP request?
gribble has joined #bitcoin-core-dev
<darosior> The router appears to explicitly mention supporting NAT-PMP but does not mention PCP at all as far as i could find. Then it can forward an IPV4 but closes the connection for the IPV6 request, as if it was a protocol violation of sort. From a quick look across the constants in common/pcp.cpp it appears the two protocols have a lot in common so maybe
<darosior> the firewall just implements NAT-PMP, not PCP, and somehow still reply successfully?
<darosior> Ah but you have code to detect NAT-PMP responses to PCP requests...
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
LainExperiments has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<Sjors[m]> PCP is the next version of NAT-PMP so it's indeed conceivable some firewall is trying to smart and support a "future" version that it doesn't actually understand.
<Sjors[m]> That would not make me feel comfortable about the quality of that particular firewall :-)
<kanzure> how long should the guix deterministic builds take?
<hebasto> kanzure: from the scratch?
<hebasto> a few hours on a decent hardware; days on SBC
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/523520f82799...7b4d072e4fad
<bitcoin-git> bitcoin/master e94c9d1 dergoegge: [doc] Amend notes on benchmarking
<bitcoin-git> bitcoin/master 7b4d072 merge-script: Merge bitcoin/bitcoin#31690: doc: Amend notes on benchmarking
<bitcoin-git> [bitcoin] fanquake merged pull request #31690: doc: Amend notes on benchmarking (master...2501-doc-bench) https://github.com/bitcoin/bitcoin/pull/31690
arferreira3 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
LainExperiments has quit [Quit: Client closed]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/7b4d072e4fad...5d6f6fd00d7d
<bitcoin-git> bitcoin/master 34f9a01 Lőrinc: refactor,bench: rename bench/readblock.cpp to bench/readwriteblock.cpp
<bitcoin-git> bitcoin/master 86b85bb Lőrinc: bench: add SaveBlockBench
<bitcoin-git> bitcoin/master 42bc491 Lőrinc: refactor,blocks: inline `UndoWriteToDisk`
<bitcoin-git> [bitcoin] ryanofsky merged pull request #31490: refactor: inline `UndoWriteToDisk` and `WriteBlockToDisk` to reduce serialization calls (master...l0rinc/undo) https://github.com/bitcoin/bitcoin/pull/31490
<bitcoin-git> [bitcoin] hebasto opened pull request #31709: cmake: Fail if `Libmultiprocess` is missing when `WITH_MULTIPROCESS=ON` (master...250122-mp-error) https://github.com/bitcoin/bitcoin/pull/31709
<bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5d6f6fd00d7d...78fa88c53ad8
<bitcoin-git> bitcoin/master fa3c787 MarcoFalke: fuzz: Abort when global PRNG is used before SeedRand::ZEROS
<bitcoin-git> bitcoin/master 78fa88c Ryan Ofsky: Merge bitcoin/bitcoin#31548: fuzz: Abort when global PRNG is used before S...
<bitcoin-git> [bitcoin] ryanofsky merged pull request #31548: fuzz: Abort when global PRNG is used before SeedRand::ZEROS (master...2412-fuzz-abort-g-rng) https://github.com/bitcoin/bitcoin/pull/31548
LainExperiments has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] BorisNaum opened pull request #31710: Typo fix release-notes-0.10.0.md (master...Fix-typo) https://github.com/bitcoin/bitcoin/pull/31710
<bitcoin-git> [bitcoin] fanquake closed pull request #31710: Typo fix release-notes-0.10.0.md (master...Fix-typo) https://github.com/bitcoin/bitcoin/pull/31710
LainExperiments has quit [Ping timeout: 240 seconds]
preimage has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
LainExperiments has joined #bitcoin-core-dev
LainExperiments has quit [Client Quit]
<bitcoin-git> [bitcoin] theuni opened pull request #31711: build: set build type and per-build-type flags as early as possible (master...cmake-early-checks-flags) https://github.com/bitcoin/bitcoin/pull/31711
eval-exec has quit [Ping timeout: 246 seconds]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/78fa88c53ad8...5acf12bafeb1
<bitcoin-git> bitcoin/master c4cc9e3 Sjors Provoost: consensus: add DeriveTarget() to pow.h
<bitcoin-git> bitcoin/master ba7b9f3 Sjors Provoost: build: move pow and chain to bitcoin_common
<bitcoin-git> bitcoin/master 7ddbed4 Sjors Provoost: rpc: add nBits to getmininginfo
<bitcoin-git> [bitcoin] ryanofsky merged pull request #31583: rpc: add target to getmininginfo field and show next block info (master...2024/12/gettarget) https://github.com/bitcoin/bitcoin/pull/31583
<lightlike> lint CI is failing on master: "HEAD was not signed with a trusted key!" (fyi @ryanofsky)
<ryanofsky> lightlike, thanks didn't see this. I did update key expiration date recently
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
preimage has left #bitcoin-core-dev [WeeChat 4.5.1]
Talkless has quit [Quit: Konversation terminated!]
<sipa> you may need to upload the updated key to hkps://keys.openpgp.org
<ryanofsky> yes that was the problem, just updated
<ryanofsky> or at least i think that was the problem. keys.openpgp.org was showing the key as expired and is not anymore
Holz has quit [Ping timeout: 248 seconds]
<achow101> anyone else seeing testnet4 immediately dying right after startup?
Holz has joined #bitcoin-core-dev
<achow101> on master
<darosior> let me check
<lightlike> syncs fine on an empty datadir for me - what do you mean with "dying" - InitError? assert?
<achow101> ah nvm, it's hitting a wallet assertion error which wasn't being printed to the debug log
<achow101> -daemon hiding these things is kinda annoying
<darosior> Ah, good. I was doing IBD and didn't hit any issue either.
<bitcoin-git> [bitcoin] hodlinator opened pull request #31713: script refactor: Remove superfluous unique_ptr-indirection (#30866 follow-up) (master...2024/11/miniscript_ownership) https://github.com/bitcoin/bitcoin/pull/31713
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] mzumsande opened pull request #31714: validation: Do less work in NeedsRedownload (master...202501_simpler_segwit_check) https://github.com/bitcoin/bitcoin/pull/31714
<bitcoin-git> [bitcoin] theuni opened pull request #31715: build: CMake security checks workarounds (master...cmake-security-checks-workarounds) https://github.com/bitcoin/bitcoin/pull/31715
<bitcoin-git> [bitcoin] nnsW3 opened pull request #31717: docs: fix README.md (master...docs-fix) https://github.com/bitcoin/bitcoin/pull/31717
bugs_ has quit [Quit: Leaving]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 264 seconds]
ghost43 has joined #bitcoin-core-dev
saturday- has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 252 seconds]
saturday- has quit [Ping timeout: 252 seconds]
arferreira3 has quit [Ping timeout: 272 seconds]
Cory93 has quit [Quit: Client closed]
Cory93 has joined #bitcoin-core-dev
hardtotell7 is now known as hardtotell
arferreira3 has joined #bitcoin-core-dev
arferreira3 has quit [Ping timeout: 260 seconds]