PaperSword has quit [Remote host closed the connection]
MrHAPPY has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
pyth has quit [Ping timeout: 245 seconds]
PaperSword has quit [Client Quit]
pyth has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
badkat has quit [Quit: Under attack!]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin_ has quit [Remote host closed the connection]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevi__ has joined #bitcoin-core-dev
kevkevi__ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
Cory94 has quit [Quit: Client closed]
Cory94 has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
badkat has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
jon_atack has quit [Ping timeout: 265 seconds]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Write error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
cmirror has quit [Remote host closed the connection]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
LainIwakura has quit [Quit: Client closed]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
MrHAPPY has quit []
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
joetor5 has quit [Quit: joetor5]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevi__ has joined #bitcoin-core-dev
kevkevi__ has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevi__ has joined #bitcoin-core-dev
kevkevi__ has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevi__ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevi__ has quit [Read error: Connection reset by peer]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
LainIwakura has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin_ has joined #bitcoin-core-dev
kevkevi__ has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevi__ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
LainIwakura has quit [Quit: Client closed]
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
antanst has quit [Ping timeout: 276 seconds]
Talkless has quit [Client Quit]
kevkevin_ has joined #bitcoin-core-dev
antanst has joined #bitcoin-core-dev
kevkevin_ has quit [Remote host closed the connection]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin_ has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Remote host closed the connection]
Christoph_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
letim1291 has joined #bitcoin-core-dev
letim1291 has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
antanst4 has joined #bitcoin-core-dev
antanst has quit [Ping timeout: 276 seconds]
antanst4 is now known as antanst
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git>
[bitcoin] maflcko opened pull request #32360: test: Force named args in RPCOverloadWrapper optional args (master...2504-named-args) https://github.com/bitcoin/bitcoin/pull/32360
Christoph_ has quit [Quit: Christoph_]
j03lliott has joined #bitcoin-core-dev
j03lliott has quit [Client Quit]
j03lliott has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
j03lliott has quit [Client Quit]
storopoli has quit [Ping timeout: 272 seconds]
storopoli has joined #bitcoin-core-dev
j03lliott has joined #bitcoin-core-dev
j03lliott has quit [Ping timeout: 240 seconds]
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 260 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 252 seconds]
neutrino777 has quit [Ping timeout: 248 seconds]
neutrino777 has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 272 seconds]
rkrux has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 248 seconds]
pablomartin has quit [Ping timeout: 276 seconds]
<rkrux>
hey, re this PR: #29124, it's just 1 functional test and had 3 ACKs previously and I have ACKed it again after it needed a rebase. I believe it's rfm but does it require the other reviewers to ACK again?
<corebot>
https://github.com/bitcoin/bitcoin/issues/29124 | test: Test that migration automatically repairs corrupted metadata with doubled derivation path by achow101 · Pull Request #29124 · bitcoin/bitcoin · GitHub
Cory94 has quit [Ping timeout: 240 seconds]
Cory94 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
rkrux has quit [Quit: Client closed]
flooded has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 276 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 248 seconds]
Christoph_ has joined #bitcoin-core-dev
Cory94 has quit [Quit: Client closed]
Cory94 has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<maflcko>
fanquake: Yeah, I had the impression this was AI generated, but some original thought may have gone into it
<maflcko>
idk, happy to wait a day how the feedback is addressed
<maflcko>
Also, could run the CI to check if its passing, as this is a ci-only change. If it isn't passing, it should be easy to reject
<fanquake>
I think it's already failing multiple CIs
<maflcko>
ah, yeah. It looks like a bot or "ai agent"
<bitcoin-git>
[bitcoin] stickies-v opened pull request #32364: refactor: validation: mark CheckBlockIndex as const (master...2025-04/const-checkblockindex) https://github.com/bitcoin/bitcoin/pull/32364
<darosior>
I think it's now safe to remove the special-casing of witness-stripped error and always add the wtxid to the reject filter in case of script validation failure? It's been 4 years since wtxid relay was released and it's now ubiquitous.
<instagibbs>
btcd afaik doesn't do wtxid relay, I think that's where we landed on being a concern? glozow
<darosior>
I think the concern is only if a large part of the network doesn't do wtxid relay, so that shouldn
<bitcoin-git>
bitcoin/master c7e2b9e Ava Chow: tests: Test migration cleans up bad inactive chain derivation path
<bitcoin-git>
bitcoin/master a4eee6d merge-script: Merge bitcoin/bitcoin#29124: test: Test that migration automatically repai...
<bitcoin-git>
[bitcoin] glozow merged pull request #29124: test: Test that migration automatically repairs corrupted metadata with doubled derivation path (master...fix-double-keypath) https://github.com/bitcoin/bitcoin/pull/29124
skr0 has quit [Quit: Leaving]
<sipa>
The only node being protected by the "don't add wtxid to reject filter" is itself, right? It prevents a witness-stripping attacker from poisoning your cache, so that you can't receive from pre-wtxid nodes anymore.
<sipa>
But this is only a concern when all your peers are pre-wtxid or non-relay nodes, or attackers.
<darosior>
I think the concern is rather that an attacker poison the cache of a large chunk of the network with the honest node's witness-stripped txid. When honest nodes tries to broadcast it may find a path of honest relay toward miners but if those use txid-based relay then it wont be able to reach the miners.
<darosior>
So i don't think doing this is really protecting the node itself, but rather if enough nodes on the network do it then it protects the honest broadcaster from not being able to reach the miners
<darosior>
But it comes at their own expense, of course.
<bitcoin-git>
bitcoin/master fadf12a MarcoFalke: test: Add missing check for empty stderr in util tester
<bitcoin-git>
bitcoin/master 65714c1 Ava Chow: Merge bitcoin/bitcoin#32327: test: Add missing check for empty stderr in u...
<bitcoin-git>
[bitcoin] achow101 merged pull request #32327: test: Add missing check for empty stderr in util tester (master...2504-test-util-empty-err) https://github.com/bitcoin/bitcoin/pull/32327
LainIwakura has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #32369: test: Use the correct node for doubled keypath test (master...fix-double-keypath-test) https://github.com/bitcoin/bitcoin/pull/32369
<darosior>
A side effect of removing the code to figure out whether validation failed because of a stripped witness, is that now a witness stripped transaction will be treated as a consensus failure and the node will be Misbehaving()'d.
LainIwakura has joined #bitcoin-core-dev
Guest49 has joined #bitcoin-core-dev
Guest49 has quit [Ping timeout: 240 seconds]
Guest49 has joined #bitcoin-core-dev
Guest49 has quit [Client Quit]
<glozow>
the attack is stopped if the btcd node manages to get it to at least 1 peer who does wtxidrelay. which… seems very reasonable
<glozow>
darosior: wait that doesn’t seem good
LainIwakura has quit [Quit: Client closed]
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
LainIwakura has joined #bitcoin-core-dev
LainIwakura has quit [Quit: Client closed]
jespada_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<darosior>
glozow: i can't think of an issue, what do you have in mind?