achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
BlueMatt[m] has quit [Ping timeout: 268 seconds]
kvaciral[m] has quit [Ping timeout: 268 seconds]
b10c[m] has quit [Ping timeout: 276 seconds]
b10c[m] has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
kvaciral[m] has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
Guest50 has joined #bitcoin-core-dev
Guest50 has quit [Client Quit]
<sipa> glozow: honest pre-segwit or pre-wtxid nodes will not relay witness-stripped transactions, i believe
<sipa> at least not bitcoin core ones
<sipa> so it shouldn't be possible to get a transitive failure
zeropoint has quit [Quit: leaving]
joetor5 has quit [Ping timeout: 268 seconds]
joetor5 has joined #bitcoin-core-dev
joetor5 has quit [Client Quit]
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
badkat has quit [Ping timeout: 276 seconds]
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] LEGENDZENT opened pull request #32370: 4 million lost bitcoin (master...lost-bitcoin) https://github.com/bitcoin/bitcoin/pull/32370
<bitcoin-git> [bitcoin] achow101 closed pull request #32370: 4 million lost bitcoin (master...lost-bitcoin) https://github.com/bitcoin/bitcoin/pull/32370
bitdex has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] azuchi opened pull request #1128: Add japanese translation for security advisory for remaining CVE-2024-52919 issue (master...ja-translate-cve-2024-52919) https://github.com/bitcoin-core/bitcoincore.org/pull/1128
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 252 seconds]
PaperSword1 is now known as PaperSword
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
Guest28 has joined #bitcoin-core-dev
Guest28 has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
szarka has quit [Quit: Leaving]
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 244 seconds]
PaperSword1 is now known as PaperSword
Christoph_ has joined #bitcoin-core-dev
szarka has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
badkat has joined #bitcoin-core-dev
Cory43 has quit [Ping timeout: 240 seconds]
Cory43 has joined #bitcoin-core-dev
gerle has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [leveldb-subtree] laanwj opened pull request #50: Remove workaround for old Linux kernel CIFS bug (bitcoin-fork...2025-04-revert-dir-fsync-hack) https://github.com/bitcoin-core/leveldb-subtree/pull/50
MrHAPPY has quit [Ping timeout: 265 seconds]
szarka has quit [Ping timeout: 252 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] fanquake pushed 3 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/6957ec9324a2...bfe173782999
<bitcoin-git> bitcoincore.org/master fc158b8 azuchi: Add japanese translation for security advisory for remaining CVE-2024-5291...
<bitcoin-git> bitcoincore.org/master d8ff556 azuchi: Fix typo
<bitcoin-git> bitcoincore.org/master bfe1737 merge-script: Merge bitcoin-core/bitcoincore.org#1128: Add japanese translation for secu...
<bitcoin-git> [bitcoincore.org] fanquake merged pull request #1128: Add japanese translation for security advisory for remaining CVE-2024-52919 issue (master...ja-translate-cve-2024-52919) https://github.com/bitcoin-core/bitcoincore.org/pull/1128
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65714c162c16...c5e44a043563
<bitcoin-git> bitcoin/master 32d55e2 Ava Chow: test: Use the correct node for doubled keypath test
<bitcoin-git> bitcoin/master c5e44a0 merge-script: Merge bitcoin/bitcoin#32369: test: Use the correct node for doubled keypat...
<bitcoin-git> [bitcoin] fanquake merged pull request #32369: test: Use the correct node for doubled keypath test (master...fix-double-keypath-test) https://github.com/bitcoin/bitcoin/pull/32369
Guyver2 has left #bitcoin-core-dev [Closing Window]
sipa has quit [Remote host closed the connection]
szarka has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 248 seconds]
pablomartin has quit [Client Quit]
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 276 seconds]
PaperSword1 is now known as PaperSword
Christoph_ has joined #bitcoin-core-dev
<laanwj> if anyone is interested in improving windows support: it would be nice to get #31014 in
<corebot> https://github.com/bitcoin/bitcoin/issues/31014 | net: Use GetAdaptersAddresses to get local addresses on Windows by laanwj · Pull Request #31014 · bitcoin/bitcoin · GitHub
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
pablomartin has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 252 seconds]
PaperSword has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
Christoph_ has quit [Quit: Christoph_]
abubakarsadiq has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
bitdex has quit [Quit: = ""]
neutrino1 has joined #bitcoin-core-dev
neutrino777 has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin_ has quit [Remote host closed the connection]
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
Cory43 has quit [Quit: Client closed]
Cory43 has joined #bitcoin-core-dev
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #32363: ci: Use previous releases in tests on Windows (master...hpp1) https://github.com/bitcoin/bitcoin/pull/32363
<darosior> glozow, sipa: it does mean that it could interfere with orphan requesting though. Not sure if it's really an issue
<darosior> A node would not request the parent of an orphan if it was first submitted as witness stripped, since its stripped-wtxid==txid would be in the reject filter
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #32378: interfaces: move `Mining` and `BlockTemplate` implementation to miner (master...04-2025-refactor-mining-interface) https://github.com/bitcoin/bitcoin/pull/32378
<instagibbs> darosior a peer front-running another peer to stall out orphan resolution forever is probably bad
<instagibbs> (ignoring our issues with churn already ofc)
<darosior> The parent would still relay through normal means though, so i'm not sure how much this front-running would even achieve from the pov of an attacker
<instagibbs> 1P1C?
<darosior> :/
<darosior> This is unfortunate. Using txid is always going to be vulnerable to this. Does this mean we can never get rid of trying to special case the witness-stripped error? That's pretty annoying...
<bitcoin-git> [bitcoin] darosior opened pull request #32379: p2p: stop special-casing witness-stripped error for unconfirmed transactions (master...2504_less_input_checks) https://github.com/bitcoin/bitcoin/pull/32379
<darosior> Opened a draft PR to facilitate discussion ^.
delta1 has quit [Quit: Connection closed for inactivity]
<glozow> Is front-running as much of an issue if we delay unsolicited?
<instagibbs> oh sorry, I think I read your comment backwards, it's the *parent* being witness stripped
<instagibbs> well adversary can hand the parent over at its leisure, constantly blinding peers to the underlying package, yeah?
szarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
Cory55 has joined #bitcoin-core-dev
Cory43 has quit [Ping timeout: 240 seconds]
zeropoint has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
pyth has quit [Quit: Leaving]
<darosior> Has anyone run into an intermittent wallet_backwards_compatibility.py CI failure? If not can a maintainer re-kick the previous releases CI job in #32155?
<corebot> https://github.com/bitcoin/bitcoin/issues/32155 | miner: timelock the coinbase to the mined block's height by darosior · Pull Request #32155 · bitcoin/bitcoin · GitHub
abubakarsadiq has quit [Quit: Connection closed for inactivity]
gerle has quit [Quit: https://quassel-irc.org - Komfortabler Chat. Überall.]
<darosior> Thanks
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
diva17 has joined #bitcoin-core-dev
Cory55 has quit [Quit: Client closed]
jespada_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Cory55 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #32380: [PoC] Modernize use of UTF-8 in Windows code (master...250429-windows-utf8) https://github.com/bitcoin/bitcoin/pull/32380
Talkless has joined #bitcoin-core-dev
badkat has quit [Quit: Under attack!]
badkat has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c5e44a043563...51d76634fb57
<bitcoin-git> bitcoin/master fa6f77e MarcoFalke: descriptors: Reject + sign in ParseKeyPathNum
<bitcoin-git> bitcoin/master fa55dd0 MarcoFalke: descriptors: Reject + sign when parsing multi threshold
<bitcoin-git> bitcoin/master fa655da MarcoFalke: test: [refactor] Use ToIntegral in CheckInferDescriptor
<bitcoin-git> [bitcoin] achow101 merged pull request #32365: descriptors: Reject + sign while parsing unsigned (master...2504-int-parsing) https://github.com/bitcoin/bitcoin/pull/32365
diva17 has left #bitcoin-core-dev [#bitcoin-core-dev]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
neutrino777 has joined #bitcoin-core-dev
neutrino1 has quit [Ping timeout: 244 seconds]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 240 seconds]
Talkless has quit [Quit: Konversation terminated!]
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 240 seconds]
Christoph_ has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 276 seconds]
skr0 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] darosior opened pull request #32381: policy: allow more than one OP_RETURN outputs per tx (master...2504_fixthefiltersyo) https://github.com/bitcoin/bitcoin/pull/32381
eugenesiegel has quit [Ping timeout: 240 seconds]
skr0 has quit [Client Quit]
<bitcoin-git> [bitcoin] w0xlt opened pull request #32382: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32382
<bitcoin-git> [bitcoin] w0xlt closed pull request #32382: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32382
jonatack has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] achow101 pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/51d76634fb57...7db096121d37
<bitcoin-git> bitcoin/master 9bc41f1 Anthony Towns: versionbits: Use std::array instead of C-style arrays
<bitcoin-git> bitcoin/master e9d6170 Anthony Towns: versionbits: Remove params from AbstractThresholdConditionChecker
<bitcoin-git> bitcoin/master a679040 Anthony Towns: consensus/params: Move version bits period/threshold to bip9 param
<bitcoin-git> [bitcoin] achow101 merged pull request #29039: versionbits refactoring (master...202312-vbits-simplify) https://github.com/bitcoin/bitcoin/pull/29039
Christoph_ has quit [Quit: Christoph_]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7db096121d37...4694732bc4c3
<bitcoin-git> bitcoin/master 94e85a8 Vasil Dimov: net: remove unnecessary check from AlreadyConnectedToAddress()
<bitcoin-git> bitcoin/master f1b1428 David Gumberg: test: Same addr, diff port is already connected
<bitcoin-git> bitcoin/master 4694732 Ava Chow: Merge bitcoin/bitcoin#32338: net: remove unnecessary check from AlreadyCon...
<bitcoin-git> [bitcoin] achow101 merged pull request #32338: net: remove unnecessary check from AlreadyConnectedToAddress() (master...AlreadyConnectedToAddress) https://github.com/bitcoin/bitcoin/pull/32338
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4694732bc4c3...7a4a2a38ea37
<bitcoin-git> bitcoin/master 9d3e39c Sjors Provoost: Log block header in net_processing
<bitcoin-git> bitcoin/master bad7c91 Sjors Provoost: Log which peer sent us a header
<bitcoin-git> bitcoin/master f9fa287 Sjors Provoost: Use LogBlockHeader for compact blocks
<bitcoin-git> [bitcoin] achow101 merged pull request #27826: validation: log which peer sent us a header (master...2023/05/saw-header) https://github.com/bitcoin/bitcoin/pull/27826
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a4a2a38ea37...0ed5f37afef1
<bitcoin-git> bitcoin/master b9d4d5f laanwj: net: Use GetAdaptersAddresses to get local addresses on Windows
<bitcoin-git> bitcoin/master 0ed5f37 Ava Chow: Merge bitcoin/bitcoin#31014: net: Use GetAdaptersAddresses to get local ad...
<bitcoin-git> [bitcoin] achow101 merged pull request #31014: net: Use GetAdaptersAddresses to get local addresses on Windows (master...2024-10-windows-address-discovery) https://github.com/bitcoin/bitcoin/pull/31014
Guest48 has joined #bitcoin-core-dev
Guest48 has quit [Client Quit]
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0ed5f37afef1...2d5b4244147b
<bitcoin-git> bitcoin/master b80d0bd Lőrinc: test: avoid stack overflow in `FindChallenges` via manual iteration
<bitcoin-git> bitcoin/master f670836 Lőrinc: test: remove old recursive `FindChallenges_recursive` implementation
<bitcoin-git> bitcoin/master e400ac5 Lőrinc: refactor: simplify repeated comparisons in `FindChallenges`
<bitcoin-git> [bitcoin] achow101 merged pull request #32351: test: avoid stack overflow in `FindChallenges` via manual iteration (master...l0rinc/FindChallenges) https://github.com/bitcoin/bitcoin/pull/32351
padillaque has joined #bitcoin-core-dev
padillaque has quit [Changing host]
padillaque has joined #bitcoin-core-dev
<padillaque> this is pad x.com/123456 - you patched all of *my* dos issues e.g. the one that was issued a cve and others. i want credit. if i am not issued credit for my discoveries and realization through tangible exploit code - i'm probably going to start paying off *stream and going after people
<padillaque> you won't sweep months or even years of my work under the rug
<padillaque> i've been doing this for 27 years and i will start 360noscoping
<padillaque> js
<padillaque> so do the right thing - it's the computer science not the fucking popularity contest
<padillaque> sorry for not being a social climbing blockchain socialite guys
bitdex has joined #bitcoin-core-dev
<padillaque> monero just credited me for a tns https://github.com/monero-project/monero/releases
<padillaque> ctrl + f kev
<padillaque> why does core refuse to acknowledge my achievements
<padillaque> this is bitcoin, not high school - and i want my discoveries on wax for my resume - this should *NOT* even be a discussion
<padillaque> dms open on x for fair devs
padillaque has quit [Quit: Client closed]
jonatack has quit [Read error: Connection reset by peer]
Cory55 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d5b4244147b...a60445cd04c8
<bitcoin-git> bitcoin/master 524f981 Luke Dashjr: Bugfix: Miner: Don't reuse block_reserved_weight for "block is full enough...
<bitcoin-git> bitcoin/master a60445c Ava Chow: Merge bitcoin/bitcoin#32355: Bugfix: Miner: Don't reuse block_reserved_wei...
<bitcoin-git> [bitcoin] achow101 merged pull request #32355: Bugfix: Miner: Don't reuse block_reserved_weight for "block is full enough to give up" weight delta (master...fix_block_full_enough) https://github.com/bitcoin/bitcoin/pull/32355
Cory55 has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a60445cd04c8...14b8dfb2bd5e
<bitcoin-git> bitcoin/master 62c209f Sebastian Falbesoner: wallet: doc: remove mentions of unavailable scrypt derivation method
<bitcoin-git> bitcoin/master a6d9b41 Sebastian Falbesoner: wallet: refactor: introduce `CMasterKey::DEFAULT_DERIVE_ITERATIONS` consta...
<bitcoin-git> bitcoin/master 8465459 Sebastian Falbesoner: wallet: refactor: dedup master key encryption / derivation rounds setting
<bitcoin-git> [bitcoin] achow101 merged pull request #31398: wallet: refactor: various master key encryption cleanups (master...202411-wallet-encryption_cleanups) https://github.com/bitcoin/bitcoin/pull/31398
<bitcoin-git> [bitcoin] w0xlt reopened pull request #32382: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32382
dermoth has quit [Ping timeout: 252 seconds]