achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
joetor5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #32383: util: Remove `fsbridge::get_filesystem_error_message()` (master...250429-fs-error) https://github.com/bitcoin/bitcoin/pull/32383
dermoth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] w0xlt closed pull request #32382: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32382
bitdex has quit [Ping timeout: 264 seconds]
joetor5 has quit [Quit: joetor5]
bitdex has joined #bitcoin-core-dev
upekkha has quit []
upekkha has joined #bitcoin-core-dev
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
cm has joined #bitcoin-core-dev
vasild_ has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 264 seconds]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
joetor5 has quit [Quit: joetor5]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
mcey has joined #bitcoin-core-dev
mcey has quit [Remote host closed the connection]
mcey has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
jojobizare has joined #bitcoin-core-dev
jojobizare has quit [Quit: Leaving]
vasild_ is now known as vasild
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] w0xlt opened pull request #32384: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32384
gnusha_ has joined #bitcoin-core-dev
edouardparis_ has joined #bitcoin-core-dev
maflcko_ has joined #bitcoin-core-dev
saturday- has joined #bitcoin-core-dev
edouardparis has quit [Ping timeout: 260 seconds]
gnusha has quit [Ping timeout: 260 seconds]
maflcko has quit [Ping timeout: 260 seconds]
Saturday7 has quit [Ping timeout: 260 seconds]
Guyver2 has joined #bitcoin-core-dev
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
neutrino777 has quit [Ping timeout: 248 seconds]
LainIwakura has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
robszarka has quit [Read error: Connection reset by peer]
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 252 seconds]
Christoph_ has quit [Quit: Christoph_]
Chris_Stewart_5 has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<hebasto> sipa:https://x.com/NicolasDorier/status/1917370497001742660
<bitcoin-git> [bitcoin] stratospher opened pull request #32385: test: add test for malleated transaction with valid witness (master...2025_04_tx_malleate) https://github.com/bitcoin/bitcoin/pull/32385
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
LainIwakura has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Christoph_ has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 276 seconds]
neutrino777 has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
mudsip has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 260 seconds]
mudsip has quit []
Guyver2 has joined #bitcoin-core-dev
Guest19 has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 245 seconds]
Guest19 has quit [Client Quit]
nanotube has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #32386: mining: rename gbt_force and gbt_force_name (master...2025/04/gbt) https://github.com/bitcoin/bitcoin/pull/32386
jespada has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #32387: [DRAFT] ipc: add windows support (master...pr/ipc-win) https://github.com/bitcoin/bitcoin/pull/32387
eugenesiegel has joined #bitcoin-core-dev
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 240 seconds]
eugenesiegel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] w0xlt closed pull request #32384: Make `cs_db` mutex non-recursive (master...cs_db) https://github.com/bitcoin/bitcoin/pull/32384
bugs_ has joined #bitcoin-core-dev
pablomartin has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
<bitcoin-git> [bitcoincore.org] fanquake opened pull request #1129: blog: ammend date of latest advisory (master...fixup_postdate) https://github.com/bitcoin-core/bitcoincore.org/pull/1129
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 244 seconds]
bugs_ has quit [Quit: Leaving]
eugenesiegel has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
szarka has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/bfe173782999...c88f668c15b2
<bitcoin-git> bitcoincore.org/master bc98e70 fanquake: blog: ammend date of latest advisory
<bitcoin-git> bitcoincore.org/master c88f668 merge-script: Merge bitcoin-core/bitcoincore.org#1129: blog: ammend date of latest advis...
<bitcoin-git> [bitcoincore.org] fanquake merged pull request #1129: blog: ammend date of latest advisory (master...fixup_postdate) https://github.com/bitcoin-core/bitcoincore.org/pull/1129
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 240 seconds]
<bitcoin-git> [gui] D33r-Gee opened pull request #870: [DRAFT] Expose AssumeUTXO Load Snapshot Functionality To The GUI (master...2025_gui_interfaces_loadsnapshot_poc) https://github.com/bitcoin-core/gui/pull/870
eugenesiegel has joined #bitcoin-core-dev
<bitcoin-git> [gui] D33r-Gee closed pull request #869: interface: Expose load utxo snapshot functionality (master...2025_gui_interfaces_loadsnapshot) https://github.com/bitcoin-core/gui/pull/869
robobub has joined #bitcoin-core-dev
neutrino777 has quit [Ping timeout: 260 seconds]
pablomartin has quit [Ping timeout: 276 seconds]
neutrino777 has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
adil has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
adil has quit [Quit: adil]
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
letim1291 has joined #bitcoin-core-dev
letim2 has joined #bitcoin-core-dev
letim2 has quit [Client Quit]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
Earnestly has quit [Ping timeout: 248 seconds]
dzxzg has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
PaperSword has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
Guest95 has joined #bitcoin-core-dev
Guest95 has quit [Client Quit]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 260 seconds]
letim1291 has quit [Quit: Client closed]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14b8dfb2bd5e...68ac9f116c02
<bitcoin-git> bitcoin/master 97eaadc Hennadii Stepanov: util: Remove `fsbridge::get_filesystem_error_message()`
<bitcoin-git> bitcoin/master 68ac9f1 Ava Chow: Merge bitcoin/bitcoin#32383: util: Remove `fsbridge::get_filesystem_error_...
<bitcoin-git> [bitcoin] achow101 merged pull request #32383: util: Remove `fsbridge::get_filesystem_error_message()` (master...250429-fs-error) https://github.com/bitcoin/bitcoin/pull/32383
<bitcoin-git> [bitcoin] maflcko opened pull request #32388: fuzz: Remove unused TimeoutExpired catch in fuzz runner (master...2504-fuzz-timeout) https://github.com/bitcoin/bitcoin/pull/32388
<bitcoin-git> [bitcoin] maflcko closed pull request #32339: ci: Merge fuzz task for macOS (master...2504-ci-merge) https://github.com/bitcoin/bitcoin/pull/32339
kevkevin has quit [Remote host closed the connection]
Guest51 has joined #bitcoin-core-dev
Guest51 has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 245 seconds]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 240 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] darosior closed pull request #32381: policy: allow more than one OP_RETURN outputs per tx (master...2504_fixthefiltersyo) https://github.com/bitcoin/bitcoin/pull/32381
Christoph_ has joined #bitcoin-core-dev
szarka has quit [Quit: Leaving]
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Talkless has quit [Quit: Konversation terminated!]
kevkevin has joined #bitcoin-core-dev
Guyver2 has quit [Remote host closed the connection]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<fjahr> pinheadmz: Not sure if the ML is the right place for that bitcoin core meta discussion, so writing it here instead: Agree that it would be good to split conceptual and technical review but also skeptical the discussion post would get traction. And even if it did, people could still copy+paste their messages into the PR later.
<fjahr> A more strict approach would be to open the PR right away but lock it to org members, so the PR is only reserved for technical review. Then there could be an issue that is linked to the PR (via closes #XXX) and that is where the conceptual discussion takes place. This is a bit backwards compared to what we often do: first open an issue, discuss the idea there, then open a PR. But if the PR is the only thing that triggers
<fjahr> people to jump into action, then maybe this is worth a shot.
<fjahr> I wouldn't want to do this for policy changes in general, though. Only in the very rare occasions where we know there will be these emotional discussions.
<Murch[m]> Unfortunately, it’s not possible to lock individual PRs and Issues only to org members, according to achow101 here: https://github.com/bitcoin-core/meta/issues/19#issuecomment-2839879023
<fjahr> Ah, ok, I thought we had done this before :/
<achow101> we can only lock to people with write permission, i.e. maintainers
TheRec has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
TheRec_ has quit [Read error: Connection reset by peer]
<fjahr> So just make everyone maintainer while we have a controversial PR open? :p
<Murch[m]> haha
<achow101> hmm, I think it actually may be possible to give frequent contributors the write permission, while restricting the ability to actually push any commits to the branches
<achow101> but there might be some other side effects with that
<achow101> probably need to play around with these settings somewhere else first
<achow101> there's a lot of branch protection rules that we haven't really explored
BlueMatt has quit [Quit: Quit]
BlueMatt has joined #bitcoin-core-dev
<lightlike> I don't think there is an actual problem if all we want is separation: just have a maintainer announce "this is the issue / thread where all the conceptual discussion goes, this is the PR for technical review. They belong together and will be evaluated together, but please post in the correct one" and then delete posts (from regulars and drive-by accounts alike) if they are in the wrong one.
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<jonatack> lightlike: sgtm. perhaps a moderator or even the pull author can announce that as well
<achow101> it's actually unclear to me whether regular contributors would have anything to say when a pr is locked?
<achow101> and it would definitely piss off more people if the "in group" can comment but no one else can. that feeds into the perception of being a cabal