<bitcoin-git>
[bitcoin] stratospher opened pull request #32385: test: add test for malleated transaction with valid witness (master...2025_04_tx_malleate) https://github.com/bitcoin/bitcoin/pull/32385
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
kevkevin has quit [Remote host closed the connection]
Guest51 has joined #bitcoin-core-dev
Guest51 has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 245 seconds]
Cory55 has quit [Quit: Client closed]
Cory55 has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 240 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] darosior closed pull request #32381: policy: allow more than one OP_RETURN outputs per tx (master...2504_fixthefiltersyo) https://github.com/bitcoin/bitcoin/pull/32381
Christoph_ has joined #bitcoin-core-dev
szarka has quit [Quit: Leaving]
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Talkless has quit [Quit: Konversation terminated!]
kevkevin has joined #bitcoin-core-dev
Guyver2 has quit [Remote host closed the connection]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<fjahr>
pinheadmz: Not sure if the ML is the right place for that bitcoin core meta discussion, so writing it here instead: Agree that it would be good to split conceptual and technical review but also skeptical the discussion post would get traction. And even if it did, people could still copy+paste their messages into the PR later.
<fjahr>
A more strict approach would be to open the PR right away but lock it to org members, so the PR is only reserved for technical review. Then there could be an issue that is linked to the PR (via closes #XXX) and that is where the conceptual discussion takes place. This is a bit backwards compared to what we often do: first open an issue, discuss the idea there, then open a PR. But if the PR is the only thing that triggers
<fjahr>
people to jump into action, then maybe this is worth a shot.
<fjahr>
I wouldn't want to do this for policy changes in general, though. Only in the very rare occasions where we know there will be these emotional discussions.
<fjahr>
Ah, ok, I thought we had done this before :/
<achow101>
we can only lock to people with write permission, i.e. maintainers
TheRec has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
TheRec_ has quit [Read error: Connection reset by peer]
<fjahr>
So just make everyone maintainer while we have a controversial PR open? :p
<Murch[m]>
haha
<achow101>
hmm, I think it actually may be possible to give frequent contributors the write permission, while restricting the ability to actually push any commits to the branches
<achow101>
but there might be some other side effects with that
<achow101>
probably need to play around with these settings somewhere else first
<achow101>
there's a lot of branch protection rules that we haven't really explored
BlueMatt has quit [Quit: Quit]
BlueMatt has joined #bitcoin-core-dev
<lightlike>
I don't think there is an actual problem if all we want is separation: just have a maintainer announce "this is the issue / thread where all the conceptual discussion goes, this is the PR for technical review. They belong together and will be evaluated together, but please post in the correct one" and then delete posts (from regulars and drive-by accounts alike) if they are in the wrong one.
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<jonatack>
lightlike: sgtm. perhaps a moderator or even the pull author can announce that as well
<achow101>
it's actually unclear to me whether regular contributors would have anything to say when a pr is locked?
<achow101>
and it would definitely piss off more people if the "in group" can comment but no one else can. that feeds into the perception of being a cabal