bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 272 seconds]
jerryf has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Remote host closed the connection]
Saturday7 has quit [Ping timeout: 264 seconds]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Saturday7 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
l0rinc has quit [Ping timeout: 240 seconds]
l0rinc has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] l0rinc opened pull request #33512: Use number of dirty cache entries in flush warnings/logs (master...l0rinc/warn-dirty-coin-coint) https://github.com/bitcoin/bitcoin/pull/33512
kevkevin has quit [Remote host closed the connection]
durandal_ has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
durandal_ has joined #bitcoin-core-dev
theStack has quit [Ping timeout: 250 seconds]
l0rinc has quit [Quit: l0rinc]
twistedline has quit []
twistedline has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jerryf has quit [Quit: jerryf]
Guest92 has joined #bitcoin-core-dev
Guest92 has quit [Client Quit]
Musa has joined #bitcoin-core-dev
Musa has quit [Client Quit]
f321x has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
darosior has quit [Ping timeout: 260 seconds]
luke-jr_ is now known as luke-jr
memset has quit [Remote host closed the connection]
darosior has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
f321x has quit [Quit: f321x]
durandal_ has quit [Ping timeout: 264 seconds]
durandal_ has joined #bitcoin-core-dev
robobub has quit [Quit: Connection closed for inactivity]
<bitcoin-git>
[bitcoin] vasild closed pull request #31316: fuzz: set the output argument of FuzzedSock::Accept() (master...fuzzedsock_accept) https://github.com/bitcoin/bitcoin/pull/31316
Guest85 has joined #bitcoin-core-dev
Guest85 has quit [Client Quit]
<vasild>
About mocked time: currently we can set a mocked time and then it stays frozen at that value. Then we can set it to another frozen value. Eventually we can remove mocked time and then it reverts to the real time which is flowing. I think it would be useful to be able to let the mocked time flow. Or (which is the same) to be able to advance the currently flowing time by a given interval and keep
<vasild>
it flowing, simulating time passage in tests. Any thoughts?
<bitcoin-git>
[bitcoin] hebasto merged pull request #33401: ci: Remove bash -c from cmake invocation using eval (master...ci-cmake-eval) https://github.com/bitcoin/bitcoin/pull/33401
TallTim_ is now known as TallTim
<shiza>
vasild: mock spawns a thread that on wake adjusts mocked time to delta between case start and now and then sleeps?
<vasild>
shiza: hmm, maybe no need for a new thread, looking at NodeClock::now() in src/util/time.cpp which returns either std::chrono::system_clock::now().time_since_epoch() (the real flowing time) or g_mock_time (frozen mock time), maybe it would return the real time + mock delta.
<sipa>
vasild: it sounds very reasonable, but is there a use case?
<vasild>
sipa: yes, this is what I am trying to understand. Over time, occassionally I felt the need for that when writing tests, but if it is just me, then there is little motivation to pursue it.
<shiza>
vasild: never done such a thing but I suppose it could fit niches in transportation software test suites or in ecash if you have very large resources for IBD performance optimization
<shiza>
sounds real time software development to me
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<_aj_>
vasild: using setmocktime(int(time.time())) to stop/bump the clock and setmocktime(0) to make it continue again seems a decent approximation of that? the mockscheduler rpc / scheduler.cpp MockForward does a similar manipulation arguably
<vasild>
setmocktime(int(time.time())) + setmocktime(0) is to pause the time and let it flow again, can't simlulate time passage, unless you do sleep(2 minutes) in the test if you want to simulate 2 minutes have passed.
<vasild>
yes, mockscheduler does that for the scheduler
bst_ has joined #bitcoin-core-dev
<_aj_>
vasild: you can do t=time.time()-3600; setmocktime(t); setmocktime(t+120); ...; setmocktime(0). can't do it for multiple chunks, but if you're controlling the flow of time once in a test, then controlling it fairly continually seems mostly sensible to me
<vasild>
yeah, that is an approximation of time passage
<_aj_>
well, rt = time.time(); t = X; setmocktime(t + time.time() - rt) would get you an approximation of time passage
kevkevin has quit [Remote host closed the connection]
pedrohgs has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
eugenesiegel has quit [Quit: Client closed]
l0rinc has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 256 seconds]
f321x has quit [Ping timeout: 272 seconds]
Guest85 has joined #bitcoin-core-dev
Guest85 has quit [Client Quit]
Guest85 has joined #bitcoin-core-dev
Guest85 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
jonatack has quit [Ping timeout: 264 seconds]
l0rinc has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
l0rinc has quit [Quit: l0rinc]
eugenesiegel has quit [Quit: Client closed]
l0rinc has joined #bitcoin-core-dev
Guest2 has joined #bitcoin-core-dev
Guest2 has quit [Client Quit]
<cfields>
review beg for libmultiprocess#220. I know it's really really late, but I'm still hoping to see that in for v30 as it fixes a substantial performance issue for libmultiprocess users as well as bitcoin-node itself.