#bitcoin-core-dev on 2025-10-18 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:05 _flood has quit [Remote host closed the connection]

00:06 _flood has joined #bitcoin-core-dev

00:09 _flood has quit [Remote host closed the connection]

00:10 _flood has joined #bitcoin-core-dev

00:12 jonatack has quit [Ping timeout: 256 seconds]

00:13 _flood has quit [Remote host closed the connection]

00:14 flooded has joined #bitcoin-core-dev

00:16 flooded has quit [Remote host closed the connection]

00:17 flooded has joined #bitcoin-core-dev

00:28 flooded has quit [Remote host closed the connection]

00:29 flooded has joined #bitcoin-core-dev

00:32 flooded has quit [Remote host closed the connection]

00:33 flooded has joined #bitcoin-core-dev

00:52 flooded has quit [Remote host closed the connection]

00:54 flooded has joined #bitcoin-core-dev

00:59 flooded has quit [Remote host closed the connection]

01:00 flooded has joined #bitcoin-core-dev

01:01 flooded has quit [Remote host closed the connection]

01:01 flooded has joined #bitcoin-core-dev

01:05 flooded has quit [Remote host closed the connection]

01:05 flooded has joined #bitcoin-core-dev

01:32 kevkevin has quit [Read error: Connection reset by peer]

01:33 kevkevin has joined #bitcoin-core-dev

01:41 kevkevin has quit [Read error: Connection reset by peer]

01:42 kevkevin has joined #bitcoin-core-dev

01:52 zeropoint has quit [Quit: leaving]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:48 TallTim_ has joined #bitcoin-core-dev

04:51 PaperSword has quit [Quit: PaperSword]

05:39 l0rinc has joined #bitcoin-core-dev

05:44 l0rinc has quit [Ping timeout: 248 seconds]

05:45 l0rinc has joined #bitcoin-core-dev

06:00 l0rinc has quit [Ping timeout: 264 seconds]

06:05 l0rinc has joined #bitcoin-core-dev

06:16 l0rinc has quit [Remote host closed the connection]

06:16 l0rinc has joined #bitcoin-core-dev

06:20 l0rinc_ has joined #bitcoin-core-dev

06:20 l0rinc has quit [Ping timeout: 240 seconds]

06:27 l0rinc_ has quit [Ping timeout: 252 seconds]

06:35 l0rinc has joined #bitcoin-core-dev

06:50 l0rinc has quit [Remote host closed the connection]

06:50 l0rinc has joined #bitcoin-core-dev

07:05 l0rinc has quit [Ping timeout: 244 seconds]

07:08 l0rinc has joined #bitcoin-core-dev

07:20 l0rinc has quit [Ping timeout: 248 seconds]

07:28 l0rinc has joined #bitcoin-core-dev

07:37 kevkevin has quit [Remote host closed the connection]

07:41 l0rinc has quit [Read error: Connection reset by peer]

07:41 l0rinc has joined #bitcoin-core-dev

07:43 l0rinc has quit [Client Quit]

07:55 kevkevin has joined #bitcoin-core-dev

08:00 kevkevin has quit [Ping timeout: 264 seconds]

08:04 dviola has quit [Quit: WeeChat 4.7.1]

08:11 dviola has joined #bitcoin-core-dev

08:12 dviola has quit [Client Quit]

08:14 dviola has joined #bitcoin-core-dev

08:15 kevkevin has joined #bitcoin-core-dev

08:41 Talkless has joined #bitcoin-core-dev

09:20 kevkevin has quit [Ping timeout: 240 seconds]

09:34 kevkevin has joined #bitcoin-core-dev

10:12 Guest73 has joined #bitcoin-core-dev

10:15 Guest73 has quit [Client Quit]

10:18 memset_ has quit [Remote host closed the connection]

10:19 memset has joined #bitcoin-core-dev

10:31 Guest37 has joined #bitcoin-core-dev

10:35 PaperSword has joined #bitcoin-core-dev

10:37 kevkevin has quit [Ping timeout: 256 seconds]

11:09 <bitcoin-git> [bitcoin] famouswizard opened pull request #33654: fix: invalid plist format and update values to meet macOS 1.0 standard (master...patch-1) https://github.com/bitcoin/bitcoin/pull/33654

11:10 TheRec has joined #bitcoin-core-dev

11:28 Guest37 has quit [Quit: Client closed]

11:32 SpellChecker_ is now known as SpellChecker

12:01 kevkevin has joined #bitcoin-core-dev

12:05 kevkevin has quit [Ping timeout: 246 seconds]

12:12 kevkevin has joined #bitcoin-core-dev

12:42 roconnor has joined #bitcoin-core-dev

13:10 kevkevin has quit [Ping timeout: 264 seconds]

13:14 jerryf has quit [Remote host closed the connection]

13:14 jerryf has joined #bitcoin-core-dev

13:30 jonatack has joined #bitcoin-core-dev

13:31 kevkevin has joined #bitcoin-core-dev

13:35 l0rinc has joined #bitcoin-core-dev

13:36 l0rinc has quit [Client Quit]

13:40 memset has quit [Remote host closed the connection]

13:40 memset has joined #bitcoin-core-dev

13:43 <dviola> hebasto, pablomartin4btc: I'm having some second thoughts about: https://github.com/bitcoin-core/gui/pull/904

13:44 <dviola> just asked in #qt-labs and they said "Most likely there's something more complex going on than just setting the hint"

13:44 <dviola> so I wanted to ask, please don't merge yet

13:47 l0rinc has joined #bitcoin-core-dev

13:52 Guest15 has joined #bitcoin-core-dev

14:03 l0rinc has quit [Remote host closed the connection]

14:03 l0rinc has joined #bitcoin-core-dev

14:15 kevkevin has quit [Remote host closed the connection]

14:33 <hebasto> dviola: kk

14:34 jonatack has quit [Ping timeout: 244 seconds]

14:34 <dviola> I'm curious whether it would be possible to set those flags before the window is created, supposedly the window gets recreated and that's why the flicker appears

14:37 <dviola> I think I'll just switch to xcb until someone with more knowledge decides to look into this again

14:46 kevkevin has joined #bitcoin-core-dev

14:59 jerryf has quit [Remote host closed the connection]

14:59 jerryf has joined #bitcoin-core-dev

15:07 kevkevin has quit [Remote host closed the connection]

15:11 kevkevin has joined #bitcoin-core-dev

15:26 Guest15 has quit [Quit: Client closed]

15:27 Guest9 has joined #bitcoin-core-dev

15:27 Guest9 has quit [Client Quit]

15:34 <dviola> trying one more thing

15:50 bugs_ has joined #bitcoin-core-dev

16:06 Guest39 has joined #bitcoin-core-dev

16:08 <dviola> ok, I think I figured it out

16:10 <dviola> the problem isn't the Qt::WindowStaysOnTopHint, but bringToFront() is doing w->show() twice and there's something calling bringToFront() on the main window

16:10 <dviola> so as such, the main window is being repainted more than it should

16:10 <dviola> I will update my PR

16:16 <dviola> hopefully pablomartin4btc can take it from here, but I'm happy with this approach

16:27 <dviola> it's not even a problem in bringToFront but *this* (BitcoinGUI) is being passed to bringToFront

16:27 <dviola> so a window that is already at the front is being told to move to the front again

16:31 <dviola> hebasto: a revert would have just dealt with the symptom and not the cause, I'm afraid

16:45 <bitcoin-git> [bitcoin] l0rinc closed pull request #33569: refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions (master...l0rinc/throw-by-value) https://github.com/bitcoin/bitcoin/pull/33569

16:46 PaperSword has quit [Quit: PaperSword]

16:46 PaperSword has joined #bitcoin-core-dev

16:48 memset has quit [Remote host closed the connection]

16:49 memset has joined #bitcoin-core-dev

17:04 dviola has quit [Ping timeout: 240 seconds]

17:07 dviola has joined #bitcoin-core-dev

17:29 <dviola> just updated the PR: https://github.com/bitcoin-core/gui/pull/904

17:39 dviola has quit [Ping timeout: 244 seconds]

17:41 diego has joined #bitcoin-core-dev

17:43 diego has left #bitcoin-core-dev [#bitcoin-core-dev]

17:44 dviola has joined #bitcoin-core-dev

17:44 evias has joined #bitcoin-core-dev

18:07 flooded has quit [Remote host closed the connection]

18:08 flooded has joined #bitcoin-core-dev

18:12 l0rinc has quit [Quit: l0rinc]

18:17 cotsuka has quit [Remote host closed the connection]

18:18 cotsuka has joined #bitcoin-core-dev

18:25 kevkevin has quit [Remote host closed the connection]

18:30 bugs_ has quit [Quit: Leaving]

18:41 kevkevin has joined #bitcoin-core-dev

18:46 kevkevin has quit [Ping timeout: 246 seconds]

19:14 kevkevin has joined #bitcoin-core-dev

19:22 kevkevin has quit [Ping timeout: 264 seconds]

19:25 l0rinc has joined #bitcoin-core-dev

19:29 l0rinc has quit [Ping timeout: 256 seconds]

19:32 dp_ has joined #bitcoin-core-dev

19:33 jarthur has quit [Ping timeout: 260 seconds]

19:33 dp_ has quit [Client Quit]

19:33 l0rinc has joined #bitcoin-core-dev

19:34 purpleKarrot has joined #bitcoin-core-dev

19:35 kevkevin has joined #bitcoin-core-dev

19:36 purpleKarrot has quit [Changing host]

19:36 purpleKarrot has joined #bitcoin-core-dev

19:41 jarthur has joined #bitcoin-core-dev

19:44 kevkevin has quit [Ping timeout: 246 seconds]

20:00 ___nick___ has joined #bitcoin-core-dev

20:01 jarthur has quit [Quit: jarthur]

20:04 ___nick___ has quit [Ping timeout: 246 seconds]

20:10 jarthur has joined #bitcoin-core-dev

20:13 jarthur has quit [Client Quit]

20:17 ___nick___ has joined #bitcoin-core-dev

20:18 memset has quit [Remote host closed the connection]

20:19 memset has joined #bitcoin-core-dev

20:19 jarthur has joined #bitcoin-core-dev

20:19 jarthur has quit [Client Quit]

20:27 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

20:28 kevkevin has joined #bitcoin-core-dev

20:29 ___nick___ has joined #bitcoin-core-dev

20:29 ___nick___ has quit [Client Quit]

20:30 durandal_ has quit [Ping timeout: 246 seconds]

20:31 ___nick___ has joined #bitcoin-core-dev

20:32 purpleKarrot has quit [Quit: purpleKarrot]

20:32 kevkevin has quit [Ping timeout: 248 seconds]

20:43 durandal_ has joined #bitcoin-core-dev

20:46 kevkevin has joined #bitcoin-core-dev

20:48 durandal_ has quit [Ping timeout: 244 seconds]

20:49 jynxbt has joined #bitcoin-core-dev

20:49 <dviola> it took me a lot of trial-and-error to solve this, as I'm not familiar with the bitcoin codebase, but I think I learned something

20:49 jonatack has joined #bitcoin-core-dev

20:50 jynxbt has quit [Client Quit]

20:51 <dviola> I noticed that for macOS GUIUtil::bringToFront(this) is being called just like on wayland: https://github.com/bitcoin/bitcoin/blob/v30.0/src/qt/bitcoingui.cpp#L567

20:51 <dviola> but in this case it's not a problem because Qt::WindowStaysOnTopHint is not being set for macOS

20:55 <dviola> anyway, I think I'm done, looking forward to your reviews

20:56 purpleKarrot has joined #bitcoin-core-dev

20:56 purpleKarrot has quit [Client Quit]

21:01 jonatack has quit [Ping timeout: 244 seconds]

21:01 evias_ has joined #bitcoin-core-dev

21:03 evias has quit [Ping timeout: 250 seconds]

21:10 durandal_ has joined #bitcoin-core-dev

21:17 robszarka has joined #bitcoin-core-dev

21:18 jonatack has joined #bitcoin-core-dev

21:20 szarka has quit [Ping timeout: 248 seconds]

21:23 l0rinc has quit [Quit: l0rinc]

21:24 durandal_ has quit [Quit: Leaving]

21:49 kevkevin has quit [Ping timeout: 256 seconds]

22:05 Talkless has quit [Quit: Konversation terminated!]

22:13 kevkevin has joined #bitcoin-core-dev

22:17 kevkevin has quit [Ping timeout: 246 seconds]

22:24 kevkevin has joined #bitcoin-core-dev

22:44 jonatack has quit [Ping timeout: 244 seconds]

23:08 evias_ has quit [Quit: This computer has gone to sleep]

23:29 <bitcoin-git> [bitcoin] furszy closed pull request #32730: p2p: avoid traversing blocks (twice) during IBD (master...2025_net_avoid_traversing_block_twice) https://github.com/bitcoin/bitcoin/pull/32730

23:55 l0rinc has joined #bitcoin-core-dev