<bitcoin-git>
[bitcoin] hebasto opened pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
<bitcoin-git>
bitcoin/master 5c5d8f2 Hennadii Stepanov: qt, test: Add tests for searching in `AddressBookPage` dialog
<bitcoin-git>
bitcoin/master e280087 Hennadii Stepanov: qt: Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class
<bitcoin-git>
[gui] hebasto merged pull request #593: Getting ready to Qt 6 (8/n). Use `QRegularExpression` in `AddressBookSortFilterProxyModel` class (master...220423-re) https://github.com/bitcoin-core/gui/pull/593
<bitcoin-git>
bitcoin/master 31122aa Ryan Ofsky: refactor: Pass interfaces::Node references to OptionsModel constructor
<bitcoin-git>
[bitcoin] mzumsande opened pull request #25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (master...202205_index_allow_reindex_chainstate) https://github.com/bitcoin/bitcoin/pull/25193
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25192: test: add coverage for unknown value to -blockfilterindex (master...2022-05-unknown-blockfilter) https://github.com/bitcoin/bitcoin/pull/25192
<bitcoin-git>
[bitcoin] hebasto opened pull request #25191: build: Make `--with-gui=qt6` configure option available on macOS (master...220523-qt6-mac) https://github.com/bitcoin/bitcoin/pull/25191
<bitcoin-git>
bitcoin/master 48d2e80 laanwj: test: Don't use shell=True in `lint-files.py`
<bitcoin-git>
bitcoin/master 908fb7e laanwj: test: Use permissions from git in `lint-files.py`
<bitcoin-git>
bitcoin/master fbb90c4 MacroFake: Merge bitcoin/bitcoin#25015: test: Use permissions from git in lint-files....
<bitcoin-git>
[bitcoin] achow101 merged pull request #25083: Set effective_value when initializing a COutput (master...draft-CalculateEffectiveValue2) https://github.com/bitcoin/bitcoin/pull/25083
<bitcoin-git>
bitcoin/master 3368f84 Andrew Chow: Merge bitcoin/bitcoin#25083: Set effective_value when initializing a COutp...
<bitcoin-git>
bitcoin/master 6fbb0ed ishaanam: Set effective_value when initializing a COutput
<bitcoin-git>
bitcoin/master baa3ddc furszy: doc: add release notes about `getreceivedbylabel` returning an error if th...
<bitcoin-git>
bitcoin/master 5ebff43 Andrew Chow: Merge bitcoin/bitcoin#25122: rpc: getreceivedbylabel, return early if no a...
<bitcoin-git>
[bitcoin] achow101 merged pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
<bitcoin-git>
[gui] hebasto merged pull request #586: Getting ready to Qt 6 (6/n). Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)` (master...220416-quit) https://github.com/bitcoin-core/gui/pull/586
<bitcoin-git>
[gui] hebasto closed pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
<bitcoin-git>
[bitcoin] Empact opened pull request #25184: refactor: Remove defunct attributes.h includes (master...2022-05-attributes-include) https://github.com/bitcoin/bitcoin/pull/25184
<bitcoin-git>
[gui] hebasto closed pull request #592: Drop wildcard support for address/label search in `AddressBookPage` (master...220423-wildcard) https://github.com/bitcoin-core/gui/pull/592
<bitcoin-git>
[bitcoin] mruddy closed pull request #24912: refactor: update CBlockIndex::nChainTx to be uint64_t (master...nchaintx_type) https://github.com/bitcoin/bitcoin/pull/24912
<bitcoin-git>
[bitcoin] aureleoules opened pull request #25183: rpc: Witness-only inputs for fundrawtransaction (master...2022-05-witness-only-fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/25183
<luke-jr>
david-bakin: various historical aspects of Bitcoin do some crazy things re endian
<gribble>
https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<bitcoin-git>
bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper
2022-05-19
<bitcoin-git>
[bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
<david-bakin>
Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other. I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341. That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<david-bakin>
I have a non-bitcoin-specific "process" question: If I get a suggestion in a PR that has actual code and the button "commit suggestion" and I press the button - how does that fix, committed in bitcoin/bitcoin, get back to my fork? Do I just do it manually (create a patch any apply it) or??
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<bitcoin-git>
bitcoin/master 3a998d2 Jon Atack: Use steady_clock in ConnectAndCallRPC and inline time call in loop conditi...
<bitcoin-git>
bitcoin/master c6122f5 ishaanam: test: use sendall in wallet_taproot.py tests
<bitcoin-git>
[bitcoin] suhailsaqan opened pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<achow101>
luke-jr: do you only see the segfaul with bitcoin-qt? and can you get it reliably?
<bitcoin-git>
[bitcoin] ishaanam opened pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
<bitcoin-git>
bitcoin/master c9fdaa5 Sebastian Falbesoner: wallet: CreateTransactionInternal(): return out-params as (optional) struct
<bitcoin-git>
bitcoin/master 4c5ceb0 Sebastian Falbesoner: wallet: CreateTransaction(): return out-params as (optional) struct
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git>
[bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
<bitcoin-git>
[bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<david-bakin>
ok. here's a question I have about the bitcoin CR experience vs that I've experienced at companies: Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time? IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness. Is it worth doing?
<sipa>
There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
<bitcoin-git>
[bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
<bitcoin-git>
[bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
<bitcoin-git>
bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
<bitcoin-git>
bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
<bitcoin-git>
[bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
<bitcoin-git>
bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
<bitcoin-git>
bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
<bitcoin-git>
[bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147