<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25303: refactor: Remove redundant addrman time checks (master...2206-less-addrman-time-checks-🚶) https://github.com/bitcoin/bitcoin/pull/25303
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25304: Revert "ci: Temporarily use clang-13 to work around clang-14 TSan bug" (master...2206-ci-rev-14-💁) https://github.com/bitcoin/bitcoin/pull/25304
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master f10e80b dergoegge: [net] Use ConnectedThroughNetwork() instead of GetNetwork() to seed addr c...
<bitcoin-git>
bitcoin/master 3382905 dergoegge: [net] Seed addr cache randomizer with port from binding address
<bitcoin-git>
bitcoin/master 292828c dergoegge: [test] Test addr cache for multiple onion binds
<bitcoin-git>
[bitcoin] fanquake merged pull request #25096: [net] Minor improvements to addr caching (master...2022-05-improve-addr-cache) https://github.com/bitcoin/bitcoin/pull/25096
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
bomb-on has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #25304: Revert "ci: Temporarily use clang-13 to work around clang-14 TSan bug" (master...2206-ci-rev-14-💁) https://github.com/bitcoin/bitcoin/pull/25304
<bitcoin-git>
[bitcoin] jonatack opened pull request #25306: logging: add LogPrintfCategory to log unconditionally with category (master...2022-06-logprintfcategory) https://github.com/bitcoin/bitcoin/pull/25306
yanmaani has quit [Ping timeout: 240 seconds]
_flood has quit [Ping timeout: 255 seconds]
flooded has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44__ has joined #bitcoin-core-dev
mikehu44___ has joined #bitcoin-core-dev
brunoerg_ has quit [Client Quit]
brunoerg has quit [Ping timeout: 276 seconds]
<bitcoin-git>
[gui] jadijadi opened pull request #615: If -prune=0 is set, Uncheck Prune on Intro page (master...jadi-prune-uncheck) https://github.com/bitcoin-core/gui/pull/615
mikehu44 has quit [Ping timeout: 258 seconds]
mikehu44__ has quit [Ping timeout: 246 seconds]
mikehu44_ has quit [Ping timeout: 260 seconds]
yanmaani has joined #bitcoin-core-dev
real_or_- is now known as real_or_random
furszy has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44___ has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25307: doc: fix typo in kernel/context.h and add `desig` to ignore-words (master...2022-06-fix-typo-kernel) https://github.com/bitcoin/bitcoin/pull/25307
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #25308: refactor: Reduce number of LoadChainstate parameters and return values (master...pr/retcode) https://github.com/bitcoin/bitcoin/pull/25308
mikehu44_ has quit [Ping timeout: 276 seconds]
mikehu44 has joined #bitcoin-core-dev
furszy has quit [Remote host closed the connection]
cornfeedhobo has joined #bitcoin-core-dev
furszy has joined #bitcoin-core-dev
ronoaldo has quit [Quit: Konversation terminated!]
<kouloumos>
The current benchmarking implementation allows for dynamic parameters using the `-asymptote=<n1,n2,...>` argument and then calculates asymptotic complexity (Big O) from multiple runs of the benchmark with different complexity n1,n2,... But it seems that no benchmark supports this and I cannot find any discussion around this topic. Was there never a need for such calculations?
<sipa>
I think it's just a feature of the benchmarking framework we use, but which was never used by us.
<jonatack>
Right, most of the benchmarks existed before we switched to the current framework written by martinus a year or so ago, and the benchmarks were ported over to use the new framework with minimum viable changes IIRC.
furszy has joined #bitcoin-core-dev
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
<kouloumos>
My bad, it is actually used at `mempool_stress`, I just didn't realize that `complexityN()` is overloaded to allow reading inside the benchmarks.
jarthur has quit [Quit: jarthur]
furszy has quit []
<laanwj>
there was also #17375 that proposed asymptote benchmerking before Martinus' framework
Talkless has quit [Quit: Konversation terminated!]
<laanwj>
martinus: thanks for the explanation
brokenprogrammer has joined #bitcoin-core-dev
brokenprogrammer has quit [Client Quit]
<bitcoin-git>
[bitcoin] mzumsande opened pull request #25314: p2p: always set nTime for self-advertisements (master...202206_missing_ntime) https://github.com/bitcoin/bitcoin/pull/25314
brokenprogrammer has joined #bitcoin-core-dev
brokenprogrammer has quit [Client Quit]
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
___nick___ has quit [Ping timeout: 240 seconds]
<kouloumos>
got it, thank you all for chipping in
jespada has joined #bitcoin-core-dev
jespada has quit [Client Quit]
<jonatack>
martinus: thanks for the link to the online documentation, noted.
kexkey has quit [Ping timeout: 244 seconds]
kexkey has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Empact opened pull request #25315: Add warning on first startup if free disk space is less than necessary (master...disk-space-check) https://github.com/bitcoin/bitcoin/pull/25315
jespada has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
tripleslash has quit [Ping timeout: 240 seconds]
tripleslash has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
kouloumos has quit [Quit: Connection closed for inactivity]