#bitcoin-core-dev on 2022-06-14 — searchable irc log

00:00 brunoerg has quit [Ping timeout: 252 seconds]

00:06 jnewbery has joined #bitcoin-core-dev

00:08 shesek has joined #bitcoin-core-dev

00:10 javi404 has quit [Ping timeout: 244 seconds]

00:14 face has joined #bitcoin-core-dev

00:21 <bitcoin-git> [bitcoin] theStack opened pull request #25367: message-capture-parser: fix out of bounds error for empty vectors (master...202206-contrib-fix_message_capture_out_of_bounds) https://github.com/bitcoin/bitcoin/pull/25367

00:46 brunoerg has joined #bitcoin-core-dev

00:55 javi404 has joined #bitcoin-core-dev

01:00 tinova has quit [Ping timeout: 258 seconds]

01:00 pinheadmz has quit [Ping timeout: 276 seconds]

01:06 brunoerg has quit [Ping timeout: 258 seconds]

01:08 tinova has joined #bitcoin-core-dev

01:08 pinheadmz has joined #bitcoin-core-dev

01:34 brunoerg has joined #bitcoin-core-dev

01:39 brunoerg has quit [Ping timeout: 250 seconds]

02:11 chinggg has joined #bitcoin-core-dev

02:16 brunoerg has joined #bitcoin-core-dev

02:20 brunoerg has quit [Ping timeout: 248 seconds]

02:26 brunoerg has joined #bitcoin-core-dev

02:31 brunoerg has quit [Ping timeout: 244 seconds]

02:32 brunoerg has joined #bitcoin-core-dev

02:37 brunoerg has quit [Ping timeout: 255 seconds]

02:43 brunoerg has joined #bitcoin-core-dev

02:48 brunoerg has quit [Ping timeout: 260 seconds]

02:54 brunoerg has joined #bitcoin-core-dev

02:57 jnewbery has quit [Ping timeout: 248 seconds]

02:57 face has quit [Ping timeout: 248 seconds]

02:57 shesek has quit [Ping timeout: 248 seconds]

02:58 brunoerg has quit [Ping timeout: 240 seconds]

03:00 brunoerg has joined #bitcoin-core-dev

03:01 chinggg has quit [Ping timeout: 252 seconds]

03:04 bomb-on has quit [Quit: aллилѹіа!]

03:05 brunoerg has quit [Ping timeout: 260 seconds]

03:06 brunoerg has joined #bitcoin-core-dev

03:10 brunoerg has quit [Ping timeout: 260 seconds]

03:16 brunoerg has joined #bitcoin-core-dev

03:18 shesek has joined #bitcoin-core-dev

03:21 brunoerg has quit [Ping timeout: 260 seconds]

03:22 brunoerg has joined #bitcoin-core-dev

03:23 jnewbery has joined #bitcoin-core-dev

03:24 face has joined #bitcoin-core-dev

03:27 brunoerg has quit [Ping timeout: 255 seconds]

03:33 brunoerg has joined #bitcoin-core-dev

03:38 brunoerg has quit [Ping timeout: 248 seconds]

03:44 brunoerg has joined #bitcoin-core-dev

03:49 brunoerg has quit [Ping timeout: 244 seconds]

03:50 brunoerg has joined #bitcoin-core-dev

03:55 brunoerg has quit [Ping timeout: 255 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 SpellChecker has quit [Remote host closed the connection]

04:01 brunoerg has joined #bitcoin-core-dev

04:01 cmirror has joined #bitcoin-core-dev

04:01 SpellChecker has joined #bitcoin-core-dev

04:06 brunoerg has quit [Ping timeout: 260 seconds]

04:07 brunoerg has joined #bitcoin-core-dev

04:12 brunoerg has quit [Ping timeout: 255 seconds]

04:18 brunoerg has joined #bitcoin-core-dev

04:19 test_ has quit [Read error: Connection reset by peer]

04:22 brunoerg has quit [Ping timeout: 248 seconds]

04:24 brunoerg has joined #bitcoin-core-dev

04:28 brunoerg has quit [Ping timeout: 255 seconds]

04:29 brunoerg has joined #bitcoin-core-dev

04:34 brunoerg has quit [Ping timeout: 248 seconds]

04:40 brunoerg has joined #bitcoin-core-dev

04:45 brunoerg has quit [Ping timeout: 260 seconds]

04:46 brunoerg has joined #bitcoin-core-dev

04:50 brunoerg has quit [Ping timeout: 255 seconds]

04:53 mikehu44 has joined #bitcoin-core-dev

04:56 sudoforge has quit [Ping timeout: 246 seconds]

04:57 brunoerg has joined #bitcoin-core-dev

05:01 brunoerg has quit [Ping timeout: 260 seconds]

05:08 brunoerg has joined #bitcoin-core-dev

05:12 brunoerg has quit [Ping timeout: 260 seconds]

05:13 martinus_ has quit [Remote host closed the connection]

05:14 brunoerg has joined #bitcoin-core-dev

05:17 bitdex has joined #bitcoin-core-dev

05:19 brunoerg has quit [Ping timeout: 260 seconds]

05:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a55606c3bdbf...cccbc5fe3ea5

05:23 <bitcoin-git> bitcoin/master 14093d5 Sjors Provoost: doc: add distcc to productivity notes

05:23 <bitcoin-git> bitcoin/master cccbc5f laanwj: Merge bitcoin/bitcoin#25359: doc: add distcc to productivity notes

05:23 <bitcoin-git> [bitcoin] laanwj merged pull request #25359: doc: add distcc to productivity notes (master...2022/06/distcc) https://github.com/bitcoin/bitcoin/pull/25359

05:25 brunoerg has joined #bitcoin-core-dev

05:29 brunoerg has quit [Ping timeout: 260 seconds]

05:35 brunoerg has joined #bitcoin-core-dev

05:41 brunoerg has quit [Ping timeout: 260 seconds]

05:58 brunoerg has joined #bitcoin-core-dev

06:03 brunoerg has quit [Ping timeout: 248 seconds]

06:04 SpellChecker has quit [Remote host closed the connection]

06:05 SpellChecker has joined #bitcoin-core-dev

06:17 sipsorcery has joined #bitcoin-core-dev

06:34 brunoerg has joined #bitcoin-core-dev

06:39 brunoerg has quit [Ping timeout: 258 seconds]

06:58 vasild has quit [Quit: leaving]

07:12 sipsorcery has quit [Ping timeout: 244 seconds]

07:20 sipsorcery has joined #bitcoin-core-dev

07:24 brunoerg has joined #bitcoin-core-dev

07:28 brunoerg has quit [Ping timeout: 260 seconds]

07:34 Guyver2 has joined #bitcoin-core-dev

07:47 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cccbc5fe3ea5...c5fbcf5f8d7b

07:47 <bitcoin-git> bitcoin/master 1cb42ae Oskar Mendel: util: modify Win32LockedPageAllocator to query windows for limit

07:47 <bitcoin-git> bitcoin/master c5fbcf5 laanwj: Merge bitcoin/bitcoin#25320: util: modify Win32LockedPageAllocator to quer...

07:47 <bitcoin-git> [bitcoin] laanwj merged pull request #25320: util: modify Win32LockedPageAllocator to query windows for limit. (master...win32-lockedpageallocator-limit) https://github.com/bitcoin/bitcoin/pull/25320

07:47 jonatack has quit [Ping timeout: 248 seconds]

07:52 o3 has quit [Quit: Connection closed for inactivity]

08:04 dougefish has quit [Ping timeout: 258 seconds]

08:10 evanlinjin has joined #bitcoin-core-dev

08:11 dougefish has joined #bitcoin-core-dev

08:17 brunoerg has joined #bitcoin-core-dev

08:21 brunoerg has quit [Ping timeout: 240 seconds]

08:31 <bitcoin-git> [bitcoin] fanquake closed pull request #23448: refactor, consensus: remove calls to global `Params()` in validation layer (master...remove_call_params) https://github.com/bitcoin/bitcoin/pull/23448

08:39 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5fbcf5f8d7b...1557014378cc

08:39 <bitcoin-git> bitcoin/master 491bb14 fanquake: build: test for timingsafe_bcmp

08:39 <bitcoin-git> bitcoin/master 1557014 laanwj: Merge bitcoin/bitcoin#25332: build: test for timingsafe_bcmp

08:39 <bitcoin-git> [bitcoin] laanwj merged pull request #25332: build: test for timingsafe_bcmp (master...test_for_timingsafe_bcmp) https://github.com/bitcoin/bitcoin/pull/25332

08:44 brunoerg has joined #bitcoin-core-dev

08:48 brunoerg has quit [Ping timeout: 244 seconds]

08:55 Guest76 has joined #bitcoin-core-dev

08:59 Guest76 has quit [Client Quit]

09:02 kexkey has quit [Ping timeout: 240 seconds]

09:04 kexkey has joined #bitcoin-core-dev

09:06 AaronvanW has joined #bitcoin-core-dev

09:17 evanlinjin has quit [Ping timeout: 240 seconds]

09:17 sipsorcery has quit [Ping timeout: 256 seconds]

09:19 brunoerg has joined #bitcoin-core-dev

09:23 <laanwj> "laanwj closed this as completed 28 minutes ago" wait what, where does "completed" come from, does github allow choosing a close reason now?

09:24 brunoerg has quit [Ping timeout: 260 seconds]

09:25 <laanwj> oh i see "close as completed" "close as not planned" is a dropdown now !

09:27 <laanwj> you can choose whether closed issues become grey or purple

09:29 evanlinjin has joined #bitcoin-core-dev

09:29 <laanwj> that's kind of cool, well, at least more useful than being able to display "achievements" on your github profile *sigh*

09:46 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1557014378cc...9e4fbebcc8e4

09:46 <bitcoin-git> bitcoin/master eb8aab7 Jon Atack: logging: add LogPrintfCategory to log unconditionally with category

09:46 <bitcoin-git> bitcoin/master ecff20d Jon Atack: logging: use LogPrintfCategory rather than a manual category

09:46 <bitcoin-git> bitcoin/master 9e4fbeb laanwj: Merge bitcoin/bitcoin#25306: logging: add LogPrintfCategory to log uncondi...

09:46 <bitcoin-git> [bitcoin] laanwj merged pull request #25306: logging: add LogPrintfCategory to log unconditionally with category (master...2022-06-logprintfcategory) https://github.com/bitcoin/bitcoin/pull/25306

09:53 brunoerg has joined #bitcoin-core-dev

09:57 brunoerg has quit [Ping timeout: 248 seconds]

10:04 brunoerg has joined #bitcoin-core-dev

10:09 brunoerg has quit [Ping timeout: 255 seconds]

10:10 brunoerg has joined #bitcoin-core-dev

10:14 brunoerg has quit [Ping timeout: 255 seconds]

10:26 brunoerg has joined #bitcoin-core-dev

10:31 brunoerg has quit [Ping timeout: 260 seconds]

10:37 brunoerg has joined #bitcoin-core-dev

10:38 <bitcoin-git> [bitcoin] brokenprogrammer opened pull request #25368: doc: Update importaddress mention incompatibility with descriptor wallet (master...importaddress-descriptor-wallet-documentation) https://github.com/bitcoin/bitcoin/pull/25368

10:39 kexkey has quit [Ping timeout: 260 seconds]

10:41 mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

10:42 brunoerg has quit [Ping timeout: 248 seconds]

10:46 mikehu44 has joined #bitcoin-core-dev

10:48 kexkey has joined #bitcoin-core-dev

10:48 brunoerg has joined #bitcoin-core-dev

10:53 brunoerg has quit [Ping timeout: 244 seconds]

10:53 evanlinjin has quit [Ping timeout: 240 seconds]

10:57 <bitcoin-git> [gui] hebasto opened pull request #618: refactor: Add `transactionoverviewwidget.cpp` source file (master...220614-tow) https://github.com/bitcoin-core/gui/pull/618

10:59 sipsorcery has joined #bitcoin-core-dev

10:59 brunoerg has joined #bitcoin-core-dev

11:04 brunoerg has quit [Ping timeout: 258 seconds]

11:04 mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

11:05 brunoerg has joined #bitcoin-core-dev

11:10 brunoerg has quit [Ping timeout: 260 seconds]

11:16 brunoerg has joined #bitcoin-core-dev

11:21 brunoerg has quit [Ping timeout: 255 seconds]

11:33 brunoerg has joined #bitcoin-core-dev

11:41 brunoerg has quit [Ping timeout: 260 seconds]

11:49 <bitcoin-git> [bitcoin] fanquake opened pull request #25369: Unsubtree Univalue (master...unsubtree_univalue) https://github.com/bitcoin/bitcoin/pull/25369

11:52 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

11:59 brunoerg has joined #bitcoin-core-dev

12:03 brunoerg has quit [Ping timeout: 246 seconds]

12:09 brunoerg has joined #bitcoin-core-dev

12:14 bitdex has quit [Quit: = ""]

12:15 real_or_random has quit [Quit: ZNC 1.8.2 - https://znc.in]

12:18 real_or_random has joined #bitcoin-core-dev

12:37 furszy has joined #bitcoin-core-dev

13:05 Guest16 has joined #bitcoin-core-dev

13:08 Guest16 has quit [Client Quit]

13:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e4fbebcc8e4...a05876619a33

13:17 <bitcoin-git> bitcoin/master 42bbbba Sebastian Falbesoner: message-capture-parser: fix out of bounds error for empty vectors

13:17 <bitcoin-git> bitcoin/master a058766 MacroFake: Merge bitcoin/bitcoin#25367: [contrib] message-capture-parser: fix out of ...

13:17 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25367: [contrib] message-capture-parser: fix out of bounds error for empty vectors (master...202206-contrib-fix_message_capture_out_of_bounds) https://github.com/bitcoin/bitcoin/pull/25367

13:59 furszy has quit []

14:14 mikehu44 has joined #bitcoin-core-dev

14:14 Guyver2 has joined #bitcoin-core-dev

14:43 furszy has joined #bitcoin-core-dev

14:53 mikehu44 has quit [Ping timeout: 276 seconds]

14:57 yanmaani has quit [Ping timeout: 240 seconds]

15:02 evanlinjin has joined #bitcoin-core-dev

15:02 Guest32 has joined #bitcoin-core-dev

15:04 yanmaani has joined #bitcoin-core-dev

15:05 jarthur has joined #bitcoin-core-dev

15:08 Guest32 has quit [Quit: Client closed]

15:09 furszy has quit []

15:21 <dongcarl> Hi all, I'm looking to get some review on #25215 and #25223. There's been quite some conceptual-level discussions and they are ready for code reviews. They're both pretty easy refactors to review too. Please let me know if there's anything I can do to help make review easier! Cheers! ☺️

15:21 <gribble> https://github.com/bitcoin/bitcoin/issues/25215 | [kernel 2d/n] Reduce CTxMemPool constructor call sites by dongcarl · Pull Request #25215 · bitcoin/bitcoin · GitHub

15:21 <gribble> https://github.com/bitcoin/bitcoin/issues/25223 | [kernel 2e/n] miner: Make `mempool` optional, stop constructing temporary empty mempools by dongcarl · Pull Request #25223 · bitcoin/bitcoin · GitHub

15:23 sudoforge has joined #bitcoin-core-dev

16:16 <bitcoin-git> [bitcoin] theStack opened pull request #25370: test: check for `getblocktxn` request with out-of-bounds tx index (master...202206-test-check_getblocktxn_out_of_bounds_tx_index) https://github.com/bitcoin/bitcoin/pull/25370

16:22 Guest37 has joined #bitcoin-core-dev

16:23 <laanwj> dongcarl: will have a look, thanks

16:32 Guest37 has quit [Quit: Client closed]

16:43 <dongcarl> laanwj: Thanks!

16:47 bomb-on has joined #bitcoin-core-dev

16:47 kouloumos has joined #bitcoin-core-dev

16:57 kexkey_ has joined #bitcoin-core-dev

16:57 kexkey_ has quit [Client Quit]

16:59 kexkey has quit [Ping timeout: 246 seconds]

17:03 kexkey has joined #bitcoin-core-dev

17:04 Talkless has joined #bitcoin-core-dev

17:15 larryruane has quit []

17:25 evanlinjin has quit [Ping timeout: 240 seconds]

17:33 sipsorcery has quit [Ping timeout: 240 seconds]

17:38 sipsorcery has joined #bitcoin-core-dev

17:52 flooded has joined #bitcoin-core-dev

17:53 yanmaani has quit [Remote host closed the connection]

17:54 yanmaani has joined #bitcoin-core-dev

17:55 flooded is now known as _flood

18:05 aleggg has quit []

18:06 Guyver2 has left #bitcoin-core-dev [Closing Window]

18:09 Eric3 has joined #bitcoin-core-dev

18:10 real_or_random_ has joined #bitcoin-core-dev

18:11 emcy has joined #bitcoin-core-dev

18:12 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a05876619a33...df933596e7e9

18:12 <bitcoin-git> bitcoin/master 0947726 fanquake: build: support LTO in depends

18:12 <bitcoin-git> bitcoin/master df93359 laanwj: Merge bitcoin/bitcoin#23611: build: add `LTO` option to depends

18:12 <bitcoin-git> [bitcoin] laanwj merged pull request #23611: build: add `LTO` option to depends (master...lto_in_depends) https://github.com/bitcoin/bitcoin/pull/23611

18:13 earnest has joined #bitcoin-core-dev

18:13 S3RK_ has joined #bitcoin-core-dev

18:17 meshcoll- has joined #bitcoin-core-dev

18:18 real_or_random has quit [*.net *.split]

18:18 dougefish has quit [*.net *.split]

18:18 face has quit [*.net *.split]

18:18 earnestly has quit [*.net *.split]

18:18 ron-slc has quit [*.net *.split]

18:18 calvinalvin has quit [*.net *.split]

18:18 gleb745438685 has quit [*.net *.split]

18:18 dhruv has quit [*.net *.split]

18:18 murrayn has quit [*.net *.split]

18:18 realies has quit [*.net *.split]

18:18 Bullitje has quit [*.net *.split]

18:18 emcy_ has quit [*.net *.split]

18:18 ExEric3 has quit [*.net *.split]

18:18 S3RK has quit [*.net *.split]

18:18 Victorsueca has quit [*.net *.split]

18:18 meshcollider has quit [*.net *.split]

18:18 face has joined #bitcoin-core-dev

18:21 Bullitje_enable has joined #bitcoin-core-dev

18:21 dougefish has joined #bitcoin-core-dev

18:21 ron-slc has joined #bitcoin-core-dev

18:21 calvinalvin has joined #bitcoin-core-dev

18:21 gleb745438685 has joined #bitcoin-core-dev

18:21 realies has joined #bitcoin-core-dev

18:21 dhruv has joined #bitcoin-core-dev

18:21 murrayn has joined #bitcoin-core-dev

18:22 realies has quit [Max SendQ exceeded]

18:24 realies has joined #bitcoin-core-dev

18:28 nanotube has quit [Ping timeout: 255 seconds]

18:45 sipsorcery has quit [Read error: Connection reset by peer]

18:49 sipsorcery has joined #bitcoin-core-dev

18:59 tripleslash has joined #bitcoin-core-dev

19:10 aleggg has joined #bitcoin-core-dev

19:15 greypw254600 has joined #bitcoin-core-dev

19:17 jnewbery_ has joined #bitcoin-core-dev

19:18 gribble` has joined #bitcoin-core-dev

19:18 Talkless has quit [Quit: Konversation terminated!]

19:19 _cold has joined #bitcoin-core-dev

19:20 Henry151_ has joined #bitcoin-core-dev

19:20 MacroFake_ has joined #bitcoin-core-dev

19:20 jrawsthorne_ has joined #bitcoin-core-dev

19:21 kallewoof has joined #bitcoin-core-dev

19:24 aleggg has quit [*.net *.split]

19:24 jnewbery has quit [*.net *.split]

19:24 cold has quit [*.net *.split]

19:24 kalle has quit [*.net *.split]

19:24 MacroFake has quit [*.net *.split]

19:24 greypw25460 has quit [*.net *.split]

19:24 da2ce7_ has quit [*.net *.split]

19:24 jrawsthorne has quit [*.net *.split]

19:24 gribble has quit [*.net *.split]

19:24 Henry151 has quit [*.net *.split]

19:24 aleggg has joined #bitcoin-core-dev

19:28 da2ce7 has joined #bitcoin-core-dev

19:37 Victorsueca has joined #bitcoin-core-dev

19:44 TheRec has quit [Ping timeout: 240 seconds]

19:52 <bitcoin-git> [bitcoin] luke-jr opened pull request #25373: Support ignoring "opt-in" flag for RBF (aka full RBF) (master...fullrbf) https://github.com/bitcoin/bitcoin/pull/25373

19:57 jamesob has quit [Quit: The Lounge - https://thelounge.chat]

20:05 _flood has quit [Remote host closed the connection]

20:06 _flood has joined #bitcoin-core-dev

20:10 jamesob has joined #bitcoin-core-dev

20:18 szkl has quit [Quit: Connection closed for inactivity]

20:28 furszy has joined #bitcoin-core-dev

21:10 furszy has quit [Remote host closed the connection]

21:16 yanmaani has quit [Ping timeout: 240 seconds]

21:30 yanmaani has joined #bitcoin-core-dev

21:39 kexkey has quit [Quit: kexkey]

21:44 kexkey has joined #bitcoin-core-dev

21:47 TheRec has joined #bitcoin-core-dev

21:47 TheRec has quit [Changing host]

21:47 TheRec has joined #bitcoin-core-dev

21:48 kouloumos has quit [Quit: Connection closed for inactivity]

21:51 cryptapus has quit [Quit: Konversation terminated!]

22:12 cryptapus has joined #bitcoin-core-dev

22:40 sipsorcery has quit [Ping timeout: 260 seconds]

22:48 brunoerg has quit [Remote host closed the connection]

22:48 brunoerg has joined #bitcoin-core-dev

22:50 AaronvanW has quit [Quit: Leaving...]

22:53 brunoerg has quit [Ping timeout: 258 seconds]

22:55 sipsorcery has joined #bitcoin-core-dev

22:59 brunoerg has joined #bitcoin-core-dev

23:03 brunoerg has quit [Ping timeout: 250 seconds]

23:05 brunoerg has joined #bitcoin-core-dev

23:09 brunoerg has quit [Ping timeout: 248 seconds]

23:16 <bitcoin-git> [bitcoin] theStack opened pull request #25374: test: remove unused `create_confirmed_utxos` helper (master...202206-test-remove_unused_create_confirmed_utxos_helper) https://github.com/bitcoin/bitcoin/pull/25374

23:16 brunoerg has joined #bitcoin-core-dev

23:20 brunoerg has quit [Ping timeout: 255 seconds]

23:32 sipsorcery has quit [Ping timeout: 250 seconds]

23:54 brunoerg has joined #bitcoin-core-dev

23:59 brunoerg has quit [Ping timeout: 256 seconds]