#bitcoin-core-dev on 2022-06-06 — searchable irc log

00:11 z9z0b3t1_ has joined #bitcoin-core-dev

00:14 z9z0b3t1c has quit [Ping timeout: 256 seconds]

00:21 brunoerg has joined #bitcoin-core-dev

00:26 brunoerg has quit [Ping timeout: 250 seconds]

00:37 SpellChecker has quit [Remote host closed the connection]

00:38 SpellChecker has joined #bitcoin-core-dev

00:55 brunoerg has joined #bitcoin-core-dev

01:00 brunoerg has quit [Ping timeout: 258 seconds]

01:48 brunoerg has joined #bitcoin-core-dev

01:53 brunoerg has quit [Ping timeout: 260 seconds]

01:57 lightningbot has quit [Remote host closed the connection]

01:57 lightningbot has joined #bitcoin-core-dev

02:41 brunoerg has joined #bitcoin-core-dev

02:45 brunoerg has quit [Ping timeout: 255 seconds]

03:09 ronoaldo has quit [Quit: Konversation terminated!]

03:27 z9z0b3t1_ has quit [Remote host closed the connection]

03:32 brunoerg has joined #bitcoin-core-dev

03:36 brunoerg has quit [Ping timeout: 244 seconds]

03:39 bitdex has joined #bitcoin-core-dev

03:51 Guest53 has joined #bitcoin-core-dev

03:59 evanlinjin has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:06 mikehu44 has joined #bitcoin-core-dev

04:07 Guest53 has quit [Ping timeout: 252 seconds]

04:15 sudoforge has quit [Ping timeout: 240 seconds]

04:17 sudoforge has joined #bitcoin-core-dev

04:23 <DavidBakin> Sometimes DrahtBot itself gives you a nice message in your PR titled "Conflicts" with a list of PRs that you should consider in relationship to your new PR. And sometimes you just get a message from Github that "DrahtBot mentioned this pull request" that points you to another PR and there's nothing there except that DrahtBot mentioned your PR over there. What's the difference?

04:23 brunoerg has joined #bitcoin-core-dev

04:27 sudoforge has quit [Ping timeout: 246 seconds]

04:28 brunoerg has quit [Ping timeout: 260 seconds]

04:39 <DavidBakin> oh wait - it looks like DrahtBot only puts the "conflict" message in your PR once then edits it to keep it up-to-date. I didn't realize that because when it edits it its place in the comment timeline doesn't change.

04:40 mikehu44_ has joined #bitcoin-core-dev

04:43 mikehu44 has quit [Ping timeout: 246 seconds]

05:07 brunoerg has joined #bitcoin-core-dev

05:08 evanlinjin has quit [Ping timeout: 240 seconds]

05:11 mikehu44_ has quit [Ping timeout: 246 seconds]

05:12 brunoerg has quit [Ping timeout: 250 seconds]

05:29 donor_ has joined #bitcoin-core-dev

05:36 donor_ has quit [Ping timeout: 258 seconds]

05:42 Guest81 has joined #bitcoin-core-dev

05:44 brunoerg has joined #bitcoin-core-dev

05:46 ExEric3 has quit [Remote host closed the connection]

05:46 Guest81 has quit [Client Quit]

05:46 donor_ has joined #bitcoin-core-dev

05:48 brunoerg has quit [Ping timeout: 244 seconds]

06:17 evanlinjin has joined #bitcoin-core-dev

06:19 brunoerg has joined #bitcoin-core-dev

06:23 brunoerg has quit [Ping timeout: 258 seconds]

06:31 donor_ has quit [Ping timeout: 240 seconds]

06:49 jonatack has quit [Ping timeout: 255 seconds]

06:51 brunoerg has joined #bitcoin-core-dev

06:56 brunoerg has quit [Ping timeout: 246 seconds]

06:56 sipsorcery has joined #bitcoin-core-dev

07:09 donor_ has joined #bitcoin-core-dev

07:15 Guest45 has joined #bitcoin-core-dev

07:15 Guest45 has quit [Client Quit]

07:28 brunoerg has joined #bitcoin-core-dev

07:29 jtraub91 has quit [Quit: WeeChat 3.2]

07:32 brunoerg has quit [Ping timeout: 255 seconds]

07:35 donor_ has quit [Ping timeout: 276 seconds]

07:53 Guyver2 has joined #bitcoin-core-dev

08:00 mikehu44 has joined #bitcoin-core-dev

08:02 jonatack has joined #bitcoin-core-dev

08:05 brunoerg has joined #bitcoin-core-dev

08:09 brunoerg has quit [Ping timeout: 258 seconds]

08:12 Guyver2_ has joined #bitcoin-core-dev

08:13 mikehu44 has quit [Ping timeout: 256 seconds]

08:13 mikehu44 has joined #bitcoin-core-dev

08:14 Guyver2 has quit [Ping timeout: 246 seconds]

08:19 mikehu44 has quit [Ping timeout: 246 seconds]

08:21 mikehu44 has joined #bitcoin-core-dev

08:37 sipsorcery has quit [Ping timeout: 260 seconds]

08:40 brunoerg has joined #bitcoin-core-dev

08:45 brunoerg has quit [Ping timeout: 260 seconds]

08:47 sipsorcery has joined #bitcoin-core-dev

09:00 cameron[m] has quit [Quit: You have been kicked for being idle]

09:04 kexkey has quit [Ping timeout: 246 seconds]

09:05 kexkey has joined #bitcoin-core-dev

09:20 AaronvanW has joined #bitcoin-core-dev

09:24 mikehu44_ has joined #bitcoin-core-dev

09:25 evanlinjin has quit [Ping timeout: 240 seconds]

09:27 mikehu44 has quit [Ping timeout: 256 seconds]

09:34 evanlinjin has joined #bitcoin-core-dev

09:34 brunoerg has joined #bitcoin-core-dev

09:38 brunoerg has quit [Ping timeout: 255 seconds]

09:39 evanlinjin has quit [Remote host closed the connection]

09:40 evanlinjin has joined #bitcoin-core-dev

09:42 ___nick___ has joined #bitcoin-core-dev

09:49 sipsorcery has quit [Remote host closed the connection]

09:49 sipsorcery has joined #bitcoin-core-dev

10:07 brunoerg has joined #bitcoin-core-dev

10:11 brunoerg has quit [Ping timeout: 244 seconds]

10:19 donor_ has joined #bitcoin-core-dev

10:36 szkl has joined #bitcoin-core-dev

10:39 brunoerg has joined #bitcoin-core-dev

10:44 brunoerg has quit [Ping timeout: 260 seconds]

10:44 emzy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]

10:46 emzy has joined #bitcoin-core-dev

10:58 evanlinjin has quit [Ping timeout: 240 seconds]

11:13 mikehu44_ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

11:19 bomb-on has joined #bitcoin-core-dev

11:31 bitdex has quit [Ping timeout: 240 seconds]

11:47 brunoerg has joined #bitcoin-core-dev

11:52 brunoerg has quit [Ping timeout: 240 seconds]

12:04 evanlinjin has joined #bitcoin-core-dev

12:12 donor_ has quit [Remote host closed the connection]

12:23 brunoerg has joined #bitcoin-core-dev

12:28 brunoerg has quit [Ping timeout: 260 seconds]

12:32 furszy has joined #bitcoin-core-dev

12:41 brunoerg has joined #bitcoin-core-dev

12:46 szkl has quit [Quit: Connection closed for inactivity]

13:04 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25284: [WIP] consensus: Remove dependency on net (BIP 155 / ADDRV2_FORMAT) (master...2206-split-consensus-net-😻) https://github.com/bitcoin/bitcoin/pull/25284

13:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b2e1d179c5b...fcde5d130029

13:17 <bitcoin-git> bitcoin/master 8790da3 Hennadii Stepanov: ci: Drop unneeded packages in "ARM64 Android APK" task

13:17 <bitcoin-git> bitcoin/master ca0c3e5 Hennadii Stepanov: ci, android: Update Command-line Tools from 2.1 up to 7.0

13:17 <bitcoin-git> bitcoin/master 7739438 Hennadii Stepanov: ci, android: Update NDK up to r23c

13:18 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25255: ci: Improve "ARM64 Android APK" task (master...220531-android) https://github.com/bitcoin/bitcoin/pull/25255

13:41 AaronvanW has quit [Quit: Leaving...]

13:48 <jamesob> If anyone has any suggestions for additional task bounties (along the lines of existing ones here: https://nydig.com/bounties) please let me know - we're looking to add more.

13:55 sudoforge has joined #bitcoin-core-dev

13:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcde5d130029...e82d8069bcd0

13:58 <bitcoin-git> bitcoin/master 210cd59 Kolby Moroz Liebl: doc: Fix typo in importdescriptors

13:58 <bitcoin-git> bitcoin/master e82d806 MacroFake: Merge bitcoin/bitcoin#25276: doc: Fix typo in importdescriptors

13:58 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25276: doc: Fix typo in importdescriptors (master...patch-13) https://github.com/bitcoin/bitcoin/pull/25276

14:03 furszy has quit [Remote host closed the connection]

14:11 <michaelfolkson> Whenever I squash commits I use "fixup" rather than "squash". I generally always want to discard the commit's log message

14:12 <michaelfolkson> Would changing the contributing guidance on squashing commits to use "fixup" rather than "squash" be an idea? Happy to open a PR if so

14:12 furszy has joined #bitcoin-core-dev

14:12 <michaelfolkson> https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

14:13 <sipa> The only difference is that with squash you get prompted to combine the messages, while with fixup it's just discarded without question. Unless we want to go into the distinction between the two (which seems too detailed for the writeup there IMO), I'd say squash is the safer option to recommend.

14:14 <michaelfolkson> Ok thanks

14:24 ronoaldo has joined #bitcoin-core-dev

14:29 <laanwj> imo the less lossy option is preferable you can always delete something in the editor, having to re-add it is more frustrating

14:47 Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]

14:50 SpellChecker has quit [Remote host closed the connection]

14:51 SpellChecker has joined #bitcoin-core-dev

14:53 evanlinjin has quit [Ping timeout: 240 seconds]

15:01 furszy has quit []

15:08 AaronvanW has joined #bitcoin-core-dev

15:13 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e82d8069bcd0...06ea2783a2c1

15:13 <bitcoin-git> bitcoin/master eaf6f63 brunoerg: rpc: fix inappropriate warning for address type p2sh-segwit in createmulti...

15:13 <bitcoin-git> bitcoin/master 3a9b9bb brunoerg: test: ensure createmultisig and addmultisigaddress are not returning any w...

15:13 <bitcoin-git> bitcoin/master 06ea278 laanwj: Merge bitcoin/bitcoin#25220: rpc: fix incorrect warning for address type p...

15:14 <bitcoin-git> [bitcoin] laanwj merged pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220

15:25 common has joined #bitcoin-core-dev

15:34 <hebasto> CMake migration updated -- https://gist.github.com/hebasto/aac97d2f6b18c4ec2ad951baeb1ac00c; more structured and with `libbitcoinkernel` now :) Feedback is welcome!

15:41 Talkless has joined #bitcoin-core-dev

15:43 furszy has joined #bitcoin-core-dev

15:50 SpellChecker_ has joined #bitcoin-core-dev

15:50 SpellChecker has quit [Ping timeout: 240 seconds]

16:00 provoostenator has quit [Quit: You have been kicked for being idle]

16:01 cmirror has quit [Ping timeout: 276 seconds]

16:05 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25285: Add AutoFile without ser-type and ser-version and use it where possible (master...2206-autofile-🌟) https://github.com/bitcoin/bitcoin/pull/25285

16:09 sipsorcery has quit [Ping timeout: 272 seconds]

16:19 sipsorcery has joined #bitcoin-core-dev

16:35 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

16:37 ___nick___ has joined #bitcoin-core-dev

16:40 ___nick___ has quit [Client Quit]

16:41 ___nick___ has joined #bitcoin-core-dev

16:46 z9z0b3t1c has joined #bitcoin-core-dev

16:47 <bitcoin-git> [bitcoin] klementtan closed pull request #23395: util: Add -shutdownnotify option (master...shutdown-notify) https://github.com/bitcoin/bitcoin/pull/23395

16:48 <bitcoin-git> [bitcoin] jonatack opened pull request #25286: scripted-diff: remove duplicate categories from LogPrint output (master...remove-duplicate-categories-from-LogPrint-output) https://github.com/bitcoin/bitcoin/pull/25286

16:59 furszy has quit [Remote host closed the connection]

17:01 <bitcoin-git> [bitcoin] klementtan opened pull request #25287: logging: threshold log level (master...threshold_log_level) https://github.com/bitcoin/bitcoin/pull/25287

17:01 <laanwj> hebasto: just tested it and could succesfully build bitcoind and bitcoin-cli (very basic test on Linux)

17:01 <bitcoin-git> [bitcoin] klementtan reopened pull request #23395: util: Add -shutdownnotify option (master...shutdown-notify) https://github.com/bitcoin/bitcoin/pull/23395

17:01 <laanwj> but it's great

17:01 <hebasto> laanwj: thank you!

17:18 <bitcoin-git> [bitcoin] martinus opened pull request #25288: test: Reliably don't start itself in lint-all.py runs all tests twice (master...2022-06-fix-lint-all-starting-itself) https://github.com/bitcoin/bitcoin/pull/25288

17:24 z9z0b3t1_ has joined #bitcoin-core-dev

17:26 <laanwj> hebasto: on freebsd i get the error "make[3]: illegal argument to -j -- must be positive integer!", does it maybe call hardcoded into "make" instead of what is used for the outer built ("gmake" in this case)?

17:27 jm has joined #bitcoin-core-dev

17:27 z9z0b3t1c has quit [Ping timeout: 244 seconds]

17:34 <laanwj> i also get an error about not being able to find a boost header at make time

17:35 sipsorcery has quit [Ping timeout: 248 seconds]

17:39 ExEric3 has joined #bitcoin-core-dev

17:46 sipsorcery has joined #bitcoin-core-dev

17:50 ExEric3 has quit [Remote host closed the connection]

17:56 ExEric3 has joined #bitcoin-core-dev

17:57 Aaronvan_ has joined #bitcoin-core-dev

18:00 AaronvanW has quit [Ping timeout: 244 seconds]

18:33 argmin has joined #bitcoin-core-dev

18:36 jm has quit [Ping timeout: 255 seconds]

18:43 argmin has quit [Quit: argmin]

18:44 <hebasto> laanwj: ^^ is this due `$(nproc)` which is not available on freebsd?

18:56 yanmaani has quit [Ping timeout: 240 seconds]

18:56 yanmaani has joined #bitcoin-core-dev

19:10 sipsorcery has quit [Read error: Connection reset by peer]

19:13 sipsorcery has joined #bitcoin-core-dev

19:15 Talkless has quit [Quit: Konversation terminated!]

19:37 tripleslash has quit [Ping timeout: 246 seconds]

19:40 z9z0b3t1c has joined #bitcoin-core-dev

19:42 tripleslash has joined #bitcoin-core-dev

19:44 z9z0b3t1_ has quit [Ping timeout: 255 seconds]

20:04 ___nick___ has quit [Ping timeout: 260 seconds]

20:04 yanmaani has quit [Remote host closed the connection]

20:08 yanmaani has joined #bitcoin-core-dev

20:15 tripleslash has quit [Ping timeout: 255 seconds]

20:38 tripleslash has joined #bitcoin-core-dev

21:36 jarthur has joined #bitcoin-core-dev

21:44 Mousticke has joined #bitcoin-core-dev

21:52 Mousticke has quit [Quit: Client closed]

21:55 sipsorcery has quit [Ping timeout: 255 seconds]

21:56 Aaronvan_ has quit [Quit: Leaving...]

22:27 <stick> yeah, that's it, no nproc on bsd

22:35 Guest79 has joined #bitcoin-core-dev

22:41 Guest47 has joined #bitcoin-core-dev

22:42 Guest47 has quit [Client Quit]

22:42 Guest47 has joined #bitcoin-core-dev

22:43 Guest47 has quit [Client Quit]

22:52 Guest79 has quit [Quit: Client closed]

23:05 jarthur has quit [Quit: jarthur]

23:28 brunoerg has quit [Remote host closed the connection]

23:46 brunoerg has joined #bitcoin-core-dev

23:50 brunoerg has quit [Ping timeout: 240 seconds]