< cfields>
jonasschnelli: fyi, #8085 allows for pausing/stopping the network in a way that should point out any possible side-effects
< jonasschnelli>
cfields: Nice. Thanks for the info. The concern (IIRC) with my previous pause/stop PR was that it should still allow broadcasting transaction during this mode.
< cfields>
jonasschnelli: i see. i suppose it'd be possible to create a state for that within CConnman.
< jtimon>
why "-par" Set the number of script verification threads (%u to %d, 0 = auto, <0 = leave that many cores free ? sounds like a terrible name
< MarcoFalke>
luke-jr: (Re my comment on the pull)
< MarcoFalke>
We don't run on native OSX, so we don't have IP's, I guess
< MarcoFalke>
Also sudo is required in .travis.yml
< MarcoFalke>
jtimon, When I hear '-par' I always think of parity checks
< luke-jr>
MarcoFalke: I think it's jsut the "Container-based (travis-ci.org)" that we need to cover
< bsm1175321>
Does there exist any UTXO set commitment implementation as a patch/PR to bitcoin? I'm interested in running some benchmarks and comparisons of ways we might do it.
< luke-jr>
I wonder if we can just use a password instead of IP whitelisting; or maybe port knocking or similar
< phantomcircuit>
I prefer that tests be separate commits in the same PR
< phantomcircuit>
is this just me?
< sipa>
phantomcircuit: seems reasonable to me
< bsm117532>
It seems that the rawtransaction* calls are not yet instrumented for segwit, no? I'm trying to create a transaction that *spends* a segwit output, and having trouble shoving it into bitcoind. I suppose sipa has some tools for manipulating segwit transactions somewhere?
< sipa>
rawtransaction should just work
< sipa>
there are even rpc tests using it
< sipa>
but likely not all calls have been tested
< sipa>
so feel free to report bugs
< bsm117532>
Oh ok I'll look at the tests. I'm unsure how to serialize the witness data. I mistakenly put it in the scriptSig thinking bitcoind would remove it...
< sipa>
no you need to put it in the witnesz
< sipa>
not the scriptsig :)
< sipa>
how to serialize the witness data, read bip144
< bsm117532>
Obviously. ;-)
< bsm117532>
Yeah petertodd's python-bitcoinlib doesn't know about witness data or how to serialize it. Looks like I'm going to be adding it. :-)
< sipa>
Good.
< sipa>
also, bitcoin core's qa/rpc/test_framework already supports it