< gmaxwell> It's mildly confusing that getmempoolentry returns the transaction itself as part of the descendantcount/descendantsize
< luke-jr> why was https://github.com/bitcoin/bitcoin/pull/7774 merged? :/
< phantomcircuit> wumpus, agree that looks like a mistake
< phantomcircuit> version was previously a number and now it's hexencoded?
< phantomcircuit> that's gonna break lots of stuff in weird ways
< gmaxwell> phantomcircuit: it's an extra field.
< gmaxwell> luke-jr: having only the integer field is a huge pain for debugging... I've been pretty happy that was there.
< phantomcircuit> gmaxwell, oh
< phantomcircuit> carry on then
< luke-jr> sigh.
< GitHub167> [bitcoin] NicolasDorier opened pull request #8344: Consensus: Use pindex for ISM check (master...not-using-block) https://github.com/bitcoin/bitcoin/pull/8344
< GitHub120> [bitcoin] jtimon opened pull request #8345: Introduce Consensus::GetFlags() and hide IsSuperMajority() (master...0.12.99-consensus-flags) https://github.com/bitcoin/bitcoin/pull/8345
< jtimon> NicolasDorier: created #8345 commented on #8344
< jtimon> #8345 only has one moveonly commit for IsSuperMajority() (at the cost of introducing a temporal circular dependency), please review
< NicolasDorier> I like some commit and not others. I'd like that we manage to merge what will be common to both of us, and then make the more controversial PR so other can compare easily our approaches
< jtimon> btcdrak: where would you prefer to put getflags ?
< jtimon> because you accept ISM needs to move out of main in the first place, right?
< GitHub25> [bitcoin] jtimon opened pull request #8346: Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs (master...0.12.99-consensus-mempool-checks) https://github.com/bitcoin/bitcoin/pull/8346
< GitHub197> [bitcoin] jtimon opened pull request #8347: Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock (master...0.12.99-consensus-const-lost) https://github.com/bitcoin/bitcoin/pull/8347