< phantomcircuit> there's no actual bug but it's kind of annoying
< phantomcircuit> there's a warding about nLowestTimestamp in importmulti
< phantomcircuit> potentially being used uninitalized
< sipa> phantomcircuit: yeah, we should fix that
< jtimon> I have understood and like some of the commits in the middle, just not enough to give an utACK in any of the PRs (note ven the merged ones yet)
< phantomcircuit> im kind of confused
< phantomcircuit> sipa: in 8831 you can see i moved IsKeyType
< phantomcircuit> but im getting wallet/walletdb.h:45: multiple definition of `IsKeyType(std::string)'
< phantomcircuit> it's protected by #ifndef BITCOIN_WALLET_WALLETDB_H
< phantomcircuit> so it shouldn't be doing that
< phantomcircuit> moving the definition to walletdb.cpp fixes this
< phantomcircuit> but i cant see why
< phantomcircuit> sipa: nvm i see where i went wrong
< phantomcircuit> derp
< bitcoin-git> [bitcoin] dcousens opened pull request #9100: tx_valid: re-order inputs to how they are encoded (master...testorder) https://github.com/bitcoin/bitcoin/pull/9100
< phantomcircuit> uh
< phantomcircuit> CWalletDB::Recover has a dummyWallet which only prints a line in debug.log if LoadKeyValue fails to parse the key/value pair
< phantomcircuit> this either should fail the recovery or just be removed
< bitcoin-git> [bitcoin] pstratem opened pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (master...2016-11-07-cwalletdb-recover) https://github.com/bitcoin/bitcoin/pull/9101
< bitcoin-git> [bitcoin] instagibbs opened pull request #9102: Really don't validate genesis block (master...dontvalidategenesis) https://github.com/bitcoin/bitcoin/pull/9102
< bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f554e03ebe5...dc6b9406bdfa
< bitcoin-git> bitcoin/master c93beac Suhas Daftuar: [qa] Test that invalid compactblocks don't result in ban
< bitcoin-git> bitcoin/master 88c3549 Suhas Daftuar: Fix compact block handling to not ban if block is invalid
< bitcoin-git> bitcoin/master d4833ff Suhas Daftuar: Bump the protocol version to distinguish new banning behavior....
< bitcoin-git> [bitcoin] sipa closed pull request #9026: Fix handling of invalid compact blocks (master...fix-invalidcb-handling) https://github.com/bitcoin/bitcoin/pull/9026
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc6b9406bdfa...b8f43e33316c
< bitcoin-git> bitcoin/master fa8278e MarcoFalke: test: Fix test_random includes
< bitcoin-git> bitcoin/master b8f43e3 Jonas Schnelli: Merge #9095: test: Fix test_random includes...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9095: test: Fix test_random includes (master...Mf1611-testRand) https://github.com/bitcoin/bitcoin/pull/9095
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b8f43e33316c...f53023dbb860
< bitcoin-git> bitcoin/master bd0de13 UdjinM6: Fix exit codes:...
< bitcoin-git> bitcoin/master 4441018 UdjinM6: Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
< bitcoin-git> bitcoin/master f53023d Wladimir J. van der Laan: Merge #9067: Fix exit codes...
< bitcoin-git> [bitcoin] laanwj closed pull request #9067: Fix exit codes (master...fixExitCodesBitcoin) https://github.com/bitcoin/bitcoin/pull/9067
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f53023dbb860...71ab476b0482
< bitcoin-git> bitcoin/master fae19aa MarcoFalke: [qa] test_framework: Exit when tmpdir exists
< bitcoin-git> bitcoin/master fab0f07 MarcoFalke: [qa] rpc-tests: Apply random offset to portseed...
< bitcoin-git> bitcoin/master 71ab476 Wladimir J. van der Laan: Merge #9098: [qa] Handle zombies and cluttered tmpdirs...
< bitcoin-git> [bitcoin] laanwj closed pull request #9098: [qa] Handle zombies and cluttered tmpdirs (master...Mf1611-qaZombies) https://github.com/bitcoin/bitcoin/pull/9098
<@wumpus> now the tests can even jump over zombies in graveyards \o/
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71ab476b0482...4e5782438c3d
< bitcoin-git> bitcoin/master 77cbbd9 R E Broadley: Make warning message about wallet balance possibly...
< bitcoin-git> bitcoin/master 4e57824 Wladimir J. van der Laan: Merge #9088: Reduce ambiguity of warning message...
< bitcoin-git> [bitcoin] laanwj closed pull request #9088: Reduce ambiguity of warning message (master...LessAmbiguousWalletWarning) https://github.com/bitcoin/bitcoin/pull/9088
< MarcoFalke> Heh, I hope it is a good thing because whenever there is a zombie there is a prob of about 0.0016 that you will step on them :P
< MarcoFalke> Previously the prob was 1, so at least you knew there is a zombie
<@wumpus> well the best way of deailng with zombies would be to no create them in the first place, make sure the test framework cleans up the dead properly
<@wumpus> this is not always possible, of course
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e5782438c3d...924de0bd75a7
< bitcoin-git> bitcoin/master 1adf82a Jorge Timón: RPC: Give more details when "generate" fails
< bitcoin-git> bitcoin/master 924de0b MarcoFalke: Merge #9087: RPC: why not give more details when "generate" fails?...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9087: RPC: why not give more details when "generate" fails? (master...0.13-errors-rpc-mining) https://github.com/bitcoin/bitcoin/pull/9087
< gmaxwell> sipa: so perhaps the mempool saving functionality should be saving the mempoolminfee... as it goes to zero after a restart.
< sipa> gmaxwell: good point
< sipa> file an issue
< gmaxwell> sipa: #9103
< gribble> https://github.com/bitcoin/bitcoin/issues/9103 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< morcos> sipa: i also thought mempool saving was going to be optional?
< morcos> on a separately question, is it fine to leave a bunch of BOOST_TEST_MESSAGE(..) in unit_tests or will they slow them down...
< morcos> coins_tests are so complicated, might be useful to not have to readd all this debugging information next time they are changed
< BlueMatt> jtimon: cool, thanks
< jtimon> wumpus: instagibbs I added the reindex rpc tests to #8994, to test #9102 (well, and #8994 in general), if you think of other rpc tests that would be interesting to duplicate for this or default values for the custom chain (ie maybe consensus.BIP34Height = 0 or whatever ) please let me know
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9102 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
< jtimon> strangely enough locally walletbackup is failing, but only when I run all of them, not when I run it individually, there must be something I haven't cleanup up properly because travis seems to be happy
< sdaftuar> jtimon: if you're seeing failures related to block sync failure in sync_blocks(), there's a good chance that
< sdaftuar> is related to #9058
< gribble> https://github.com/bitcoin/bitcoin/issues/9058 | Fixes for p2p-compactblocks.py test timeouts on travis (#8842) by ryanofsky · Pull Request #9058 · bitcoin/bitcoin · GitHub
< jtimon> I'm not really sure what's happening, it's not a very clear error and the fact that walletbackup passes individually makes it more weird, but I will take a look, thanks
< bitcoin-git> [bitcoin] morcos opened pull request #9107: Safer modify new coins (master...saferModifyNewCoins) https://github.com/bitcoin/bitcoin/pull/9107
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9108: WIP: Use importmulti timestamp when importing watch only keys (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108
< gmaxwell> morcos: it's optional, you can totally kill -9 the process instead of calling stop. :P
< gmaxwell> (I suppose it would be reasonable to add an option to let people disable it, though I don't know why anyone would set it, except perhaps saving 150 mb of disk space.
< sipa> morcos: i'm not opposed to making it optional, i just didn't think it was a requirement for the first PR
< sipa> gmaxwell: i assume you're joking, but there are downsides to killing that may be worse, like not storing the latest blocks' effect to disk
< cfields> sdaftuar: regarding #9026, did you consider adding fMayBanPeerIfInvalid to CState rather than passing it around? I realize it's merged, just curious after starting to review 9075
< gribble> https://github.com/bitcoin/bitcoin/issues/9026 | Fix handling of invalid compact blocks by sdaftuar · Pull Request #9026 · bitcoin/bitcoin · GitHub
< sipa> cfields: i dislike turning CValidationState into an input parameter as well
< cfields> sipa: fair enough, I suppose that would be the only input. I was thinking there were already some there.
< gmaxwell> sipa: well we should fix those downsides if they're actually a concern. :) losing a few blocks of verification should be a non-issue.
< phantomcircuit> gmaxwell: i think it can be more than a few
< sipa> gmaxwell: not needing a shutdown procedure is a nice design principle, but i don't think we're there
< gmaxwell> seems pretty fine to me.