05:08 < jl2012> i need to do some debug. How could I make it to print all p2p messages to the log?

05:09 < achow101> jl2012: -debug=net

05:09 < jl2012> thanks!

05:18 < jl2012> achow101: what if I also want to see the full messages, such as the block data being sent?

05:19 < achow101> I don't think there is an option to log all of that. you can wireshark it though

06:56 < shangzhou> 2:34 PM <wumpus> shangzhou: it has no (ut)ACKs at all,certainly still needs review

06:58 < shangzhou> wumpus: #9037 just a reminder :)

06:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub

06:59 < wumpus> shangzhou: it still has no ACKs, so is by no means ready for merging, no need to remind me of it

06:59 < wumpus> (well it has kazcw's but it was there last time IIRC)

07:00 < wumpus> would be great if people reviewed it ofc

07:00 < shangzhou> Ok thanks

07:01 < wumpus> but I'm perfectly able to revisit pull requests that still haven't moved forward, while I tend to miss the ones which everybody (TM) acked and should be merged, that's why I asked people

07:50 < BlueMatt> wumpus: re: #9229 yes, but the fix should be fixing the autotools detection of inet_pton, not continuing to work around it?

07:50 < gribble> https://github.com/bitcoin/bitcoin/issues/9229 | Remove calls to getaddrinfo_a by TheBlueMatt · Pull Request #9229 · bitcoin/bitcoin · GitHub

07:50 < BlueMatt> (or are you suggesting just remove that codeblock?0

08:04 < BlueMatt> (though its also weird we have so many ifdef branches there....)

08:18 < jonasschnelli> BlueMatt: Haven't really looked at this, but AFAIK libevent provides portable wrappers for some of those functions..

08:18 < BlueMatt> jonasschnelli: yes, eventually we should switch everything to libevent...for now, lets just fix the segfault in a backport-able way :p

08:19 < jonasschnelli> Yes. Makes sense.

08:29 < bitcoin-git> [bitcoin] fsb4000 opened pull request #9233: Fix some typos (master...master) https://github.com/bitcoin/bitcoin/pull/9233

09:01 < wumpus> the getaddrinfo_a issue is curious, I have a nagging feeling we're just using it wrong, it's hard to believe a standard library function to be so trivially broken. Then again, in that case it makes sense to replace its usage too.

09:45 < wumpus> BlueMatt: I'm not suggesting any specific fix, just trying to figure out what is going wrong in the first place

09:45 < wumpus> BlueMatt: using inet_pton on systems that actually have it is great, I don't know why it falsely detects its presence on windows

09:47 < wumpus> only on windows *64 bit* at that

09:58 < fanquake> wumpus looks like pretty much all the code in 9229 was introduced in #4421

09:58 < gribble> https://github.com/bitcoin/bitcoin/issues/4421 | Use async name resolving to improve net thread responsiveness by 4tar · Pull Request #4421 · bitcoin/bitcoin · GitHub

10:01 < wumpus> fanquake: indeed, good find

10:10 < fanquake> wumpus re 'none required', see https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Libraries.html

10:10 < fanquake> "The result of this test is cached in the ac_cv_search_function variable as ‘none required’ if function is already available"

11:36 < jl2012> where is the code for sending block to another node through p2p network?

13:45 < jonasschnelli> jl2012: have a look at ProcessGetData in main.cpp

13:45 < jonasschnelli> There is a if (inv.type == MSG_BLOCK)

15:09 < timothy> may I ask an "ethic" question?

16:17 < bitcoin-git> [bitcoin] laanwj opened pull request #9234: torcontrol: Explicitly request RSA1024 private key (master...2016_11_torcontrol_key_ttpe) https://github.com/bitcoin/bitcoin/pull/9234