< bitcoin-git>
bitcoin/master dd5b011 John Newbery: [Trivial] add comment about setting peer as HB peer....
< bitcoin-git>
bitcoin/master 729de15 Wladimir J. van der Laan: Merge #9604: [Trivial] add comment about setting peer as HB peer....
< bitcoin-git>
[bitcoin] laanwj closed pull request #9604: [Trivial] add comment about setting peer as HB peer. (master...HBpeercomment) https://github.com/bitcoin/bitcoin/pull/9604
< bitcoin-git>
[bitcoin] jnewbery opened pull request #9706: Remove unicode characters from RPC user and password in QA tests (master...rpctestuser) https://github.com/bitcoin/bitcoin/pull/9706
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #9708: Clean Up all known races/platform-specific UB (master...2017-02-fix-copystats-races) https://github.com/bitcoin/bitcoin/pull/9708
< bitcoin-git>
[bitcoin] jnewbery closed pull request #9706: Remove unicode characters from RPC user and password in QA tests (master...rpctestuser) https://github.com/bitcoin/bitcoin/pull/9706
< bitcoin-git>
[bitcoin] jnewbery opened pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (master...gettxoutproofhelp) https://github.com/bitcoin/bitcoin/pull/9711
< Chris_Stewart_5>
Do we limit the amount of sigops that can be in a tx *besides* the limitations of 201 script ops and 80000 sigop cost?
< Chris_Stewart_5>
sigop cost for a block*
< bitcoin-git>
[bitcoin] laanwj opened pull request #9712: bench: Fix initialization order in registration (master...2017_02_fiasco) https://github.com/bitcoin/bitcoin/pull/9712
< bitcoin-git>
[bitcoin] jnewbery opened pull request #9713: Fix error causes and messages in rpc/net.cpp (master...fixsetbanerrormessages) https://github.com/bitcoin/bitcoin/pull/9713
< BlueMatt>
sipa: whats the point of invlockorders in sync.cpp? it looks entirely untested/unused-aside-from-insert/erase
< sipa>
BlueMatt: yes, it's in order to implement DeleteLock
< BlueMatt>
oh, i missed that its using it to delete from lockorders, sorry
< bitcoin-git>
[bitcoin] jnewbery opened pull request #9714: Return correct error codes from bumpfee() (master...bumpfeeerrormessages) https://github.com/bitcoin/bitcoin/pull/9714
< gmaxwell>
moments from the front lines:
< gmaxwell>
12:36 < gmaxwell> Dorian_: Is your wallet still syncing?
< gmaxwell>
12:37 < Dorian_> gmaxwell - yes but it says is gonna do it for 4 years (!)
< achow101>
what's the style for brackets and if statements? Is it bracket on same line, next line? brackets with single line ifs?
< Chris_Stewart_5>
I think adam3us had a good point about exploits and single line ifs awhile back
< BlueMatt>
achow101: if (rainbows && unicorns) {
< BlueMatt>
magic();
< BlueMatt>
}
< achow101>
cool.
< gmaxwell>
I believe this is also permitted: if (rainbows && unicorns) magic(); < braceless but only if one line.
< BlueMatt>
does mininode not support multiple simultaneous connections????
< BlueMatt>
sdaftuar, maybe?
< gmaxwell>
what is no loger prermitted is:
< gmaxwell>
if (dragons)
< gmaxwell>
slay()
< gmaxwell>
else
< gmaxwell>
party();
< gmaxwell>
and similar things that have more ;.
< adam3us>
Chris_Stewart_5 it was just a personal rant. have seen other things fail when the magic turns out to be a macro that wasnt defended by do { foo(); bar(); } while (0) and being #define magic() foo(); bar() and then bad bad things happening when an if is added
< achow101>
ok. good to know.
< achow101>
I was just doing changes and I noticed that the style for if statements is all over the place
< BlueMatt>
heh, python is garbage....like all random python shit, asyncore decided you wanted magic to happen in the background so dont bother exposing the socket connected-ness until you send data on the socket
< BlueMatt>
making it impossible to test disconnect by not sending anything
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (master...2017-02-disconnect-no-verack) https://github.com/bitcoin/bitcoin/pull/9715