< achow101> does testnet use the bitcoin.conf in the datadir or one in datadir/testnet3?
< sipa> "it's complicated"
< achow101> one? both? something else?
< sipa> both...
< sipa> depending on whether you explicitly specify a datadir
< sipa> (i think)
< achow101> great
< luke-jr> AFAIK there isn't a bitcoin.conf in datadir/testnet3?
< luke-jr> (and if you make one it will be ignored)
< luke-jr> I could be wrong, but I recall expecting it to work, and finding it doesn't..
< jcorgan> i have a couple questions/comments about some of the init.cpp network parameter settings
< jcorgan> my goal is to allow hostname lookups for some of the params (-proxy, -onion, -torcontrol)
< jcorgan> there is a -dns parameter for enabling this for -connect, -addnode, and -seednode
< jcorgan> and it gets read into fAllowLookup
< jcorgan> the initialization for those eventually resolves to Lookup(...) with fAllowNode as the final parameter
< jcorgan> i changed the LookupNumeric to Lookup for -proxy and -onion, with the same args, and it works
< jcorgan> but only if i move the initialization for -dns up before this section so the fNameLookup is set already
< jcorgan> so, this is only a few lines change in init.cpp; is this all it takes?
< jcorgan> (i haven't touched torcontrol yet, but the other two are working for me now)
< jcorgan> is it ok to extend the meaning of -dns to cover these three other params in addition to the ones it affects now?
< jcorgan> oh, s/fAllowLookup/fNameLookup/
< jcorgan> would this be useful to anyone but me?
< jcorgan> maybe it would be easier to just do a PR
< sipa> jcorgan: seems reasonable to me
< jcorgan> i'll finish the torcontrol stuff and PR it then
< jcorgan> it will also need some documentation changes to reflect this
< jcorgan> ah, torcontrol is calling a raw address parser in libevent, will need to do some actual work to implement hostname lookup for that
< jonasschnelli> Would it make sense to mention something about the net refactoring in the 0.14er release notes? https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.14.0-Release-notes
< gmaxwell> jonasschnelli: need to do a measurement of a sync between a pair of old nodes and a pair of new nodes.
< gmaxwell> and just mention as a top level release note that the IBD speed went from x to y due to networking improvements, assume valid, validation cache improvements, and other optimizations.
< jonasschnelli> gmaxwell: I need to talk about the 0.14 release tomorrow,... do we have a rough estimation already?
< gmaxwell> A kazillion fold.
< gmaxwell> For a talk you can say reduced by hours.
< jonasschnelli> Okay. That seems to be vague but precise enough. :)
< gmaxwell> on fast computers the network changes and validation cache help a lot, and on really slow computers the assume valid change is more tens of hours reduction.
< jonasschnelli> Regardless of talks, etc. We should mention the sigcache and the network "refactor" in the release notes.
< gmaxwell> well as I said, we should mention the performance, and list why. The headline is the performance.
< jonasschnelli> It seems to me that the a major part of the effort for 0.14 is missing in the release notes
< jonasschnelli> I agree with performance as headline.
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d978c41e1ec4...ec66d06e6ef3
< bitcoin-git> bitcoin/master 5e903a5 Wladimir J. van der Laan: devtools: Handle Qt formatting characters edge-case in update-translations.py...
< bitcoin-git> bitcoin/master 7179e7c Wladimir J. van der Laan: qt: Periodic translations update
< bitcoin-git> bitcoin/master ec66d06 Wladimir J. van der Laan: Merge #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (master...2017_02_qt_translations) https://github.com/bitcoin/bitcoin/pull/9735
< bitcoin-git> [bitcoin] laanwj closed pull request #9751: Mini fix bincoin against bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9751
< wumpus> just bumped the expiration dates for my key (0x74810B012346C9A6) and the bitcoin core release signing key (0x90C8019E36C2E964) two years forward, you might want to re-fetch them
< wumpus> (or --refresh-keys)
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec66d06e6ef3...edc9e63c5799
< bitcoin-git> bitcoin/master 442887f Russell Yanofsky: Require timestamps for importmulti keys...
< bitcoin-git> bitcoin/master 3cf9917 Russell Yanofsky: Add test to check new importmulti "now" value...
< bitcoin-git> bitcoin/master 266a811 Russell Yanofsky: Use MTP for importmulti "now" timestamps
< bitcoin-git> [bitcoin] laanwj closed pull request #9682: Require timestamps for importmulti keys (master...pr/multinow) https://github.com/bitcoin/bitcoin/pull/9682
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc9e63c5799...b08656e34314
< bitcoin-git> bitcoin/master 2cbd119 Matt Corallo: Disconnect peers which we do not receive VERACKs from within 60 sec
< bitcoin-git> bitcoin/master 8aaba7a Matt Corallo: qa: mininode learns when a socket connects, not its first action
< bitcoin-git> bitcoin/master b436f92 Matt Corallo: qa: Expose on-connection to mininode listeners
< bitcoin-git> [bitcoin] laanwj closed pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (master...2017-02-disconnect-no-verack) https://github.com/bitcoin/bitcoin/pull/9715
< jonasschnelli> Going to test 9108 now
< bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b08656e34314...e87ce95fbdc6
< bitcoin-git> bitcoin/master c45b9fb Cory Fields: net: correctly ban before the handshake is complete...
< bitcoin-git> bitcoin/master 8502e7a Cory Fields: net: parse reject earlier...
< bitcoin-git> bitcoin/master cbfc5a6 Cory Fields: net: require a verack before responding to anything else...
< bitcoin-git> [bitcoin] laanwj closed pull request #9720: net: fix banning and disallow sending messages before receiving verack (master...fix-ban) https://github.com/bitcoin/bitcoin/pull/9720
< jonasschnelli> luke-jr: I think your sensitive datafilter is nice,.. but we always dump the sent command into the console window... this should also be filtered, not?
< jonasschnelli> Is there a reason why the internal miner mines to p2pk instead of p2pkh?
< jonasschnelli> void CWallet::GetScriptForMining(boost::shared_ptr<CReserveScript> &script)
< jonasschnelli> seems to generate CScript() << ToByteVector(pubkey) << OP_CHECKSIG;
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e87ce95fbdc6...a441db01b527
< bitcoin-git> bitcoin/master 0b4f273 Luke Dashjr: Bugfix: Qt/Options: Restore persistent "restart required" notice
< bitcoin-git> bitcoin/master a441db0 Jonas Schnelli: Merge #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice (master...bugfix_gui_opts_restartreq) https://github.com/bitcoin/bitcoin/pull/9755
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9760: [wallet] Remove importmulti always-true check (master...pr/multitaut) https://github.com/bitcoin/bitcoin/pull/9760
< jl2012> jonasschnelli: I think it's overall cheaper to use P2PK
< luke-jr> jonasschnelli: dunno, maybe
< sipa> jonasschnelli: i think the real reason is just histoical
< sipa> *historical
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9761: Use 2 hour grace period for key timestamps in importmulti rescans (master...pr/multigrace) https://github.com/bitcoin/bitcoin/pull/9761
< bitcoin-git> [bitcoin] pstratem opened pull request #9762: Add txdetails parameter to getblock. (master...2017-02-14-getblock-includetxs) https://github.com/bitcoin/bitcoin/pull/9762