< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/72fb5158b1c8...19be26afe3d0
< bitcoin-git> bitcoin/master 8455e36 practicalswift: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test...
< bitcoin-git> bitcoin/master 19be26a MarcoFalke: Merge #9555: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp)...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9555: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp) (master...avoid-ub-in-tx_invalid-test) https://github.com/bitcoin/bitcoin/pull/9555
< gmaxwell> dear god, UIs are hard.
< gmaxwell> 19:02 < pawn> gmaxwell: I have the new version. I opened the console. I ran dumpwallet, and it's not giving anything back to me. I passed wallet.dat and /Users/pawn/Library/Application\ Support/Bitcoin/wallet.dat as an argument.
< sipa> :'(
< gmaxwell> I had him back up first.
< gwillen> that is ... not a failure mode I ever would have thought of. Users find very creative ways to hurt themselves. I'm glad you had him back up.
< gmaxwell> saw things similar prior. (button for a most common symbol in my words isn't working)
< achow101> Does anyone else have a compiler warning for wallet/db.cpp:620?
< phantomcircuit> achow101, compiler warnings are hard to reproduce because they all have different ideas of what to warn about
< gmaxwell> achow101: whats the warning?
< gmaxwell> if it's a shadow warning, mention it on #9911
< gribble> https://github.com/bitcoin/bitcoin/issues/9911 | Wshadow: various gcc fixes by paveljanik · Pull Request #9911 · bitcoin/bitcoin · GitHub
< achow101> it is a shadow warning
< achow101> looks like paveljanik already got it and fixed it
< paveljanik> yup :-)
< bitcoin-git> [bitcoin] practicalswift opened pull request #9936: [trivial] Fix three typos introduced into walletdb.h in yesterday's merge of commit 7184e25 (master...fix-typos-introduced-in-commit-7184e25c) https://github.com/bitcoin/bitcoin/pull/9936
< bitcoin-git> [bitcoin] laanwj opened pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
< bitcoin-git> [bitcoin] laanwj closed pull request #9928: Allow verify-commit.sh to just verify the HEAD commit (Use non-recursive verification by default) (master...2017/03/vc_simple) https://github.com/bitcoin/bitcoin/pull/9928
< wumpus> going to tag 0.14.0 final in a bit
< wumpus> gah, the github-merge script is not working anymore
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/19be26afe3d0...00c13ea637d6
< bitcoin-git> bitcoin/master f20e664 Matt Corallo: Check gpg version before setting --weak-digest
< bitcoin-git> bitcoin/master b3ec305 Matt Corallo: Fix bashisms in verify-commits and always check top commit's tree
< bitcoin-git> bitcoin/master 00c13ea Wladimir J. van der Laan: Merge #9932: Fix verify-commits on travis and always check top commit's tree...
< bitcoin-git> [bitcoin] laanwj closed pull request #9932: Fix verify-commits on travis and always check top commit's tree (master...2017-03-fix-verify-commits) https://github.com/bitcoin/bitcoin/pull/9932
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/309bf16257b2395ce502017be627186b749ee749
< bitcoin-git> bitcoin/master 309bf16 Wladimir J. van der Laan: devtools: Fix a syntax error typo...
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/309bf16257b2...779f2f97478c
< bitcoin-git> bitcoin/master 73296f5 Matt Corallo: CScheduler boost->std::function, use millisecs for times, not secs
< bitcoin-git> bitcoin/master 735d9b5 Matt Corallo: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB
< bitcoin-git> bitcoin/master 0235be1 Matt Corallo: Rename FlushWalletDB -> CompactWalletDB, add function description
< bitcoin-git> [bitcoin] laanwj closed pull request #9605: Use CScheduler for wallet flushing, remove ThreadFlushWalletDB (master...2017-01-cscheduler-cleanups) https://github.com/bitcoin/bitcoin/pull/9605
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/779f2f97478c...6015df5b855f
< bitcoin-git> bitcoin/master 02c57b5 Suhas Daftuar: Optimize GetWitnessHash() for non-segwit transactions
< bitcoin-git> bitcoin/master 6015df5 Wladimir J. van der Laan: Merge #9912: Optimize GetWitnessHash() for non-segwit transactions...
< bitcoin-git> [bitcoin] laanwj closed pull request #9912: Optimize GetWitnessHash() for non-segwit transactions (master...2017-03-optimize-witness-hash) https://github.com/bitcoin/bitcoin/pull/9912
< bitcoin-git> [bitcoin] laanwj closed pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
< wumpus> crap, travis is *still* failing with #9932
< gribble> https://github.com/bitcoin/bitcoin/issues/9932 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< Victorsueca> lol
< luke-jr> gribble also XD
< Victorsueca> everything seems to fail today
< wumpus> yes it's still morning and I've already had it with today
< jeremyrubin> wumpus: Aw hang in there
< jeremyrubin> wumpus: crack some bubbly whn you're done ;)
< wumpus> hah
< wumpus> * [new tag] v0.14.0 -> v0.14.0
< jonasschnelli> \o/
< Ylbam> +1
< btcdrak> woo
< shangzhou> \o/
< jeremyrubin> yay!
< * jeremyrubin> opens 0.15 PR ;)
< * Victorsueca> compiles
< bitcoin-git> [bitcoin] JeremyRubin closed pull request #8464: [WIP] "Lockfree" Checkqueue Implementation (master...lockfree-checkqueue-squashed) https://github.com/bitcoin/bitcoin/pull/8464
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #9938: Lock-Free CheckQueue (master...PR-lockfree-checkqueue) https://github.com/bitcoin/bitcoin/pull/9938
< jeremyrubin> Alright going to sleep after writing that one up
< jonasschnelli> 659878f197b29e05fcd89f3bd18a17d0d0952d479bbc6c95f4aecc7f0cd104e5 bitcoin-0.14.0-osx-unsigned.dmg
< wumpus> 05edd35d4b119ec92ecedde3b2da6a69078161741421da8ed039908a8e223405 :/
< wumpus> oh wait nm
< wumpus> built the rc3 again instead of final :)
< jonasschnelli> 14898a9b54eb8e88eeec2f29024f2fb47a6b54dbc0e8c587eea4bec0a13fb951 bitcoin-0.14.0-win-unsigned.tar.gz
< jonasschnelli> 06e6ceeb687e784e9aaad45e9407c7eed5f7e9c9bbe44083179287f54f0f9f2b bitcoin-0.14.0-x86_64-linux-gnu.tar.gz
< bitcoin-git> [bitcoin] joaopaulofonseca opened pull request #9939: Cache vout IsMine() value on `CWallet::AvailableCoins()` (master...enhancement/cache-wallet-available-coins-output-ismine) https://github.com/bitcoin/bitcoin/pull/9939
< jonasschnelli> Hmm... just did an importmulti from the Qt console... the rescan window does not show up.
< achow101> my gitian builds match jonasschnelli's
< jonasschnelli> achow101: great
< wumpus> mine match jonasschnelli's too
< cfields> woohoo, final tag :)
< cfields> I'm about to head to the airport, will be able to sign in ~6hrs
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/6015df5b855f...3178b2c740f1
< bitcoin-git> bitcoin/master c6b82d1 Russell Yanofsky: Add tests for CWalletTx::nTimeSmart
< bitcoin-git> bitcoin/master 1f98abe Russell Yanofsky: Factor out CWallet::nTimeSmart computation into a method....
< bitcoin-git> bitcoin/master 6c996c2 Russell Yanofsky: Add documentation describing CWallet::nTimeSmart....
< morcos> wumpus: #9602 has 5+ ACK's can we go ahead and merge while its clean? The only quibbling seems to be about more comment cleanups and some outstanding lack of consensus on breaking priortisetransaction API. That change can always be modified later.
< gribble> https://github.com/bitcoin/bitcoin/issues/9602 | Remove coin age priority and free transactions - implementation by morcos · Pull Request #9602 · bitcoin/bitcoin · GitHub
< BlueMatt> wumpus: hmm, the travis error on 309bf16 i can reproduce - I dont match your sha512 tree
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9940: Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers (master...2017-03-verify-commits-no-recursion) https://github.com/bitcoin/bitcoin/pull/9940
< wumpus> morcos: ok
< wumpus> BlueMatt: I've done nothing special, just used github-merge.py, no clue why that SHA512 wouldn't match :/
< wumpus> BlueMatt: maybe we should revert the SHA512 change until we have a clue what is happening here
< wumpus> let's see if I can reproduce it myself, anyhow
< wumpus> 309bf16 doesn't even have a SHA512
< wumpus> it was a quick fixup (without github-merge) to get github-merge to work again
< bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/3178b2c740f1...30ff3a2fc95c
< bitcoin-git> bitcoin/master ddf58c7 MarcoFalke: wallet: Remove sendfree...
< bitcoin-git> bitcoin/master 12839cd Alex Morcos: [rpc] Remove estimatepriority and estimatesmartpriority....
< bitcoin-git> bitcoin/master 272b25a Alex Morcos: [mining] Remove -blockprioritysize....
< bitcoin-git> [bitcoin] laanwj closed pull request #9602: Remove coin age priority and free transactions - implementation (master...nopriority) https://github.com/bitcoin/bitcoin/pull/9602
< morcos> yay!! thanks and sorry for the pestering! (#9548 can go too now, i wasn't sure if it conflicted, but it doesnt)
< gribble> https://github.com/bitcoin/bitcoin/issues/9548 | Remove min reasonable fee by morcos · Pull Request #9548 · bitcoin/bitcoin · GitHub
< btcdrak> nice work morcos!
< wumpus> morcos: no problem, if a pull is ready it should be merged
< wumpus> yes great work :)
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/30ff3a2fc95c...47510ad3dd51
< bitcoin-git> bitcoin/master ac9d3d2 Alex Morcos: Change fee estimation bucket limit variable names
< bitcoin-git> bitcoin/master 2a7b56c Alex Morcos: CBlockPolicyEstimator now uses hard coded minimum bucket feerate
< bitcoin-git> bitcoin/master ad82cb0 Alex Morcos: Remove unnecessary min fee argument in CTxMemPool constructor
< bitcoin-git> [bitcoin] laanwj closed pull request #9548: Remove min reasonable fee (master...removeMinReasonableFee) https://github.com/bitcoin/bitcoin/pull/9548
< BlueMatt> wumpus: well that explains why it didnt match :P
< bitcoin-git> [bitcoin] morcos opened pull request #9942: Refactor CBlockPolicyEstimator (master...moveTxConfirmStats) https://github.com/bitcoin/bitcoin/pull/9942
< bitcoin-git> [bitcoin] jnewbery opened pull request #9943: Make script.py wildcard importable. (master...rpctestsprimitives) https://github.com/bitcoin/bitcoin/pull/9943
< bitcoin-git> [bitcoin] jnewbery closed pull request #9876: Remove wildcard imports from qa (master...remove_wildcard_imports) https://github.com/bitcoin/bitcoin/pull/9876
< achow101> github as this review feature where you can submit all of your comments as one review and that goes out to recipients as one email. I ask that people please use that to avoid spamming people's inboxes with emails for every single comment you make
< achow101> s/as this/has this/
< BlueMatt> achow101: sadly you cant respond in batch
< BlueMatt> so you get a batch review, and then a million response emails :(
< BlueMatt> also, I'd generally recommend a threaded email client to fix this issue :P
< achow101> well that's annoying then.
< sipa> you can't respond in batch?
< sipa> really?
< BlueMatt> sipa: i dont think so? Did I miss something?
< BlueMatt> maybe i did...hmmm
< achow101> BlueMatt: if you respond in the "view changes" tab, you can respond in a batch with the "start a review" button when you click to reply
< BlueMatt> ahh, ok
< BlueMatt> but, really, also, threaded email client and folders :)
< achow101> I have a threaded email client. I just have everything expanded by default and saw a ton of emails for all of your comments :)
< bitcoin-git> [bitcoin] sipa closed pull request #9909: tests: Add FindEarliestAtLeast test for edge cases (master...pr/faltest) https://github.com/bitcoin/bitcoin/pull/9909
< sipa> oops, misclick
< kanzure> should decoderawtransaction calculate total input amounts?
< sipa> no
< kanzure> is there another way for an rpc user to do basic sanity checks on transactions like that?
< sipa> if they have the inputs, sure
< sipa> which should be trivial if it's their own
< sipa> and nearly impossible otherwise
< sipa> (would require a fully indexed blockchain)
< kanzure> which rpc command though?
< achow101> kanzure: there was a proposal for a verifyrawtransaction but it was controversial so it got dropped
< achow101> the only way to check if a transaction is valid is to send it
< sipa> kanzure: if you have -txindex, use getrawtransaction
< sipa> kanzure: otherwise, don't
< kanzure> getrawtransaction seems to only take txid
< kanzure> oh you mean check inputs via getrawtransaction
< sipa> yes, you fetch all the inputs
< kanzure> ok ok fine, thanks
< gmaxwell> we need to specify a new raw transaction format that can carry inputs... but without segwit it's insufficient to verify things.
< sipa> kanzure: or use gettransaction
< luke-jr> "(note: this is a temporary file, to be added-to by anybody, and moved to release-notes at release time)" made it into the final tag XD
< sipa> (which only works if it's your own transaction)
< gmaxwell> but it should be segwit only because of that.
< kanzure> context: i am doing a simple user interface for a 8-of-12 signing ritual, checking some other nodes to make sure the total inputs add up to something reasonable and expected
< gmaxwell> top
< kanzure> sipa: no, iterating over inputs via getrawtransaction is good enough for now. also giving inputs in the transaction format sounds good to me.
< sipa> kanzure: still, it requires a full txindex node
< sipa> kanzure: unless all the outputs are available
< sipa> which i guess will be the case for you
< sipa> s/outputs are available/inputs are unspent/
< luke-jr> hm, we lost bitcoin.conf.5 (manpage)
< BlueMatt> any idea in what pr?
< BlueMatt> its there there in contrib/debian
< bitcoin-git> [bitcoin] jnewbery opened pull request #9945: Improve logging in bctest.py if there is a formatting mismatch (master...improve_bctest_logging) https://github.com/bitcoin/bitcoin/pull/9945
< luke-jr> BlueMatt: not in 0.14/master?
< BlueMatt> oh, nvm, I'm thinking of contrib/debain/examples/
< bitcoin-git> [bitcoin] pinheadmz opened pull request #9946: Fix build errors if spaces in path or parent directory (master...dirspaces2) https://github.com/bitcoin/bitcoin/pull/9946