< Chris_Stewart_5> jcorgan: I think it is better to use "visible" ASICBOOST and "invisbile" ASICBOOST
< bitcoin-git> [bitcoin] kewde opened pull request #10164: Wallet: reduce excess logic InMemPool() (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10164
< chatter29> hey guys
< jcorgan> uh oh
< chatter29> hey jcorgan
< NicolasDorier> I just noticed : RPC Error messages are translated
< NicolasDorier> is it a mistake ?
< NicolasDorier> this is kind of big deal as the RPCErrorCode are sometimes not precise enough
< NicolasDorier> so I made lot's of assumption based on RPC Message instead
< NicolasDorier> just saw now they are translated....
< NicolasDorier> I intend to do a PR to make a new kind of RPC Code on which client code can depends
< NicolasDorier> or is it better to extend the existing one ?
< bitcoin-git> [bitcoin] kallewoof closed pull request #9686: [WIP] RPC help tabulation (master...rpc-help-tabulation) https://github.com/bitcoin/bitcoin/pull/9686
< Naphex> 21:45 < sturles> Theese days you can buy beer with testnet coins, as long as you use LN..
< Naphex> (sorry, miss paste)
< NicolasDorier> I rebased https://github.com/bitcoin/bitcoin/pull/9728 I would be happy if Hardware wallets people can review. I ate my own dog food, and it seems this PR would really help helping bitcoin core wore seemlessly with hardware wallet and normal wallet without code modification.
< NicolasDorier> (without code modification on software already written)
< NicolasDorier> This would allow easy transition to hardware wallet for RPC users.
< bitcoin-git> [bitcoin] NicolasDorier opened pull request #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair (master...inputcoin) https://github.com/bitcoin/bitcoin/pull/10165
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c28670e92b6...a3a2160b6650
< bitcoin-git> bitcoin/master 1352092 John Newbery: Log calls to getblocktemplate
< bitcoin-git> bitcoin/master a3a2160 Wladimir J. van der Laan: Merge #10162: [trivial] Log calls to getblocktemplate...
< bitcoin-git> [bitcoin] laanwj closed pull request #10162: [trivial] Log calls to getblocktemplate (master...loggetblocktemplatecalls) https://github.com/bitcoin/bitcoin/pull/10162
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #10043: Fix bug in CKey DER encoding (master...2017/03/fix_der_comp) https://github.com/bitcoin/bitcoin/pull/10043
< jonasschnelli> wumpus: I think #9681 is rfm
< gribble> https://github.com/bitcoin/bitcoin/issues/9681 | Refactor Bumpfee, move core functionality to CWallet by jonasschnelli · Pull Request #9681 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a3a2160b6650...928695bee67e
< bitcoin-git> bitcoin/master b67eb8d Wladimir J. van der Laan: doc: Remove version numbers from READMEs...
< bitcoin-git> bitcoin/master 168a703 Wladimir J. van der Laan: doc: Make build system insert version in Doxyfile
< bitcoin-git> bitcoin/master 08d9aee Wladimir J. van der Laan: build: Remove duplicate version information from src/clientversion.h...
< bitcoin-git> [bitcoin] laanwj closed pull request #10155: build: Deduplicate version numbers (master...2017_03_version_bump) https://github.com/bitcoin/bitcoin/pull/10155
< wumpus> jonasschnelli: thanks
< wumpus> btw: as bitcoin.org migrated to a new server, I'm waiting for things to be in order to upload 0.14.1rc1 binaries, this is why it's taking longer than normal
< bitcoin-git> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/928695bee67e...a5fd74667459
< bitcoin-git> bitcoin/master d1a95e8 Jonas Schnelli: Bumpfee move request parameter interaction to the top
< bitcoin-git> bitcoin/master 0337a39 Jonas Schnelli: Refactor Bumpfee core functionality
< bitcoin-git> bitcoin/master 2718db0 Jonas Schnelli: Restore invalid fee check (must be > 0)
< bitcoin-git> [bitcoin] laanwj closed pull request #9681: Refactor Bumpfee, move core functionality to CWallet (master...2017/02/qt_bump) https://github.com/bitcoin/bitcoin/pull/9681
< karelb> hello... I want to build my own bitcoind with the resulting tar similar to what bitcoind has as release tgz... "make dist" doesn't do that apparently, but I can't find out what does
< karelb> make install DESTDIR=$(pwd)/here/ does the most close, but not 100%
< karelb> I don't want to follow the whole gitian guide :/
< karelb> plus "make install" doesn't strip the debug symbols, so the resulting files are quite big
< karelb> ....oh, I should have asked this in #bitcoin , right
< sipa> you should use the gitian build
< karelb> @sipa : :/ I was afraid of that. The guide seems pretty long.
< wumpus> yes, the gitian process is the right way to generate distributable binaries
< wumpus> (alternatively you could try to follow the gitian descriptor without actually running a gitian build, but that seems more work than just following it, plus you won't get deterministic binaries that others can verify)
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5fd74667459...df1ca9e93a61
< bitcoin-git> bitcoin/master 63062bd John Newbery: [tests] color test results and sort alphabetically
< bitcoin-git> bitcoin/master bb92d83 John Newbery: [tests] Add unicode symbols for tests passing/failing/skipping
< bitcoin-git> bitcoin/master d80baaa John Newbery: fixup - align summary row correctly and make colors/glyphs globals
< bitcoin-git> [bitcoin] laanwj closed pull request #10159: [tests] color test results and sort alphabetically (master...sort_test_results) https://github.com/bitcoin/bitcoin/pull/10159
< karelb> Hm, I have 0 experience with gitian and I'm afraid of it, and the guide starts with installing virtual machine and installing debian on it, so I was thinking if there isn't something quicker :) OK I will dive in
< bitcoin-git> [bitcoin] paveljanik opened pull request #10166: Ignore Doxyfile generated from Doxyfile.in template. (master...20170407_gitignoreDoxyfile) https://github.com/bitcoin/bitcoin/pull/10166
< sipa> karelb: right, or what wumpus says: you can look a the gitian descriptor to see the build scriots used for release builds
< wumpus> karelb: the guide is only one of the ways of using it, you don't necessarily need the outer vm if you already have linux of some kind running (esp if that is debian or ubuntu), it's just that the vm with debian works for everyone even those using windows
< bitcoin-git> [bitcoin] practicalswift opened pull request #10167: [trivial] Fix typo ("improssible" → "impossible") (master...improssible) https://github.com/bitcoin/bitcoin/pull/10167
< jnewbery> I'm getting these errors since #10155 was merged to master:
< gribble> https://github.com/bitcoin/bitcoin/issues/10155 | build: Deduplicate version numbers by laanwj · Pull Request #10155 · bitcoin/bitcoin · GitHub
< jnewbery> CXX libbitcoin_server_a-checkpoints.o
< jnewbery> In file included from addrdb.cpp:10:0:
< jnewbery> clientversion.h:14:48: warning: missing terminating ' character
< jnewbery> #error Client version information missing: wasn't defined by bitcoin-config.h nor defined any other way
< jnewbery> ^
< jnewbery> CXX libbitcoin_server_a-httprpc.o
< jnewbery> removing the ' from the #error fixes it for me
< jnewbery> wumpus: ^^
< wumpus> huh
< jnewbery> looks like it's happening on travis too: https://travis-ci.org/bitcoin/bitcoin/jobs/219669340
< wumpus> why didn't travis catch that one on the PR
< wumpus> oh it's just a warning
< jnewbery> it's a warning, not an error
< wumpus> phew
< jnewbery> sorry - confusing. The warning said error :)
< jnewbery> I'll PR it
< bitcoin-git> [bitcoin] jnewbery opened pull request #10168: Fix build warning from #error text (master...fixbuildwarning) https://github.com/bitcoin/bitcoin/pull/10168
< morcos> wumpus: not sure if you want another ack on #9942? i don't think its necessary, as its just the precursor. i have another dozen commits that are almost ready to go, but i'd like to wait for that to be merged and rebase my new stuff on to master.
< gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery closed pull request #10160: [WIP] updatepeer RPC (master...updatepeer) https://github.com/bitcoin/bitcoin/pull/10160
< bitcoin-git> [bitcoin] jnewbery opened pull request #10169: [tests] Remove func test code duplication (master...remove_func_test_code_duplication) https://github.com/bitcoin/bitcoin/pull/10169
< warren> https://github.com/bitcoin/bitcoin/issues/10170 "Normalized, Deterministic OSX SDK tarball" This is an opportunity for non-C++ developers to contribute to Bitcoin Core development.
< warren> ask wumpus requested, filed a ticket so I don't forget it. hope somebody with more time gets to it before me. I don't have a mac so i can't test it there.