< Lauda>
There's a reason why it is optional in said pull
< luke-jr>
hmm, GUI % for rescanning is different from debug.log %
< jonasschnelli>
luke-jr: I guess the GUI rescaning should be overhauled... Last time I used it, it was completely blocking the GUI and AFAIK not even updating the progress bar
< luke-jr>
jonasschnelli: it's done during the splash screen..
< jonasschnelli>
luke-jr: That. Yes. But there is another (importmulti, import*)
< luke-jr>
ah
< luke-jr>
jonasschnelli: I suggest waiting until after multiwallet to overhaul
< jonasschnelli>
yes. Good point.
< luke-jr>
right now, multiwallet will rescan one wallet at a time at startup, so that will use optimising
< sipa>
murchandamus: very quick first comment: types like vector<pair<pair<..>>> aren't very readable
< sipa>
at least you can use tuple instead of pair
< sipa>
but probably you should create a simple struct for readability
< murchandamus>
sipa: I just saw that it was updated in origin/master to exactly that effect, I'll fix that in my next commit
< murchandamus>
sipa: So my biggest blocker at the moment would be, how do I get the size of the input to calculate the effectiveValue in GenerateEffectiveValue. Although, I just realized that instagibbs's PR from a few weeks ago should have that.
< murchandamus>
So, I'll look into that first, nevermind. d)
< sipa>
murchandamus: look at how fundrawtransaction does it
< gmaxwell>
murchandamus: if it's blocking your progress, you could leave it for last... just stick a constant in there.