< bitcoin-git>
bitcoin/master 1bcd442 practicalswift: Remove the virtual specifier for functions with the override specifier...
< bitcoin-git>
bitcoin/master 50fae68 MarcoFalke: Merge #10701: Remove the virtual specifier for functions with the override specifier...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #10701: Remove the virtual specifier for functions with the override specifier (master...virtual-override) https://github.com/bitcoin/bitcoin/pull/10701
< meshcollider>
fanquake: you're so quick with the labels haha
< gmaxwell>
Does someone want to try drafting a release note to advise people about -resetguisettings
< meshcollider>
is there a 'Known Issues' section or something in the release notes?
< meshcollider>
or should it go into the Compatibility section
< gmaxwell>
perhaps we should create a known issues section.
< gmaxwell>
I think we still don't know how people get into a state where this problem bites them.
< gmaxwell>
(watch it turn out to be some altcoin correupting the settings 'accidentally' :P )
< meshcollider>
the fix will be included in 0.15.1 right
< bitcoin-git>
[bitcoin] aeyoll opened pull request #11235: Trivial: Fix a grammar mistake and a typo in the french translations (master...fix-french-translations) https://github.com/bitcoin/bitcoin/pull/11235
< bitcoin-git>
[bitcoin] aeyoll closed pull request #11235: Trivial: Fix a grammar mistake and a typo in the french translations (master...fix-french-translations) https://github.com/bitcoin/bitcoin/pull/11235
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11236: Add note on translations to CONTRIBUTING.md (master...201709_translations_in_contributing) https://github.com/bitcoin/bitcoin/pull/11236
< Lauda>
listreceivedbyaddress is this supposed to return addresses that one has *sent* to as well?
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11237: Fixing division by zero in time remaining (master...201709_fix_estimated_time) https://github.com/bitcoin/bitcoin/pull/11237
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11238: Fix potential null deference and resource leaks (master...201708_fbinfer_fixes) https://github.com/bitcoin/bitcoin/pull/11238
< harding>
For 0.15.0 users raring to go with segwit, is there any reason to discourage them from using, e.g., bitcoin-cli addwitnessaddress $( bitcoin-cli getnewaddress ) ?
< chainhead>
It doesn't work well when restoring from an old backup
< harding>
chainhead: ooh, good point. I hadn't thought of that. Thanks!
< sipa>
harding: also does not support labels/accounts
< sipa>
harding: and yes, will fail to recover from a backup
< bitcoin-git>
bitcoin/master ce5381e Wladimir J. van der Laan: build: Rename --enable-experimental-asm to --enable-asm and enable by default...
< bitcoin-git>
bitcoin/master 538cc0c Wladimir J. van der Laan: build: Mention use of asm in summary
< bitcoin-git>
bitcoin/master df8c722 Wladimir J. van der Laan: Merge #11176: build: Rename --enable-experimental-asm to --enable-asm and enable by default...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11176: build: Rename --enable-experimental-asm to --enable-asm and enable by default (master...2017_08_non_experimental_asm) https://github.com/bitcoin/bitcoin/pull/11176
< bitcoin-git>
bitcoin/master 5ac072c Dan Raviv: Fix boost headers included as user instead of system headers...
< bitcoin-git>
bitcoin/master 38a54a5 Wladimir J. van der Laan: Merge #11164: Fix boost headers included as user instead of system headers...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11164: Fix boost headers included as user instead of system headers (master...fix/boost-system-includes) https://github.com/bitcoin/bitcoin/pull/11164
< bitcoin-git>
[bitcoin] donaloconnor opened pull request #11244: Docs: Add extra step to clean $PATH var to strip out windows %PATH% paths. (master...windows_build_fix) https://github.com/bitcoin/bitcoin/pull/11244
< bitcoin-git>
bitcoin/master 47ba2c3 Akio Nakamura: Fix currency/fee-rate unit string in the help text...
< bitcoin-git>
bitcoin/master 4eb1f39 MarcoFalke: Merge #11173: RPC: Fix currency unit string in the help text...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11173: RPC: Fix currency unit string in the help text (master...use_currency_unit_constant) https://github.com/bitcoin/bitcoin/pull/11173
< bitcoin-git>
bitcoin/master a1ea1cf Chris Moore: qt: Use IsMine to validate custom change address...
< bitcoin-git>
bitcoin/master a31e9ad MarcoFalke: Merge #11247: qt: Use IsMine to validate custom change address...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11247: qt: Use IsMine to validate custom change address (master...Mf1708-qtIsMine) https://github.com/bitcoin/bitcoin/pull/11247
< bitcoin-git>
[bitcoin] achow101 opened pull request #11250: Bump wallet version to 159900 and remove the `usehd` option (master...bump-wallet-version) https://github.com/bitcoin/bitcoin/pull/11250
< bitcoin-git>
bitcoin/master ce3baa1 Ferdinando M. Ametrano: changed regtest RPCport to 18443 to avoid conflict with testnet 18332
< bitcoin-git>
bitcoin/master 28485c7 Wladimir J. van der Laan: Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332...
< bitcoin-git>
[bitcoin] laanwj closed pull request #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 (master...fametrano-regtestport) https://github.com/bitcoin/bitcoin/pull/10825
< sipa>
promag: but CTxDestination does belong in script/standard.h, IMHO
< promag>
so move {Encode,Decode,IsValid}Destination to script/standard.h there?
< sipa>
oh, no
< sipa>
code that just deals with script signing shouldn't need to depend on string encoding logic
< sipa>
addresses are a UI thing
< sipa>
CTxDestination is a script signing logic thing
< sipa>
i was thinking maybe have an address.{h,cpp} that just does bech32/base58/encode/decode/...
< wumpus>
sounds sensible
< sipa>
while base58.* is just the base58 encoding/decoding logic (without any address-specific thing), and bech32.* is just the bech32 encoding/decoding logic (without any address-specific thing)
< promag>
yes, like amount.h
< sipa>
right
< promag>
ok, now that's clear, ty
< sipa>
sorry, i should probably have clarified earlier what i had in mind