< bitcoin-git> [bitcoin] rodasmith opened pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
< bitcoin-git> [bitcoin] ken2812221 closed pull request #14655: qt: remove unused SECURE style (master...qt-unused-secure) https://github.com/bitcoin/bitcoin/pull/14655
< bitcoin-git> [bitcoin] rodasmith closed pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
< warren> dongcarl: huzzah
< hebasto> wumpus: MarcoFalke: ethic/testing/QA question. If one's PR (e.g., #14123) contains cherry-picked commits from my PR should I avoid ACKing such PR?
< gribble> https://github.com/bitcoin/bitcoin/issues/14123 | gui: Add GUIUtil::bringToFront by promag · Pull Request #14123 · bitcoin/bitcoin · GitHub
< sipa> hebasto: feel free to ack
< hebasto> sipa: ty
< wumpus> esotericnonsense: nice!
< wumpus> hebasto: no, you can still review the rest, you could say you haven't reviewed commit XXX because it's your own
< hebasto> wumpus: ok
< luke-jr> someone looking for help with -rpcallowip in #bitcoin right now FYI
< promag> wumpus: could you look at #14670, esp the PR description. I think this is it XD
< gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
< vishwas> hi
< gwillen> vishwas: you should try to get your debugger to print it as a hex string
< gwillen> if you get that you can pass it to the "decodescript" RPC
< gwillen> note that scriptPubKey in the structure there is a C++ vector object, you really can't do much by poking around inside it
< gwillen> all that "direct" and "indirect" stuff is internal implementation details of C++ vectors
< vishwas> thanks gwillen let me try that.
< vishwas> @gwillen ; one question, so when the UTXO finally gets stored in to the block, this vector object should get transformed into string ?
< vishwas> or its gets stored in this form only.?
< setpill> hrm. does the gitian build process check the integrity of the osslsigncode tarfile downloaded from sourceforge in any way?
< setpill> or the patch downloaded from bitcoincore.org for that matter...
< setpill> ah, expected them in the script that downloads them, thanks
< instagibbs> in functional tests is there a nice way to send coinbase outputs to p2pk as per `generate`?
< instagibbs> now that generate is gone
< instagibbs> I guess s/functional tests/rpc/
< provoostenator> Can someone elaborate on the difference between a FlatSigningProvider and a HidingSigningProvider and why only the latter has a working GetKeyOrigin?
< sipa> provoostenator: FlatSigningProvider provides the data stored in fields in the object itself
< sipa> it's what you use if you just have a bunch of keys, pubkeys, scripts, and origins, and want to make it available to the signing code
< sipa> HidingSigningProvider takes as input *another* signingprovider, but hides certain information from it (in particular, private keys)
< sipa> and what do you mean with "no working GetKeyOrigin" ?
< provoostenator> sipa: in the WIP hardware wallet support branch I find that walletcreatefundedpbst no longer adds origin info. Trying to triangulate why: https://github.com/achow101/bitcoin/tree/hww
< sipa> provoostenator: you're setting the flag for hd paths to true, right?
< provoostenator> This in the case of a wallet with no private keys. Yes, the bip32 bool at the end is true
< provoostenator> I find that only HidingSigningProvider::GetKeyOrigin is called, which afaik can only return false and doesn't actual set the info field.
< sipa> huh
< sipa> why do you think so?
< bitcoin-git> [bitcoin] instagibbs opened pull request #14678: remove redundant KeyOriginInfo access, already done in CreateSig (master...redundant_keypath) https://github.com/bitcoin/bitcoin/pull/14678
< provoostenator> sipa: I set log statements on both HidingSigningProvider::GetKeyOrigin and FlatSigningProvider::GetKeyOrigin and only the former is called.
< instagibbs> provoostenator, the underlying m_provider is CWallet though?
< provoostenator> Oh, I assemed it referred to the base class, n00b...
< instagibbs> It "wraps" CWallet to "hide" stuff. Honestly they should have documentation :)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d864e45730be...4e6dc7a0ef22
< bitcoin-git> bitcoin/master 99d33a6 Chun Kuan Lee: appveyor: Script improvement part II
< bitcoin-git> bitcoin/master 4e6dc7a MarcoFalke: Merge #14665: appveyor: Script improvement part II...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14665: appveyor: Script improvement part II (master...appveyor-quiet) https://github.com/bitcoin/bitcoin/pull/14665
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e6dc7a0ef22...66c70249f9e6
< bitcoin-git> bitcoin/master 053b6f4 Harry Moreno: align items in contrib init
< bitcoin-git> bitcoin/master 66c7024 MarcoFalke: Merge #14611: docs: align items in contrib init...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14611: docs: align items in contrib init (master...morenoh149-patch-1) https://github.com/bitcoin/bitcoin/pull/14611
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/66c70249f9e6...e8d490f27e69
< bitcoin-git> bitcoin/master e4dc39b Hennadii Stepanov: Replace platform dependent type with proper const
< bitcoin-git> bitcoin/master bafb921 Hennadii Stepanov: Remove duplicated code...
< bitcoin-git> bitcoin/master 5352030 Russell Yanofsky: Avoid using numeric_limits for sequence numbers and lock times...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13677: Remind developers that disablewallet=1 should always work (master...2018/07/disable-wallet) https://github.com/bitcoin/bitcoin/pull/13677
< bitcoin-git> [bitcoin] instagibbs opened pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
< provoostenator> Any one-liner to serialize a KeyOriginInfo object to std::string (for debugging)?
< provoostenator> (or to char *)
< sipa> provoostenator: decodepsbt has code for that
< sipa> oh, it does it in 2 separate json fields
< provoostenator> sipa: got it, that should be easy to reuse
< MarcoFalke> ?
< bitcoin-git> [bitcoin] jamesob opened pull request #14683: tests: better combine_logs.py behavior (master...2018-11-better-cons-log) https://github.com/bitcoin/bitcoin/pull/14683
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8d490f27e69...d26d15c6c89a
< bitcoin-git> bitcoin/master 590a57f practicalswift: tests: Remove unused testing code
< bitcoin-git> bitcoin/master c82190c practicalswift: tests: Add Python dead code linter (vulture)
< bitcoin-git> bitcoin/master d26d15c MarcoFalke: Merge #14365: tests: Add Python dead code linter (vulture) to Travis...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14365: tests: Add Python dead code linter (vulture) to Travis (master...lint-python-dead-code) https://github.com/bitcoin/bitcoin/pull/14365
< esotericnonsense> wumpus: :) when I get bored of bashing JS libraries into submission I'll add some more stuff. need to get away from this chart distraction and add some actually useful API bits. :p\
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14684: [doc] conf: Remove deprecated options from docs, Other cleanup (master...Mf1609-trivialPre14) https://github.com/bitcoin/bitcoin/pull/14684
< provoostenator> (mystery solved, the older version of achow101's hww PR would write "h" into meta.hdKeypath, which trips up ParseHDKeypath. The new version always uses '.
< sipa> provoostenator: ha, nice find
< provoostenator> Hardware wallet fun in ##hww
< instagibbs> achow101, ^
< provoostenator> ##hwi
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d26d15c6c89a...11e1ac3ae085
< bitcoin-git> bitcoin/master b191c7d James O'Beirne: doc: add comment explaining recentRejects-DoS behavior...
< bitcoin-git> bitcoin/master 11e1ac3 MarcoFalke: Merge #14436: doc: add comment explaining recentRejects-DoS behavior...
< jnewbery> instagibbs: re generate to P2PK, I don't think so - is there a reason you can't use P2PKH or P2WPKH?
< instagibbs> I used multisig to test my hypothesis instead, thanks anyways
< instagibbs> https://github.com/bitcoin/bitcoin/pull/14678 turns out it was just redundancy, not a bug
< ezzzy> are there any up-to-date resources documenting the bitcoin protocol, except of en.bitcoin.it/wiki/Protocol_documentation?
< dondreyt> I'm currently in the process of doing some debugging of Bitcoin Core. Is there a way to output a CScript to console, in particular a public key signature as a string representation of hexadecimal?
< phantomcircuit> dondreyt, iirc there's a descodescript rpc call
< phantomcircuit> if that's what you mean
< meshcollider> dondreyt: HexStr(script.begin(), script.end())
< dondreyt> Ah yeah, HexStr is what I'm looking for for. Do you pass in the CScript as a third parameter into that?
< meshcollider> No I'm assuming the CScript is called script
< meshcollider> It returns the string
< dondreyt> meshcollider: I see
< dondreyt> meshcollider: To view the output of this when you call "submitblock" from the console, is there a function I should use? I see LogPrintf scattered throughout, but I wasn't sure where the outputted to.
< dondreyt> phanetomcircuit: Thanks, I'll check out descodescript as well. Didn't know there was an RPC for that.
< meshcollider> dondreyt: logprintf prints to the debug.log file
< dondreyt> meshcollider: Ahhh okay, makes perfect sense. Thanks
< meshcollider> np
< phantomcircuit> dondreyt, wait what are you trying to do exactly?
< dondreyt> phantomcircuit: Just in the learning phase of seeing how data is represented and passed around. I submitted a block via RPC and have been following it through the validation path.
< phantomcircuit> dondreyt, oh ok, might want to add a bunch of LogPrint statements then using HexStr like meshcollider suggested
< phantomcircuit> then you can decodescript the hexstrings
< dondreyt> phantomcircuit: Okay, I'm going to go ahead and do that.
< jamesob> anyone know if jimpo_'s still working on #14121? if not, I'd like to rebase it
< gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub