< hebasto>
wumpus: MarcoFalke: ethic/testing/QA question. If one's PR (e.g., #14123) contains cherry-picked commits from my PR should I avoid ACKing such PR?
< setpill>
ah, expected them in the script that downloads them, thanks
< instagibbs>
in functional tests is there a nice way to send coinbase outputs to p2pk as per `generate`?
< instagibbs>
now that generate is gone
< instagibbs>
I guess s/functional tests/rpc/
< provoostenator>
Can someone elaborate on the difference between a FlatSigningProvider and a HidingSigningProvider and why only the latter has a working GetKeyOrigin?
< sipa>
provoostenator: FlatSigningProvider provides the data stored in fields in the object itself
< sipa>
it's what you use if you just have a bunch of keys, pubkeys, scripts, and origins, and want to make it available to the signing code
< sipa>
HidingSigningProvider takes as input *another* signingprovider, but hides certain information from it (in particular, private keys)
< sipa>
and what do you mean with "no working GetKeyOrigin" ?
< provoostenator>
sipa: in the WIP hardware wallet support branch I find that walletcreatefundedpbst no longer adds origin info. Trying to triangulate why: https://github.com/achow101/bitcoin/tree/hww
< sipa>
provoostenator: you're setting the flag for hd paths to true, right?
< provoostenator>
This in the case of a wallet with no private keys. Yes, the bip32 bool at the end is true
< provoostenator>
I find that only HidingSigningProvider::GetKeyOrigin is called, which afaik can only return false and doesn't actual set the info field.
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14678: remove redundant KeyOriginInfo access, already done in CreateSig (master...redundant_keypath) https://github.com/bitcoin/bitcoin/pull/14678
< provoostenator>
sipa: I set log statements on both HidingSigningProvider::GetKeyOrigin and FlatSigningProvider::GetKeyOrigin and only the former is called.
< instagibbs>
provoostenator, the underlying m_provider is CWallet though?
< provoostenator>
Oh, I assemed it referred to the base class, n00b...
< instagibbs>
It "wraps" CWallet to "hide" stuff. Honestly they should have documentation :)
< bitcoin-git>
bitcoin/master 5352030 Russell Yanofsky: Avoid using numeric_limits for sequence numbers and lock times...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #13677: Remind developers that disablewallet=1 should always work (master...2018/07/disable-wallet) https://github.com/bitcoin/bitcoin/pull/13677
< bitcoin-git>
[bitcoin] instagibbs opened pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
< provoostenator>
Any one-liner to serialize a KeyOriginInfo object to std::string (for debugging)?
< provoostenator>
(or to char *)
< sipa>
provoostenator: decodepsbt has code for that
< sipa>
oh, it does it in 2 separate json fields
< provoostenator>
sipa: got it, that should be easy to reuse
< bitcoin-git>
bitcoin/master d26d15c MarcoFalke: Merge #14365: tests: Add Python dead code linter (vulture) to Travis...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #14365: tests: Add Python dead code linter (vulture) to Travis (master...lint-python-dead-code) https://github.com/bitcoin/bitcoin/pull/14365
< esotericnonsense>
wumpus: :) when I get bored of bashing JS libraries into submission I'll add some more stuff. need to get away from this chart distraction and add some actually useful API bits. :p\
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14684: [doc] conf: Remove deprecated options from docs, Other cleanup (master...Mf1609-trivialPre14) https://github.com/bitcoin/bitcoin/pull/14684
< provoostenator>
(mystery solved, the older version of achow101's hww PR would write "h" into meta.hdKeypath, which trips up ParseHDKeypath. The new version always uses '.
< ezzzy>
are there any up-to-date resources documenting the bitcoin protocol, except of en.bitcoin.it/wiki/Protocol_documentation?
< dondreyt>
I'm currently in the process of doing some debugging of Bitcoin Core. Is there a way to output a CScript to console, in particular a public key signature as a string representation of hexadecimal?
< phantomcircuit>
dondreyt, iirc there's a descodescript rpc call
< dondreyt>
Ah yeah, HexStr is what I'm looking for for. Do you pass in the CScript as a third parameter into that?
< meshcollider>
No I'm assuming the CScript is called script
< meshcollider>
It returns the string
< dondreyt>
meshcollider: I see
< dondreyt>
meshcollider: To view the output of this when you call "submitblock" from the console, is there a function I should use? I see LogPrintf scattered throughout, but I wasn't sure where the outputted to.
< dondreyt>
phanetomcircuit: Thanks, I'll check out descodescript as well. Didn't know there was an RPC for that.
< meshcollider>
dondreyt: logprintf prints to the debug.log file
< dondreyt>
meshcollider: Ahhh okay, makes perfect sense. Thanks
< meshcollider>
np
< phantomcircuit>
dondreyt, wait what are you trying to do exactly?
< dondreyt>
phantomcircuit: Just in the learning phase of seeing how data is represented and passed around. I submitted a block via RPC and have been following it through the validation path.
< phantomcircuit>
dondreyt, oh ok, might want to add a bunch of LogPrint statements then using HexStr like meshcollider suggested
< phantomcircuit>
then you can decodescript the hexstrings
< dondreyt>
phantomcircuit: Okay, I'm going to go ahead and do that.
< jamesob>
anyone know if jimpo_'s still working on #14121? if not, I'd like to rebase it