< phantomcircuit> sipa, hmm actually just a bad measurement from perf it seems
< esotericnonsense> sipa: yes!
< esotericnonsense> 2**90. :o.
< Roybent> (silicone, saline, string) implants
< bitcoin-git> [bitcoin] 1Il1 opened pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
< bitcoin-git> [bitcoin] 1Il1 opened pull request #14714: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47ed24cf8aa7...b60f4e3f0951
< bitcoin-git> bitcoin/master a6b5ec1 marcoagner: rpc: creates possibility to preserve labels on importprivkey...
< bitcoin-git> bitcoin/master b60f4e3 Jonas Schnelli: Merge #13381: RPC: creates possibility to preserve labels on importprivkey...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #13381: RPC: creates possibility to preserve labels on importprivkey (master...feature_preserve_labels_on_import) https://github.com/bitcoin/bitcoin/pull/13381
< bitcoin-git> [bitcoin] 1Il1 closed pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b60f4e3f0951...083f53547092
< bitcoin-git> bitcoin/master 8711cc0 Hennadii Stepanov: qt: Improve BitcoinAmountField class...
< bitcoin-git> bitcoin/master a16f44c Hennadii Stepanov: qt: Remove "Pay only required fee" checkbox...
< bitcoin-git> bitcoin/master 083f535 Jonas Schnelli: Merge #14608: qt: Remove the "Pay only required fee..." checkbox...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #14608: qt: Remove the "Pay only required fee..." checkbox (master...20181030-remove-payonlyrequiredfee) https://github.com/bitcoin/bitcoin/pull/14608
< bitcoin-git> [bitcoin] Empact opened pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
< bitcoin-git> [bitcoin] Empact opened pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
< promag> saw this travis error https://pasteboard.co/HMXvxSX.png
< meshcollider> #14690 looks RTM
< gribble> https://github.com/bitcoin/bitcoin/issues/14690 | Throw error if CPubKey is invalid during PSBT keypath serialization by instagibbs · Pull Request #14690 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/083f53547092...ce7fcc356909
< bitcoin-git> bitcoin/master 4e4de10 Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization
< bitcoin-git> bitcoin/master ce7fcc3 Wladimir J. van der Laan: Merge #14690: Throw error if CPubKey is invalid during PSBT keypath serialization...
< bitcoin-git> [bitcoin] laanwj closed pull request #14690: Throw error if CPubKey is invalid during PSBT keypath serialization (master...check_psbt_pubkey) https://github.com/bitcoin/bitcoin/pull/14690
< wumpus> achow101: I've also heard that; only "webhooks" remain :(
< wumpus> why does microsoft hate IRC :-(((( (no, kidding, this was already planned before the takeover)
< wumpus> would be fairly straightforward to make an IRC bot that listens to github events, very similar to the twitter/mastodon bot, but it's yet another moving part it was nice that github handled this
< bitcoin-git> [bitcoin] murrayn opened pull request #14718: Remove unreferenced boost headers and quieten remaining clang warnings (master...clang_warnings) https://github.com/bitcoin/bitcoin/pull/14718
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce7fcc356909...c51e1516a930
< bitcoin-git> bitcoin/master 27154ce 1Il1: util.h: explicitly include required QString header
< bitcoin-git> bitcoin/master c51e151 Wladimir J. van der Laan: Merge #14714: util.h: explicitly include required QString header...
< bitcoin-git> [bitcoin] laanwj closed pull request #14714: tests: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c51e1516a930...5d605b27457d
< bitcoin-git> bitcoin/master 6c787d3 MarcoFalke: tests: Make feature_block pass on centos
< bitcoin-git> bitcoin/master fa21568 MarcoFalke: qa: Avoid race in p2p_invalid_block by waiting for the block request
< bitcoin-git> bitcoin/master 5d605b2 MarcoFalke: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request (master...Mf1811-qaPassOnCentOs) https://github.com/bitcoin/bitcoin/pull/14700
< instagibbs> wumpus, would you mind if i made the sigdata const before you consider merging in #14678 ? Or would that "reset" the review? I think it would make intent of function more clear
< gribble> https://github.com/bitcoin/bitcoin/issues/14678 | [wallet] remove redundant KeyOriginInfo access, already done in CreateSig by instagibbs · Pull Request #14678 · bitcoin/bitcoin · GitHub
< wumpus> instagibbs: I don't mind
< wumpus> better to just do it the best way possible than put in a fixup PR just after it's merged, that's frustrating! I think "resetting review" is more of a concern for complex changes
< instagibbs> yep, just making sure
< wumpus> right
< phantomcircuit> hmm sipa is definitely right that a sorted vector would be fast
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
< luke-jr> wumpus: unfortunately, it looks like the existing plugin for github stuff doesn't work with my ljrbot :<
< luke-jr> (and last time I tried to update it to the Limnoria fork, it was a mess)
< wumpus> luke-jr: oh too bad
< luke-jr> although, now that #anime has their own bot, maybe I can delete all the problematic aliases they added and try again, but ... time... :x
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d605b27457d...e0c6bb782308
< bitcoin-git> bitcoin/master fa3df02 MarcoFalke: travis: Avoid timeout on verify-commits check
< bitcoin-git> bitcoin/master fa5a6ce MarcoFalke: qa: Raise ci test_runner timeout to 40 mins
< bitcoin-git> bitcoin/master e0c6bb7 MarcoFalke: Merge #14705: travis: Avoid timeout on verify-commits check...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0c6bb782308...c651265c934c
< bitcoin-git> bitcoin/master fa0d36f MarcoFalke: rpc: Include rpc/util.h where needed for RPCHelpMan...
< bitcoin-git> bitcoin/master fa483e1 MarcoFalke: rpc: Add RPCHelpMan for machine-generated help
< bitcoin-git> bitcoin/master c651265 MarcoFalke: Merge #14530: Use RPCHelpMan to generate RPC doc strings...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14530: Use RPCHelpMan to generate RPC doc strings (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
< bitcoin-git> [bitcoin] Empact closed pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
< stevenroose> SendMoney (in rpcwallet) takes a CTxDestination
< stevenroose> Is that somehow compatible with OP_RETURN?
< stevenroose> Doesn't seem to support it.. Is there a workaround?
< stevenroose> sipa: ^?
< stevenroose> Or would I need an extra variant for that?
< stevenroose> hmm, nvm
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< wumpus> no, CTxDestination doesn't support send-money-into-the-void destination
< wumpus> could add an extra variant for that, but as there's no address type nor standard representation for that, it's not clear how to fit it in
< wumpus> there's CNoDestination but it's used to signal errors
< wumpus> would probably make sense to move reverse_iterator.h and reverselock.h under util/
< sipa> agree
< wumpus> and sync.h maybe
< sipa> what about prevector and limitedmap?
< wumpus> those qualify as util too imo
< sipa> oh and indirectmap
< sipa> cuckoocache too
< sipa> they're all completely standalone things
< wumpus> yes!
< sipa> in a way, things like logging and cmdline parsing are far more application specific than all those things
< wumpus> it would almost warrant a separate 'types' directory for data types which are otherwise independent of the OS and application
< wumpus> though as we already have 'compat', 'support' and 'util' for util-ish things it'd be kinda overkill
< sipa> oh, and span
< wumpus> would make sense to have a clear guideline there first
< sipa> and memusage :)
< sipa> the last one isn't a type definition, but it is completely independent
< sipa> perhaps a directory for all "things that totally could be part of the c++ standard library"
< wumpus> that would include fs.h too
< sipa> ah yes
< sipa> utilstrencodings too
< wumpus> it's very much different from the data structure ones though as it pulls in a large part of the OS
< sipa> and utiltime maybe, if we see it as a simpler std::chrono kind of thing
< wumpus> it's more similar to the stuff in compat/ in that regard
< wumpus> but all util* just moved to util/, let's not move them so soon again :)
< sipa> sure
< sipa> but it may make sense for someone to write a proposal for "what things should be in what directory"
< sipa> and then do it all at once
< wumpus> I don't think that ever works in practice for us
< sipa> haha
< sipa> perhaps not
< sipa> but i very much agree we shouldn't "i think these things belong more here, here is a PR to just move that"
< sipa> that ends up going back and forth
< wumpus> I was suprised how quickly people agreed on the util/ move, let's not pushit too far
< wumpus> also true
< wumpus> was just surprised how many utilities there are inthe bare /src/ directory, it really doesnt matter that much
< wumpus> certainly not going to open a PR for it :)
< instagibbs> #14679 probably also ready for merge
< gribble> https://github.com/bitcoin/bitcoin/issues/14679 | importmulti: Dont add internal addresses to address book by instagibbs · Pull Request #14679 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c651265c934c...f617e05c38c9
< bitcoin-git> bitcoin/master 7afddfa Gregory Sanders: importmulti: Don't add internal addresses to address book
< bitcoin-git> bitcoin/master f617e05 Wladimir J. van der Laan: Merge #14679: importmulti: Don't add internal addresses to address book...
< bitcoin-git> [bitcoin] laanwj closed pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
< MarcoFalke> Moved the discussion into an issue, so we don't loose track of that: #14721
< gribble> https://github.com/bitcoin/bitcoin/issues/14721 | developer doc: Source code organization for standalone (util) functions · Issue #14721 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14712: wallet: Require a start block in ScanForWalletTransactions (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f617e05c38c9...8c59bb85f979
< bitcoin-git> bitcoin/master fa0815c Jon Layton: rpc: Correctly name arguments
< bitcoin-git> bitcoin/master 8c59bb8 MarcoFalke: Merge #14720: rpc: Correctly name arguments...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
< bralyclow> anyone around, posting a question I need your help with...question everyone, I have a bitcoin core full node and wallet, I tried sending a transaction today from a wallet on the node that spent all the BTC in all associated addresses at 1 satoshi per byte and the transaction has been unconfirmed now for over 8 hours which it should have been picked up by this 8 hour timeframe, my question is how can I increase the fee when ther
< bralyclow> e is no BTC left in the wallet and associated addresses and when I try I get this error, "Increasing transaction fee failed (Transaction does not have a change output)" Can I simply deposit 10000 satoshi to an address in that wallet and then try to increase the fee to get it sent, or what can be done and how?
< jarthur> Was it all truly spent, or did you get some back in change? And did you opt for a replaceable/RBF transaction?
< jarthur> Also, this is the development channel. #bitcoin is the place to ask general network usage questions.
< bralyclow> sorry about asking in here, but yes, all spent, no change or change address created as the fee was to be taken from the total left in that wallet, I did mark the transaction as enable RBF
< bitcoin-git> [bitcoin] hebasto opened pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725