< bitcoin-git>
bitcoin/master 8284756 John Newbery: A few minor formatting fixes and clarifications to descriptors.md
< bitcoin-git>
bitcoin/master d7fbe7d Wladimir J. van der Laan: Merge #14778: A few minor formatting fixes and clarifications to descriptors.md...
< bitcoin-git>
[bitcoin] laanwj closed pull request #14778: A few minor formatting fixes and clarifications to descriptors.md (master...descriptors_doc_update) https://github.com/bitcoin/bitcoin/pull/14778
< bitcoin-git>
bitcoin/master 895e6bb Andrew Chow: build: if VERSION_BUILD is non-zero, include it in the package version...
< bitcoin-git>
bitcoin/master 04b0bc7 Andrew Chow: build: include rc number in version number
< bitcoin-git>
bitcoin/master 75a4bf6 Andrew Chow: Update release-process.md to include RC version bumping
< bitcoin-git>
[bitcoin] laanwj closed pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612
< bitcoin-git>
bitcoin/master b81a186 Gregory Sanders: GetPubKey: make sigdata const
< bitcoin-git>
bitcoin/master 0595164 Wladimir J. van der Laan: Merge #14678: [wallet] remove redundant KeyOriginInfo access, already done in CreateSig...
< bitcoin-git>
[bitcoin] marcoagner opened pull request #14795: test: allows test_runner command line to receive parameters for each test (master...fix_test_runner_parameters) https://github.com/bitcoin/bitcoin/pull/14795
< lopp>
hi folks, can anyone help me understand the verify-commits.py script? when I try running it with no arguments it just returns "HEAD was not signed with a trusted key!"
< sipa>
lopp: what is your HEAD commit?
< lopp>
59f05d1161698dcca6eaf719422d4ec3401f2954
< lopp>
@sipa I'll also note that I'm running it with python3.6 - when I tried running with 2.7 it threw syntax errors
< sipa>
lopp: python 3 sounds correct
< sipa>
lopp: i think you may need to refresh your pubkeys
< lopp>
@sipa is that what the gpg.sh script is for? it's not clear to me
< ken2812221>
lopp: You would have to import those trusted key into gpg at first.
< ken2812221>
while read -r LINE; do gpg --recv-keys $LINE; done < contrib/verify-commits/trusted-keys
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits
< lopp>
error: gpg failed to sign the data fatal: failed to write commit object
< lopp>
Merge commit 6b90a2a0e06548b5c30a160fe76351a44fe3f861 is not clean
< lopp>
I haven't been able to successfully run the verification yet; I did import the GPG keys (which was tricky because I had some other permissions issues with my GPG dirmngr)
< lopp>
when I run against HEAD in master it outputs the same error along with a small diff
< lopp>
Using verify-commits data from /home/lopp/code/bitcoin/contrib/verify-commits error: gpg failed to sign the data fatal: failed to write commit object Merge commit HEAD is not clean
< midnightmagic>
Not going to be a lot of people around on thanksgiving weekend my man. :-)
< lopp>
are you suggesting that people have a life outside of bitcoin??? :-P
< midnightmagic>
only sometimes.
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< lopp>
are there any code coverage reports for Core?