< bitcoin-git> [bitcoin] AkioNak opened pull request #15335: Fix lack of warning of unrecognized section names (master...conf_include_multi) https://github.com/bitcoin/bitcoin/pull/15335
< bitcoin-git> [bitcoin] bvbfan opened pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2fbf6a57d282...64127b3098a1
< bitcoin-git> bitcoin/master 60e190c João Barbosa: gui: Fix WalletController deletion
< bitcoin-git> bitcoin/master 07b9aad João Barbosa: gui: Expose BitcoinGUI::unsubscribeFromCoreSignals
< bitcoin-git> bitcoin/master fd6d499 João Barbosa: gui: Fix m_node.startShutdown() order
< bitcoin-git> [bitcoin] laanwj merged pull request #15280: gui: Fix shutdown order (master...019-01-gui-shutdown) https://github.com/bitcoin/bitcoin/pull/15280
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64127b3098a1...424327e1a8f5
< bitcoin-git> bitcoin/master fae169c MarcoFalke: test: Make bloom tests deterministic
< bitcoin-git> bitcoin/master 424327e Wladimir J. van der Laan: Merge #15324: test: Make bloom tests deterministic
< bitcoin-git> [bitcoin] laanwj merged pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
< wumpus> #15140 confuses me a bit
< gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
< wumpus> does it fix an actual problem?
< luke-jr> wumpus: I guess the test wasn't testing what it was supposed to? not sure
< wumpus> yea that's what it purports to do, the change itself is kind of strange though
< wumpus> it seems that a more minimal fix could solve it
< wumpus> but I might be wrong
< promag> coffee break merge #15322
< gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/424327e1a8f5...ebc6542d982c
< bitcoin-git> bitcoin/master 712d35b João Barbosa: wallet: Add missing cs_db lock
< bitcoin-git> bitcoin/master ebc6542 Wladimir J. van der Laan: Merge #15322: wallet: Add missing cs_db lock
< bitcoin-git> [bitcoin] laanwj merged pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
< promag> that was fast
< wumpus> promag: yep already intended to merge that one
< promag> ok ty
< wumpus> but you reminded me
< promag> I'm now with #15153
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< fanquake> promag restarted all the tests in 15153
< fanquake> planning on testing that again
< promag> fanquake: I'll push shortly
< promag> I think it's good enough for 1st GUI support
< promag> in order to support "cancel open because it's rescanning" we have to do some refactors
< fanquake> promag, yes I think so. There are still edge cases/improvements that can be fixed/made later
< fanquake> i.e closing a modal after opening a wallet, then opening the same wallet again
< fanquake> You end up with the first completing, then the second opening failing because the same wallet is loaded already.
< promag> fanquake: I think I can fix that, by disabling the close
< promag> fanquake: right
< fanquake> Disabling the close button could work, although that's probably not ideal if you are stuck with a long time to rescan wallet, and want to bail out.
< promag> fanquake: ryanofsky: I think Node::loadWallet should return the Wallet immediately, and the the GUI could add handlers and interact with the wallet asynchronously
< promag> fanquake: ah I see, then I it should not be modal, and if the same wallet is opened then it fails
< wumpus> hhmm translation process for adding new translations needs to be updated for the MSVC build system
< wumpus> translations are listed in three places now :(
< wumpus> (working on this)
< bitcoin-git> [bitcoin] benthecarman opened pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338
< bitcoin-git> [bitcoin] laanwj opened pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
< bitcoin-git> [bitcoin] hebasto opened pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
< dongcarl> Re #13865, wondering if people think this is a good idea. Pro: git bisectability, Con: travis will be even slower
< gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
< luke-jr> dongcarl: it shouldn't affect build times *too* much, so long as it uses the same build dir between commits
< dongcarl> Okay, I will PR to do `git --exec` then
< dongcarl> or rather `git rebase --exec`
< instagibbs> I don't have a lot of experience in this but how often has this been a problem
< dongcarl> instagibbs: You mean git bisectability?
< luke-jr> that's a good point too
< wumpus> I don't see a strong reason to do this either
< instagibbs> dongcarl, correct, how often has this been an issue
< luke-jr> AFAIK git bisect doesn't go inside merges unless the issue is part of that set of commits
< wumpus> testing the top commit of a PR should be enough, anything else is for certain going to confuse people, how many projects run the CI on every single commit even in merges?
< dongcarl> I guess I was thinking that if we had a long-standing bug we could use bisect to find where it started
< luke-jr> too bad there's no way to set priorities so Travis just runs everything on intermediate commits if it gets idle cycles
< luke-jr> dongcarl: you can do that regardless
< wumpus> bisect is already quite usable
< wumpus> never had problems really
< instagibbs> dongcarl, I believe luke is right in that it can still do it, regardless
< dongcarl> Okay cool
< instagibbs> as long as merge commits are properly passing
< wumpus> right
< dongcarl> luke-jr: wanna close #13865?
< gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
< instagibbs> You can also mark known-bad commits
< instagibbs> and skip them
< * dongcarl> of little faith in the Linus, repenting
< luke-jr> dongcarl: I don't have access to close it
< luke-jr> instagibbs: hm, I wonder if there's a way to make a permanent list of skip commits
< instagibbs> someone can grind through commits and build it :P
< instagibbs> then we can make a bisect wrapper script that allows bisection to skip
< luke-jr> no, I just mean, next time I'm bisecting, it'd be nice to be able to do `git bisect skip --remember` or something
< instagibbs> ah, not sure about that one
< promag> dongcarl: I like the idea and most branches have few commit. however travis already takes a lot of time..
< promag> wumpus: if there was enough horsepower then you wouldn't mind it
< bitcoin-git> [bitcoin] promag opened pull request #15341: rpc: Support specifying change address in bumpfee (master...019-01-bumpfee-changeaddress) https://github.com/bitcoin/bitcoin/pull/15341
< luke-jr> kinda crazy to think how far CPUs have come, and still there is a question of horsepower for some things
< wumpus> c++ is crazy expensive to compile
< wumpus> both in memory as cpu
< wumpus> I don't know why that's the case, but pretty much every language does better in that regard
< promag> what is the motivation of #15340? is this something found elsewhere?
< gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
< wumpus> it was discussed on IRC at some point as a way to make googling errors easier
< hebasto> promag: ^
< wumpus> but this is quite an ugly change :/ and it doesn't even really work like this
< hebasto> wumpus: yep (
< sipa> wumpus: templates.. they essentially require recompiling for every instantiation
< wumpus> sipa: it's true but many other languages have parametrized types too
< luke-jr> wumpus: we had C++ in 2005
< luke-jr> maybe not C++11, but surely the feature additions aren't *that* big a difference
< sipa> wumpus: perhaps the pervasive use of templates in the standard library
< sipa> how many languages have a sort function instantiated for every call
< promag> another coffee break merge #15297
< gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
< wumpus> luke-jr: maybe the source code compiled was smaller, on average, at the time :)
< promag> wumpus: do you want me to review any specific pr?
< wumpus> compilers certainly have improved since then
< promag> 0.18 or hp?
< wumpus> promag: that's really up to you
< wumpus> but it's a good point that so close to a release, having two lists to prioritize review isn't great
< wumpus> normally I'd say "high priority for review" takes precedence as it's blocking people
< wumpus> most things tagged 0.18 will be untagged anyway when it's time for the release and they haven't made it
< wumpus> promag: thanks!
< promag> no problem
< wumpus> luke-jr: of course our functional test suite takes significant time too, blaming the compiler only isn't fair :)
< wumpus> promag: that one has no (ut)ACKs at all
< promag> wumpus: I know :(
< promag> maybe next week coffee
< luke-jr> XD
< wumpus> hehe
< luke-jr> wumpus: I suppose in 2005, we didn't have CI
< luke-jr> but anyway, that wasn't really my point. :x
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ebc6542d982c...6a5feb7d821f
< bitcoin-git> bitcoin/master bef8fdd ken2812221: msvc: Fix silent merge conflict between #13926 and #14372
< bitcoin-git> bitcoin/master 6a5feb7 MarcoFalke: Merge #15325: msvc: Fix silent merge conflict between #13926 and #14372
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15325: msvc: Fix silent merge conflict between #13926 and #14372 (master...msvc-merge-conflict) https://github.com/bitcoin/bitcoin/pull/15325
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a5feb7d821f...70d06eb857ce
< bitcoin-git> bitcoin/master fa6b7b9 MarcoFalke: travis: Revert "Run extended tests once daily"
< bitcoin-git> bitcoin/master 70d06eb MarcoFalke: Merge #15328: travis: Revert "Run extended tests once daily"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70d06eb857ce...cf8aa5c76ad8
< bitcoin-git> bitcoin/master df8a7d3 Wladimir J. van der Laan: qt: Pre-0.18 split-off translations update
< bitcoin-git> bitcoin/master cf8aa5c Wladimir J. van der Laan: Merge #15339: qt: Pre-0.18 split-off translations update
< bitcoin-git> [bitcoin] laanwj merged pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
< bitcoin-git> [bitcoin] dongcarl opened pull request #15343: netaddress: Make IPv4 loopback comment more descriptive (master...019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
< bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
< bitcoin-git> [bitcoin] Empact opened pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344
< dongcarl> Hey all, anyone got a good understanding of `mapLocalHost`?
< dongcarl> What does "local address for a particular peer" mean?
< * dongcarl> looking at `GetLocal`
< sipa> dongcarl: for a IPv4 peer your own address will likely be an IPv4 one
< sipa> i think
< sipa> this code has evolved a bit since i last worked on it
< dongcarl> sipa: So... `GetLocal` tries to find the best "local" address to give to a peer?
< dongcarl> Why would it matter to peers? I feel like I'm misunderstanding...
< wumpus> it's used to determine what address to gossip IIRC
< dongcarl> Got the answer in `CNetAddr::GetReachabilityFrom`
< wumpus> okay!
< bitcoin-git> [bitcoin] dongcarl opened pull request #15345: net: Correct comparison of addr count (master...019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
< dongcarl> wumpus: In situations like #15343, would it be okay for me to just fix the indentation for the function?
< gribble> https://github.com/bitcoin/bitcoin/issues/15343 | netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
< gkrizek> wumpus: I just pushed a fix for the leading digit problem on branch names. I updated the ghi instance on your server as well
< wumpus> dongcarl: how much of the indentation is broken? is it the case for other functions as well?
< wumpus> but sure, you certainly don't need to fix all the indentation, just don't introduce any new wrong one
< wumpus> gkrizek: oh great! thank you
< bitcoin-git> [bitcoin] laanwj closed pull request #15274: remove redundant 'solved' from ProduceSignature (master...sign_redundant_solved) https://github.com/bitcoin/bitcoin/pull/15274
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cf8aa5c76ad8...76deb30550b2
< bitcoin-git> bitcoin/master b0c7b54 Carl Dong: init: Use systemd automatic directory creation
< bitcoin-git> bitcoin/master bad1716 Carl Dong: init: Modify docs and add release note for 12255
< bitcoin-git> bitcoin/master 76deb30 Wladimir J. van der Laan: Merge #12255: Update bitcoin.service to conform to init.md
< bitcoin-git> [bitcoin] laanwj merged pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76deb30550b2...bfbe42585e9b
< bitcoin-git> bitcoin/master 107623c Carl Dong: net: Correct comparison of addr count
< bitcoin-git> bitcoin/master bfbe425 Wladimir J. van der Laan: Merge #15345: net: Correct comparison of addr count
< bitcoin-git> [bitcoin] laanwj merged pull request #15345: net: Correct comparison of addr count (master...2019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
< dongcarl> Can anyone tell me what the deprecated variable naming convention is? I see that `v*` is vector... `f*` seems to be booleans? There's also a `vf` in net.cpp, which is an array of booleans?
< sipa> dongcarl: v=vector, map=map, str=string, sz=c-style-string, f=flag
< sipa> vf=vector of flags
< dongcarl> sipa: Thank you!
< wumpus> don't use it in new code though
< dongcarl> wumpus: Haha yeah ofc
< dongcarl> I'm just reading thru net.cpp adding comments
< sipa> there are many variables whose type changed without the name changing accordingly
< sipa> there's probably some fun archaeology to do with that
< dongcarl> "fun"
< wumpus> dongcarl: btw if you intend to submit more comment changes to net code, that'd be very helpful, but it's probably better to group them into one PR instead of opening separate ones like #15343
< gribble> https://github.com/bitcoin/bitcoin/issues/15343 | [doc] netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
< dongcarl> wumpus: Okay will do, I guess I'll just separate them into different commits so that we can drop/modify them easily during review
< wumpus> yea multiple commits is fine!
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bfbe42585e9b...452acee4da20
< bitcoin-git> bitcoin/master 77777c5 MarcoFalke: log: Construct global logger on first use
< bitcoin-git> bitcoin/master 452acee MarcoFalke: Merge #15266: memory: Construct globals on first use
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15266: memory: Construct globals on first use (master...Mf1901-cofu) https://github.com/bitcoin/bitcoin/pull/15266
< dongcarl> Does anyone know what the "p" in "paddrPeer" in net.cpp might be referring to?
< sipa> pointer
< promag> classic XD
< sipa> promag: that's hungarian style :)
< * dongcarl> facepalms
< dongcarl> Oh wow that's an actual thing
< dongcarl> TIL
< hebasto> jonasschnelli: thank you for your opinion about #15340 but this pr breaks translation process, unfortunately.
< gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
< promag> dongcarl: apologies for that, you were much happier before
< sipa> dongcarl: so psz is pointer-to-zero-terminated-string
< sipa> which used to occur frequently
< dongcarl> sipa: My mom warned me about nasty C-style zero-terminated strings! They hang out in all the bad stacks!
< wumpus> hebasto: *conceptually* it's a good idea, it's just virtually impossible to implement correctly with gettext
< hebasto> wumpus: thanks
< wumpus> we've run into a similar issue in the past for the status bar, where we wanted to return the untranslated error on the RPC and the translated one on the GUI
< wumpus> ended up duplicating the text ...
< wumpus> would certainly *not* be nice to do for all errors
< wumpus> dongcarl: your mother is very wise
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14169: add -debuglogsize=<n> option (master...master) https://github.com/bitcoin/bitcoin/pull/14169
< bitcoin-git> [bitcoin] darosior opened pull request #15346: cli: encryptwallet password entered from stdin. fixes #15318 (master...cli_encryptwallet_stdin) https://github.com/bitcoin/bitcoin/pull/15346
< bitcoin-git> [bitcoin] hebasto reopened pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
< bitcoin-git> [bitcoin] hebasto opened pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347