03:20 < achow101> meshcollider: it's because you're too slow to merge things :)

05:33 < fanquake> Reviving some flame graphs for Core: https://imgur.com/a/QrDFAfv

07:34 < jonasschnelli> fanquake: nice!

07:35 < jonasschnelli> (flamegraph)

07:35 < jonasschnelli> I remember doing one with – was it callgrind – ? I think they can be of great use.

07:52 < fanquake> jonasschnelli: thanks. Just using dtrace for now. Trying to improve the coloured output a bit.

07:52 < fanquake> I've now split it up such that LevelDB is green, Boost blue, system is orange and Core yellow. Still not perfect.

07:53 < fanquake> Also higher resolution now. Couple more examples:

07:53 < fanquake> Startup: https://imgur.com/a/yTav68E

07:53 < fanquake> Later into IBD: https://imgur.com/a/LDugOpK

07:56 < jonasschnelli> fanquake: I think they are interactive (JS/HTML)...

07:57 < jonasschnelli> I'm interested to generate one for every master commit....

07:57 < fanquake> jonasschnelli: yes, it generates SVGs, that you can click on, filter, search through etc

07:57 < jonasschnelli> Ah.

07:57 < fanquake> I'd upload the SVGs for others to look at directly, but I'm not sure where to do that quickly/easily ?

07:58 < fanquake> imgur or github wont accept them

07:58 < jonasschnelli> Similar to the CI I run, maybe we can run Startup / IBD. etc. on a dedicated calm system and callgrind/flamgraph it. So comparision is possible

07:58 < jonasschnelli> fanquake: have a server somewhere. :P

07:59 < fanquake> jonasschnelli: heh yea

08:00 < fanquake> i.e If you drill down by selecting the calls you are interested in: https://imgur.com/a/1fPFb2S

08:58 < kallewoof> While writing code to do the reorg feature in signet, I realized something really weird happened to my node when it switched chains. It was basically submitting several hundred transactions to the mempool for relay, despite those transactions being already mined and confirmed (some 4000+ blocks earlier).

09:01 < kallewoof> I think those transactions are coinbase transactions, too. But maybe not all of them. Example -> https://pastebin.com/NHBJcUGP

09:17 < promag> someone can review/merge #16404? ty

09:17 < gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub

11:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e55444a2a8a2...6b6386e85492

11:50 < bitcoin-git> bitcoin/master fa566b2 MarcoFalke: test: Add missing sync_blocks to feature_pruning

11:50 < bitcoin-git> bitcoin/master 6b6386e MarcoFalke: Merge #16538: test: Add missing sync_blocks to feature_pruning

11:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538

11:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b6386e85492...1063fc9cf9b5

11:56 < bitcoin-git> bitcoin/master 05fdb97 Antoine Riard: [doc] Update and extend benchmarking.md

11:56 < bitcoin-git> bitcoin/master 1063fc9 MarcoFalke: Merge #16536: doc: Update and extend benchmarking.md

11:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16536: doc: Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536

12:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1063fc9cf9b5...c77f7cdbd1ce

12:02 < bitcoin-git> bitcoin/master fa883ab MarcoFalke: net: Use mockable time for tx download

12:02 < bitcoin-git> bitcoin/master fab3658 Suhas Daftuar: [qa] Test that getdata requests work as expected

12:02 < bitcoin-git> bitcoin/master c77f7cd MarcoFalke: Merge #16197: net: Use mockable time for tx download

12:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16197: net: Use mockable time for tx download (master...1906-netMock) https://github.com/bitcoin/bitcoin/pull/16197

12:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c77f7cdbd1ce...d5ea8f4bf39a

12:09 < bitcoin-git> bitcoin/master 68f5466 Ben Woosley: test: Fix “local variable 'e' is assigned to but never used”

12:09 < bitcoin-git> bitcoin/master fa8a1d7 MarcoFalke: test: Adapt test framework for chains other than "regtest"

12:09 < bitcoin-git> bitcoin/master faf3683 MarcoFalke: test: Avoid hardcoding the chain name in combine_logs

12:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509

12:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5ea8f4bf39a...62117f9f363e

12:17 < bitcoin-git> bitcoin/master 77770d9 MarcoFalke: test: Properly serialize BIP34 coinbase height

12:17 < bitcoin-git> bitcoin/master fa8489a MarcoFalke: test: Add test for BIP30 duplicate tx

12:17 < bitcoin-git> bitcoin/master 62117f9 MarcoFalke: Merge #16363: test: Add test for BIP30 duplicate tx

12:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363

15:52 < bitcoin-git> [bitcoin] ajtowns closed pull request #16229: Standardise deployment handling (master...201906-deployments) https://github.com/bitcoin/bitcoin/pull/16229

15:54 < bitcoin-git> [bitcoin] Alko89 opened pull request #16547: Check usages of #if defined(...) (master...if-defined-usages) https://github.com/bitcoin/bitcoin/pull/16547

16:43 < bitcoin-git> [bitcoin] hebasto closed pull request #16508: Disallow double negation syntax (-nofoo=0) for options (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508

16:45 < MarcoFalke> [04:58] <kallewoof> While writing code to do the reorg feature in signet, I realized something really weird happened to my node when it switched chains. It was basically submitting several hundred transactions to the mempool for relay, despite those transactions being already mined and confirmed (some 4000+ blocks earlier).

16:45 < MarcoFalke> Probably due to the wallet refactor on tx re-submission

16:45 < MarcoFalke> the IsCoinBase check was removed

16:45 < MarcoFalke> cc ariard

16:46 < MarcoFalke> #16452

16:46 < gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub

16:49 < bitcoin-git> [bitcoin] mmachicao opened pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548

17:09 < bitcoin-git> [bitcoin] emilengler closed pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544

17:38 < bitcoin-git> [bitcoin] Sjors opened pull request #16549: [WIP] UI external signer support (e.g. hardware wallet) (master...2019/08/hww-qt) https://github.com/bitcoin/bitcoin/pull/16549

17:39 < provoostenator> ^ that was supposed to be Draft

18:42 < kallewoof> MarcoFalke: Hm, not sure if 16452 is related or not from looking at the changes. Anyway Ithink you can trigger this by simply starting two regtest nodes and reorging one to the other. They should start spamming those messages I think

21:28 < sanket1729> and(pk(C),or(pk(C),or(9@pk(C),older(1000))))

21:29 < sipa> what is this arcane language you utter?

21:29 < sanket1729> oops, sorry

22:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16551: test: Test that low difficulty chain fork is rejected (master...1908-testDosLowHeader) https://github.com/bitcoin/bitcoin/pull/16551