< bitcoin-git>
[bitcoin] clashicly opened pull request #16857: Elaborate on the need to re-login on Debian-based systems to use tor … (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16857
< bitcoin-git>
bitcoin/0.17 e9adb96 Sjors Provoost: [wallet] abort when attempting to fund a transaction above maxtxfee
< bitcoin-git>
bitcoin/0.17 0e7c746 João Barbosa: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
< bitcoin-git>
bitcoin/0.17 1659b9b Wladimir J. van der Laan: Merge #16639: [0.17] abort when attempting to fund a transaction above -ma...
< bitcoin-git>
[bitcoin] laanwj merged pull request #16639: [0.17] abort when attempting to fund a transaction above -maxtxfee (0.17...2019/08/backport_max_fee) https://github.com/bitcoin/bitcoin/pull/16639
< bitcoin-git>
[bitcoin] jameshilliard opened pull request #16858: Qt: advise users not to switch wallets when opening a BIP70 URI. (master...bip70-message) https://github.com/bitcoin/bitcoin/pull/16858
< gribble>
https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
< meshcollider>
Yeah it hasn't had much review, it could make it if people wanted to review it today/tomorrow
< wumpus>
not sure #16852 can really be considered a feature, maybe
< gribble>
https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
< wumpus>
I'd be fine with merging that after the feature freeze at least
< wumpus>
adding #16851 to high prio, who knows it can still make it
< meshcollider>
is triage permission sufficient to edit projects?
< aj>
i'm thinking we can try this as a project for a little while and maybe if it turns out to be useful maybe it will eventually be worth making labels map to columns better or similar
< aj>
i couldn't tell what permissions were needed for projects by looking at the docs
< wumpus>
meshcollider: good question, I don't really know
< sipa>
i believe it isn't
< sipa>
or at least it wasn't a while ago
< dongcarl>
I believe I have triage permission... And I can add things to projects...
< sipa>
dongcarl: no i reverted your triage permission back to what it was before after you complained your couldn't edit projects anymore
< dongcarl>
sipa: Oh cool. Had forgotten
< wumpus>
that makes it significantly less useful than using labels
< meshcollider>
concept ack adding aj to the issue management team then?
< wumpus>
oh, fine with me
< aj>
i think you can have organization level projects and have more fine grained permissions there fwiw
< sipa>
dongcarl: let's test; can you still edit projects now?
< sipa>
(i made you triage)
< dongcarl>
sipa: nope I cannot
< dongcarl>
makes sense
< dongcarl>
aj: Would like a "previous attempts" column if possible
< sipa>
dongcarl: cool; reverted back
< dongcarl>
aj: Lmk when the new project is up, I'll tranfer things over and close the previous one
< wumpus>
ok, let's add aj to write access then
< aj>
dongcarl: not sure what "previous attempts" would mean? (versus a note in the PR itself eg)
< wumpus>
ACK on the idea at least, if you're going to maintain this actively
< aj>
wumpus: that's the plan, and the script is working so far
< wumpus>
great!
< aj>
also, any other ideas about how to separate things welcome, here, email or commenting on the gist all work
< dongcarl>
aj: Well I just thought it'd be nice for those who are picking PRs to work on to have an easy view of past attempts at certain refactors/features
< dongcarl>
no need to hold up the meeting tho if there are other things to talk about, I can post on gist
< aj>
dongcarl: maybe an "upforgrabs" column would make more sense, as in "past attempts that haven't yet been taken up" and you just look at the PR for previous attempts for that particular feature once it's been grabbed?
< aj>
ack for chatting out of meeting though
< dongcarl>
aj: That's perfect
< wumpus>
aj: ok, added you
< wumpus>
#topic disable BIP70 support by default for 0.19 (BlueMatt)
< meshcollider>
Congrats on 40k GitHub stars btw
< wumpus>
same!
< BlueMatt>
more a fanquake topic than I
< BlueMatt>
but question is whether to do it independant of #16852
< gribble>
https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
< BlueMatt>
imo yes, but would be nice to land both
< wumpus>
fanquake isn't here now afaik it's middle of the night down under
< BlueMatt>
and mostly lets kill bip70, finally
< jonasschnelli>
16852 needs more review... three days left though
< achow101>
There's also #16858
< gribble>
https://github.com/bitcoin/bitcoin/issues/16858 | Qt: advise users not to switch wallets when opening a BIP70 URI. by jameshilliard · Pull Request #16858 · bitcoin/bitcoin · GitHub
< wumpus>
yes, I'm in favor too
< jonasschnelli>
I have plans to merge 16858 (the warning) in 3 days if no objections
< achow101>
I think it's fine to disable without 16852. it's really such a small thing that no one will probably notice
< jonasschnelli>
I guess its too late for the string search and the complete removal
< BlueMatt>
ehh removal by default I'd still love to see in 19 either way
< jonasschnelli>
review it!
< meshcollider>
Yeah I think it's doable
< BlueMatt>
i mean even without 16852
< wumpus>
the string search one just needs testing
< wumpus>
it certainly could make it in for 0.19
< BlueMatt>
but, right, should test 16852
< achow101>
to properly review the string search, you probably will want to look at the X.509 and Protobuf specs
< wumpus>
the thing is that no one seems to actually have a wallet with payment request in it :)
< BlueMatt>
or, at least, an un-expired payment request
< BlueMatt>
cause they die after expiry anyway, so it cant be worse lol
< achow101>
I've got a few from my own testing
< achow101>
I can just like send payment requests to people for testnet
< achow101>
i jumped through the hoops to get a bitpay testnet account so I can get these things at will now
< wumpus>
hah
< bitcoin-git>
[bitcoin] laanwj closed pull request #15064: [PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] (master...bip70_merchant_to_to) https://github.com/bitcoin/bitcoin/pull/15064
< jonasschnelli>
Can't you not just use gavings old php script?
< jonasschnelli>
I ues that in the past
< jonasschnelli>
*used
< wumpus>
does that still work?
< jonasschnelli>
I guess the protocol hasn't changed :)
< jonasschnelli>
I mean you need to load the script an your own server
< achow101>
anyone have a really big testnet wallet they are willing to send to me? I need something to test and benchmark my work with wallet memory usage
< BlueMatt>
phantomcircuit: ^
< sipa>
achow101: override your IsMine to return true
< sipa>
largest wallet you can imagine :)
< achow101>
that's uh.. scary
< sipa>
or slightly less crazy, define it as SHA256(scriptPubKey)[0] == 0 or so
< achow101>
i'll just import a bunch of addresses instead
< phantomcircuit>
BlueMatt, i have literally no idea where that is
< phantomcircuit>
i sent it to you!
< BlueMatt>
no, i stole the money without the file
< achow101>
nice
< phantomcircuit>
oh
< phantomcircuit>
hmm
< phantomcircuit>
i can look maybe it's somewhere
< elichai2>
wumpus: saw now you talked about translations. actually 2 weeks ago I went over the Hebrew one as much as I could and got someone from the community involved to help with it. the big problem I see is that anyone can override good translation with bad ones