< provoostenator> In case anyone is bored this weekend and wants to learn more a BIP70: #16852 needs a test case IMO.
< gribble> https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
< provoostenator> I created ##bitcoin-core-gitian: a channel to stalk people when there's something to sign. I don't know how the stalking is going to work though :-)
< luke-jr> prefer to keep that here?
< luke-jr> I'm already at my freendoe channel limit..
< luke-jr> also, it'd make a lot more sense to make it not Bitcoin-specific even IMO
< provoostenator> luke-jr: I'm not saying it should be here, but I tend to miss the memo
< warren> my ability to debootstrap a working Ubuntu chroot on fedora broke a few years ago, and I didn't bother fixing it because I figured dongcarl would replace gitian eventually.
< provoostenator> I'm not very up to date on which other projects use Gitian
< luke-jr> warren: I use KVM
< warren> provoostenator: tor browser?
< luke-jr> warren: no, Tor abandoned gitian
< warren> oh, do they have a different deterministic builder now?
< luke-jr> IIRC something Debian made
< provoostenator> I'm also looking forward to GUIX, but I figured we'll be stuck with Gitian for a least a while, and then some for backports.
< warren> oh, most of Debian is itself reproducible so it's probably just https://reproducible-builds.org/docs/source-date-epoch/ with a particular chroot with defined versions
< warren> provoostenator: I've tried to encourage carl to come up with a good name for the new buildsystem (like Gitian). We thought we came up with a good name yesterday but it turned out a video game already used it. grrr.
< luke-jr> Replicator?
< warren> luke-jr: great way to get the twitter carnivores mad
< luke-jr> eh?
< kanzure> supergitian?
< jonatack> /join ##bitcoin-core-gitian
< jonatack> heh
< meshcollider> There's supposed to be a wallet meeting in 4 minutes but my internet is a bit spotty, can someone else host just in case?
< jonatack> Wallet meeting, anyone? I'm guessing some people may be at the Optech workshop
< provoostenator> Meeting sounds good, but not sure if I can make it to the end, so can't host.
< jonatack> #startmeeting
< lightningbot> Meeting started Fri Sep 27 19:03:23 2019 UTC. The chair is jonatack. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< meshcollider> Thanks jonatack :)
< kanzure> hi
< achow101> walletmeeting?
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
< jonatack> hi. topics?
< provoostenator> Topic suggestion: GUI send wizard
< jonatack> #topic GUI send wizard
< provoostenator> Feedback welcome on #16966
< gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors · Pull Request #16966 · bitcoin/bitcoin · GitHub
< achow101> cool
< provoostenator> I'm especially trying to figure out how to "store" the pending transaction in the dialog
< provoostenator> Normally a fresh transaction uses WalletTransactionModel, a QT only thing
< provoostenator> BUmp fee uses CMutableTransaction
< provoostenator> And cool people use PSBT
< provoostenator> The current version just switches between WalletTransactionModel and CMutableTransaction (and PSBT if I were to add it).
< provoostenator> There's three stages to the wizard: draft, sign and finish (broadcast).
< meshcollider> Looks cool provoostenator :)
< provoostenator> Draft is the same as our current send screen. Sign is our current confirmation screen (send & bump fee). Finish (broadcast) sends the transaction and displays a summary.
< provoostenator> My idea is to expand Sign with a list of connected hardware wallets in a followup.
< provoostenator> And to expand Finish / Broadcast with PSBT export for offline signers (based on gwillen's stuff)
< provoostenator> And when you load a PSBT file, it will jump straight to the Sign step if it needs your signature, and to the Finish step if not.
< provoostenator> So I think it's a nice enough abstraction.
< jonatack> Sounds great :) will try to review soon. Anything more on the wizard?
< jonatack> Other topics?
< jonatack> #action Review PR #16966
< gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors · Pull Request #16966 · bitcoin/bitcoin · GitHub
< jonatack> #endmeeting
< lightningbot> Meeting ended Fri Sep 27 19:13:22 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< jonatack> I guess that was all.
< jarthur> Worth the effort to make an FAQ page for BIP 70 support in the wallet? I don't know how widespread the confusion/concerns are.
< jarthur> (on bitcoincore.org)
< provoostenator> I suspect the overlap of Bitcoin Core users and people who use merchants that only support BIP70 isn't massive. But I don't have numbers.
< provoostenator> Loudness is not a good indicator of severeness unfortunately.
< jarthur> Right.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6c8aed1f140...6b2210f1016c
< bitcoin-git> bitcoin/master fdb3e8f Anthony Towns: Ignore old versionbit activations
< bitcoin-git> bitcoin/master 6b2210f MarcoFalke: Merge #16713: Ignore old versionbit activations to avoid 'unknown softfork...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16713: Ignore old versionbit activations to avoid 'unknown softforks' warning (master...2019-08-silence-softfork-warning) https://github.com/bitcoin/bitcoin/pull/16713
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16978: test: Seed test RNG context for each test case, print seed (master...1909-testSeed) https://github.com/bitcoin/bitcoin/pull/16978
< MarcoFalke> [14:09] <warren> my ability to debootstrap a working Ubuntu chroot on fedora broke a few years ago, and I didn't bother fixing it because I figured dongcarl would replace gitian eventually.
< MarcoFalke> You can use docker or podman
< provoostenator> #15845 is fast!
< gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub