00:10 < bitcoin-git> [bitcoin] elichai opened pull request #16791: Enable Link Time Optimizations (master...2019-09-thinlto) https://github.com/bitcoin/bitcoin/pull/16791

00:51 < bitcoin-git> [bitcoin] meshcollider opened pull request #16792: Assert that the HRP is lowercase in Bech32::Encode (master...201909_bech32_hrp_check) https://github.com/bitcoin/bitcoin/pull/16792

06:27 < oriondeimos> hi

11:39 < coinmonks> Hey Matt, this is Gaurav from Coinmonks, I have messaged you on Twitter, Can you check it when you get time

12:58 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/33f9750b1b86...d3e672119e80

12:58 < bitcoin-git> bitcoin/master 072f37a Wladimir J. van der Laan: gui: Update transifex slug for 0.19

12:58 < bitcoin-git> bitcoin/master 057fac3 Wladimir J. van der Laan: gui: Update English source translation

12:58 < bitcoin-git> bitcoin/master d3e6721 Wladimir J. van der Laan: Merge #16788: gui: Update transifex slug for 0.19

12:59 < bitcoin-git> [bitcoin] laanwj merged pull request #16788: gui: Update transifex slug for 0.19 (master...2019_10_tx_slug_0_19) https://github.com/bitcoin/bitcoin/pull/16788

13:04 < MarcoFalke> wumpus: Looks like #16745 missed the translation freeze. If so, could you please close it. Otherwise merge :)

13:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16745 | wallet: Translate all initErrors in CreateWalletFromFile by MarcoFalke · Pull Request #16745 · bitcoin/bitcoin · GitHub

13:18 < luke-jr> eh, even if it did, it's something to get for 0.19.1

14:23 < bitcoin-git> [bitcoin] promag opened pull request #16793: refactor: Avoid locking cs_main in ProcessNewBlockHeaders (master...2019-09-csmain-headers) https://github.com/bitcoin/bitcoin/pull/16793

14:24 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d3e672119e80...6e431296dace

14:24 < bitcoin-git> bitcoin/master fa70d19 MarcoFalke: util: Make util/error bilingual_str (refactor)

14:24 < bitcoin-git> bitcoin/master fa61365 MarcoFalke: wallet: Translate all initErrors in CreateWalletFromFile

14:24 < bitcoin-git> bitcoin/master 6e43129 Wladimir J. van der Laan: Merge #16745: wallet: Translate all initErrors in CreateWalletFromFile

14:24 < promag> luke-jr: why does multiprocess fix the laggy gui?

14:25 < wumpus> MarcoFalke: it's fine it's a fairly small change

14:25 < bitcoin-git> [bitcoin] laanwj merged pull request #16745: wallet: Translate all initErrors in CreateWalletFromFile (master...1908-walletTranslate) https://github.com/bitcoin/bitcoin/pull/16745

14:25 < MarcoFalke> ok, thx for the merge

14:33 < bitcoin-git> [bitcoin] promag closed pull request #16066: mempool: Skip estimator if block is older than X (master...2019-05-ibd-avoid-mempool-estimator) https://github.com/bitcoin/bitcoin/pull/16066

14:34 < promag> jonasschnelli: fanquake: please review #16261 for create wallet on the gui

14:34 < gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub

14:34 < promag> wumpus: ^? :P

14:35 < jonasschnelli> promag: just saw it. It won't change the cs_main locking really, right?

14:35 < jonasschnelli> Just moves it further down

14:35 < jonasschnelli> (where it always was)

14:35 < promag> jonasschnelli: you mean in 16261?

14:35 < luke-jr> promag: isn't the laggy GUI because of locking? which would now be part of a separate process..

14:35 < jonasschnelli> 16774

14:35 < promag> luke-jr: but if IPC is sync then it will be laggy

14:36 < luke-jr> only if GUI blocks on IPC

14:36 < promag> luke-jr: if we make m_node.xxx calls async then it won't be laggy

14:36 < luke-jr> which would probably be a pretty bad design?

14:36 < promag> luke-jr: no, we must move m_node calls out of gui thread

14:37 < promag> jonasschnelli: IsIBD is already determined in NotifyHeaderstTip, so just return that to the caller

14:40 < promag> luke-jr: nothing should block the GUI thread, such as IO and thread contention

14:50 < promag> luke-jr: "only if GUI blocks on IPC" - right, what I'm saying is that we can make this in single process

15:18 < bitcoin-git> [bitcoin] sdaftuar closed pull request #15169: Parallelize CheckInputs() in AcceptToMemoryPool() (master...2018-12-parallel-mempool-scriptchecks) https://github.com/bitcoin/bitcoin/pull/15169

15:34 < ryanofsky> multiprocess can potentially make gui more responsive with nested event loops during ipc calls. but this is less ideal than entirely avoiding blocking calls on the gui thread. see #10504

15:34 < gribble> https://github.com/bitcoin/bitcoin/issues/10504 | GUI unresponsive during slow operations · Issue #10504 · bitcoin/bitcoin · GitHub

15:38 < jb55> what do ya'll think about something like qtwebdriver for end-to-end qt testing? would there be value in that?

15:49 < ryanofsky> jb55, how does that work exactly? is there a link to an example test case? I'm looking at https://github.com/cisco-open-source/qtwebdriver/blob/WD_1.X_dev/src/Test/ but it looks more like test setup than interacting and checking for conditions

15:51 < ryanofsky> oh i guess it starts a server, and then you write tests in a selenium client like python's: https://pypi.org/project/selenium/

15:51 < instagibbs> re: test/util/bitcoin-util-test.py, is there a principled way of replacing the output json in unit tests with updated text, other than hacking the script to overwrite the expected results?

15:58 < bitcoin-git> [bitcoin] emilengler closed pull request #16761: Add blockpause setting (master...2019-08-blockpause) https://github.com/bitcoin/bitcoin/pull/16761

16:07 < bitcoin-git> [bitcoin] instagibbs opened pull request #16795: have raw transaction decoding infer output descriptors (master...decode_descriptor) https://github.com/bitcoin/bitcoin/pull/16795

17:37 < Chris_Stewart_5> is there a race condition between 'createwallet' and 'listwalletdir' ?

17:39 < Chris_Stewart_5> this piece of code seems to be failing ( '<-' means block until the async computation is complete, in this case createWallet) https://github.com/bitcoin-s/bitcoin-s/pull/550/files#diff-113c8761520a8526491cee5fe7b637b2R45

17:39 < Chris_Stewart_5> failing sporadically

18:00 < Chris_Stewart_5> Never mind, the issue was unrelated

18:07 < jb55> ryanofsky: yeah I was just looking into it today. I was hoping it would be like chrome webdriver where you could click things and interact with the UI for e2e testing. Then you could write ui interaction tests in python...

18:08 < jb55> not sure if many people do that with qt apps

18:09 < ryanofsky> if it works with selenium ide (https://www.seleniumhq.org/selenium-ide/) maybe that would make it easy to write tests

18:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16796: wallet: Fix segfault in CreateWalletFromFile (master...1909-walletSegfault) https://github.com/bitcoin/bitcoin/pull/16796

18:41 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16661: wallet: Fix segfault in CreateWalletFromFile, Pass error to rpc caller (master...1908-walletErrorSegfault) https://github.com/bitcoin/bitcoin/pull/16661

19:28 < bitcoin-git> [bitcoin] sdaftuar closed pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400

19:37 < bitcoin-git> [bitcoin] sdaftuar reopened pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400

19:45 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #16797: scripts: Add convenience script for committing scripted-diffs from a file (master...scripts/commit-script) https://github.com/bitcoin/bitcoin/pull/16797

19:53 < bitcoin-git> [bitcoin] achow101 opened pull request #16798: Refactor rawtransaction_util's SignTransaction to separate prevtx parsing (master...split-signtx-prevtx) https://github.com/bitcoin/bitcoin/pull/16798

20:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e431296dace...8e00a6855240

20:40 < bitcoin-git> bitcoin/master dcc448e Jonas Schnelli: Avoid unnecessary "Synchronizing blockheaders" log messages

20:40 < bitcoin-git> bitcoin/master 8e00a68 MarcoFalke: Merge #16774: Avoid unnecessary "Synchronizing blockheaders" log messages

20:41 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16774: Avoid unnecessary "Synchronizing blockheaders" log messages (master...2019/09/hdr_log) https://github.com/bitcoin/bitcoin/pull/16774