< shesek> how do conflicting transactions fit into the most recent sorting of listttransactions? do they get sorted at the original height they were confirmed at? also, are there any guarantees for the ordering of unconfirmed transactions among themselves?
< bitcoin-git> [bitcoin] hebasto opened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< bitcoin-git> [bitcoin] fanquake opened pull request #18928: build: don't pass -w when building for Windows (master...dont_try_suppress_all_warnings_win) https://github.com/bitcoin/bitcoin/pull/18928
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18929: ci: Pass down MAKEJOBS to fuzz test_runner (master...2005-fuzzMakejobs) https://github.com/bitcoin/bitcoin/pull/18929
< bitcoin-git> [bitcoin] jonatack opened pull request #18931: net: use CMessageHeader::HEADER_SIZE, add missing include (master...netcpp-use-CMessageHeader_HEADER_SIZE) https://github.com/bitcoin/bitcoin/pull/18931
< bitcoin-git> [bitcoin] brakmic opened pull request #18932: test: move sync_blocks implementation to framework member function (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18933: rpc: Add submit option to generateblock (master...2004-rpcBlock) https://github.com/bitcoin/bitcoin/pull/18933
< bitcoin-git> [bitcoin] brakmic opened pull request #18935: test: add more assert_* methods (master...new-asserts-for-functional-testing) https://github.com/bitcoin/bitcoin/pull/18935
< bitcoin-git> [bitcoin] andrewtoth opened pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
< phantomcircuit> can i not use LoadBlockIndex from wallet.cpp or is there some black magic auto conf thing i need to adjust for the linker to work?
< luke-jr> phantomcircuit: bitcoin-wallet doesn't do blockchain stuff
< phantomcircuit> luke-jr, so i should use the chain interface?
< phantomcircuit> im looking at the wallet rpc rescan which ends up calling CWallet::ScanForWalletTransactions which does walk the chain, but through the chain interface
< luke-jr> yes
< midnight> sipa: hello! hashrate graphs! Far as I know, nobody else publishes reliably-accurate graphs.
< midnight> :-)
< sipa> midnight: yes, what is wrong with them?
< phantomcircuit> sipa, he's saying they're good
< midnight> sipa: Thank you!
< sipa> oh, you're welcome :)
< bitcoin-git> [bitcoin] theStack opened pull request #18937: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg (master...20200520-refactor-replace-command-by-msgtype-part-3) https://github.com/bitcoin/bitcoin/pull/18937
< bitcoin-git> [bitcoin] practicalswift opened pull request #18938: tests: Fill fuzzing coverage gaps for functions in consensus/validation.h, primitives/block.h and util/translation.h (master...fuzzers-misc-5) https://github.com/bitcoin/bitcoin/pull/18938
< bitcoin-git> [bitcoin] brakmic closed pull request #17551: test: added test for RPCConvertNamedValues in rpc_tests (master...expanding-test-coverage) https://github.com/bitcoin/bitcoin/pull/17551
< bitcoin-git> [bitcoin] brakmic closed pull request #17700: cli: add -generate option (master...resurrect-generate-method) https://github.com/bitcoin/bitcoin/pull/17700
< bitcoin-git> [bitcoin] brakmic closed pull request #17732: test: check for valgrind presence and set appropriate exit flags (master...valgrind-detection) https://github.com/bitcoin/bitcoin/pull/17732
< bitcoin-git> [bitcoin] brakmic closed pull request #17623: rpc: add extensive file checks for dumptxoutset and dumpwallet (master...checks-for-dump-functions) https://github.com/bitcoin/bitcoin/pull/17623
< bitcoin-git> [bitcoin] brakmic closed pull request #18570: rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/18570
< bitcoin-git> [bitcoin] brakmic closed pull request #18592: rpc: replace raw pointers with shared_ptrs (master...rpcwallet-replace-pointers) https://github.com/bitcoin/bitcoin/pull/18592
< bitcoin-git> [bitcoin] brakmic closed pull request #18611: cli: show default values in config args log (master...compare-params) https://github.com/bitcoin/bitcoin/pull/18611
< bitcoin-git> [bitcoin] brakmic closed pull request #18827: rpc: added getrpcwhitelist method (master...getrpcwhitelist) https://github.com/bitcoin/bitcoin/pull/18827
< bitcoin-git> [bitcoin] brakmic closed pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
< bitcoin-git> [bitcoin] brakmic closed pull request #18932: test: move sync_* implementations to framework member functions (master...move-sync-blocks-to-framework) https://github.com/bitcoin/bitcoin/pull/18932
< bitcoin-git> [bitcoin] brakmic closed pull request #18935: test: add more assert_* methods (master...new-asserts-for-functional-testing) https://github.com/bitcoin/bitcoin/pull/18935
< bitcoin-git> [bitcoin] brakmic closed pull request #18830: rpc: add user field to getrpcinfo's json (master...getrpcinfo) https://github.com/bitcoin/bitcoin/pull/18830
< fanquake> Anyone know why brakmic closed all of his PRs?
< luke-jr> ☹
< fjahr> Seems very weird. The last one was opened 5h before it was closed.
< fanquake> I guess the answer is in #18930. He must have decided to leave.
< gribble> https://github.com/bitcoin/bitcoin/issues/18930 | test: Remove sync_blocks global · Issue #18930 · bitcoin/bitcoin · GitHub
< phantomcircuit> lol "please stop submitting prs"
< phantomcircuit> what the fuck
< bitcoin-git> [bitcoin] mzumsande opened pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
< jonatack> brakmic was making a real effort lately to begin reviewing as well