< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc5333d31f28...362f9c60a54e
< bitcoin-git> bitcoin/master 784ae09 codeShark149: test: Add capability to disable RPC timeout in functional tests.
< bitcoin-git> bitcoin/master 38c3dd9 codeShark149: docs: Add notes on how to diasble rpc timeout in functional tests while at...
< bitcoin-git> bitcoin/master 362f9c6 MarcoFalke: Merge #18986: tests: Add capability to disable RPC timeout in functional t...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18986: tests: Add capability to disable RPC timeout in functional tests (master...notimeout-flag) https://github.com/bitcoin/bitcoin/pull/18986
< hebasto> jonasschnelli: hi, mind reviewing #18152 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/18152 | qt: Use SynchronizationState enum for signals to GUI by hebasto · Pull Request #18152 · bitcoin/bitcoin · GitHub
< tryphe> is there a reason configure.ac doesn't add "noexecstack" to LDFLAGS? it seems like we're using lots of other hardening options but not that one. is it not necessary?
< fanquake> tryphe: It's on by default if you're compiling using Ubuntu, which we are for gitian builds. We do have to add it explicitly when building for RISCV though: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L160
< fanquake> We also test our release binaries to ensure that the stacks are not marked executable
< tryphe> fanquake, oh, that makes sense, i did see that in the gitian script for riscv while searching but couldn't figure out why not for everything else :p
< luke-jr> tryphe: because it's not configure's job to decide your build flags
< luke-jr> #14066 does set it explicitly for all platforms
< gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
< luke-jr> in gitian
< tryphe> luke-jr, what's the point of ./configure --with-hardening then? it enabled relro, now, pie, but not noexecstack?
< luke-jr> maybe --with-hardening should do that too
< tryphe> on Debian 9, it's not, and i'm getting a different hash when i add noexecstack
< tryphe> different bitcoind hash
< tryphe> my thought was that everyone who went with --with-hardening assumed it was enabled, or maybe didn't know about it enough to look for it manually
< tryphe> shall i open a PR?
< fanquake> tryphe: is the binary actually marked as requiring an executable stack
< tryphe> fanquake, good point, i guess not
< tryphe> for both bins: src/bitcoind: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=ec42b47cbaf82198ba6902e12568bac6f09ccde1, not stripped
< tryphe> but i wonder why the bin hash is different, secondary differences?
< fanquake> You can something like diffoscope on the two binaries and check what the differences are
< tryphe> i guess if pie is on, it's still a shared object, so that could be why it's not on by default
< tryphe> it's=noexecstack
< tryphe> because i don't think you could have execstack with -pie
< tryphe> building diffoscope now, it's just taking a bit :) will try to post it here when done if possible
< jonasschnelli> hebasto: oh. 18152 looks great. I haven't looked at it previously! Will review.
< hebasto> jonasschnelli: thanks!
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/362f9c60a54e...c73bd004ae81
< bitcoin-git> bitcoin/master c6131bf Pieter Wuille: Abstract logic to determine whether to answer tx GETDATA
< bitcoin-git> bitcoin/master f2f32a3 Pieter Wuille: Push down use of cs_main into FindTxForGetData
< bitcoin-git> bitcoin/master 2896c41 Pieter Wuille: Do not answer GETDATA for to-be-announced tx
< bitcoin-git> [bitcoin] fanquake merged pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c73bd004ae81...042ff521421f
< bitcoin-git> bitcoin/master fa243be MarcoFalke: log: Remove "No rpcpassword set" from logs
< bitcoin-git> bitcoin/master 042ff52 fanquake: Merge #18999: log: Remove "No rpcpassword set" from logs
< bitcoin-git> [bitcoin] fanquake merged pull request #18999: log: Remove "No rpcpassword set" from logs (master...2005-logRpcPassword) https://github.com/bitcoin/bitcoin/pull/18999
< elichai2> Finished reading http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-08-19.00.log.html, I have a naive question, no-one suggested using leveldb(since we already use that in validation) to replace bdb, is it because the main reason is for future table features or there is something bad/problematic with leveldb?
< aj> i think it might be that leveldb isn't a single-file database, so it's hard for users to move their wallet to a new pc or similar?
< elichai2> that's a good argument :)
< bitcoin-git> [bitcoin] hosseinamin closed pull request #14898: rpc listtransactions new argument options (paginatebypointer impl) (master...master) https://github.com/bitcoin/bitcoin/pull/14898
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/042ff521421f...e7736854ef6c
< bitcoin-git> bitcoin/master fa006ca MarcoFalke: ci: tsan on clang-9
< bitcoin-git> bitcoin/master faf5521 MarcoFalke: ci: Set DEBIAN_FRONTEND=noninteractive
< bitcoin-git> bitcoin/master e773685 fanquake: Merge #19008: ci: tsan on clang-9
< bitcoin-git> [bitcoin] fanquake merged pull request #19008: ci: tsan on clang-9 (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
< bitcoin-git> [bitcoin] Sjors opened pull request #19013: test: add v0.20.0 to backwards compatibility test (master...2020/05/previous_release_0.20) https://github.com/bitcoin/bitcoin/pull/19013
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
< bitcoin-git> [bitcoin] fanquake closed pull request #18903: test: fix TEST_PREVIOUS_RELEASES check (master...getenv_defaults_to_None) https://github.com/bitcoin/bitcoin/pull/18903
< bitcoin-git> [bitcoin] jonasschnelli pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e7736854ef6c...d44dd513226f
< bitcoin-git> bitcoin/master 1df7701 Hennadii Stepanov: refactor: Remove unused bool parameter in BlockNotifyGenesisWait()
< bitcoin-git> bitcoin/master 2bec309 Hennadii Stepanov: refactor: Remove unused bool parameter in RPCNotifyBlockChange()
< bitcoin-git> bitcoin/master 1dab574 Hennadii Stepanov: refactor: Pass SynchronizationState enum to GUI
< bitcoin-git> [bitcoin] jonasschnelli merged pull request #18152: qt: Use SynchronizationState enum for signals to GUI (master...20200215-pr18121-followup2) https://github.com/bitcoin/bitcoin/pull/18152
< bitcoin-git> [bitcoin] practicalswift opened pull request #19015: build: Enable some commonly enabled compiler diagnostics (master...compiler-diagnostics) https://github.com/bitcoin/bitcoin/pull/19015
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d44dd513226f...aa8d76806c74
< bitcoin-git> bitcoin/master 2abe8cc Luke Dashjr: Bugfix: Include "csv","!segwit" in "rules"
< bitcoin-git> bitcoin/master 412d5fe Luke Dashjr: QA: feature_segwit: Check that template "rules" includes "!segwit" as appr...
< bitcoin-git> bitcoin/master aa8d768 MarcoFalke: Merge #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key (master...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/17946
< fanquake> Anyone want to offer an opinion in #18956
< gribble> https://github.com/bitcoin/bitcoin/issues/18956 | build: enforce minimum required Windows version (7) by fanquake · Pull Request #18956 · bitcoin/bitcoin · GitHub
< fanquake> I'll take a "couldn't care less"
< bitcoin-git> [bitcoin] practicalswift closed pull request #18920: doc: Document how to analyze Bitcoin Core using Clang Static Analysis, clang-tidy and cppcheck (master...static-analysis-clang-tidy) https://github.com/bitcoin/bitcoin/pull/18920
< michaelfolkson> fanquake: What do we know about how many people (if any) are running on these versions of these Windows?
< michaelfolkson> fanquake: By enforce you mean not only do we not wish to support it we also want to do everything in our power that people don't try to run on these Windows versions?
< michaelfolkson> Doesn't impact me personally so I guess that is a "couldn't care less" :)
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16756: test: Connection eviction logic tests (master...201908_test_eviction) https://github.com/bitcoin/bitcoin/pull/16756
< bitcoin-git> [bitcoin] limpbrains opened pull request #19018: docs: fixing description of the field sequence in walletcreatefundedpsbt RPC method (master...walletcreatefundedpsbt-fix-docs) https://github.com/bitcoin/bitcoin/pull/19018
< bitcoin-git> [bitcoin] luke-jr opened pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
< phantomcircuit> sipa, any opposition to putting the generated scriptPubKey's into FillableSigningProvider::mapScripts ?
< sipa> phantomcircuit: achow101 may be a better person to ask at this point
< phantomcircuit> achow101, same question^
< achow101> for what purpose?
< sipa> also, what does generated mean, and which signingprovider?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19020: net: Use C++11 member initialization in protocol (master...2005-netCxx11MemberInit) https://github.com/bitcoin/bitcoin/pull/19020
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19023: test: Fix intermittent ETIMEDOUT on FreeBSD (master...2005-testFixIntermFreeBsdTimeout) https://github.com/bitcoin/bitcoin/pull/19023